All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS
@ 2023-11-12 20:03 Simon Glass
  2023-11-12 20:03 ` [PATCH v3 2/2] blk: Drop reference to DM_SPL Simon Glass
  2023-11-17 13:41 ` [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS Tom Rini
  0 siblings, 2 replies; 4+ messages in thread
From: Simon Glass @ 2023-11-12 20:03 UTC (permalink / raw)
  To: U-Boot Mailing List; +Cc: Tom Rini, Simon Glass, Marek Vasut, Pavel Herrmann

This does not existing anymore. Update SPL_DM_STATS to use the correct
Kconfig option, which is SPL_DM

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v3:
- Split the patch into two

Changes in v2:
- Add new patch to correct references to DM_SPL

 drivers/core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
index fe5c41d57ecd..209d90e01fa5 100644
--- a/drivers/core/Kconfig
+++ b/drivers/core/Kconfig
@@ -88,7 +88,7 @@ config DM_STATS
 
 config SPL_DM_STATS
 	bool "Collect and show driver model stats in SPL"
-	depends on DM_SPL
+	depends on SPL_DM
 	help
 	  Enable this to collect and display memory statistics about driver
 	  model. This can help to figure out where all the memory is going and
-- 
2.42.0.869.gea05f2083d-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 2/2] blk: Drop reference to DM_SPL
  2023-11-12 20:03 [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS Simon Glass
@ 2023-11-12 20:03 ` Simon Glass
  2023-11-17 13:41   ` Tom Rini
  2023-11-17 13:41 ` [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS Tom Rini
  1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2023-11-12 20:03 UTC (permalink / raw)
  To: U-Boot Mailing List
  Cc: Tom Rini, Simon Glass, AKASHI Takahiro, Johan Jonker, Kever Yang,
	Mayuresh Chitale, Tobias Waldekranz

The intent here is to only allow SPL_LEGACY_BLK if !SPL_DM - i.e. that
when driver model is enabled in SPL, legacy block cannot be used.

However this combination is used by about 240 boards, so we cannot
disallow it, at least not yet.

So just drop the condition.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 drivers/block/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index b897cf1a3d1b..6ad18889f61e 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -13,7 +13,7 @@ config BLK
 
 config SPL_LEGACY_BLOCK
 	bool # "Enable Legacy Block Device"
-	depends on SPL && !DM_SPL
+	depends on SPL
 	default y if SPL_MMC || SPL_USB_STORAGE || SCSI || NVME || IDE
 	default y if SPL_AHCI_PCI
 	help
-- 
2.42.0.869.gea05f2083d-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS
  2023-11-12 20:03 [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS Simon Glass
  2023-11-12 20:03 ` [PATCH v3 2/2] blk: Drop reference to DM_SPL Simon Glass
@ 2023-11-17 13:41 ` Tom Rini
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-11-17 13:41 UTC (permalink / raw)
  To: Simon Glass; +Cc: U-Boot Mailing List, Marek Vasut, Pavel Herrmann

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

On Sun, Nov 12, 2023 at 01:03:46PM -0700, Simon Glass wrote:

> This does not existing anymore. Update SPL_DM_STATS to use the correct
> Kconfig option, which is SPL_DM
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 2/2] blk: Drop reference to DM_SPL
  2023-11-12 20:03 ` [PATCH v3 2/2] blk: Drop reference to DM_SPL Simon Glass
@ 2023-11-17 13:41   ` Tom Rini
  0 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-11-17 13:41 UTC (permalink / raw)
  To: Simon Glass
  Cc: U-Boot Mailing List, AKASHI Takahiro, Johan Jonker, Kever Yang,
	Mayuresh Chitale, Tobias Waldekranz

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

On Sun, Nov 12, 2023 at 01:03:47PM -0700, Simon Glass wrote:

> The intent here is to only allow SPL_LEGACY_BLK if !SPL_DM - i.e. that
> when driver model is enabled in SPL, legacy block cannot be used.
> 
> However this combination is used by about 240 boards, so we cannot
> disallow it, at least not yet.
> 
> So just drop the condition.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-11-17 13:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-12 20:03 [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS Simon Glass
2023-11-12 20:03 ` [PATCH v3 2/2] blk: Drop reference to DM_SPL Simon Glass
2023-11-17 13:41   ` Tom Rini
2023-11-17 13:41 ` [PATCH v3 1/2] dm: core: Correct reference to DM_SPL in SPL_DM_STATS Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.