* [PATCH] perf test: Use existing config value for objdump path
@ 2023-11-13 10:23 James Clark
2023-11-20 20:48 ` Namhyung Kim
0 siblings, 1 reply; 3+ messages in thread
From: James Clark @ 2023-11-13 10:23 UTC (permalink / raw)
To: linux-perf-users, irogers, acme
Cc: James Clark, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Adrian Hunter,
Yonghong Song, Fangrui Song, Kan Liang, Yang Jihong,
linux-kernel
There is already an existing config value for changing the objdump path,
so instead of having two values that do the same thing, make perf test
use annotate.objdump as well.
Signed-off-by: James Clark <james.clark@arm.com>
---
tools/perf/Documentation/perf-config.txt | 8 ++------
tools/perf/tests/builtin-test.c | 2 +-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt
index 16398babd1ef..379f9d7a8ab1 100644
--- a/tools/perf/Documentation/perf-config.txt
+++ b/tools/perf/Documentation/perf-config.txt
@@ -251,7 +251,8 @@ annotate.*::
addr2line binary to use for file names and line numbers.
annotate.objdump::
- objdump binary to use for disassembly and annotations.
+ objdump binary to use for disassembly and annotations,
+ including in the 'perf test' command.
annotate.disassembler_style::
Use this to change the default disassembler style to some other value
@@ -722,11 +723,6 @@ session-<NAME>.*::
Defines new record session for daemon. The value is record's
command line without the 'record' keyword.
-test.*::
-
- test.objdump::
- objdump binary to use for disassembly and annotations.
-
SEE ALSO
--------
linkperf:perf[1]
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 113e92119e1d..b8c21e81a021 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -518,7 +518,7 @@ static int run_workload(const char *work, int argc, const char **argv)
static int perf_test__config(const char *var, const char *value,
void *data __maybe_unused)
{
- if (!strcmp(var, "test.objdump"))
+ if (!strcmp(var, "annotate.objdump"))
test_objdump_path = value;
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf test: Use existing config value for objdump path
2023-11-13 10:23 [PATCH] perf test: Use existing config value for objdump path James Clark
@ 2023-11-20 20:48 ` Namhyung Kim
2023-11-27 18:57 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Namhyung Kim @ 2023-11-20 20:48 UTC (permalink / raw)
To: James Clark
Cc: linux-perf-users, irogers, acme, Peter Zijlstra, Ingo Molnar,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
Yonghong Song, Fangrui Song, Kan Liang, Yang Jihong,
linux-kernel
Hello,
On Mon, Nov 13, 2023 at 2:23 AM James Clark <james.clark@arm.com> wrote:
>
> There is already an existing config value for changing the objdump path,
> so instead of having two values that do the same thing, make perf test
> use annotate.objdump as well.
>
> Signed-off-by: James Clark <james.clark@arm.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/Documentation/perf-config.txt | 8 ++------
> tools/perf/tests/builtin-test.c | 2 +-
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt
> index 16398babd1ef..379f9d7a8ab1 100644
> --- a/tools/perf/Documentation/perf-config.txt
> +++ b/tools/perf/Documentation/perf-config.txt
> @@ -251,7 +251,8 @@ annotate.*::
> addr2line binary to use for file names and line numbers.
>
> annotate.objdump::
> - objdump binary to use for disassembly and annotations.
> + objdump binary to use for disassembly and annotations,
> + including in the 'perf test' command.
>
> annotate.disassembler_style::
> Use this to change the default disassembler style to some other value
> @@ -722,11 +723,6 @@ session-<NAME>.*::
> Defines new record session for daemon. The value is record's
> command line without the 'record' keyword.
>
> -test.*::
> -
> - test.objdump::
> - objdump binary to use for disassembly and annotations.
> -
> SEE ALSO
> --------
> linkperf:perf[1]
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 113e92119e1d..b8c21e81a021 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -518,7 +518,7 @@ static int run_workload(const char *work, int argc, const char **argv)
> static int perf_test__config(const char *var, const char *value,
> void *data __maybe_unused)
> {
> - if (!strcmp(var, "test.objdump"))
> + if (!strcmp(var, "annotate.objdump"))
> test_objdump_path = value;
>
> return 0;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf test: Use existing config value for objdump path
2023-11-20 20:48 ` Namhyung Kim
@ 2023-11-27 18:57 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-11-27 18:57 UTC (permalink / raw)
To: Namhyung Kim
Cc: James Clark, linux-perf-users, irogers, Peter Zijlstra,
Ingo Molnar, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Adrian Hunter, Yonghong Song, Fangrui Song, Kan Liang,
Yang Jihong, linux-kernel
Em Mon, Nov 20, 2023 at 12:48:38PM -0800, Namhyung Kim escreveu:
> Hello,
>
> On Mon, Nov 13, 2023 at 2:23 AM James Clark <james.clark@arm.com> wrote:
> >
> > There is already an existing config value for changing the objdump path,
> > so instead of having two values that do the same thing, make perf test
> > use annotate.objdump as well.
> >
> > Signed-off-by: James Clark <james.clark@arm.com>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next.
- Arnaldo
> Thanks,
> Namhyung
>
> > ---
> > tools/perf/Documentation/perf-config.txt | 8 ++------
> > tools/perf/tests/builtin-test.c | 2 +-
> > 2 files changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt
> > index 16398babd1ef..379f9d7a8ab1 100644
> > --- a/tools/perf/Documentation/perf-config.txt
> > +++ b/tools/perf/Documentation/perf-config.txt
> > @@ -251,7 +251,8 @@ annotate.*::
> > addr2line binary to use for file names and line numbers.
> >
> > annotate.objdump::
> > - objdump binary to use for disassembly and annotations.
> > + objdump binary to use for disassembly and annotations,
> > + including in the 'perf test' command.
> >
> > annotate.disassembler_style::
> > Use this to change the default disassembler style to some other value
> > @@ -722,11 +723,6 @@ session-<NAME>.*::
> > Defines new record session for daemon. The value is record's
> > command line without the 'record' keyword.
> >
> > -test.*::
> > -
> > - test.objdump::
> > - objdump binary to use for disassembly and annotations.
> > -
> > SEE ALSO
> > --------
> > linkperf:perf[1]
> > diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> > index 113e92119e1d..b8c21e81a021 100644
> > --- a/tools/perf/tests/builtin-test.c
> > +++ b/tools/perf/tests/builtin-test.c
> > @@ -518,7 +518,7 @@ static int run_workload(const char *work, int argc, const char **argv)
> > static int perf_test__config(const char *var, const char *value,
> > void *data __maybe_unused)
> > {
> > - if (!strcmp(var, "test.objdump"))
> > + if (!strcmp(var, "annotate.objdump"))
> > test_objdump_path = value;
> >
> > return 0;
> > --
> > 2.34.1
> >
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-27 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-13 10:23 [PATCH] perf test: Use existing config value for objdump path James Clark
2023-11-20 20:48 ` Namhyung Kim
2023-11-27 18:57 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.