* [PATCH net-next] wifi: rt2x00: Simplify bool conversion
@ 2023-11-15 1:00 Yang Li
2023-11-30 19:19 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-11-15 1:00 UTC (permalink / raw)
To: kvalo, stf_xl; +Cc: linux-wireless, linux-kernel, Yang Li, Abaci Robot
./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:1331:47-52: WARNING: conversion to bool not needed here
./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:1332:47-52: WARNING: conversion to bool not needed here
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7531
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 70cd35d90338..b6421fb32bee 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -1328,8 +1328,8 @@ static bool rt2800_watchdog_dma_busy(struct rt2x00_dev *rt2x00dev)
else
rt2x00dev->txdma_busy = 0;
- busy_rx = rt2x00dev->rxdma_busy > 30 ? true : false;
- busy_tx = rt2x00dev->txdma_busy > 30 ? true : false;
+ busy_rx = rt2x00dev->rxdma_busy > 30;
+ busy_tx = rt2x00dev->txdma_busy > 30;
if (!busy_rx && !busy_tx)
return false;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] wifi: rt2x00: Simplify bool conversion
2023-11-15 1:00 [PATCH net-next] wifi: rt2x00: Simplify bool conversion Yang Li
@ 2023-11-30 19:19 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-11-30 19:19 UTC (permalink / raw)
To: Yang Li; +Cc: stf_xl, linux-wireless, linux-kernel, Yang Li, Abaci Robot
Yang Li <yang.lee@linux.alibaba.com> wrote:
> ./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:1331:47-52: WARNING: conversion to bool not needed here
> ./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:1332:47-52: WARNING: conversion to bool not needed here
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7531
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Patch applied to wireless-next.git, thanks.
cda398fcb488 wifi: rt2x00: Simplify bool conversion
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231115010017.112081-1-yang.lee@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-30 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-15 1:00 [PATCH net-next] wifi: rt2x00: Simplify bool conversion Yang Li
2023-11-30 19:19 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.