All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Inki Dae <inki.dae@samsung.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
Date: Thu, 16 Nov 2023 10:28:55 -0600	[thread overview]
Message-ID: <20231116162855.GA2435337-robh@kernel.org> (raw)
In-Reply-To: <20231113-sultry-cold-d63dd9f015d9@squawk>

On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> > When number of clock varies between variants, the Devicetree bindings
> > coding convention expects to have widest constraints in top-level
> > definition of the properties and narrow them in allOf:if:then block.
> > 
> > This is more readable and sometimes allows to spot some errors in the
> > bindings.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> 
> Åcked-by: Conor Dooley <conor.dooley@microchip.com>

  ^

Not an 'A'. I only caught this because I go thru everything 
Acked/Reviewed-by first and this one was missed.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties
Date: Thu, 16 Nov 2023 10:28:55 -0600	[thread overview]
Message-ID: <20231116162855.GA2435337-robh@kernel.org> (raw)
In-Reply-To: <20231113-sultry-cold-d63dd9f015d9@squawk>

On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote:
> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote:
> > When number of clock varies between variants, the Devicetree bindings
> > coding convention expects to have widest constraints in top-level
> > definition of the properties and narrow them in allOf:if:then block.
> > 
> > This is more readable and sometimes allows to spot some errors in the
> > bindings.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> 
> Åcked-by: Conor Dooley <conor.dooley@microchip.com>

  ^

Not an 'A'. I only caught this because I go thru everything 
Acked/Reviewed-by first and this one was missed.

Rob

  reply	other threads:[~2023-11-16 16:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-12 18:43 [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Krzysztof Kozlowski
2023-11-12 18:44 ` [PATCH 2/5] dt-bindings: gpu: samsung: re-order entries to match coding convention Krzysztof Kozlowski
2023-11-13 13:50   ` Conor Dooley
2023-11-13 13:50     ` Conor Dooley
2023-11-12 18:44 ` [PATCH 3/5] dt-bindings: gpu: samsung: constrain clocks in top-level properties Krzysztof Kozlowski
2023-11-13 13:51   ` Conor Dooley
2023-11-13 13:51     ` Conor Dooley
2023-11-16 16:28     ` Rob Herring [this message]
2023-11-16 16:28       ` Rob Herring
2023-11-16 17:17       ` Krzysztof Kozlowski
2023-11-16 17:17         ` Krzysztof Kozlowski
2023-11-16 17:24         ` Conor Dooley
2023-11-16 17:24           ` Conor Dooley
2023-11-12 18:44 ` [PATCH 4/5] dt-bindings: gpu: samsung-g2d: constrain iommus and power-domains Krzysztof Kozlowski
2023-11-13 13:49   ` Conor Dooley
2023-11-13 13:49     ` Conor Dooley
2023-11-12 18:44 ` [PATCH 5/5] dt-bindings: gpu: samsung-scaler: " Krzysztof Kozlowski
2023-11-13 13:49   ` Conor Dooley
2023-11-13 13:49     ` Conor Dooley
2023-11-13 13:48 ` [PATCH 1/5] dt-bindings: gpu: samsung-rotator: drop redundant quotes Conor Dooley
2023-11-13 13:48   ` Conor Dooley
2023-11-14 15:21 ` Rob Herring
2023-11-14 15:21   ` Rob Herring
2023-12-08 13:20 ` Rob Herring
2023-12-08 13:20   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231116162855.GA2435337-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.