[Intel-xe] [PATCH 0/2] drm/xe: Fix display build with W=1

[Intel-xe] [PATCH 0/2] drm/xe: Fix display build with W=1

[Lucas De Marchi]

Remaining 2 fixups to finally get xe with CONFIG_DRM_XE_DISPLAY to build
with W=1.

Lucas De Marchi (2):
  fixup! drm/xe/display: Implement display support
  fixup! drm/xe/display: Create a dummy version for vga decode

 drivers/gpu/drm/xe/display/intel_fbdev_fb.c  | 2 ++
 drivers/gpu/drm/xe/display/xe_display_misc.c | 2 ++
 2 files changed, 4 insertions(+)

-- 
2.40.1

[Intel-xe] [PATCH 1/2] fixup! drm/xe/display: Implement display support

[Lucas De Marchi]

Add missing header to fix warning while building with W=1:

	  CC [M]  drivers/gpu/drm/xe/display/intel_fbdev_fb.o
	../drivers/gpu/drm/xe/display/intel_fbdev_fb.c:14:25: error: no previous prototype for ‘intel_fbdev_fb_alloc’ [-Werror=missing-prototypes]
	   14 | struct drm_framebuffer *intel_fbdev_fb_alloc(struct drm_fb_helper *helper,
	      |                         ^~~~~~~~~~~~~~~~~~~~
	../drivers/gpu/drm/xe/display/intel_fbdev_fb.c:77:5: error: no previous prototype for ‘intel_fbdev_fb_fill_info’ [-Werror=missing-prototypes]
	   77 | int intel_fbdev_fb_fill_info(struct drm_i915_private *i915, struct fb_info *info,
	      |     ^~~~~~~~~~~~~~~~~~~~~~~~
	cc1: all warnings being treated as errors

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
index 961b26e267ec..51ae3561fd0d 100644
--- a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
+++ b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
@@ -3,6 +3,8 @@
  * Copyright © 2023 Intel Corporation
  */
 
+#include "intel_fbdev_fb.h"
+
 #include <drm/drm_fb_helper.h>
 
 #include "xe_gt.h"
-- 
2.40.1

[Intel-xe] [PATCH 2/2] fixup! drm/xe/display: Create a dummy version for vga decode

[Lucas De Marchi]

Fix build with W=1:

	  CC [M]  drivers/gpu/drm/xe/display/intel_fbdev_fb.o
	../drivers/gpu/drm/xe/display/xe_display_misc.c:10:14: error: no previous prototype for ‘intel_gmch_vga_set_decode’ [-Werror=missing-prototypes]
	   10 | unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
	      |              ^~~~~~~~~~~~~~~~~~~~~~~~~
	cc1: all warnings being treated as errors

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/display/xe_display_misc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c b/drivers/gpu/drm/xe/display/xe_display_misc.c
index 81ff97e704ea..242c2ef4ca93 100644
--- a/drivers/gpu/drm/xe/display/xe_display_misc.c
+++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
@@ -7,6 +7,8 @@
 
 struct pci_dev;
 
+unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode);
+
 unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
 {
 	/* ToDo: Implement the actual handling of vga decode */
-- 
2.40.1

Re: [Intel-xe] [PATCH 1/2] fixup! drm/xe/display: Implement display support

[Gustavo Sousa]

Quoting Lucas De Marchi (2023-11-17 14:56:23-03:00)
>Add missing header to fix warning while building with W=1:
>
>          CC [M]  drivers/gpu/drm/xe/display/intel_fbdev_fb.o
>        ../drivers/gpu/drm/xe/display/intel_fbdev_fb.c:14:25: error: no previous prototype for ‘intel_fbdev_fb_alloc’ [-Werror=missing-prototypes]
>           14 | struct drm_framebuffer *intel_fbdev_fb_alloc(struct drm_fb_helper *helper,
>              |                         ^~~~~~~~~~~~~~~~~~~~
>        ../drivers/gpu/drm/xe/display/intel_fbdev_fb.c:77:5: error: no previous prototype for ‘intel_fbdev_fb_fill_info’ [-Werror=missing-prototypes]
>           77 | int intel_fbdev_fb_fill_info(struct drm_i915_private *i915, struct fb_info *info,
>              |     ^~~~~~~~~~~~~~~~~~~~~~~~
>        cc1: all warnings being treated as errors
>
>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
>index 961b26e267ec..51ae3561fd0d 100644
>--- a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
>+++ b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
>@@ -3,6 +3,8 @@
>  * Copyright © 2023 Intel Corporation
>  */
> 
>+#include "intel_fbdev_fb.h"
>+
> #include <drm/drm_fb_helper.h>
> 
> #include "xe_gt.h"
>-- 
>2.40.1
>

Re: [Intel-xe] [PATCH 2/2] fixup! drm/xe/display: Create a dummy version for vga decode

[Gustavo Sousa]

Quoting Lucas De Marchi (2023-11-17 14:56:24-03:00)
>Fix build with W=1:
>
>          CC [M]  drivers/gpu/drm/xe/display/intel_fbdev_fb.o
>        ../drivers/gpu/drm/xe/display/xe_display_misc.c:10:14: error: no previous prototype for ‘intel_gmch_vga_set_decode’ [-Werror=missing-prototypes]
>           10 | unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
>              |              ^~~~~~~~~~~~~~~~~~~~~~~~~
>        cc1: all warnings being treated as errors
>
>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>---
> drivers/gpu/drm/xe/display/xe_display_misc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/display/xe_display_misc.c b/drivers/gpu/drm/xe/display/xe_display_misc.c
>index 81ff97e704ea..242c2ef4ca93 100644
>--- a/drivers/gpu/drm/xe/display/xe_display_misc.c
>+++ b/drivers/gpu/drm/xe/display/xe_display_misc.c
>@@ -7,6 +7,8 @@
> 
> struct pci_dev;
> 
>+unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode);
>+

Not pretty, but gets the job done.

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

> unsigned int intel_gmch_vga_set_decode(struct pci_dev *pdev, bool enable_decode)
> {
>         /* ToDo: Implement the actual handling of vga decode */
>-- 
>2.40.1
>

[Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: Fix display build with W=1 (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe: Fix display build with W=1 (rev2)
URL   : https://patchwork.freedesktop.org/series/126598/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: 723ff01a3 drm/xe: ATS-M device ID update
=== git am output follows ===
error: patch failed: drivers/gpu/drm/xe/display/intel_fbdev_fb.c:3
error: drivers/gpu/drm/xe/display/intel_fbdev_fb.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: fixup! drm/xe/display: Implement display support
Patch failed at 0001 fixup! drm/xe/display: Implement display support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

[Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: Fix display build with W=1 (rev3)

[Patchwork]

== Series Details ==

Series: drm/xe: Fix display build with W=1 (rev3)
URL   : https://patchwork.freedesktop.org/series/126598/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: 89e2bb1e1 fixup! drm/xe: Moving and renaming existing frequency sysfs attributes
=== git am output follows ===
error: patch failed: drivers/gpu/drm/xe/display/intel_fbdev_fb.c:3
error: drivers/gpu/drm/xe/display/intel_fbdev_fb.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: fixup! drm/xe/display: Implement display support
Patch failed at 0001 fixup! drm/xe/display: Implement display support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

[Intel-xe] ✗ CI.Patch_applied: failure for drm/xe: Fix display build with W=1 (rev2)

[Patchwork]

== Series Details ==

Series: drm/xe: Fix display build with W=1 (rev2)
URL   : https://patchwork.freedesktop.org/series/126598/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-xe-next' with base: ===
Base commit: 89e2bb1e1 fixup! drm/xe: Moving and renaming existing frequency sysfs attributes
=== git am output follows ===
error: patch failed: drivers/gpu/drm/xe/display/intel_fbdev_fb.c:3
error: drivers/gpu/drm/xe/display/intel_fbdev_fb.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: fixup! drm/xe/display: Implement display support
Patch failed at 0001 fixup! drm/xe/display: Implement display support
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".