* [PATCH] Tried removing the error
@ 2023-11-19 6:55 ` attreyee-muk
0 siblings, 0 replies; 2+ messages in thread
From: attreyee-muk @ 2023-11-19 6:55 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
syzbot+ef3256a360c02207a4cb
Cc: attreyee-muk, syzkaller-bugs, dri-devel, linux-kernel
Respected maintainers,
Looking at the code and the call trace reported by Syzbot, I understood
that the issue lies in the drm_gem.c file in
drm_gem_object_handle_put_unlocked(obj);. As per my understanding, I
believe that a warning is given out when the DRM GEM object handle gets
destroyed along with the function getting returned immediately. To take
care of the warning only, I think that the WARN_ON can be removed with
only the function getting returned when the object handle gets
destroyed, without a warning. Or else, we can even have a message
logging in the place of a direct warning which will give out the
information that the object handle has been destroyed. I also think that
the WARN_ON is given for debugging purposes and hence proposing a
solution if the warning can be replaced with a simple message log.
I am looking forward to getting help in this regard from the respected maintainers.
Thank You
Attreyee Mukherjee
Signed-off-by: attreyee-muk <tintinm2017@gmail.com>
---
drivers/gpu/drm/drm_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 44a948b80ee1..b6be9400cd11 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -222,7 +222,7 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
struct drm_device *dev = obj->dev;
bool final = false;
- if (WARN_ON(READ_ONCE(obj->handle_count) == 0))
+ if (READ_ONCE(obj->handle_count) == 0)
return;
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Tried removing the error
@ 2023-11-19 6:55 ` attreyee-muk
0 siblings, 0 replies; 2+ messages in thread
From: attreyee-muk @ 2023-11-19 6:55 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
syzbot+ef3256a360c02207a4cb
Cc: syzkaller-bugs, linux-kernel, dri-devel, attreyee-muk
Respected maintainers,
Looking at the code and the call trace reported by Syzbot, I understood
that the issue lies in the drm_gem.c file in
drm_gem_object_handle_put_unlocked(obj);. As per my understanding, I
believe that a warning is given out when the DRM GEM object handle gets
destroyed along with the function getting returned immediately. To take
care of the warning only, I think that the WARN_ON can be removed with
only the function getting returned when the object handle gets
destroyed, without a warning. Or else, we can even have a message
logging in the place of a direct warning which will give out the
information that the object handle has been destroyed. I also think that
the WARN_ON is given for debugging purposes and hence proposing a
solution if the warning can be replaced with a simple message log.
I am looking forward to getting help in this regard from the respected maintainers.
Thank You
Attreyee Mukherjee
Signed-off-by: attreyee-muk <tintinm2017@gmail.com>
---
drivers/gpu/drm/drm_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 44a948b80ee1..b6be9400cd11 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -222,7 +222,7 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
struct drm_device *dev = obj->dev;
bool final = false;
- if (WARN_ON(READ_ONCE(obj->handle_count) == 0))
+ if (READ_ONCE(obj->handle_count) == 0)
return;
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-19 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-19 6:55 [PATCH] Tried removing the error attreyee-muk
2023-11-19 6:55 ` attreyee-muk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.