All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
@ 2023-11-22  6:31 Khem Raj
  2023-11-22  6:31 ` [PATCH v9 2/3] vte: Upgrade to 0.74.1 Khem Raj
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Khem Raj @ 2023-11-22  6:31 UTC (permalink / raw)
  To: openembedded-core; +Cc: Markus Volk, Khem Raj, Alexandre Belloni

From: Markus Volk <f_l_k@t-online.de>

Rework recipe

- remove legacy of the autotools buildsystem
- remove BBCLASSEXTEND
- build	vapi dependent on gi-data
- docs require gir, add	a EXTRA_OEMESON:append to avoid	fail in
  a combination	where docs=true	and gir=false
- gtk+3 and gtk4 are requested by default-> add gtk4 depending
  on DISTRO_FEATURE
- install systemd support files	depending on DISTRO_FEATURE
- update 0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch

(From OE-Core rev: f9ddacafbdcf0539a8d5eecfa981194b401f1062)

Signed-off-by: Markus Volk <f_l_k@t-online.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
v9: Rebased

 ...EXITCODE-macro-for-non-glibc-systems.patch | 35 ++++++++-----------
 .../vte/{vte_0.72.2.bb => vte_0.74.0.bb}      | 29 ++++++---------
 2 files changed, 25 insertions(+), 39 deletions(-)
 rename meta/recipes-support/vte/{vte_0.72.2.bb => vte_0.74.0.bb} (66%)

diff --git a/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch b/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch
index b4100fc381e..8934d5f80a6 100644
--- a/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch
+++ b/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch
@@ -11,32 +11,25 @@ Upstream-Status: Submitted [1]
 Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
 
 [1] https://gitlab.gnome.org/GNOME/vte/issues/72
-
 ---
- src/missing.hh | 4 ++++
- src/widget.cc  | 1 +
- 2 files changed, 5 insertions(+)
+ src/widget.cc  | 4 +++
+ 1 files changed, 4 insertions(+)
 
---- a/src/missing.hh
-+++ b/src/missing.hh
-@@ -24,6 +24,10 @@
- #define NSIG (8 * sizeof(sigset_t))
- #endif
+diff --git a/src/widget.cc b/src/widget.cc
+index 07f7cabf..31a77f68 100644
+--- a/src/widget.cc
++++ b/src/widget.cc
+@@ -16,6 +16,10 @@
+  * along with this library.  If not, see <https://www.gnu.org/licenses/>.
+  */
  
 +#ifndef W_EXITCODE
 +#define W_EXITCODE(ret, sig) ((ret) << 8 | (sig))
 +#endif
 +
- #ifndef HAVE_FDWALK
- int fdwalk(int (*cb)(void* data, int fd),
-            void* data);
---- a/src/widget.cc
-+++ b/src/widget.cc
-@@ -21,6 +21,7 @@
- #include "widget.hh"
- 
- #include <sys/wait.h> // for W_EXITCODE
-+#include "missing.hh" // for W_EXITCODE on non-glibc systems
+ #include "config.h"
  
- #include <exception>
- #include <new>
+ #include "widget.hh"
+-- 
+2.42.0
+
diff --git a/meta/recipes-support/vte/vte_0.72.2.bb b/meta/recipes-support/vte/vte_0.74.0.bb
similarity index 66%
rename from meta/recipes-support/vte/vte_0.72.2.bb
rename to meta/recipes-support/vte/vte_0.74.0.bb
index 44e71491f62..21203adcf79 100644
--- a/meta/recipes-support/vte/vte_0.72.2.bb
+++ b/meta/recipes-support/vte/vte_0.74.0.bb
@@ -16,32 +16,27 @@ DEPENDS = "glib-2.0 glib-2.0-native gtk+3 libpcre2 libxml2-native gperf-native i
 GIR_MESON_OPTION = 'gir'
 GIDOCGEN_MESON_OPTION = "docs"
 
-inherit gnomebase gi-docgen features_check upstream-version-is-even gobject-introspection
+inherit gnomebase gi-docgen features_check upstream-version-is-even gobject-introspection vala
 
-# vapigen.m4 is required when vala is not present (but the one from vala should be used normally)
 SRC_URI += "file://0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch"
-SRC_URI[archive.sha256sum] = "f7966fd185a6981f53964162b71cfef7e606495155d6f5827b72aa0dd6741c9e"
+SRC_URI[archive.sha256sum] = "9ae08f777952ba793221152d360550451580f42d3b570e3341ebb6841984c76b"
 
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
-# Help g-ir-scanner find the .so for linking
-do_compile:prepend() {
-    export GIR_EXTRA_LIBS_PATH="${B}/src/.libs"
-}
+EXTRA_OEMESON += "${@bb.utils.contains('GI_DATA_ENABLED', 'True', '-Dvapi=true', '-Dvapi=false', d)}"
+EXTRA_OEMESON:append = " ${@bb.utils.contains('GI_DATA_ENABLED', 'False', '-Ddocs=false', '', d)}"
 
-# Package additional files
-FILES:${PN}-dev += "${datadir}/vala/vapi/*"
-
-PACKAGECONFIG ??= "gnutls"
-PACKAGECONFIG[vala] = "-Dvapi=true,-Dvapi=false,vala-native vala"
+PACKAGECONFIG ??= " \
+	gnutls \
+	${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+	${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gtk4', '', d)} \
+"
+PACKAGECONFIG[gtk4] = "-Dgtk4=true,-Dgtk4=false,gtk4"
 PACKAGECONFIG[gnutls] = "-Dgnutls=true,-Dgnutls=false,gnutls"
 PACKAGECONFIG[systemd] = "-D_systemd=true,-D_systemd=false,systemd"
-# vala requires gir
-PACKAGECONFIG:remove:class-native = "vala"
-
-CFLAGS += "-D_GNU_SOURCE"
 
 PACKAGES =+ "libvte ${PN}-prompt"
+FILES:${PN} +="${systemd_user_unitdir}"
 FILES:libvte = "${libdir}/*.so.* ${libdir}/girepository-1.0/*"
 FILES:${PN}-prompt = " \
     ${sysconfdir}/profile.d \
@@ -49,5 +44,3 @@ FILES:${PN}-prompt = " \
 "
 
 FILES:${PN}-dev += "${datadir}/glade/"
-
-BBCLASSEXTEND = "native nativesdk"
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v9 2/3] vte: Upgrade to 0.74.1
  2023-11-22  6:31 [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Khem Raj
@ 2023-11-22  6:31 ` Khem Raj
  2023-11-22  6:31 ` [PATCH v9 3/3] image.bbclass: Add glib-2.0/schemas to MULTILIBRE_ALLOW_REP Khem Raj
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2023-11-22  6:31 UTC (permalink / raw)
  To: openembedded-core; +Cc: Khem Raj, Alexandre Belloni

* Inherit systemd class
* Add packageconfig for fribidi support

(From OE-Core rev: 6c952b332cc07aa0babec8bc2839b3701f308d54)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
v9: Rebased

 meta/recipes-support/vte/{vte_0.74.0.bb => vte_0.74.1.bb} | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 rename meta/recipes-support/vte/{vte_0.74.0.bb => vte_0.74.1.bb} (89%)

diff --git a/meta/recipes-support/vte/vte_0.74.0.bb b/meta/recipes-support/vte/vte_0.74.1.bb
similarity index 89%
rename from meta/recipes-support/vte/vte_0.74.0.bb
rename to meta/recipes-support/vte/vte_0.74.1.bb
index 21203adcf79..8a7054a13cd 100644
--- a/meta/recipes-support/vte/vte_0.74.0.bb
+++ b/meta/recipes-support/vte/vte_0.74.1.bb
@@ -16,10 +16,10 @@ DEPENDS = "glib-2.0 glib-2.0-native gtk+3 libpcre2 libxml2-native gperf-native i
 GIR_MESON_OPTION = 'gir'
 GIDOCGEN_MESON_OPTION = "docs"
 
-inherit gnomebase gi-docgen features_check upstream-version-is-even gobject-introspection vala
+inherit gnomebase gi-docgen features_check upstream-version-is-even gobject-introspection systemd vala
 
 SRC_URI += "file://0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch"
-SRC_URI[archive.sha256sum] = "9ae08f777952ba793221152d360550451580f42d3b570e3341ebb6841984c76b"
+SRC_URI[archive.sha256sum] = "2328c3f1c998350a18e0e513348e9fc581d57ea4e7b89aedf11e0e3c65042b4f"
 
 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
 
@@ -31,6 +31,7 @@ PACKAGECONFIG ??= " \
 	${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
 	${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gtk4', '', d)} \
 "
+PACKAGECONFIG[fribidi] = "-Dfribidi=true,-Dfribidi=false,fribidi"
 PACKAGECONFIG[gtk4] = "-Dgtk4=true,-Dgtk4=false,gtk4"
 PACKAGECONFIG[gnutls] = "-Dgnutls=true,-Dgnutls=false,gnutls"
 PACKAGECONFIG[systemd] = "-D_systemd=true,-D_systemd=false,systemd"
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v9 3/3] image.bbclass: Add glib-2.0/schemas to MULTILIBRE_ALLOW_REP
  2023-11-22  6:31 [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Khem Raj
  2023-11-22  6:31 ` [PATCH v9 2/3] vte: Upgrade to 0.74.1 Khem Raj
@ 2023-11-22  6:31 ` Khem Raj
  2023-11-24 15:02 ` [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Ross Burton
  2023-11-24 16:21 ` Ross Burton
  3 siblings, 0 replies; 10+ messages in thread
From: Khem Raj @ 2023-11-22  6:31 UTC (permalink / raw)
  To: openembedded-core; +Cc: Khem Raj, Ross Burton

This helps in allowing duplicate files for glib-2.0 schemas

Fixes
ERROR: core-image-sato-1.0-r0 do_rootfs: Multilib check error: duplicate files /mnt/b/yoe/master/build/tmp/work/qemux86_64-yoe-linux/core-image-sato/1.0/multilib/lib32/usr/share/glib-2.0/schemas/gschemas.compiled /mnt/b/yo
e/master/build/tmp/work/qemux86_64-yoe-linux/core-image-sato/1.0/rootfs/usr/share/glib-2.0/schemas/gschemas.compiled is not the same

[YOCTO #15291]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Ross Burton <ross.burton@arm.com>
---
v9: Rebased

 meta/classes-recipe/image.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/image.bbclass b/meta/classes-recipe/image.bbclass
index 7231fad940d..ace0441adbd 100644
--- a/meta/classes-recipe/image.bbclass
+++ b/meta/classes-recipe/image.bbclass
@@ -609,7 +609,7 @@ python create_symlinks() {
             bb.note("Skipping symlink, source does not exist: %s -> %s" % (dst, src))
 }
 
-MULTILIBRE_ALLOW_REP =. "${base_bindir}|${base_sbindir}|${bindir}|${sbindir}|${libexecdir}|${sysconfdir}|${nonarch_base_libdir}/udev|/lib/modules/[^/]*/modules.*|"
+MULTILIBRE_ALLOW_REP =. "${datadir}/glib-2.0/schemas|{base_bindir}|${base_sbindir}|${bindir}|${sbindir}|${libexecdir}|${sysconfdir}|${nonarch_base_libdir}/udev|/lib/modules/[^/]*/modules.*|"
 MULTILIB_CHECK_FILE = "${WORKDIR}/multilib_check.py"
 MULTILIB_TEMP_ROOTFS = "${WORKDIR}/multilib"
 
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
  2023-11-22  6:31 [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Khem Raj
  2023-11-22  6:31 ` [PATCH v9 2/3] vte: Upgrade to 0.74.1 Khem Raj
  2023-11-22  6:31 ` [PATCH v9 3/3] image.bbclass: Add glib-2.0/schemas to MULTILIBRE_ALLOW_REP Khem Raj
@ 2023-11-24 15:02 ` Ross Burton
  2023-11-24 16:21 ` Ross Burton
  3 siblings, 0 replies; 10+ messages in thread
From: Ross Burton @ 2023-11-24 15:02 UTC (permalink / raw)
  To: raj.khem; +Cc: OE Core mailing list, Markus Volk, Alexandre Belloni

I think you mean “0.72.2".

Ross

> On 22 Nov 2023, at 06:31, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> 
> From: Markus Volk <f_l_k@t-online.de>
> 
> Rework recipe
> 
> - remove legacy of the autotools buildsystem
> - remove BBCLASSEXTEND
> - build vapi dependent on gi-data
> - docs require gir, add a EXTRA_OEMESON:append to avoid fail in
>  a combination where docs=true and gir=false
> - gtk+3 and gtk4 are requested by default-> add gtk4 depending
>  on DISTRO_FEATURE
> - install systemd support files depending on DISTRO_FEATURE
> - update 0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch
> 
> (From OE-Core rev: f9ddacafbdcf0539a8d5eecfa981194b401f1062)
> 
> Signed-off-by: Markus Volk <f_l_k@t-online.de>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> v9: Rebased
> 
> ...EXITCODE-macro-for-non-glibc-systems.patch | 35 ++++++++-----------
> .../vte/{vte_0.72.2.bb => vte_0.74.0.bb}      | 29 ++++++---------
> 2 files changed, 25 insertions(+), 39 deletions(-)
> rename meta/recipes-support/vte/{vte_0.72.2.bb => vte_0.74.0.bb} (66%)
> 
> diff --git a/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch b/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch
> index b4100fc381e..8934d5f80a6 100644
> --- a/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch
> +++ b/meta/recipes-support/vte/vte/0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch
> @@ -11,32 +11,25 @@ Upstream-Status: Submitted [1]
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> 
> [1] https://gitlab.gnome.org/GNOME/vte/issues/72
> -
> ---
> - src/missing.hh | 4 ++++
> - src/widget.cc  | 1 +
> - 2 files changed, 5 insertions(+)
> + src/widget.cc  | 4 +++
> + 1 files changed, 4 insertions(+)
> 
> ---- a/src/missing.hh
> -+++ b/src/missing.hh
> -@@ -24,6 +24,10 @@
> - #define NSIG (8 * sizeof(sigset_t))
> - #endif
> +diff --git a/src/widget.cc b/src/widget.cc
> +index 07f7cabf..31a77f68 100644
> +--- a/src/widget.cc
> ++++ b/src/widget.cc
> +@@ -16,6 +16,10 @@
> +  * along with this library.  If not, see <https://www.gnu.org/licenses/>.
> +  */
> 
> +#ifndef W_EXITCODE
> +#define W_EXITCODE(ret, sig) ((ret) << 8 | (sig))
> +#endif
> +
> - #ifndef HAVE_FDWALK
> - int fdwalk(int (*cb)(void* data, int fd),
> -            void* data);
> ---- a/src/widget.cc
> -+++ b/src/widget.cc
> -@@ -21,6 +21,7 @@
> - #include "widget.hh"
> - 
> - #include <sys/wait.h> // for W_EXITCODE
> -+#include "missing.hh" // for W_EXITCODE on non-glibc systems
> + #include "config.h"
> 
> - #include <exception>
> - #include <new>
> + #include "widget.hh"
> +-- 
> +2.42.0
> +
> diff --git a/meta/recipes-support/vte/vte_0.72.2.bb b/meta/recipes-support/vte/vte_0.74.0.bb
> similarity index 66%
> rename from meta/recipes-support/vte/vte_0.72.2.bb
> rename to meta/recipes-support/vte/vte_0.74.0.bb
> index 44e71491f62..21203adcf79 100644
> --- a/meta/recipes-support/vte/vte_0.72.2.bb
> +++ b/meta/recipes-support/vte/vte_0.74.0.bb
> @@ -16,32 +16,27 @@ DEPENDS = "glib-2.0 glib-2.0-native gtk+3 libpcre2 libxml2-native gperf-native i
> GIR_MESON_OPTION = 'gir'
> GIDOCGEN_MESON_OPTION = "docs"
> 
> -inherit gnomebase gi-docgen features_check upstream-version-is-even gobject-introspection
> +inherit gnomebase gi-docgen features_check upstream-version-is-even gobject-introspection vala
> 
> -# vapigen.m4 is required when vala is not present (but the one from vala should be used normally)
> SRC_URI += "file://0001-Add-W_EXITCODE-macro-for-non-glibc-systems.patch"
> -SRC_URI[archive.sha256sum] = "f7966fd185a6981f53964162b71cfef7e606495155d6f5827b72aa0dd6741c9e"
> +SRC_URI[archive.sha256sum] = "9ae08f777952ba793221152d360550451580f42d3b570e3341ebb6841984c76b"
> 
> ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"
> 
> -# Help g-ir-scanner find the .so for linking
> -do_compile:prepend() {
> -    export GIR_EXTRA_LIBS_PATH="${B}/src/.libs"
> -}
> +EXTRA_OEMESON += "${@bb.utils.contains('GI_DATA_ENABLED', 'True', '-Dvapi=true', '-Dvapi=false', d)}"
> +EXTRA_OEMESON:append = " ${@bb.utils.contains('GI_DATA_ENABLED', 'False', '-Ddocs=false', '', d)}"
> 
> -# Package additional files
> -FILES:${PN}-dev += "${datadir}/vala/vapi/*"
> -
> -PACKAGECONFIG ??= "gnutls"
> -PACKAGECONFIG[vala] = "-Dvapi=true,-Dvapi=false,vala-native vala"
> +PACKAGECONFIG ??= " \
> + gnutls \
> + ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gtk4', '', d)} \
> +"
> +PACKAGECONFIG[gtk4] = "-Dgtk4=true,-Dgtk4=false,gtk4"
> PACKAGECONFIG[gnutls] = "-Dgnutls=true,-Dgnutls=false,gnutls"
> PACKAGECONFIG[systemd] = "-D_systemd=true,-D_systemd=false,systemd"
> -# vala requires gir
> -PACKAGECONFIG:remove:class-native = "vala"
> -
> -CFLAGS += "-D_GNU_SOURCE"
> 
> PACKAGES =+ "libvte ${PN}-prompt"
> +FILES:${PN} +="${systemd_user_unitdir}"
> FILES:libvte = "${libdir}/*.so.* ${libdir}/girepository-1.0/*"
> FILES:${PN}-prompt = " \
>     ${sysconfdir}/profile.d \
> @@ -49,5 +44,3 @@ FILES:${PN}-prompt = " \
> "
> 
> FILES:${PN}-dev += "${datadir}/glade/"
> -
> -BBCLASSEXTEND = "native nativesdk"
> -- 
> 2.43.0
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#191018): https://lists.openembedded.org/g/openembedded-core/message/191018
> Mute This Topic: https://lists.openembedded.org/mt/102744802/6875888
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
  2023-11-22  6:31 [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Khem Raj
                   ` (2 preceding siblings ...)
  2023-11-24 15:02 ` [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Ross Burton
@ 2023-11-24 16:21 ` Ross Burton
  2023-11-24 16:24   ` Ross Burton
  3 siblings, 1 reply; 10+ messages in thread
From: Ross Burton @ 2023-11-24 16:21 UTC (permalink / raw)
  To: raj.khem; +Cc: OE Core mailing list, Markus Volk, Alexandre Belloni

On 22 Nov 2023, at 06:31, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> +PACKAGECONFIG ??= " \
> + gnutls \
> + ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gtk4', '', d)} \
> +"
> +PACKAGECONFIG[gtk4] = "-Dgtk4=true,-Dgtk4=false,gtk4”

So for example a Sato system which is entirely 100% GTK+3 will now also pull in the entire GTK4 stack, right?

That’s clearly and obviously the wrong thing to do.

Split the packages so that the GTK3 binaries are in separate packages to the GTK4 binaries.

Ross


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
  2023-11-24 16:21 ` Ross Burton
@ 2023-11-24 16:24   ` Ross Burton
  2023-11-24 16:57     ` Khem Raj
  0 siblings, 1 reply; 10+ messages in thread
From: Ross Burton @ 2023-11-24 16:24 UTC (permalink / raw)
  To: OE Core mailing list; +Cc: raj.khem, Markus Volk, Alexandre Belloni



> On 24 Nov 2023, at 16:21, Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote:
> 
> On 22 Nov 2023, at 06:31, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
>> +PACKAGECONFIG ??= " \
>> + gnutls \
>> + ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
>> + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gtk4', '', d)} \
>> +"
>> +PACKAGECONFIG[gtk4] = "-Dgtk4=true,-Dgtk4=false,gtk4”
> 
> So for example a Sato system which is entirely 100% GTK+3 will now also pull in the entire GTK4 stack, right?
> 
> That’s clearly and obviously the wrong thing to do.
> 
> Split the packages so that the GTK3 binaries are in separate packages to the GTK4 binaries.

I can only presume nobody looks at buildhistory-diff, but this isn’t a subtle problem:

packages/core2-64-poky-linux/vte/vte-dbg: PKGSIZE changed from 7057208 to 14127056 (+100%)
packages/core2-64-poky-linux/vte/vte-dbg: RRECOMMENDS: removed "fribidi-dbg", added "gtk4-dbg libsystemd-dbg"
packages/core2-64-poky-linux/vte/vte-dev: RDEPENDS: added "gtk4-dev cairo-dev"
packages/core2-64-poky-linux/vte/vte-dev: PKGSIZE changed from 391257 to 815848 (+109%)
packages/core2-64-poky-linux/vte/vte-dev: RRECOMMENDS: removed "fribidi-dev", added "vala-dev libsystemd-dev gtk4-dev systemd-dev"
packages/core2-64-poky-linux/vte/vte-dev: FILELIST: added "/usr/include/vte-2.91-gtk4/vte/vte.h /usr/include/vte-2.91-gtk4/vte/vteglobals.h /usr/include/vte-2.91-gtk4/vte/vteenums.h /usr/include/vte-2.91-gtk4/vte/vteterminal.h /usr/share/gir-1.0/Vte-3.91.gir /usr/share/vala/vapi/vte-2.91-gtk4.vapi /usr/include/vte-2.91-gtk4/vte/vtemacros.h /usr/include/vte-2.91-gtk4/vte/vteregex.h /usr/share/vala/vapi/vte-2.91.deps /usr/include/vte-2.91-gtk4/vte/vtepty.h /usr/lib/libvte-2.91-gtk4.so /usr/share/vala/vapi/vte-2.91-gtk4.deps /usr/share/vala/vapi/vte-2.91.vapi /usr/include/vte-2.91-gtk4/vte/vtedeprecated.h /usr/include/vte-2.91-gtk4/vte/vtetypebuiltins.h /usr/lib/pkgconfig/vte-2.91-gtk4.pc /usr/include/vte-2.91-gtk4/vte/vtetypebuiltins-gtk4.h /usr/include/vte-2.91-gtk4/vte/vteversion.h"
packages/core2-64-poky-linux/vte/vte-locale-el: PKGSIZE changed from 1278 to 1622 (+27%)
packages/core2-64-poky-linux/vte/vte: RDEPENDS: added "gtk4 (['>= 4.12.3'])"
packages/core2-64-poky-linux/vte/vte: PKGSIZE changed from 93336 to 178466 (+91%)
packages/core2-64-poky-linux/vte/vte: FILELIST: added "/usr/lib/systemd/user/vte-spawn-.scope.d/defaults.conf /usr/bin/vte-2.91-gtk4”

Ross

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
  2023-11-24 16:24   ` Ross Burton
@ 2023-11-24 16:57     ` Khem Raj
  2023-11-24 17:01       ` Ross Burton
  0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2023-11-24 16:57 UTC (permalink / raw)
  To: Ross Burton; +Cc: Alexandre Belloni, Markus Volk, OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 2887 bytes --]

On Fri, Nov 24, 2023 at 8:24 AM Ross Burton <Ross.Burton@arm.com> wrote:

>
>
> > On 24 Nov 2023, at 16:21, Ross Burton via lists.openembedded.org
> <ross.burton=arm.com@lists.openembedded.org> wrote:
> >
> > On 22 Nov 2023, at 06:31, Khem Raj via lists.openembedded.org <raj.khem=
> gmail.com@lists.openembedded.org> wrote:
> >> +PACKAGECONFIG ??= " \
> >> + gnutls \
> >> + ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
> >> + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gtk4', '', d)} \
> >> +"
> >> +PACKAGECONFIG[gtk4] = "-Dgtk4=true,-Dgtk4=false,gtk4”
> >
> > So for example a Sato system which is entirely 100% GTK+3 will now also
> pull in the entire GTK4 stack, right?
> >
> > That’s clearly and obviously the wrong thing to do.
> >
> > Split the packages so that the GTK3 binaries are in separate packages to
> the GTK4 binaries.
>

Hmm interesting I wonder if it Will avoid adding the dependencies for dbg
and dev packages

>
> I can only presume nobody looks at buildhistory-diff, but this isn’t a
> subtle problem:




>
> packages/core2-64-poky-linux/vte/vte-dbg: PKGSIZE changed from 7057208 to
> 14127056 (+100%)
> packages/core2-64-poky-linux/vte/vte-dbg: RRECOMMENDS: removed
> "fribidi-dbg", added "gtk4-dbg libsystemd-dbg"
> packages/core2-64-poky-linux/vte/vte-dev: RDEPENDS: added "gtk4-dev
> cairo-dev"
> packages/core2-64-poky-linux/vte/vte-dev: PKGSIZE changed from 391257 to
> 815848 (+109%)
> packages/core2-64-poky-linux/vte/vte-dev: RRECOMMENDS: removed
> "fribidi-dev", added "vala-dev libsystemd-dev gtk4-dev systemd-dev"
> packages/core2-64-poky-linux/vte/vte-dev: FILELIST: added
> "/usr/include/vte-2.91-gtk4/vte/vte.h
> /usr/include/vte-2.91-gtk4/vte/vteglobals.h
> /usr/include/vte-2.91-gtk4/vte/vteenums.h
> /usr/include/vte-2.91-gtk4/vte/vteterminal.h
> /usr/share/gir-1.0/Vte-3.91.gir /usr/share/vala/vapi/vte-2.91-gtk4.vapi
> /usr/include/vte-2.91-gtk4/vte/vtemacros.h
> /usr/include/vte-2.91-gtk4/vte/vteregex.h
> /usr/share/vala/vapi/vte-2.91.deps /usr/include/vte-2.91-gtk4/vte/vtepty.h
> /usr/lib/libvte-2.91-gtk4.so /usr/share/vala/vapi/vte-2.91-gtk4.deps
> /usr/share/vala/vapi/vte-2.91.vapi
> /usr/include/vte-2.91-gtk4/vte/vtedeprecated.h
> /usr/include/vte-2.91-gtk4/vte/vtetypebuiltins.h
> /usr/lib/pkgconfig/vte-2.91-gtk4.pc
> /usr/include/vte-2.91-gtk4/vte/vtetypebuiltins-gtk4.h
> /usr/include/vte-2.91-gtk4/vte/vteversion.h"
> packages/core2-64-poky-linux/vte/vte-locale-el: PKGSIZE changed from 1278
> to 1622 (+27%)
> packages/core2-64-poky-linux/vte/vte: RDEPENDS: added "gtk4 (['>=
> 4.12.3'])"
> packages/core2-64-poky-linux/vte/vte: PKGSIZE changed from 93336 to 178466
> (+91%)
> packages/core2-64-poky-linux/vte/vte: FILELIST: added
> "/usr/lib/systemd/user/vte-spawn-.scope.d/defaults.conf
> /usr/bin/vte-2.91-gtk4”
>
> Ross

[-- Attachment #2: Type: text/html, Size: 4043 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
  2023-11-24 16:57     ` Khem Raj
@ 2023-11-24 17:01       ` Ross Burton
  2023-11-24 17:05         ` Khem Raj
  0 siblings, 1 reply; 10+ messages in thread
From: Ross Burton @ 2023-11-24 17:01 UTC (permalink / raw)
  To: Khem Raj; +Cc: Alexandre Belloni, Markus Volk, OE Core mailing list

> > Split the packages so that the GTK3 binaries are in separate packages to the GTK4 binaries.
> 
> Hmm interesting I wonder if it Will avoid adding the dependencies for dbg and dev packages 

It won’t, you’ll need to manually handle those dependencies.

Ross

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
  2023-11-24 17:01       ` Ross Burton
@ 2023-11-24 17:05         ` Khem Raj
  2023-11-24 17:42           ` Alexander Kanavin
  0 siblings, 1 reply; 10+ messages in thread
From: Khem Raj @ 2023-11-24 17:05 UTC (permalink / raw)
  To: Ross Burton; +Cc: Alexandre Belloni, Markus Volk, OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Fri, Nov 24, 2023 at 9:01 AM Ross Burton <Ross.Burton@arm.com> wrote:

> > > Split the packages so that the GTK3 binaries are in separate packages
> to the GTK4 binaries.
> >
> > Hmm interesting I wonder if it Will avoid adding the dependencies for
> dbg and dev packages
>
> It won’t, you’ll need to manually handle those dependencies.
>

Right. So the real question still remains regardless how this is packaged
which is can multilib rootfs have different glib cache

>
> Ross

[-- Attachment #2: Type: text/html, Size: 942 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0
  2023-11-24 17:05         ` Khem Raj
@ 2023-11-24 17:42           ` Alexander Kanavin
  0 siblings, 0 replies; 10+ messages in thread
From: Alexander Kanavin @ 2023-11-24 17:42 UTC (permalink / raw)
  To: Khem Raj
  Cc: Ross Burton, Alexandre Belloni, Markus Volk, OE Core mailing list

On Fri, 24 Nov 2023 at 18:05, Khem Raj <raj.khem@gmail.com> wrote:
>> > > Split the packages so that the GTK3 binaries are in separate packages to the GTK4 binaries.
>> >
>> > Hmm interesting I wonder if it Will avoid adding the dependencies for dbg and dev packages
>>
>> It won’t, you’ll need to manually handle those dependencies.
>
>
> Right. So the real question still remains regardless how this is packaged which is can multilib rootfs have different glib cache

That only becomes an issue once we have gtk4 in our multilib testing,
and as long as vte packaging splits the pieces properly (Ross's
buildhistory output shows it can be easily done), we don't have to
deal with it for now.

Markus, perhaps you can do it, as you have more experience in
gtk-related packaging?

Alex


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-11-24 17:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-22  6:31 [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Khem Raj
2023-11-22  6:31 ` [PATCH v9 2/3] vte: Upgrade to 0.74.1 Khem Raj
2023-11-22  6:31 ` [PATCH v9 3/3] image.bbclass: Add glib-2.0/schemas to MULTILIBRE_ALLOW_REP Khem Raj
2023-11-24 15:02 ` [OE-core] [PATCH v9 1/3] vte: upgrade 2.72.2 -> 2.74.0 Ross Burton
2023-11-24 16:21 ` Ross Burton
2023-11-24 16:24   ` Ross Burton
2023-11-24 16:57     ` Khem Raj
2023-11-24 17:01       ` Ross Burton
2023-11-24 17:05         ` Khem Raj
2023-11-24 17:42           ` Alexander Kanavin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.