* [PATCH -next 1/2] media: chips-media: wave5: Remove unneeded semicolon
@ 2023-11-27 0:59 Yang Li
2023-11-27 0:59 ` [PATCH -next 2/2] " Yang Li
2023-11-30 9:53 ` [PATCH -next 1/2] " Sebastian Fricke
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2023-11-27 0:59 UTC (permalink / raw)
To: nas.chung, jackson.lee, mchehab
Cc: linux-media, linux-kernel, Yang Li, Abaci Robot
./drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c:95:2-3: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7633
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
index f29cfa3af94a..8bbf9d10b467 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
@@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
break;
case VPU_INST_STATE_STOP:
break;
- };
+ }
dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
state_to_str(inst->state), state_to_str(state));
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next 2/2] media: chips-media: wave5: Remove unneeded semicolon
2023-11-27 0:59 [PATCH -next 1/2] media: chips-media: wave5: Remove unneeded semicolon Yang Li
@ 2023-11-27 0:59 ` Yang Li
2023-11-30 9:53 ` [PATCH -next 1/2] " Sebastian Fricke
1 sibling, 0 replies; 3+ messages in thread
From: Yang Li @ 2023-11-27 0:59 UTC (permalink / raw)
To: nas.chung, jackson.lee, mchehab
Cc: linux-media, linux-kernel, Yang Li, Abaci Robot
./drivers/media/platform/chips-media/wave5/wave5-hw.c
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7634
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/media/platform/chips-media/wave5/wave5-hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c
index 3fcb2d92add8..4606d3425339 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-hw.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c
@@ -2318,7 +2318,7 @@ static bool wave5_vpu_enc_check_common_param_valid(struct vpu_instance *inst,
param->intra_refresh_mode);
return false;
}
- };
+ }
return true;
invalid_refresh_argument:
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next 1/2] media: chips-media: wave5: Remove unneeded semicolon
2023-11-27 0:59 [PATCH -next 1/2] media: chips-media: wave5: Remove unneeded semicolon Yang Li
2023-11-27 0:59 ` [PATCH -next 2/2] " Yang Li
@ 2023-11-30 9:53 ` Sebastian Fricke
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Fricke @ 2023-11-30 9:53 UTC (permalink / raw)
To: Yang Li
Cc: nas.chung, jackson.lee, mchehab, linux-media, linux-kernel, Abaci Robot
Hey Yang,
On 27.11.2023 08:59, Yang Li wrote:
>./drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c:95:2-3: Unneeded semicolon
Just pasting this line here makes the commit look a bit confusing.
It would be enough to simply write:
A switch statement does not require a semicolon after the closing curly
bracket, remove it.
The same applies for the second patch.
Greetings,
Sebastian
>
>Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7633
>Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>---
> drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>index f29cfa3af94a..8bbf9d10b467 100644
>--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c
>@@ -92,7 +92,7 @@ static int switch_state(struct vpu_instance *inst, enum vpu_instance_state state
> break;
> case VPU_INST_STATE_STOP:
> break;
>- };
>+ }
>
> dev_dbg(inst->dev->dev, "Switch state from %s to %s.\n",
> state_to_str(inst->state), state_to_str(state));
>--
>2.20.1.7.g153144c
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-30 9:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-27 0:59 [PATCH -next 1/2] media: chips-media: wave5: Remove unneeded semicolon Yang Li
2023-11-27 0:59 ` [PATCH -next 2/2] " Yang Li
2023-11-30 9:53 ` [PATCH -next 1/2] " Sebastian Fricke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.