[PATCH V3 1/2] dt-bindings: clock: support i.MX93 Analog clock module

[PATCH V3 1/2] dt-bindings: clock: support i.MX93 Analog clock module

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Support i.MX93 Analog module which produces PLL and OSC for Clock
Controller Module

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
 Rename back to fsl,imx93-anatop.yaml

V2:
 Update subject and commit, rename file to fsl,imx93-analog.yaml

 .../bindings/clock/fsl,imx93-anatop.yaml      | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml

diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
new file mode 100644
index 000000000000..5d696ccc8986
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX93 Analog Clock Module
+
+maintainers:
+  - Peng Fan <peng.fan@nxp.com>
+
+description: |
+  NXP i.MX93 Analog module which produces PLL and OSC to Clock Controller
+  Module.
+
+properties:
+  compatible:
+    items:
+      - const: fsl,imx93-anatop
+
+  reg:
+    maxItems: 1
+
+  '#clock-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    clock-controller@44480000 {
+        compatible = "fsl,imx93-anatop";
+        reg = <0x44480000 0x2000>;
+        #clock-cells = <1>;
+    };
+
+...
-- 
2.37.1

[PATCH V3 1/2] dt-bindings: clock: support i.MX93 Analog clock module

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Support i.MX93 Analog module which produces PLL and OSC for Clock
Controller Module

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
 Rename back to fsl,imx93-anatop.yaml

V2:
 Update subject and commit, rename file to fsl,imx93-analog.yaml

 .../bindings/clock/fsl,imx93-anatop.yaml      | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml

diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
new file mode 100644
index 000000000000..5d696ccc8986
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX93 Analog Clock Module
+
+maintainers:
+  - Peng Fan <peng.fan@nxp.com>
+
+description: |
+  NXP i.MX93 Analog module which produces PLL and OSC to Clock Controller
+  Module.
+
+properties:
+  compatible:
+    items:
+      - const: fsl,imx93-anatop
+
+  reg:
+    maxItems: 1
+
+  '#clock-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    clock-controller@44480000 {
+        compatible = "fsl,imx93-anatop";
+        reg = <0x44480000 0x2000>;
+        #clock-cells = <1>;
+    };
+
+...
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V3 2/2] arm64: dts: imx93: update analog node

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

The analog module produces PLL and OSC for Clock Controller Module. Since
the binding doc has been updated to clock-controller for this module,
Let's also update the device tree node.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
 None
V2:
 Update subject/commit
 Drop node alias

 arch/arm64/boot/dts/freescale/imx93.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index ceccf4766440..235f1ae583e5 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -422,9 +422,10 @@ mediamix: power-domain@44462400 {
 				};
 			};
 
-			anatop: anatop@44480000 {
-				compatible = "fsl,imx93-anatop", "syscon";
+			clock-controller@44480000 {
+				compatible = "fsl,imx93-anatop";
 				reg = <0x44480000 0x2000>;
+				#clock-cells = <1>;
 			};
 
 			tmu: tmu@44482000 {
-- 
2.37.1

[PATCH V3 2/2] arm64: dts: imx93: update analog node

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

The analog module produces PLL and OSC for Clock Controller Module. Since
the binding doc has been updated to clock-controller for this module,
Let's also update the device tree node.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
 None
V2:
 Update subject/commit
 Drop node alias

 arch/arm64/boot/dts/freescale/imx93.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index ceccf4766440..235f1ae583e5 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -422,9 +422,10 @@ mediamix: power-domain@44462400 {
 				};
 			};
 
-			anatop: anatop@44480000 {
-				compatible = "fsl,imx93-anatop", "syscon";
+			clock-controller@44480000 {
+				compatible = "fsl,imx93-anatop";
 				reg = <0x44480000 0x2000>;
+				#clock-cells = <1>;
 			};
 
 			tmu: tmu@44482000 {
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V3 1/2] dt-bindings: clock: support i.MX93 Analog clock module

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]

On Wed, Oct 25, 2023 at 03:22:41PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Support i.MX93 Analog module which produces PLL and OSC for Clock
> Controller Module
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> ---
> V3:
>  Rename back to fsl,imx93-anatop.yaml
> 
> V2:
>  Update subject and commit, rename file to fsl,imx93-analog.yaml
> 
>  .../bindings/clock/fsl,imx93-anatop.yaml      | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> new file mode 100644
> index 000000000000..5d696ccc8986
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX93 Analog Clock Module
> +
> +maintainers:
> +  - Peng Fan <peng.fan@nxp.com>
> +
> +description: |
> +  NXP i.MX93 Analog module which produces PLL and OSC to Clock Controller
> +  Module.

As I mentioned before, the module contains a PLL and an oscillator, it
doesn't produce them.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH V3 1/2] dt-bindings: clock: support i.MX93 Analog clock module

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 1503 bytes --]

On Wed, Oct 25, 2023 at 03:22:41PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Support i.MX93 Analog module which produces PLL and OSC for Clock
> Controller Module
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> ---
> V3:
>  Rename back to fsl,imx93-anatop.yaml
> 
> V2:
>  Update subject and commit, rename file to fsl,imx93-analog.yaml
> 
>  .../bindings/clock/fsl,imx93-anatop.yaml      | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> new file mode 100644
> index 000000000000..5d696ccc8986
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX93 Analog Clock Module
> +
> +maintainers:
> +  - Peng Fan <peng.fan@nxp.com>
> +
> +description: |
> +  NXP i.MX93 Analog module which produces PLL and OSC to Clock Controller
> +  Module.

As I mentioned before, the module contains a PLL and an oscillator, it
doesn't produce them.

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V3 2/2] arm64: dts: imx93: update analog node

[Shawn Guo]

On Wed, Oct 25, 2023 at 03:22:42PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The analog module produces PLL and OSC for Clock Controller Module. Since
> the binding doc has been updated to clock-controller for this module,
> Let's also update the device tree node.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

s/analog/anatop

Fixed it up and applied.

Shawn

Re: [PATCH V3 2/2] arm64: dts: imx93: update analog node

[Shawn Guo]

On Wed, Oct 25, 2023 at 03:22:42PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The analog module produces PLL and OSC for Clock Controller Module. Since
> the binding doc has been updated to clock-controller for this module,
> Let's also update the device tree node.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

s/analog/anatop

Fixed it up and applied.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel