* [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
@ 2023-12-05 23:16 Gary Rookard
2023-12-05 23:16 ` [PATCH 1/5] staging: rtl8192e: renamed variable bRegShortGI20MHz Gary Rookard
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Gary Rookard @ 2023-12-05 23:16 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Hi,
This patch series renames (5) different variables with
checkpatch coding style issue, Avoid CamelCase.
Patch 1/5) renamed variable bRegShortGI20MHz
Patch 2/5) renamed variable bRegShortGI40MHz
Patch 3/5) renamed variable bRegBW40MHz
Patch 4/5) renamed variable bRegSuppCCK
Patch 5/5) renamed variable nAMSDU_MaxSize
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
*** BLURB HERE ***
Gary Rookard (5):
staging: rtl8192e: renamed variable bRegShortGI20MHz
staging: rtl8192e: renamed variable bRegShortGI40MHz
staging: rtl8192e: renamed variable bRegBW40MHz
staging: rtl8192e: renamed variable bRegSuppCCK
staging: rtl8192e: renamed variable nAMSDU_MaxSize
drivers/staging/rtl8192e/rtl819x_HT.h | 10 +++----
drivers/staging/rtl8192e/rtl819x_HTProc.c | 32 +++++++++++------------
2 files changed, 21 insertions(+), 21 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/5] staging: rtl8192e: renamed variable bRegShortGI20MHz
2023-12-05 23:16 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
@ 2023-12-05 23:16 ` Gary Rookard
2023-12-05 23:16 ` [PATCH 2/5] staging: rtl8192e: renamed variable bRegShortGI40MHz Gary Rookard
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Gary Rookard @ 2023-12-05 23:16 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegShortGI20MHz -> reg_short_gi_20mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index dd86faab6f53..411a1d61128c 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -98,7 +98,7 @@ struct rt_hi_throughput {
u8 cur_bw_40mhz;
u8 bRegShortGI40MHz;
u8 bCurShortGI40MHz;
- u8 bRegShortGI20MHz;
+ u8 reg_short_gi_20mhz;
u8 bCurShortGI20MHz;
u8 bRegSuppCCK;
u8 bCurSuppCCK;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index f263f329db77..c8792f6397ed 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -71,7 +71,7 @@ void ht_update_default_setting(struct rtllib_device *ieee)
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
- ht_info->bRegShortGI20MHz = 1;
+ ht_info->reg_short_gi_20mhz = 1;
ht_info->bRegShortGI40MHz = 1;
ht_info->bRegBW40MHz = 1;
@@ -478,7 +478,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
ht_info->cur_tx_bw40mhz = ((pPeerHTInfo->RecommemdedTxWidth == 1) ?
true : false);
- ht_info->bCurShortGI20MHz = ((ht_info->bRegShortGI20MHz) ?
+ ht_info->bCurShortGI20MHz = ((ht_info->reg_short_gi_20mhz) ?
((pPeerHTCap->ShortGI20Mhz == 1) ?
true : false) : false);
ht_info->bCurShortGI40MHz = ((ht_info->bRegShortGI40MHz) ?
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] staging: rtl8192e: renamed variable bRegShortGI40MHz
2023-12-05 23:16 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-05 23:16 ` [PATCH 1/5] staging: rtl8192e: renamed variable bRegShortGI20MHz Gary Rookard
@ 2023-12-05 23:16 ` Gary Rookard
2023-12-05 23:16 ` [PATCH 3/5] staging: rtl8192e: renamed variable bRegBW40MHz Gary Rookard
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Gary Rookard @ 2023-12-05 23:16 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegShortGI40MHz -> reg_short_gi_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index 411a1d61128c..825c60cbcacb 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -96,7 +96,7 @@ struct rt_hi_throughput {
u8 current_ht_support;
u8 bRegBW40MHz;
u8 cur_bw_40mhz;
- u8 bRegShortGI40MHz;
+ u8 reg_short_gi_40mhz;
u8 bCurShortGI40MHz;
u8 reg_short_gi_20mhz;
u8 bCurShortGI20MHz;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index c8792f6397ed..580b1423c46b 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -72,7 +72,7 @@ void ht_update_default_setting(struct rtllib_device *ieee)
struct rt_hi_throughput *ht_info = ieee->ht_info;
ht_info->reg_short_gi_20mhz = 1;
- ht_info->bRegShortGI40MHz = 1;
+ ht_info->reg_short_gi_40mhz = 1;
ht_info->bRegBW40MHz = 1;
@@ -481,7 +481,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
ht_info->bCurShortGI20MHz = ((ht_info->reg_short_gi_20mhz) ?
((pPeerHTCap->ShortGI20Mhz == 1) ?
true : false) : false);
- ht_info->bCurShortGI40MHz = ((ht_info->bRegShortGI40MHz) ?
+ ht_info->bCurShortGI40MHz = ((ht_info->reg_short_gi_40mhz) ?
((pPeerHTCap->ShortGI40Mhz == 1) ?
true : false) : false);
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] staging: rtl8192e: renamed variable bRegBW40MHz
2023-12-05 23:16 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-05 23:16 ` [PATCH 1/5] staging: rtl8192e: renamed variable bRegShortGI20MHz Gary Rookard
2023-12-05 23:16 ` [PATCH 2/5] staging: rtl8192e: renamed variable bRegShortGI40MHz Gary Rookard
@ 2023-12-05 23:16 ` Gary Rookard
2023-12-05 23:16 ` [PATCH 4/5] staging: rtl8192e: renamed variable bRegSuppCCK Gary Rookard
2023-12-05 23:16 ` [PATCH 5/5] staging: rtl8192e: renamed variable nAMSDU_MaxSize Gary Rookard
4 siblings, 0 replies; 11+ messages in thread
From: Gary Rookard @ 2023-12-05 23:16 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegBW40MHz -> reg_bw_40mhz
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index 825c60cbcacb..ef88d7d713fb 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -94,7 +94,7 @@ enum ht_aggre_mode {
struct rt_hi_throughput {
u8 enable_ht;
u8 current_ht_support;
- u8 bRegBW40MHz;
+ u8 reg_bw_40mhz;
u8 cur_bw_40mhz;
u8 reg_short_gi_40mhz;
u8 bCurShortGI40MHz;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 580b1423c46b..68ad082d41be 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -74,9 +74,9 @@ void ht_update_default_setting(struct rtllib_device *ieee)
ht_info->reg_short_gi_20mhz = 1;
ht_info->reg_short_gi_40mhz = 1;
- ht_info->bRegBW40MHz = 1;
+ ht_info->reg_bw_40mhz = 1;
- if (ht_info->bRegBW40MHz)
+ if (ht_info->reg_bw_40mhz)
ht_info->bRegSuppCCK = 1;
else
ht_info->bRegSuppCCK = true;
@@ -275,7 +275,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
pCapELE->ChlWidth = 0;
else
- pCapELE->ChlWidth = (pHT->bRegBW40MHz ? 1 : 0);
+ pCapELE->ChlWidth = (pHT->reg_bw_40mhz ? 1 : 0);
pCapELE->MimoPwrSave = pHT->self_mimo_ps;
pCapELE->GreenField = 0;
@@ -286,7 +286,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
pCapELE->RxSTBC = 0;
pCapELE->DelayBA = 0;
pCapELE->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0;
- pCapELE->DssCCk = ((pHT->bRegBW40MHz) ? (pHT->bRegSuppCCK ? 1 : 0) : 0);
+ pCapELE->DssCCk = ((pHT->reg_bw_40mhz) ? (pHT->bRegSuppCCK ? 1 : 0) : 0);
pCapELE->PSMP = 0;
pCapELE->LSigTxopProtect = 0;
@@ -734,7 +734,7 @@ void HTSetConnectBwMode(struct rtllib_device *ieee,
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
- if (!ht_info->bRegBW40MHz)
+ if (!ht_info->reg_bw_40mhz)
return;
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] staging: rtl8192e: renamed variable bRegSuppCCK
2023-12-05 23:16 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
` (2 preceding siblings ...)
2023-12-05 23:16 ` [PATCH 3/5] staging: rtl8192e: renamed variable bRegBW40MHz Gary Rookard
@ 2023-12-05 23:16 ` Gary Rookard
2023-12-05 23:16 ` [PATCH 5/5] staging: rtl8192e: renamed variable nAMSDU_MaxSize Gary Rookard
4 siblings, 0 replies; 11+ messages in thread
From: Gary Rookard @ 2023-12-05 23:16 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it bRegSuppCCK -> reg_supp_cck
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index ef88d7d713fb..c3efff2873d4 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -100,7 +100,7 @@ struct rt_hi_throughput {
u8 bCurShortGI40MHz;
u8 reg_short_gi_20mhz;
u8 bCurShortGI20MHz;
- u8 bRegSuppCCK;
+ u8 reg_supp_cck;
u8 bCurSuppCCK;
enum ht_spec_ver ePeerHTSpecVer;
struct ht_capab_ele SelfHTCap;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 68ad082d41be..910f8e9c9394 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -77,9 +77,9 @@ void ht_update_default_setting(struct rtllib_device *ieee)
ht_info->reg_bw_40mhz = 1;
if (ht_info->reg_bw_40mhz)
- ht_info->bRegSuppCCK = 1;
+ ht_info->reg_supp_cck = 1;
else
- ht_info->bRegSuppCCK = true;
+ ht_info->reg_supp_cck = true;
ht_info->nAMSDU_MaxSize = 7935UL;
ht_info->bAMSDU_Support = 0;
@@ -286,7 +286,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
pCapELE->RxSTBC = 0;
pCapELE->DelayBA = 0;
pCapELE->MaxAMSDUSize = (MAX_RECEIVE_BUFFER_SIZE >= 7935) ? 1 : 0;
- pCapELE->DssCCk = ((pHT->reg_bw_40mhz) ? (pHT->bRegSuppCCK ? 1 : 0) : 0);
+ pCapELE->DssCCk = ((pHT->reg_bw_40mhz) ? (pHT->reg_supp_cck ? 1 : 0) : 0);
pCapELE->PSMP = 0;
pCapELE->LSigTxopProtect = 0;
@@ -485,7 +485,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
((pPeerHTCap->ShortGI40Mhz == 1) ?
true : false) : false);
- ht_info->bCurSuppCCK = ((ht_info->bRegSuppCCK) ?
+ ht_info->bCurSuppCCK = ((ht_info->reg_supp_cck) ?
((pPeerHTCap->DssCCk == 1) ? true :
false) : false);
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] staging: rtl8192e: renamed variable nAMSDU_MaxSize
2023-12-05 23:16 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
` (3 preceding siblings ...)
2023-12-05 23:16 ` [PATCH 4/5] staging: rtl8192e: renamed variable bRegSuppCCK Gary Rookard
@ 2023-12-05 23:16 ` Gary Rookard
4 siblings, 0 replies; 11+ messages in thread
From: Gary Rookard @ 2023-12-05 23:16 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it nAMSDU_MaxSize -> amsdu_max_size
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HT.h | 2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h
index c3efff2873d4..5018c3905be8 100644
--- a/drivers/staging/rtl8192e/rtl819x_HT.h
+++ b/drivers/staging/rtl8192e/rtl819x_HT.h
@@ -108,7 +108,7 @@ struct rt_hi_throughput {
u8 PeerHTCapBuf[32];
u8 PeerHTInfoBuf[32];
u8 bAMSDU_Support;
- u16 nAMSDU_MaxSize;
+ u16 amsdu_max_size;
u8 bCurrent_AMSDU_Support;
u16 nCurrent_AMSDU_MaxSize;
u8 bAMPDUEnable;
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 910f8e9c9394..6475832f23f6 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -81,7 +81,7 @@ void ht_update_default_setting(struct rtllib_device *ieee)
else
ht_info->reg_supp_cck = true;
- ht_info->nAMSDU_MaxSize = 7935UL;
+ ht_info->amsdu_max_size = 7935UL;
ht_info->bAMSDU_Support = 0;
ht_info->bAMPDUEnable = 1;
@@ -493,10 +493,10 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
nMaxAMSDUSize = (pPeerHTCap->MaxAMSDUSize == 0) ? 3839 : 7935;
- if (ht_info->nAMSDU_MaxSize > nMaxAMSDUSize)
+ if (ht_info->amsdu_max_size > nMaxAMSDUSize)
ht_info->nCurrent_AMSDU_MaxSize = nMaxAMSDUSize;
else
- ht_info->nCurrent_AMSDU_MaxSize = ht_info->nAMSDU_MaxSize;
+ ht_info->nCurrent_AMSDU_MaxSize = ht_info->amsdu_max_size;
ht_info->current_ampdu_enable = ht_info->bAMPDUEnable;
if (ieee->rtllib_ap_sec_type &&
@@ -569,7 +569,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
ht_info->bCurSuppCCK = true;
ht_info->bCurrent_AMSDU_Support = false;
- ht_info->nCurrent_AMSDU_MaxSize = ht_info->nAMSDU_MaxSize;
+ ht_info->nCurrent_AMSDU_MaxSize = ht_info->amsdu_max_size;
ht_info->current_mpdu_density = ht_info->MPDU_Density;
ht_info->CurrentAMPDUFactor = ht_info->AMPDU_Factor;
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 21:56 ` Gary Rookard
@ 2023-12-09 17:16 ` Philipp Hortmann
0 siblings, 0 replies; 11+ messages in thread
From: Philipp Hortmann @ 2023-12-09 17:16 UTC (permalink / raw)
To: Gary Rookard; +Cc: gregkh, linux-staging, linux-kernel
On 12/8/23 22:56, Gary Rookard wrote:
>
> Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:
>
>> On 12/8/23 02:55, Gary Rookard wrote:
>>> Hi,
>>> This patch series renames 5 different variables with the checkpatch
>>> coding style issue, Avoid CamelCase.
>>> Patch 1/5) renamed variable bCurShortGI40MHz
>>> Patch 2/5) renamed variable bcurShortGI20MHz
>>> Patch 3/5) renamed variable CCKOFDMRate
>>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>>> Patch 5/5) renamed variable IOTPeer
>>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>>> Gary Rookard (5):
>>> staging: rtl8192e: renamed variable bCurShortGI40MHz
>>> staging: rtl8192e: renamed variable bCurShortGI20MHz
>>> staging: rtl8192e: renamed variable CCKOFDMRate
>>> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>>> staging: rtl8192e: renamed variable IOTPeer
>>> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
>>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
>>> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
>>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
>>> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
>>> 5 files changed, 47 insertions(+), 47 deletions(-)
>>>
>>
>>
>> Please use present-tense as outlined here:
>> https://kernelnewbies.org/PatchPhilosophy
>> So rename instead of renamed
>>
>> Please use a more unique Subject for your coverletter.
>> It often cannot cover everything. But more unique is better.
>>
>>
>>
>> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
>
> Okay, "rename" it be, instead of me thinking in the past simple tense,
> of "renamed".
>
> As for the coverletter(s)...repetition a big problem.
>
> There's not much in the way of uniqueness that can be added...regretfully
> Tagging the Subject line with a numeric value is possible and
> should deviate the coverletter(s) enough so they don't "appear the same".
> e.g. staging: rtl8192e: this patch series (1) blah blah blah...
> e.g. staging: rtl8192e: this patch series (2) blah blah blah...
> e.g. staging: rtl8192e: this patch series (3) " " "
>
> Regards,
> Gary
>
Hi Gary
Here is a proposal:
[PATCH 0/5] staging: rtl8192e: Rename variable bCurShortGI40MHz and further
That will give a pretty good recognizable name.
Thanks for your support.
Bye Philipp
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 17:49 ` Philipp Hortmann
2023-12-08 21:56 ` Gary Rookard
@ 2023-12-09 0:41 ` Gary Rookard
1 sibling, 0 replies; 11+ messages in thread
From: Gary Rookard @ 2023-12-09 0:41 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: gregkh, linux-staging, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]
Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:
> On 12/8/23 02:55, Gary Rookard wrote:
>> Hi,
>> This patch series renames 5 different variables with the checkpatch
>> coding style issue, Avoid CamelCase.
>> Patch 1/5) renamed variable bCurShortGI40MHz
>> Patch 2/5) renamed variable bcurShortGI20MHz
>> Patch 3/5) renamed variable CCKOFDMRate
>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>> Patch 5/5) renamed variable IOTPeer
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> Gary Rookard (5):
>> staging: rtl8192e: renamed variable bCurShortGI40MHz
>> staging: rtl8192e: renamed variable bCurShortGI20MHz
>> staging: rtl8192e: renamed variable CCKOFDMRate
>> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>> staging: rtl8192e: renamed variable IOTPeer
>> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
>> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
>> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
>> 5 files changed, 47 insertions(+), 47 deletions(-)
>>
>
>
> Please use present-tense as outlined here:
> https://kernelnewbies.org/PatchPhilosophy
> So rename instead of renamed
>
> Please use a more unique Subject for your coverletter.
> It often cannot cover everything. But more unique is better.
>
>
>
> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Okay, will use "rename" instead past simple tense "renamed"
The coverletter(s) are having a repetition problem, I can add an
numeric value to their Subject lines to "unique" them as there is not much
else available to do so with.
Regards,
Gary
--
Sent with my mu4e on Gentoo GNU/linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 17:49 ` Philipp Hortmann
@ 2023-12-08 21:56 ` Gary Rookard
2023-12-09 17:16 ` Philipp Hortmann
2023-12-09 0:41 ` Gary Rookard
1 sibling, 1 reply; 11+ messages in thread
From: Gary Rookard @ 2023-12-08 21:56 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: gregkh, linux-staging, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]
Philipp Hortmann <philipp.g.hortmann@gmail.com> writes:
> On 12/8/23 02:55, Gary Rookard wrote:
>> Hi,
>> This patch series renames 5 different variables with the checkpatch
>> coding style issue, Avoid CamelCase.
>> Patch 1/5) renamed variable bCurShortGI40MHz
>> Patch 2/5) renamed variable bcurShortGI20MHz
>> Patch 3/5) renamed variable CCKOFDMRate
>> Patch 4/5) renamed variable HTIOTActIsCCDFsync
>> Patch 5/5) renamed variable IOTPeer
>> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>> Gary Rookard (5):
>> staging: rtl8192e: renamed variable bCurShortGI40MHz
>> staging: rtl8192e: renamed variable bCurShortGI20MHz
>> staging: rtl8192e: renamed variable CCKOFDMRate
>> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>> staging: rtl8192e: renamed variable IOTPeer
>> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
>> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
>> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
>> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
>> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
>> 5 files changed, 47 insertions(+), 47 deletions(-)
>>
>
>
> Please use present-tense as outlined here:
> https://kernelnewbies.org/PatchPhilosophy
> So rename instead of renamed
>
> Please use a more unique Subject for your coverletter.
> It often cannot cover everything. But more unique is better.
>
>
>
> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Okay, "rename" it be, instead of me thinking in the past simple tense,
of "renamed".
As for the coverletter(s)...repetition a big problem.
There's not much in the way of uniqueness that can be added...regretfully
Tagging the Subject line with a numeric value is possible and
should deviate the coverletter(s) enough so they don't "appear the same".
e.g. staging: rtl8192e: this patch series (1) blah blah blah...
e.g. staging: rtl8192e: this patch series (2) blah blah blah...
e.g. staging: rtl8192e: this patch series (3) " " "
Regards,
Gary
--
Sent with my mu4e on Gentoo GNU/linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 869 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
2023-12-08 1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
@ 2023-12-08 17:49 ` Philipp Hortmann
2023-12-08 21:56 ` Gary Rookard
2023-12-09 0:41 ` Gary Rookard
0 siblings, 2 replies; 11+ messages in thread
From: Philipp Hortmann @ 2023-12-08 17:49 UTC (permalink / raw)
To: Gary Rookard, gregkh; +Cc: linux-staging, linux-kernel
On 12/8/23 02:55, Gary Rookard wrote:
> Hi,
>
> This patch series renames 5 different variables with the checkpatch
> coding style issue, Avoid CamelCase.
>
> Patch 1/5) renamed variable bCurShortGI40MHz
> Patch 2/5) renamed variable bcurShortGI20MHz
> Patch 3/5) renamed variable CCKOFDMRate
> Patch 4/5) renamed variable HTIOTActIsCCDFsync
> Patch 5/5) renamed variable IOTPeer
>
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>
>
> Gary Rookard (5):
> staging: rtl8192e: renamed variable bCurShortGI40MHz
> staging: rtl8192e: renamed variable bCurShortGI20MHz
> staging: rtl8192e: renamed variable CCKOFDMRate
> staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
> staging: rtl8192e: renamed variable IOTPeer
>
> .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
> drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
> drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
> 5 files changed, 47 insertions(+), 47 deletions(-)
>
Please use present-tense as outlined here:
https://kernelnewbies.org/PatchPhilosophy
So rename instead of renamed
Please use a more unique Subject for your coverletter.
It often cannot cover everything. But more unique is better.
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
@ 2023-12-08 1:55 Gary Rookard
2023-12-08 17:49 ` Philipp Hortmann
0 siblings, 1 reply; 11+ messages in thread
From: Gary Rookard @ 2023-12-08 1:55 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Hi,
This patch series renames 5 different variables with the checkpatch
coding style issue, Avoid CamelCase.
Patch 1/5) renamed variable bCurShortGI40MHz
Patch 2/5) renamed variable bcurShortGI20MHz
Patch 3/5) renamed variable CCKOFDMRate
Patch 4/5) renamed variable HTIOTActIsCCDFsync
Patch 5/5) renamed variable IOTPeer
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
Gary Rookard (5):
staging: rtl8192e: renamed variable bCurShortGI40MHz
staging: rtl8192e: renamed variable bCurShortGI20MHz
staging: rtl8192e: renamed variable CCKOFDMRate
staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
staging: rtl8192e: renamed variable IOTPeer
.../staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 22 +++----
drivers/staging/rtl8192e/rtl819x_HT.h | 6 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c | 58 +++++++++----------
drivers/staging/rtl8192e/rtllib_tx.c | 4 +-
5 files changed, 47 insertions(+), 47 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-12-09 17:16 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-05 23:16 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-05 23:16 ` [PATCH 1/5] staging: rtl8192e: renamed variable bRegShortGI20MHz Gary Rookard
2023-12-05 23:16 ` [PATCH 2/5] staging: rtl8192e: renamed variable bRegShortGI40MHz Gary Rookard
2023-12-05 23:16 ` [PATCH 3/5] staging: rtl8192e: renamed variable bRegBW40MHz Gary Rookard
2023-12-05 23:16 ` [PATCH 4/5] staging: rtl8192e: renamed variable bRegSuppCCK Gary Rookard
2023-12-05 23:16 ` [PATCH 5/5] staging: rtl8192e: renamed variable nAMSDU_MaxSize Gary Rookard
2023-12-08 1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-08 17:49 ` Philipp Hortmann
2023-12-08 21:56 ` Gary Rookard
2023-12-09 17:16 ` Philipp Hortmann
2023-12-09 0:41 ` Gary Rookard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.