[tglx-devel:timers/pushpull 30/32] kernel/time/timer_migration.c:1529 tmigr_cpu_online() warn: unsigned 'ret' is never less than zero.

[tglx-devel:timers/pushpull 30/32] kernel/time/timer_migration.c:1529 tmigr_cpu_online() warn: unsigned 'ret' is never less than zero.

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git timers/pushpull
head:   c5f729902c462bd2f9153641aebe042bbb5f9ede
commit: f7012466efc3b7e5a3220e702ada7e51245caf20 [30/32] timers: Implement the hierarchical pull model
config: x86_64-randconfig-161-20231203 (https://download.01.org/0day-ci/archive/20231206/202312060700.eMx860Ek-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231206/202312060700.eMx860Ek-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312060700.eMx860Ek-lkp@intel.com/

smatch warnings:
kernel/time/timer_migration.c:1529 tmigr_cpu_online() warn: unsigned 'ret' is never less than zero.

vim +/ret +1529 kernel/time/timer_migration.c

  1518	
  1519	static int tmigr_cpu_online(unsigned int cpu)
  1520	{
  1521		struct tmigr_cpu *tmc = this_cpu_ptr(&tmigr_cpu);
  1522		unsigned int ret;
  1523	
  1524		/* First online attempt? Initialize CPU data */
  1525		if (!tmc->tmgroup) {
  1526			raw_spin_lock_init(&tmc->lock);
  1527	
  1528			ret = tmigr_add_cpu(cpu);
> 1529			if (ret < 0)
  1530				return ret;
  1531	
  1532			if (tmc->childmask == 0)
  1533				return -EINVAL;
  1534	
  1535			timerqueue_init(&tmc->cpuevt.nextevt);
  1536			tmc->cpuevt.nextevt.expires = KTIME_MAX;
  1537			tmc->cpuevt.ignore = true;
  1538			tmc->cpuevt.cpu = cpu;
  1539	
  1540			tmc->remote = false;
  1541			WRITE_ONCE(tmc->wakeup, KTIME_MAX);
  1542		}
  1543		raw_spin_lock_irq(&tmc->lock);
  1544		if (timer_base_is_idle())
  1545			tmc->idle = true;
  1546		else
  1547			__tmigr_cpu_activate(tmc);
  1548		tmc->online = true;
  1549		raw_spin_unlock_irq(&tmc->lock);
  1550		return 0;
  1551	}
  1552	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki