* drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
@ 2023-12-05 23:45 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-12-05 23:45 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Yang Yingliang <yangyingliang@huawei.com>
CC: Geert Uytterhoeven <geert+renesas@glider.be>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bee0e7762ad2c6025b9f5245c040fcc36ef2bde8
commit: 5376e3d904532e657fd7ca1a9b1ff3d351527b90 pinctrl: renesas: core: Fix possible null-ptr-deref in sh_pfc_map_resources()
date: 1 year, 7 months ago
:::::: branch date: 26 hours ago
:::::: commit date: 1 year, 7 months ago
config: riscv-randconfig-r071-20231112 (https://download.01.org/0day-ci/archive/20231206/202312060743.IxWpeHu3-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231206/202312060743.IxWpeHu3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312060743.IxWpeHu3-lkp@intel.com/
smatch warnings:
drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
vim +/res +77 drivers/pinctrl/renesas/core.c
f9165132c5ee68 drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 29
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 30 static int sh_pfc_map_resources(struct sh_pfc *pfc,
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 31 struct platform_device *pdev)
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 32 {
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 33 struct sh_pfc_window *windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 34 unsigned int *irqs = NULL;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 35 unsigned int num_windows;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 36 struct resource *res;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 37 unsigned int i;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 38 int num_irqs;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 39
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 40 /* Count the MEM and IRQ resources. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 41 for (num_windows = 0;; num_windows++) {
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 42 res = platform_get_resource(pdev, IORESOURCE_MEM, num_windows);
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 @43 if (!res)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 44 break;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 45 }
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 46 if (num_windows == 0)
bee9f22ba196b0 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-02-16 47 return -EINVAL;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 48
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 49 num_irqs = platform_irq_count(pdev);
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 50 if (num_irqs < 0)
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 51 return num_irqs;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 52
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 53 /* Allocate memory windows and IRQs arrays. */
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 54 windows = devm_kcalloc(pfc->dev, num_windows, sizeof(*windows),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 55 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 56 if (windows == NULL)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 57 return -ENOMEM;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 58
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 59 pfc->num_windows = num_windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 60 pfc->windows = windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 61
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 62 if (num_irqs) {
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 63 irqs = devm_kcalloc(pfc->dev, num_irqs, sizeof(*irqs),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 64 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 65 if (irqs == NULL)
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 66 return -ENOMEM;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 67
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 68 pfc->num_irqs = num_irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 69 pfc->irqs = irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 70 }
973931ae0a2dad drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 71
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 72 /* Fill them. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 73 for (i = 0; i < num_windows; i++) {
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 74 windows->virt = devm_platform_get_and_ioremap_resource(pdev, i, &res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 75 if (IS_ERR(windows->virt))
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 76 return -ENOMEM;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 @77 windows->phys = res->start;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 78 windows->size = resource_size(res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 79 windows++;
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 80 }
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 81 for (i = 0; i < num_irqs; i++)
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 82 *irqs++ = platform_get_irq(pdev, i);
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 83
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 84 return 0;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 85 }
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 86
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
@ 2023-12-12 13:21 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-12-12 13:21 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Yang Yingliang <yangyingliang@huawei.com>
CC: Geert Uytterhoeven <geert+renesas@glider.be>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 26aff849438cebcd05f1a647390c4aa700d5c0f1
commit: 5376e3d904532e657fd7ca1a9b1ff3d351527b90 pinctrl: renesas: core: Fix possible null-ptr-deref in sh_pfc_map_resources()
date: 1 year, 7 months ago
:::::: branch date: 13 hours ago
:::::: commit date: 1 year, 7 months ago
config: riscv-randconfig-r071-20231112 (https://download.01.org/0day-ci/archive/20231212/202312122151.4L2hFzks-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231212/202312122151.4L2hFzks-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312122151.4L2hFzks-lkp@intel.com/
smatch warnings:
drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
vim +/res +77 drivers/pinctrl/renesas/core.c
f9165132c5ee68 drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 29
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 30 static int sh_pfc_map_resources(struct sh_pfc *pfc,
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 31 struct platform_device *pdev)
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 32 {
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 33 struct sh_pfc_window *windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 34 unsigned int *irqs = NULL;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 35 unsigned int num_windows;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 36 struct resource *res;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 37 unsigned int i;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 38 int num_irqs;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 39
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 40 /* Count the MEM and IRQ resources. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 41 for (num_windows = 0;; num_windows++) {
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 42 res = platform_get_resource(pdev, IORESOURCE_MEM, num_windows);
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 @43 if (!res)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 44 break;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 45 }
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 46 if (num_windows == 0)
bee9f22ba196b0 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-02-16 47 return -EINVAL;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 48
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 49 num_irqs = platform_irq_count(pdev);
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 50 if (num_irqs < 0)
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 51 return num_irqs;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 52
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 53 /* Allocate memory windows and IRQs arrays. */
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 54 windows = devm_kcalloc(pfc->dev, num_windows, sizeof(*windows),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 55 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 56 if (windows == NULL)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 57 return -ENOMEM;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 58
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 59 pfc->num_windows = num_windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 60 pfc->windows = windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 61
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 62 if (num_irqs) {
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 63 irqs = devm_kcalloc(pfc->dev, num_irqs, sizeof(*irqs),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 64 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 65 if (irqs == NULL)
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 66 return -ENOMEM;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 67
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 68 pfc->num_irqs = num_irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 69 pfc->irqs = irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 70 }
973931ae0a2dad drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 71
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 72 /* Fill them. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 73 for (i = 0; i < num_windows; i++) {
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 74 windows->virt = devm_platform_get_and_ioremap_resource(pdev, i, &res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 75 if (IS_ERR(windows->virt))
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 76 return -ENOMEM;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 @77 windows->phys = res->start;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 78 windows->size = resource_size(res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 79 windows++;
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 80 }
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 81 for (i = 0; i < num_irqs; i++)
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 82 *irqs++ = platform_get_irq(pdev, i);
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 83
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 84 return 0;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 85 }
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 86
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
@ 2023-12-10 15:12 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-12-10 15:12 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Yang Yingliang <yangyingliang@huawei.com>
CC: Geert Uytterhoeven <geert+renesas@glider.be>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c527f5606aa545233a4d2c6d5c636ed82b8633ef
commit: 5376e3d904532e657fd7ca1a9b1ff3d351527b90 pinctrl: renesas: core: Fix possible null-ptr-deref in sh_pfc_map_resources()
date: 1 year, 7 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 1 year, 7 months ago
config: riscv-randconfig-r071-20231112 (https://download.01.org/0day-ci/archive/20231210/202312102325.44Tk7VDw-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231210/202312102325.44Tk7VDw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312102325.44Tk7VDw-lkp@intel.com/
smatch warnings:
drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
vim +/res +77 drivers/pinctrl/renesas/core.c
f9165132c5ee68 drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 29
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 30 static int sh_pfc_map_resources(struct sh_pfc *pfc,
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 31 struct platform_device *pdev)
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 32 {
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 33 struct sh_pfc_window *windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 34 unsigned int *irqs = NULL;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 35 unsigned int num_windows;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 36 struct resource *res;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 37 unsigned int i;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 38 int num_irqs;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 39
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 40 /* Count the MEM and IRQ resources. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 41 for (num_windows = 0;; num_windows++) {
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 42 res = platform_get_resource(pdev, IORESOURCE_MEM, num_windows);
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 @43 if (!res)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 44 break;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 45 }
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 46 if (num_windows == 0)
bee9f22ba196b0 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-02-16 47 return -EINVAL;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 48
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 49 num_irqs = platform_irq_count(pdev);
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 50 if (num_irqs < 0)
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 51 return num_irqs;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 52
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 53 /* Allocate memory windows and IRQs arrays. */
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 54 windows = devm_kcalloc(pfc->dev, num_windows, sizeof(*windows),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 55 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 56 if (windows == NULL)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 57 return -ENOMEM;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 58
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 59 pfc->num_windows = num_windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 60 pfc->windows = windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 61
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 62 if (num_irqs) {
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 63 irqs = devm_kcalloc(pfc->dev, num_irqs, sizeof(*irqs),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 64 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 65 if (irqs == NULL)
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 66 return -ENOMEM;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 67
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 68 pfc->num_irqs = num_irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 69 pfc->irqs = irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 70 }
973931ae0a2dad drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 71
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 72 /* Fill them. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 73 for (i = 0; i < num_windows; i++) {
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 74 windows->virt = devm_platform_get_and_ioremap_resource(pdev, i, &res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 75 if (IS_ERR(windows->virt))
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 76 return -ENOMEM;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 @77 windows->phys = res->start;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 78 windows->size = resource_size(res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 79 windows++;
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 80 }
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 81 for (i = 0; i < num_irqs; i++)
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 82 *irqs++ = platform_get_irq(pdev, i);
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 83
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 84 return 0;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 85 }
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 86
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
@ 2023-12-04 11:02 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-12-04 11:02 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Yang Yingliang <yangyingliang@huawei.com>
CC: Geert Uytterhoeven <geert+renesas@glider.be>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 33cc938e65a98f1d29d0a18403dbbee050dcad9a
commit: 5376e3d904532e657fd7ca1a9b1ff3d351527b90 pinctrl: renesas: core: Fix possible null-ptr-deref in sh_pfc_map_resources()
date: 1 year, 7 months ago
:::::: branch date: 25 hours ago
:::::: commit date: 1 year, 7 months ago
config: riscv-randconfig-r071-20231112 (https://download.01.org/0day-ci/archive/20231204/202312041858.sgpvt40z-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231204/202312041858.sgpvt40z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312041858.sgpvt40z-lkp@intel.com/
smatch warnings:
drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43)
vim +/res +77 drivers/pinctrl/renesas/core.c
f9165132c5ee68 drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 29
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 30 static int sh_pfc_map_resources(struct sh_pfc *pfc,
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 31 struct platform_device *pdev)
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 32 {
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 33 struct sh_pfc_window *windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 34 unsigned int *irqs = NULL;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 35 unsigned int num_windows;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 36 struct resource *res;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 37 unsigned int i;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 38 int num_irqs;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 39
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 40 /* Count the MEM and IRQ resources. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 41 for (num_windows = 0;; num_windows++) {
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 42 res = platform_get_resource(pdev, IORESOURCE_MEM, num_windows);
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 @43 if (!res)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 44 break;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 45 }
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 46 if (num_windows == 0)
bee9f22ba196b0 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-02-16 47 return -EINVAL;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 48
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 49 num_irqs = platform_irq_count(pdev);
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 50 if (num_irqs < 0)
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 51 return num_irqs;
ad7fe1a1a35994 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2019-10-16 52
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 53 /* Allocate memory windows and IRQs arrays. */
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 54 windows = devm_kcalloc(pfc->dev, num_windows, sizeof(*windows),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 55 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 56 if (windows == NULL)
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 57 return -ENOMEM;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 58
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 59 pfc->num_windows = num_windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 60 pfc->windows = windows;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 61
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 62 if (num_irqs) {
a86854d0c599b3 drivers/pinctrl/sh-pfc/core.c Kees Cook 2018-06-12 63 irqs = devm_kcalloc(pfc->dev, num_irqs, sizeof(*irqs),
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 64 GFP_KERNEL);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 65 if (irqs == NULL)
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 66 return -ENOMEM;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 67
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 68 pfc->num_irqs = num_irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 69 pfc->irqs = irqs;
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 70 }
973931ae0a2dad drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 71
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 72 /* Fill them. */
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 73 for (i = 0; i < num_windows; i++) {
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 74 windows->virt = devm_platform_get_and_ioremap_resource(pdev, i, &res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 75 if (IS_ERR(windows->virt))
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 76 return -ENOMEM;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 @77 windows->phys = res->start;
5376e3d904532e drivers/pinctrl/renesas/core.c Yang Yingliang 2022-04-29 78 windows->size = resource_size(res);
70c8f01a357ac7 drivers/pinctrl/sh-pfc/core.c Laurent Pinchart 2013-12-11 79 windows++;
1724acfd598bdf drivers/sh/pfc/core.c Laurent Pinchart 2012-12-15 80 }
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 81 for (i = 0; i < num_irqs; i++)
c7977ec4a33633 drivers/pinctrl/sh-pfc/core.c Geert Uytterhoeven 2015-06-25 82 *irqs++ = platform_get_irq(pdev, i);
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 83
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 84 return 0;
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 85 }
b0e10211cba162 drivers/sh/pfc.c Magnus Damm 2011-12-09 86
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-12 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-05 23:45 drivers/pinctrl/renesas/core.c:77 sh_pfc_map_resources() error: we previously assumed 'res' could be null (see line 43) kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-12-12 13:21 kernel test robot
2023-12-10 15:12 kernel test robot
2023-12-04 11:02 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.