* [PATCH] module: Remove redundant TASK_UNINTERRUPTIBLE
@ 2023-12-08 8:29 Kevin Hao
2023-12-19 21:30 ` Luis Chamberlain
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Hao @ 2023-12-08 8:29 UTC (permalink / raw)
To: Luis Chamberlain; +Cc: linux-modules
TASK_KILLABLE already includes TASK_UNINTERRUPTIBLE, so there is no
need to add a separate TASK_UNINTERRUPTIBLE.
Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
kernel/module/dups.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/module/dups.c b/kernel/module/dups.c
index f3d7ea1e96d8..9a92f2f8c9d3 100644
--- a/kernel/module/dups.c
+++ b/kernel/module/dups.c
@@ -207,7 +207,7 @@ bool kmod_dup_request_exists_wait(char *module_name, bool wait, int *dup_ret)
* optimization enabled ...
*/
ret = wait_for_completion_state(&kmod_req->first_req_done,
- TASK_UNINTERRUPTIBLE | TASK_KILLABLE);
+ TASK_KILLABLE);
if (ret) {
*dup_ret = ret;
return true;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] module: Remove redundant TASK_UNINTERRUPTIBLE
2023-12-08 8:29 [PATCH] module: Remove redundant TASK_UNINTERRUPTIBLE Kevin Hao
@ 2023-12-19 21:30 ` Luis Chamberlain
0 siblings, 0 replies; 2+ messages in thread
From: Luis Chamberlain @ 2023-12-19 21:30 UTC (permalink / raw)
To: Kevin Hao; +Cc: linux-modules
On Fri, Dec 08, 2023 at 04:29:34PM +0800, Kevin Hao wrote:
> TASK_KILLABLE already includes TASK_UNINTERRUPTIBLE, so there is no
> need to add a separate TASK_UNINTERRUPTIBLE.
>
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
Applied and pushed, thanks!
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-19 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-08 8:29 [PATCH] module: Remove redundant TASK_UNINTERRUPTIBLE Kevin Hao
2023-12-19 21:30 ` Luis Chamberlain
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.