[PATCH] cmd: part: Cover both part type entries with GUID ifdef

[PATCH] cmd: part: Cover both part type entries with GUID ifdef

[Marek Vasut]

The 'part type' subcommand depends on GUID partition table support.
The help text exposes one of two 'part type' subcommand entries,
hide both in case GUID partition table support is not enabled to
avoid confusing users.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
 cmd/part.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/part.c b/cmd/part.c
index 0ce190005d3..c75f85acd52 100644
--- a/cmd/part.c
+++ b/cmd/part.c
@@ -308,9 +308,9 @@ U_BOOT_CMD(
 #ifdef CONFIG_PARTITION_TYPE_GUID
 	"part type <interface> <dev>:<part>\n"
 	"    - print partition type\n"
-#endif
 	"part type <interface> <dev>:<part> <varname>\n"
 	"    - set environment variable to partition type\n"
+#endif
 	"part set <interface> <dev> type\n"
 	"    - set partition type for a device\n"
 	"part types\n"
-- 
2.42.0

Re: [PATCH] cmd: part: Cover both part type entries with GUID ifdef

[Simon Glass]

On Sun, 10 Dec 2023 at 14:25, Marek Vasut
<marek.vasut+renesas@mailbox.org> wrote:
>
> The 'part type' subcommand depends on GUID partition table support.
> The help text exposes one of two 'part type' subcommand entries,
> hide both in case GUID partition table support is not enabled to
> avoid confusing users.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  cmd/part.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH] cmd: part: Cover both part type entries with GUID ifdef

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Sun, Dec 10, 2023 at 10:25:07PM +0100, Marek Vasut wrote:

> The 'part type' subcommand depends on GUID partition table support.
> The help text exposes one of two 'part type' subcommand entries,
> hide both in case GUID partition table support is not enabled to
> avoid confusing users.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]