All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch/riscv/kernel/sys_riscv.c: removed asm-generic
@ 2023-12-11 22:52 ` tanzirh
  0 siblings, 0 replies; 4+ messages in thread
From: tanzirh @ 2023-12-11 22:52 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: linux-riscv, linux-kernel, Nick Desaulniers, Tanzir Hasan

arch/riscv/kernel/sys_riscv.c builds without using anything
from asm-generic/mman-common.h. There seems to be no reason
to include this file.

Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---

---
 arch/riscv/kernel/sys_riscv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
index a2ca5b7756a5..ebcaf386ea62 100644
--- a/arch/riscv/kernel/sys_riscv.c
+++ b/arch/riscv/kernel/sys_riscv.c
@@ -14,7 +14,6 @@
 #include <asm/switch_to.h>
 #include <asm/uaccess.h>
 #include <asm/unistd.h>
-#include <asm-generic/mman-common.h>
 #include <vdso/vsyscall.h>
 
 static long riscv_sys_mmap(unsigned long addr, unsigned long len,

---
base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
change-id: 20231211-removeasmgeneric-f6be13a42b6b

Best regards,
-- 
Tanzir Hasan <tanzirh@google.com>


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arch/riscv/kernel/sys_riscv.c: removed asm-generic
@ 2023-12-11 22:52 ` tanzirh
  0 siblings, 0 replies; 4+ messages in thread
From: tanzirh @ 2023-12-11 22:52 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: linux-riscv, linux-kernel, Nick Desaulniers, Tanzir Hasan

arch/riscv/kernel/sys_riscv.c builds without using anything
from asm-generic/mman-common.h. There seems to be no reason
to include this file.

Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---

---
 arch/riscv/kernel/sys_riscv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
index a2ca5b7756a5..ebcaf386ea62 100644
--- a/arch/riscv/kernel/sys_riscv.c
+++ b/arch/riscv/kernel/sys_riscv.c
@@ -14,7 +14,6 @@
 #include <asm/switch_to.h>
 #include <asm/uaccess.h>
 #include <asm/unistd.h>
-#include <asm-generic/mman-common.h>
 #include <vdso/vsyscall.h>
 
 static long riscv_sys_mmap(unsigned long addr, unsigned long len,

---
base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
change-id: 20231211-removeasmgeneric-f6be13a42b6b

Best regards,
-- 
Tanzir Hasan <tanzirh@google.com>


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arch/riscv/kernel/sys_riscv.c: removed asm-generic
  2023-12-11 22:52 ` tanzirh
@ 2023-12-12  0:05   ` Nick Desaulniers
  -1 siblings, 0 replies; 4+ messages in thread
From: Nick Desaulniers @ 2023-12-12  0:05 UTC (permalink / raw)
  To: tanzirh
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv,
	linux-kernel, Nick Desaulniers, Conor Dooley

On Mon, Dec 11, 2023 at 2:52 PM <tanzirh@google.com> wrote:
>
> arch/riscv/kernel/sys_riscv.c builds without using anything
> from asm-generic/mman-common.h. There seems to be no reason
> to include this file.
>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
>
> ---
>  arch/riscv/kernel/sys_riscv.c | 1 -

If you run `git log arch/riscv/kernel/sys_riscv.c`, you'll find the
prefix used on the oneline of the commit for this file is generally
one of:

- RISC-V:
- riscv:

You should choose one of the above rather than
`arch/riscv/kernel/sys_riscv.c:`.  Sorry I missed that in internal
code review, but would you mind please sending a v2 with that fixed?
I'd expect something like:

riscv: remove unused header

+Conor who pointed this out to me on IRC

>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
> index a2ca5b7756a5..ebcaf386ea62 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -14,7 +14,6 @@
>  #include <asm/switch_to.h>
>  #include <asm/uaccess.h>
>  #include <asm/unistd.h>
> -#include <asm-generic/mman-common.h>
>  #include <vdso/vsyscall.h>
>
>  static long riscv_sys_mmap(unsigned long addr, unsigned long len,
>
> ---
> base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
> change-id: 20231211-removeasmgeneric-f6be13a42b6b
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@google.com>
>


--
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arch/riscv/kernel/sys_riscv.c: removed asm-generic
@ 2023-12-12  0:05   ` Nick Desaulniers
  0 siblings, 0 replies; 4+ messages in thread
From: Nick Desaulniers @ 2023-12-12  0:05 UTC (permalink / raw)
  To: tanzirh
  Cc: Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv,
	linux-kernel, Nick Desaulniers, Conor Dooley

On Mon, Dec 11, 2023 at 2:52 PM <tanzirh@google.com> wrote:
>
> arch/riscv/kernel/sys_riscv.c builds without using anything
> from asm-generic/mman-common.h. There seems to be no reason
> to include this file.
>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
>
> ---
>  arch/riscv/kernel/sys_riscv.c | 1 -

If you run `git log arch/riscv/kernel/sys_riscv.c`, you'll find the
prefix used on the oneline of the commit for this file is generally
one of:

- RISC-V:
- riscv:

You should choose one of the above rather than
`arch/riscv/kernel/sys_riscv.c:`.  Sorry I missed that in internal
code review, but would you mind please sending a v2 with that fixed?
I'd expect something like:

riscv: remove unused header

+Conor who pointed this out to me on IRC

>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
> index a2ca5b7756a5..ebcaf386ea62 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -14,7 +14,6 @@
>  #include <asm/switch_to.h>
>  #include <asm/uaccess.h>
>  #include <asm/unistd.h>
> -#include <asm-generic/mman-common.h>
>  #include <vdso/vsyscall.h>
>
>  static long riscv_sys_mmap(unsigned long addr, unsigned long len,
>
> ---
> base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
> change-id: 20231211-removeasmgeneric-f6be13a42b6b
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@google.com>
>


--
Thanks,
~Nick Desaulniers

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-12  0:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 22:52 [PATCH] arch/riscv/kernel/sys_riscv.c: removed asm-generic tanzirh
2023-12-11 22:52 ` tanzirh
2023-12-12  0:05 ` Nick Desaulniers
2023-12-12  0:05   ` Nick Desaulniers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.