* [asahilinux:bits/170-atcphy 3/11] drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
@ 2023-12-10 22:37 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-12-10 22:37 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Sven Peter <sven@svenpeter.dev>
CC: Hector Martin <marcan@marcan.st>
tree: https://github.com/AsahiLinux/linux bits/170-atcphy
head: 4931e8edc0670b6acf66c1b83702c7521722ff1c
commit: 3b2571b8e8064a73eca2cec23cf86cfe7f7050f5 [3/11] WIP: phy: apple: Add Apple Type-C PHY
:::::: branch date: 3 weeks ago
:::::: commit date: 3 months ago
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231211/202312110624.SVpwzkJ6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231211/202312110624.SVpwzkJ6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202312110624.SVpwzkJ6-lkp@intel.com/
smatch warnings:
drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(offset > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(mask > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2157 atcphy_parse_new_tunable() warn: impossible condition '(value > (~0)) => (0-u32max > u32max)'
vim +1609 drivers/phy/apple/atc.c
3b2571b8e8064a Sven Peter 2022-11-30 1566
3b2571b8e8064a Sven Peter 2022-11-30 1567 static int atcphy_usb3_power_on(struct phy *phy)
3b2571b8e8064a Sven Peter 2022-11-30 1568 {
3b2571b8e8064a Sven Peter 2022-11-30 1569 struct apple_atcphy *atcphy = phy_get_drvdata(phy);
3b2571b8e8064a Sven Peter 2022-11-30 1570 enum atcphy_pipehandler_state state;
3b2571b8e8064a Sven Peter 2022-11-30 1571 int ret = 0;
3b2571b8e8064a Sven Peter 2022-11-30 1572
3b2571b8e8064a Sven Peter 2022-11-30 1573 /*
3b2571b8e8064a Sven Peter 2022-11-30 1574 * Both usb role switch and mux set work will be running concurrently.
3b2571b8e8064a Sven Peter 2022-11-30 1575 * Make sure atcphy_mux_set_work is done bringing up ATCPHY before
3b2571b8e8064a Sven Peter 2022-11-30 1576 * trying to switch dwc3 to the correct PHY.
3b2571b8e8064a Sven Peter 2022-11-30 1577 */
3b2571b8e8064a Sven Peter 2022-11-30 1578 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1579 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1580 reinit_completion(&atcphy->atcphy_online_event);
3b2571b8e8064a Sven Peter 2022-11-30 1581 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1582 wait_for_completion_timeout(&atcphy->atcphy_online_event,
3b2571b8e8064a Sven Peter 2022-11-30 1583 msecs_to_jiffies(1000));
3b2571b8e8064a Sven Peter 2022-11-30 1584 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1585 }
3b2571b8e8064a Sven Peter 2022-11-30 1586
3b2571b8e8064a Sven Peter 2022-11-30 1587 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1588 dev_err(atcphy->dev, "ATCPHY did not come up; won't allow dwc3 to come up.\n");
3b2571b8e8064a Sven Peter 2022-11-30 1589 return -EINVAL;
3b2571b8e8064a Sven Peter 2022-11-30 1590 }
3b2571b8e8064a Sven Peter 2022-11-30 1591
3b2571b8e8064a Sven Peter 2022-11-30 1592 atcphy->dwc3_online = true;
3b2571b8e8064a Sven Peter 2022-11-30 1593 state = atcphy_modes[atcphy->mode].pipehandler_state;
3b2571b8e8064a Sven Peter 2022-11-30 1594 switch (state) {
3b2571b8e8064a Sven Peter 2022-11-30 1595 case ATCPHY_PIPEHANDLER_STATE_USB2:
3b2571b8e8064a Sven Peter 2022-11-30 1596 case ATCPHY_PIPEHANDLER_STATE_USB3:
3b2571b8e8064a Sven Peter 2022-11-30 1597 ret = atcphy_configure_pipehandler(atcphy, state);
3b2571b8e8064a Sven Peter 2022-11-30 1598 break;
3b2571b8e8064a Sven Peter 2022-11-30 1599
3b2571b8e8064a Sven Peter 2022-11-30 1600 case ATCPHY_PIPEHANDLER_STATE_INVALID:
3b2571b8e8064a Sven Peter 2022-11-30 1601 default:
3b2571b8e8064a Sven Peter 2022-11-30 1602 dev_warn(atcphy->dev, "Invalid state %d in usb3_set_phy\n",
3b2571b8e8064a Sven Peter 2022-11-30 1603 state);
3b2571b8e8064a Sven Peter 2022-11-30 1604 ret = -EINVAL;
3b2571b8e8064a Sven Peter 2022-11-30 1605 }
3b2571b8e8064a Sven Peter 2022-11-30 1606
3b2571b8e8064a Sven Peter 2022-11-30 1607 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1608
3b2571b8e8064a Sven Peter 2022-11-30 @1609 return 0;
3b2571b8e8064a Sven Peter 2022-11-30 1610 }
3b2571b8e8064a Sven Peter 2022-11-30 1611
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* [asahilinux:bits/170-atcphy 3/11] drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
@ 2023-12-11 8:10 Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-12-11 8:10 UTC (permalink / raw)
To: oe-kbuild, Sven Peter; +Cc: lkp, oe-kbuild-all, Hector Martin
tree: https://github.com/AsahiLinux/linux bits/170-atcphy
head: 4931e8edc0670b6acf66c1b83702c7521722ff1c
commit: 3b2571b8e8064a73eca2cec23cf86cfe7f7050f5 [3/11] WIP: phy: apple: Add Apple Type-C PHY
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231211/202312110624.SVpwzkJ6-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231211/202312110624.SVpwzkJ6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202312110624.SVpwzkJ6-lkp@intel.com/
smatch warnings:
drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(offset > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(mask > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2157 atcphy_parse_new_tunable() warn: impossible condition '(value > (~0)) => (0-u32max > u32max)'
vim +1609 drivers/phy/apple/atc.c
3b2571b8e8064a Sven Peter 2022-11-30 1567 static int atcphy_usb3_power_on(struct phy *phy)
3b2571b8e8064a Sven Peter 2022-11-30 1568 {
3b2571b8e8064a Sven Peter 2022-11-30 1569 struct apple_atcphy *atcphy = phy_get_drvdata(phy);
3b2571b8e8064a Sven Peter 2022-11-30 1570 enum atcphy_pipehandler_state state;
3b2571b8e8064a Sven Peter 2022-11-30 1571 int ret = 0;
3b2571b8e8064a Sven Peter 2022-11-30 1572
3b2571b8e8064a Sven Peter 2022-11-30 1573 /*
3b2571b8e8064a Sven Peter 2022-11-30 1574 * Both usb role switch and mux set work will be running concurrently.
3b2571b8e8064a Sven Peter 2022-11-30 1575 * Make sure atcphy_mux_set_work is done bringing up ATCPHY before
3b2571b8e8064a Sven Peter 2022-11-30 1576 * trying to switch dwc3 to the correct PHY.
3b2571b8e8064a Sven Peter 2022-11-30 1577 */
3b2571b8e8064a Sven Peter 2022-11-30 1578 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1579 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1580 reinit_completion(&atcphy->atcphy_online_event);
3b2571b8e8064a Sven Peter 2022-11-30 1581 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1582 wait_for_completion_timeout(&atcphy->atcphy_online_event,
3b2571b8e8064a Sven Peter 2022-11-30 1583 msecs_to_jiffies(1000));
3b2571b8e8064a Sven Peter 2022-11-30 1584 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1585 }
3b2571b8e8064a Sven Peter 2022-11-30 1586
3b2571b8e8064a Sven Peter 2022-11-30 1587 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1588 dev_err(atcphy->dev, "ATCPHY did not come up; won't allow dwc3 to come up.\n");
3b2571b8e8064a Sven Peter 2022-11-30 1589 return -EINVAL;
mutex_unlock(&atcphy->lock); before returning.
3b2571b8e8064a Sven Peter 2022-11-30 1590 }
3b2571b8e8064a Sven Peter 2022-11-30 1591
3b2571b8e8064a Sven Peter 2022-11-30 1592 atcphy->dwc3_online = true;
3b2571b8e8064a Sven Peter 2022-11-30 1593 state = atcphy_modes[atcphy->mode].pipehandler_state;
3b2571b8e8064a Sven Peter 2022-11-30 1594 switch (state) {
3b2571b8e8064a Sven Peter 2022-11-30 1595 case ATCPHY_PIPEHANDLER_STATE_USB2:
3b2571b8e8064a Sven Peter 2022-11-30 1596 case ATCPHY_PIPEHANDLER_STATE_USB3:
3b2571b8e8064a Sven Peter 2022-11-30 1597 ret = atcphy_configure_pipehandler(atcphy, state);
3b2571b8e8064a Sven Peter 2022-11-30 1598 break;
3b2571b8e8064a Sven Peter 2022-11-30 1599
3b2571b8e8064a Sven Peter 2022-11-30 1600 case ATCPHY_PIPEHANDLER_STATE_INVALID:
3b2571b8e8064a Sven Peter 2022-11-30 1601 default:
3b2571b8e8064a Sven Peter 2022-11-30 1602 dev_warn(atcphy->dev, "Invalid state %d in usb3_set_phy\n",
3b2571b8e8064a Sven Peter 2022-11-30 1603 state);
3b2571b8e8064a Sven Peter 2022-11-30 1604 ret = -EINVAL;
3b2571b8e8064a Sven Peter 2022-11-30 1605 }
3b2571b8e8064a Sven Peter 2022-11-30 1606
3b2571b8e8064a Sven Peter 2022-11-30 1607 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1608
3b2571b8e8064a Sven Peter 2022-11-30 @1609 return 0;
3b2571b8e8064a Sven Peter 2022-11-30 1610 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* [asahilinux:bits/170-atcphy 3/11] drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
@ 2023-11-30 7:09 Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-11-30 7:09 UTC (permalink / raw)
To: oe-kbuild, Sven Peter; +Cc: lkp, oe-kbuild-all, Hector Martin
tree: https://github.com/AsahiLinux/linux bits/170-atcphy
head: 4931e8edc0670b6acf66c1b83702c7521722ff1c
commit: 3b2571b8e8064a73eca2cec23cf86cfe7f7050f5 [3/11] WIP: phy: apple: Add Apple Type-C PHY
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231130/202311300600.AQaWLIms-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231130/202311300600.AQaWLIms-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311300600.AQaWLIms-lkp@intel.com/
smatch warnings:
drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(offset > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(mask > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2157 atcphy_parse_new_tunable() warn: impossible condition '(value > (~0)) => (0-u32max > u32max)'
vim +1609 drivers/phy/apple/atc.c
3b2571b8e8064a Sven Peter 2022-11-30 1567 static int atcphy_usb3_power_on(struct phy *phy)
3b2571b8e8064a Sven Peter 2022-11-30 1568 {
3b2571b8e8064a Sven Peter 2022-11-30 1569 struct apple_atcphy *atcphy = phy_get_drvdata(phy);
3b2571b8e8064a Sven Peter 2022-11-30 1570 enum atcphy_pipehandler_state state;
3b2571b8e8064a Sven Peter 2022-11-30 1571 int ret = 0;
3b2571b8e8064a Sven Peter 2022-11-30 1572
3b2571b8e8064a Sven Peter 2022-11-30 1573 /*
3b2571b8e8064a Sven Peter 2022-11-30 1574 * Both usb role switch and mux set work will be running concurrently.
3b2571b8e8064a Sven Peter 2022-11-30 1575 * Make sure atcphy_mux_set_work is done bringing up ATCPHY before
3b2571b8e8064a Sven Peter 2022-11-30 1576 * trying to switch dwc3 to the correct PHY.
3b2571b8e8064a Sven Peter 2022-11-30 1577 */
3b2571b8e8064a Sven Peter 2022-11-30 1578 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1579 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1580 reinit_completion(&atcphy->atcphy_online_event);
3b2571b8e8064a Sven Peter 2022-11-30 1581 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1582 wait_for_completion_timeout(&atcphy->atcphy_online_event,
3b2571b8e8064a Sven Peter 2022-11-30 1583 msecs_to_jiffies(1000));
3b2571b8e8064a Sven Peter 2022-11-30 1584 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1585 }
3b2571b8e8064a Sven Peter 2022-11-30 1586
3b2571b8e8064a Sven Peter 2022-11-30 1587 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1588 dev_err(atcphy->dev, "ATCPHY did not come up; won't allow dwc3 to come up.\n");
3b2571b8e8064a Sven Peter 2022-11-30 1589 return -EINVAL;
Need to unlock before returning.
3b2571b8e8064a Sven Peter 2022-11-30 1590 }
3b2571b8e8064a Sven Peter 2022-11-30 1591
3b2571b8e8064a Sven Peter 2022-11-30 1592 atcphy->dwc3_online = true;
3b2571b8e8064a Sven Peter 2022-11-30 1593 state = atcphy_modes[atcphy->mode].pipehandler_state;
3b2571b8e8064a Sven Peter 2022-11-30 1594 switch (state) {
3b2571b8e8064a Sven Peter 2022-11-30 1595 case ATCPHY_PIPEHANDLER_STATE_USB2:
3b2571b8e8064a Sven Peter 2022-11-30 1596 case ATCPHY_PIPEHANDLER_STATE_USB3:
3b2571b8e8064a Sven Peter 2022-11-30 1597 ret = atcphy_configure_pipehandler(atcphy, state);
3b2571b8e8064a Sven Peter 2022-11-30 1598 break;
3b2571b8e8064a Sven Peter 2022-11-30 1599
3b2571b8e8064a Sven Peter 2022-11-30 1600 case ATCPHY_PIPEHANDLER_STATE_INVALID:
3b2571b8e8064a Sven Peter 2022-11-30 1601 default:
3b2571b8e8064a Sven Peter 2022-11-30 1602 dev_warn(atcphy->dev, "Invalid state %d in usb3_set_phy\n",
3b2571b8e8064a Sven Peter 2022-11-30 1603 state);
3b2571b8e8064a Sven Peter 2022-11-30 1604 ret = -EINVAL;
3b2571b8e8064a Sven Peter 2022-11-30 1605 }
3b2571b8e8064a Sven Peter 2022-11-30 1606
3b2571b8e8064a Sven Peter 2022-11-30 1607 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1608
3b2571b8e8064a Sven Peter 2022-11-30 @1609 return 0;
3b2571b8e8064a Sven Peter 2022-11-30 1610 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* [asahilinux:bits/170-atcphy 3/11] drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
@ 2023-11-30 2:18 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2023-11-30 2:18 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Sven Peter <sven@svenpeter.dev>
CC: Hector Martin <marcan@marcan.st>
tree: https://github.com/AsahiLinux/linux bits/170-atcphy
head: 4931e8edc0670b6acf66c1b83702c7521722ff1c
commit: 3b2571b8e8064a73eca2cec23cf86cfe7f7050f5 [3/11] WIP: phy: apple: Add Apple Type-C PHY
:::::: branch date: 7 days ago
:::::: commit date: 2 months ago
config: arm64-randconfig-r081-20231127 (https://download.01.org/0day-ci/archive/20231130/202311300600.AQaWLIms-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231130/202311300600.AQaWLIms-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311300600.AQaWLIms-lkp@intel.com/
smatch warnings:
drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock'.
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(offset > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2156 atcphy_parse_new_tunable() warn: impossible condition '(mask > (~0)) => (0-u32max > u32max)'
drivers/phy/apple/atc.c:2157 atcphy_parse_new_tunable() warn: impossible condition '(value > (~0)) => (0-u32max > u32max)'
vim +1609 drivers/phy/apple/atc.c
3b2571b8e8064a Sven Peter 2022-11-30 1566
3b2571b8e8064a Sven Peter 2022-11-30 1567 static int atcphy_usb3_power_on(struct phy *phy)
3b2571b8e8064a Sven Peter 2022-11-30 1568 {
3b2571b8e8064a Sven Peter 2022-11-30 1569 struct apple_atcphy *atcphy = phy_get_drvdata(phy);
3b2571b8e8064a Sven Peter 2022-11-30 1570 enum atcphy_pipehandler_state state;
3b2571b8e8064a Sven Peter 2022-11-30 1571 int ret = 0;
3b2571b8e8064a Sven Peter 2022-11-30 1572
3b2571b8e8064a Sven Peter 2022-11-30 1573 /*
3b2571b8e8064a Sven Peter 2022-11-30 1574 * Both usb role switch and mux set work will be running concurrently.
3b2571b8e8064a Sven Peter 2022-11-30 1575 * Make sure atcphy_mux_set_work is done bringing up ATCPHY before
3b2571b8e8064a Sven Peter 2022-11-30 1576 * trying to switch dwc3 to the correct PHY.
3b2571b8e8064a Sven Peter 2022-11-30 1577 */
3b2571b8e8064a Sven Peter 2022-11-30 1578 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1579 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1580 reinit_completion(&atcphy->atcphy_online_event);
3b2571b8e8064a Sven Peter 2022-11-30 1581 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1582 wait_for_completion_timeout(&atcphy->atcphy_online_event,
3b2571b8e8064a Sven Peter 2022-11-30 1583 msecs_to_jiffies(1000));
3b2571b8e8064a Sven Peter 2022-11-30 1584 mutex_lock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1585 }
3b2571b8e8064a Sven Peter 2022-11-30 1586
3b2571b8e8064a Sven Peter 2022-11-30 1587 if (atcphy->mode != atcphy->target_mode) {
3b2571b8e8064a Sven Peter 2022-11-30 1588 dev_err(atcphy->dev, "ATCPHY did not come up; won't allow dwc3 to come up.\n");
3b2571b8e8064a Sven Peter 2022-11-30 1589 return -EINVAL;
3b2571b8e8064a Sven Peter 2022-11-30 1590 }
3b2571b8e8064a Sven Peter 2022-11-30 1591
3b2571b8e8064a Sven Peter 2022-11-30 1592 atcphy->dwc3_online = true;
3b2571b8e8064a Sven Peter 2022-11-30 1593 state = atcphy_modes[atcphy->mode].pipehandler_state;
3b2571b8e8064a Sven Peter 2022-11-30 1594 switch (state) {
3b2571b8e8064a Sven Peter 2022-11-30 1595 case ATCPHY_PIPEHANDLER_STATE_USB2:
3b2571b8e8064a Sven Peter 2022-11-30 1596 case ATCPHY_PIPEHANDLER_STATE_USB3:
3b2571b8e8064a Sven Peter 2022-11-30 1597 ret = atcphy_configure_pipehandler(atcphy, state);
3b2571b8e8064a Sven Peter 2022-11-30 1598 break;
3b2571b8e8064a Sven Peter 2022-11-30 1599
3b2571b8e8064a Sven Peter 2022-11-30 1600 case ATCPHY_PIPEHANDLER_STATE_INVALID:
3b2571b8e8064a Sven Peter 2022-11-30 1601 default:
3b2571b8e8064a Sven Peter 2022-11-30 1602 dev_warn(atcphy->dev, "Invalid state %d in usb3_set_phy\n",
3b2571b8e8064a Sven Peter 2022-11-30 1603 state);
3b2571b8e8064a Sven Peter 2022-11-30 1604 ret = -EINVAL;
3b2571b8e8064a Sven Peter 2022-11-30 1605 }
3b2571b8e8064a Sven Peter 2022-11-30 1606
3b2571b8e8064a Sven Peter 2022-11-30 1607 mutex_unlock(&atcphy->lock);
3b2571b8e8064a Sven Peter 2022-11-30 1608
3b2571b8e8064a Sven Peter 2022-11-30 @1609 return 0;
3b2571b8e8064a Sven Peter 2022-11-30 1610 }
3b2571b8e8064a Sven Peter 2022-11-30 1611
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-11 8:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-10 22:37 [asahilinux:bits/170-atcphy 3/11] drivers/phy/apple/atc.c:1609 atcphy_usb3_power_on() warn: inconsistent returns '&atcphy->lock' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-12-11 8:10 Dan Carpenter
2023-11-30 7:09 Dan Carpenter
2023-11-30 2:18 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.