From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Jan Kara <jack@suse.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: manual merge of the vfs tree with the f2fs tree
Date: Wed, 20 Dec 2023 14:05:29 +1100 [thread overview]
Message-ID: <20231220140529.3979085c@canb.auug.org.au> (raw)
In-Reply-To: <20231220013402.GW1674809@ZenIV>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
Hi Al,
On Wed, 20 Dec 2023 01:34:02 +0000 Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> My suggested resolution had been wrong, actually - the way it's written,
> link count drop should be conditional on old_is_dir, cross-directory or
> not.
>
> I think the right solution is
> if (old_dir_entry)
> f2fs_set_link(old_inode, old_dir_entry, old_dir_page, new_dir);
> if (old_is_dir)
> f2fs_i_links_write(old_dir, false);
Ok, I will fix it up.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-12-20 3:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 23:47 linux-next: manual merge of the vfs tree with the f2fs tree Stephen Rothwell
2023-12-20 0:13 ` Stephen Rothwell
2023-12-20 1:34 ` Al Viro
2023-12-20 3:05 ` Stephen Rothwell [this message]
2023-12-20 4:44 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2021-04-19 0:53 Stephen Rothwell
2018-10-03 0:12 Stephen Rothwell
2017-11-08 23:06 Stephen Rothwell
2017-11-08 23:01 Stephen Rothwell
2017-02-27 0:05 Stephen Rothwell
2017-02-27 8:27 ` David Howells
2016-07-25 0:21 Stephen Rothwell
2016-05-03 1:41 Stephen Rothwell
2015-05-07 2:05 Stephen Rothwell
2015-04-13 1:53 Stephen Rothwell
2014-06-10 1:23 Stephen Rothwell
2014-04-29 0:37 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220140529.3979085c@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=chao@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.