All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
@ 2023-12-21  3:26 ` Peter Chiu
  0 siblings, 0 replies; 10+ messages in thread
From: Peter Chiu @ 2023-12-21  3:26 UTC (permalink / raw)
  To: Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger,
	AngeloGioacchino Del Regno, linux-wireless, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek, Peter Chiu

The mt7986 can support four interrupts to distribute the interrupts
to different CPUs.

Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
---
v2: Change to use description instead of using items.
v3: Change to use items and set different minItems for mediatek,mt7986-wmac
v4: Move allOf after required and remove duplicated blank line.
---
 .../bindings/net/wireless/mediatek,mt76.yaml  | 32 ++++++++++++++++---
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 252207adbc54..0c6835db397f 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -19,9 +19,6 @@ description: |
   Alternatively, it can specify the wireless part of the MT7628/MT7688
   or MT7622/MT7986 SoC.
 
-allOf:
-  - $ref: ieee80211.yaml#
-
 properties:
   compatible:
     enum:
@@ -38,7 +35,12 @@ properties:
       MT7986 should contain 3 regions consys, dcm, and sku, in this order.
 
   interrupts:
-    maxItems: 1
+    minItems: 1
+    items:
+      - description: major interrupt for rings
+      - description: additional interrupt for ring 19
+      - description: additional interrupt for ring 4
+      - description: additional interrupt for ring 5
 
   power-domains:
     maxItems: 1
@@ -217,6 +219,23 @@ required:
   - compatible
   - reg
 
+allOf:
+  - $ref: ieee80211.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mediatek,mt7986-wmac
+    then:
+      properties:
+        interrupts:
+          minItems: 4
+    else:
+      properties:
+        interrupts:
+          maxItems: 1
+
 unevaluatedProperties: false
 
 examples:
@@ -293,7 +312,10 @@ examples:
         reg = <0x18000000 0x1000000>,
               <0x10003000 0x1000>,
               <0x11d10000 0x1000>;
-        interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>;
+        interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>;
         clocks = <&topckgen 50>,
                  <&topckgen 62>;
         clock-names = "mcu", "ap2conn";
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
@ 2023-12-21  3:26 ` Peter Chiu
  0 siblings, 0 replies; 10+ messages in thread
From: Peter Chiu @ 2023-12-21  3:26 UTC (permalink / raw)
  To: Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger,
	AngeloGioacchino Del Regno, linux-wireless, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek, Peter Chiu

The mt7986 can support four interrupts to distribute the interrupts
to different CPUs.

Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
---
v2: Change to use description instead of using items.
v3: Change to use items and set different minItems for mediatek,mt7986-wmac
v4: Move allOf after required and remove duplicated blank line.
---
 .../bindings/net/wireless/mediatek,mt76.yaml  | 32 ++++++++++++++++---
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 252207adbc54..0c6835db397f 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -19,9 +19,6 @@ description: |
   Alternatively, it can specify the wireless part of the MT7628/MT7688
   or MT7622/MT7986 SoC.
 
-allOf:
-  - $ref: ieee80211.yaml#
-
 properties:
   compatible:
     enum:
@@ -38,7 +35,12 @@ properties:
       MT7986 should contain 3 regions consys, dcm, and sku, in this order.
 
   interrupts:
-    maxItems: 1
+    minItems: 1
+    items:
+      - description: major interrupt for rings
+      - description: additional interrupt for ring 19
+      - description: additional interrupt for ring 4
+      - description: additional interrupt for ring 5
 
   power-domains:
     maxItems: 1
@@ -217,6 +219,23 @@ required:
   - compatible
   - reg
 
+allOf:
+  - $ref: ieee80211.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mediatek,mt7986-wmac
+    then:
+      properties:
+        interrupts:
+          minItems: 4
+    else:
+      properties:
+        interrupts:
+          maxItems: 1
+
 unevaluatedProperties: false
 
 examples:
@@ -293,7 +312,10 @@ examples:
         reg = <0x18000000 0x1000000>,
               <0x10003000 0x1000>,
               <0x11d10000 0x1000>;
-        interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>;
+        interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>,
+                     <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>;
         clocks = <&topckgen 50>,
                  <&topckgen 62>;
         clock-names = "mcu", "ap2conn";
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
  2023-12-21  3:26 ` Peter Chiu
@ 2023-12-21  8:19   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-21  8:19 UTC (permalink / raw)
  To: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger,
	AngeloGioacchino Del Regno, linux-wireless, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek

On 21/12/2023 04:26, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
> 
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> ---
> v2: Change to use description instead of using items.
> v3: Change to use items and set different minItems for mediatek,mt7986-wmac
> v4: Move allOf after required and remove duplicated blank line.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
@ 2023-12-21  8:19   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-21  8:19 UTC (permalink / raw)
  To: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger,
	AngeloGioacchino Del Regno, linux-wireless, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek

On 21/12/2023 04:26, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
> 
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> ---
> v2: Change to use description instead of using items.
> v3: Change to use items and set different minItems for mediatek,mt7986-wmac
> v4: Move allOf after required and remove duplicated blank line.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
  2023-12-21  3:26 ` Peter Chiu
@ 2024-02-12  7:20   ` Rafał Miłecki
  -1 siblings, 0 replies; 10+ messages in thread
From: Rafał Miłecki @ 2024-02-12  7:20 UTC (permalink / raw)
  To: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger,
	AngeloGioacchino Del Regno, linux-wireless, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek

On 21.12.2023 04:26, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.

Can we have this patch picked up, please? Felix? Kalle?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
@ 2024-02-12  7:20   ` Rafał Miłecki
  0 siblings, 0 replies; 10+ messages in thread
From: Rafał Miłecki @ 2024-02-12  7:20 UTC (permalink / raw)
  To: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger,
	AngeloGioacchino Del Regno, linux-wireless, devicetree,
	linux-kernel, linux-arm-kernel, linux-mediatek

On 21.12.2023 04:26, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.

Can we have this patch picked up, please? Felix? Kalle?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
  2023-12-21  3:26 ` Peter Chiu
@ 2024-02-12  8:51   ` AngeloGioacchino Del Regno
  -1 siblings, 0 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-02-12  8:51 UTC (permalink / raw)
  To: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger, linux-wireless,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

Il 21/12/23 04:26, Peter Chiu ha scritto:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
> 
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
@ 2024-02-12  8:51   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 10+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-02-12  8:51 UTC (permalink / raw)
  To: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Kalle Valo, Matthias Brugger, linux-wireless,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

Il 21/12/23 04:26, Peter Chiu ha scritto:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
> 
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
  2024-02-12  7:20   ` Rafał Miłecki
@ 2024-02-12 10:24     ` Kalle Valo
  -1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2024-02-12 10:24 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
	linux-wireless, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek

Rafał Miłecki <zajec5@gmail.com> writes:

> On 21.12.2023 04:26, Peter Chiu wrote:
>> The mt7986 can support four interrupts to distribute the interrupts
>> to different CPUs.
>
> Can we have this patch picked up, please? Felix? Kalle?

Felix has applied this to this tree:

https://github.com/nbd168/wireless/commit/26b98d08fda9ebef33c5eb3e1a6a14be64358caf

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986
@ 2024-02-12 10:24     ` Kalle Valo
  0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2024-02-12 10:24 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Peter Chiu, Felix Fietkau, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Lorenzo Bianconi, Ryder Lee, Shayne Chen,
	Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
	linux-wireless, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek

Rafał Miłecki <zajec5@gmail.com> writes:

> On 21.12.2023 04:26, Peter Chiu wrote:
>> The mt7986 can support four interrupts to distribute the interrupts
>> to different CPUs.
>
> Can we have this patch picked up, please? Felix? Kalle?

Felix has applied this to this tree:

https://github.com/nbd168/wireless/commit/26b98d08fda9ebef33c5eb3e1a6a14be64358caf

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-02-12 10:24 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21  3:26 [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986 Peter Chiu
2023-12-21  3:26 ` Peter Chiu
2023-12-21  8:19 ` Krzysztof Kozlowski
2023-12-21  8:19   ` Krzysztof Kozlowski
2024-02-12  7:20 ` Rafał Miłecki
2024-02-12  7:20   ` Rafał Miłecki
2024-02-12 10:24   ` Kalle Valo
2024-02-12 10:24     ` Kalle Valo
2024-02-12  8:51 ` AngeloGioacchino Del Regno
2024-02-12  8:51   ` AngeloGioacchino Del Regno

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.