* [PATCH v2] drm/debugfs: drop unneeded DEBUG_FS guard
@ 2023-12-23 18:32 ` Dario Binacchi
0 siblings, 0 replies; 4+ messages in thread
From: Dario Binacchi @ 2023-12-23 18:32 UTC (permalink / raw)
To: linux-kernel
Cc: Thomas Zimmermann, Jani Nikula, Maxime Ripard, dri-devel,
Dario Binacchi, David Airlie
The Makefile enables/disables the file compilation depending on
CONFIG_DEBUG_FS.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
---
Changes in v2:
- Add 'Reviewed-by' tag of Jani Nikula
drivers/gpu/drm/drm_debugfs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index f291fb4b359f..f80d9cf3e71a 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -45,8 +45,6 @@
#include "drm_crtc_internal.h"
#include "drm_internal.h"
-#if defined(CONFIG_DEBUG_FS)
-
/***************************************************
* Initialization, etc.
**************************************************/
@@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
debugfs_remove_recursive(crtc->debugfs_entry);
crtc->debugfs_entry = NULL;
}
-
-#endif /* CONFIG_DEBUG_FS */
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] drm/debugfs: drop unneeded DEBUG_FS guard
@ 2023-12-23 18:32 ` Dario Binacchi
0 siblings, 0 replies; 4+ messages in thread
From: Dario Binacchi @ 2023-12-23 18:32 UTC (permalink / raw)
To: linux-kernel
Cc: Dario Binacchi, Jani Nikula, Daniel Vetter, David Airlie,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, dri-devel
The Makefile enables/disables the file compilation depending on
CONFIG_DEBUG_FS.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
---
Changes in v2:
- Add 'Reviewed-by' tag of Jani Nikula
drivers/gpu/drm/drm_debugfs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index f291fb4b359f..f80d9cf3e71a 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -45,8 +45,6 @@
#include "drm_crtc_internal.h"
#include "drm_internal.h"
-#if defined(CONFIG_DEBUG_FS)
-
/***************************************************
* Initialization, etc.
**************************************************/
@@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
debugfs_remove_recursive(crtc->debugfs_entry);
crtc->debugfs_entry = NULL;
}
-
-#endif /* CONFIG_DEBUG_FS */
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/debugfs: drop unneeded DEBUG_FS guard
2023-12-23 18:32 ` Dario Binacchi
@ 2024-01-02 14:48 ` Jani Nikula
-1 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2024-01-02 14:48 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: Dario Binacchi, Daniel Vetter, David Airlie, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, dri-devel
On Sat, 23 Dec 2023, Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> The Makefile enables/disables the file compilation depending on
> CONFIG_DEBUG_FS.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks for the patch, pushed to drm-misc-next.
BR,
Jani.
>
> ---
>
> Changes in v2:
> - Add 'Reviewed-by' tag of Jani Nikula
>
> drivers/gpu/drm/drm_debugfs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index f291fb4b359f..f80d9cf3e71a 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -45,8 +45,6 @@
> #include "drm_crtc_internal.h"
> #include "drm_internal.h"
>
> -#if defined(CONFIG_DEBUG_FS)
> -
> /***************************************************
> * Initialization, etc.
> **************************************************/
> @@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
> debugfs_remove_recursive(crtc->debugfs_entry);
> crtc->debugfs_entry = NULL;
> }
> -
> -#endif /* CONFIG_DEBUG_FS */
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/debugfs: drop unneeded DEBUG_FS guard
@ 2024-01-02 14:48 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2024-01-02 14:48 UTC (permalink / raw)
To: Dario Binacchi, linux-kernel
Cc: Thomas Zimmermann, Maxime Ripard, dri-devel, Dario Binacchi,
David Airlie
On Sat, 23 Dec 2023, Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
> The Makefile enables/disables the file compilation depending on
> CONFIG_DEBUG_FS.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks for the patch, pushed to drm-misc-next.
BR,
Jani.
>
> ---
>
> Changes in v2:
> - Add 'Reviewed-by' tag of Jani Nikula
>
> drivers/gpu/drm/drm_debugfs.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index f291fb4b359f..f80d9cf3e71a 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -45,8 +45,6 @@
> #include "drm_crtc_internal.h"
> #include "drm_internal.h"
>
> -#if defined(CONFIG_DEBUG_FS)
> -
> /***************************************************
> * Initialization, etc.
> **************************************************/
> @@ -588,5 +586,3 @@ void drm_debugfs_crtc_remove(struct drm_crtc *crtc)
> debugfs_remove_recursive(crtc->debugfs_entry);
> crtc->debugfs_entry = NULL;
> }
> -
> -#endif /* CONFIG_DEBUG_FS */
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-02 14:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-23 18:32 [PATCH v2] drm/debugfs: drop unneeded DEBUG_FS guard Dario Binacchi
2023-12-23 18:32 ` Dario Binacchi
2024-01-02 14:48 ` Jani Nikula
2024-01-02 14:48 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.