* [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.8
@ 2024-01-05 18:12 Fabrice Fontaine
2024-01-06 9:50 ` Thomas Petazzoni via buildroot
2024-01-12 18:42 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2024-01-05 18:12 UTC (permalink / raw)
To: buildroot; +Cc: Marcus Folkesson, Fabrice Fontaine
libostree unconditionally uses loop_config since bump to version 2023.5
in commit c64a3e9767757f6bab0ecf2df35871508003f39e and
https://github.com/containers/composefs/commit/d7f24100c932cd0da9c315de7c7d44fe7a5005cd
which is only available with kernel >= 5.8 and
https://github.com/torvalds/linux/commit/3448914e8cc550ba792d4ccc74471d1ca4293aae
resulting in the following build failure:
composefs/libcomposefs/lcfs-mount.c: In function 'setup_loopback':
composefs/libcomposefs/lcfs-mount.c:273:16: error: variable 'loopconfig' has initializer but incomplete type
273 | struct loop_config loopconfig = { 0 };
| ^~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/25d9d4f256861628ddd8e8ce659a39655d27b457
- http://autobuild.buildroot.org/results/5c7e1e47c6eb43f7832ef7820ec2b5ac0f3c3696
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libostree/Config.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/libostree/Config.in b/package/libostree/Config.in
index 9c59413eb1..49eed6517e 100644
--- a/package/libostree/Config.in
+++ b/package/libostree/Config.in
@@ -6,7 +6,7 @@ config BR2_PACKAGE_LIBOSTREE
depends on BR2_USE_MMU # e2fsprogs, libglib2, libgpgme
# doesn't build with musl due to lack of TEMP_FAILURE_RETRY()
depends on !BR2_TOOLCHAIN_USES_MUSL
- depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_4 # linux/fsverity.h
+ depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8 # loop_config
select BR2_PACKAGE_E2FSPROGS
select BR2_PACKAGE_LIBARCHIVE if BR2_s390x
select BR2_PACKAGE_LIBGLIB2
@@ -19,9 +19,9 @@ config BR2_PACKAGE_LIBOSTREE
https://ostree.readthedocs.io/en/latest/
-comment "libostree needs a uClibc or glibc toolchain w/ threads, dynamic library, wchar, headers >= 5.4"
+comment "libostree needs a uClibc or glibc toolchain w/ threads, dynamic library, wchar, headers >= 5.8"
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
|| !BR2_USE_WCHAR || BR2_TOOLCHAIN_USES_MUSL || \
- !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_4
+ !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
depends on BR2_USE_MMU
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.8
2024-01-05 18:12 [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.8 Fabrice Fontaine
@ 2024-01-06 9:50 ` Thomas Petazzoni via buildroot
2024-01-12 18:42 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-01-06 9:50 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Marcus Folkesson, buildroot
On Fri, 5 Jan 2024 19:12:07 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> libostree unconditionally uses loop_config since bump to version 2023.5
> in commit c64a3e9767757f6bab0ecf2df35871508003f39e and
> https://github.com/containers/composefs/commit/d7f24100c932cd0da9c315de7c7d44fe7a5005cd
> which is only available with kernel >= 5.8 and
> https://github.com/torvalds/linux/commit/3448914e8cc550ba792d4ccc74471d1ca4293aae
> resulting in the following build failure:
>
> composefs/libcomposefs/lcfs-mount.c: In function 'setup_loopback':
> composefs/libcomposefs/lcfs-mount.c:273:16: error: variable 'loopconfig' has initializer but incomplete type
> 273 | struct loop_config loopconfig = { 0 };
> | ^~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/25d9d4f256861628ddd8e8ce659a39655d27b457
> - http://autobuild.buildroot.org/results/5c7e1e47c6eb43f7832ef7820ec2b5ac0f3c3696
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libostree/Config.in | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.8
2024-01-05 18:12 [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.8 Fabrice Fontaine
2024-01-06 9:50 ` Thomas Petazzoni via buildroot
@ 2024-01-12 18:42 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-01-12 18:42 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Marcus Folkesson, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libostree unconditionally uses loop_config since bump to version 2023.5
> in commit c64a3e9767757f6bab0ecf2df35871508003f39e and
> https://github.com/containers/composefs/commit/d7f24100c932cd0da9c315de7c7d44fe7a5005cd
> which is only available with kernel >= 5.8 and
> https://github.com/torvalds/linux/commit/3448914e8cc550ba792d4ccc74471d1ca4293aae
> resulting in the following build failure:
> composefs/libcomposefs/lcfs-mount.c: In function 'setup_loopback':
> composefs/libcomposefs/lcfs-mount.c:273:16: error: variable 'loopconfig' has initializer but incomplete type
> 273 | struct loop_config loopconfig = { 0 };
> | ^~~~~~~~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/25d9d4f256861628ddd8e8ce659a39655d27b457
> - http://autobuild.buildroot.org/results/5c7e1e47c6eb43f7832ef7820ec2b5ac0f3c3696
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-12 18:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-05 18:12 [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.8 Fabrice Fontaine
2024-01-06 9:50 ` Thomas Petazzoni via buildroot
2024-01-12 18:42 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.