* [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-09 7:09 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-09 7:09 UTC (permalink / raw)
To: devicetree, dri-devel
Cc: neil.armstrong, quic_jesszhan, sam, airlied, daniel,
maarten.lankhorst, mripard, tzimmermann, robh+dt,
krzysztof.kozlowski+dt, conor+dt, wahrenst, dave.stevenson,
thierry.reding, changhuang.liang, keith.zhao, shengyang.chen,
jack.zhu, linux-kernel
This patchset adds waveshare 7inch touchscreen panel support
for the StarFive JH7110 SoC.
changes since v1:
- Rebased on tag v6.7.
patch 1:
- Gave up original changing.
- Changed the commit message.
- Add compatible in panel-simple.yaml
patch 2:
- Gave up original changing.
- Changed the commit message.
- Add new mode for the panel in panel-simple.c
v1: https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
Shengyang Chen (2):
dt-bindings: display: panel: panel-simple: Add compatible property for
waveshare 7inch touchscreen panel
gpu: drm: panel: panel-simple: add new display mode for waveshare
7inch touchscreen panel
.../bindings/display/panel/panel-simple.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
2 files changed, 30 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-09 7:09 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-09 7:09 UTC (permalink / raw)
To: devicetree, dri-devel
Cc: neil.armstrong, conor+dt, keith.zhao, tzimmermann,
krzysztof.kozlowski+dt, dave.stevenson, sam, linux-kernel,
mripard, jack.zhu, robh+dt, thierry.reding, wahrenst,
shengyang.chen, quic_jesszhan, changhuang.liang
This patchset adds waveshare 7inch touchscreen panel support
for the StarFive JH7110 SoC.
changes since v1:
- Rebased on tag v6.7.
patch 1:
- Gave up original changing.
- Changed the commit message.
- Add compatible in panel-simple.yaml
patch 2:
- Gave up original changing.
- Changed the commit message.
- Add new mode for the panel in panel-simple.c
v1: https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
Shengyang Chen (2):
dt-bindings: display: panel: panel-simple: Add compatible property for
waveshare 7inch touchscreen panel
gpu: drm: panel: panel-simple: add new display mode for waveshare
7inch touchscreen panel
.../bindings/display/panel/panel-simple.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
2 files changed, 30 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 36+ messages in thread
* [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
2024-01-09 7:09 ` Shengyang Chen
@ 2024-01-09 7:09 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-09 7:09 UTC (permalink / raw)
To: devicetree, dri-devel
Cc: neil.armstrong, quic_jesszhan, sam, airlied, daniel,
maarten.lankhorst, mripard, tzimmermann, robh+dt,
krzysztof.kozlowski+dt, conor+dt, wahrenst, dave.stevenson,
thierry.reding, changhuang.liang, keith.zhao, shengyang.chen,
jack.zhu, linux-kernel
The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
It can be drived by Raspberry Pi panel's process but it needs different
timing from Raspberry Pi panel. Add compatible property for it.
Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 11422af3477e..02f6b1b2ddc9 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -335,6 +335,8 @@ properties:
- vivax,tpc9150-panel
# VXT 800x480 color TFT LCD panel
- vxt,vl050-8048nt-c01
+ # Waveshare 7" (800x480) touchscreen LCD panel
+ - waveshare,7inch-touchscreen
# Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
- winstar,wf35ltiacd
# Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
--
2.17.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
@ 2024-01-09 7:09 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-09 7:09 UTC (permalink / raw)
To: devicetree, dri-devel
Cc: neil.armstrong, conor+dt, keith.zhao, tzimmermann,
krzysztof.kozlowski+dt, dave.stevenson, sam, linux-kernel,
mripard, jack.zhu, robh+dt, thierry.reding, wahrenst,
shengyang.chen, quic_jesszhan, changhuang.liang
The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
It can be drived by Raspberry Pi panel's process but it needs different
timing from Raspberry Pi panel. Add compatible property for it.
Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 11422af3477e..02f6b1b2ddc9 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -335,6 +335,8 @@ properties:
- vivax,tpc9150-panel
# VXT 800x480 color TFT LCD panel
- vxt,vl050-8048nt-c01
+ # Waveshare 7" (800x480) touchscreen LCD panel
+ - waveshare,7inch-touchscreen
# Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
- winstar,wf35ltiacd
# Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
--
2.17.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel
2024-01-09 7:09 ` Shengyang Chen
@ 2024-01-09 7:09 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-09 7:09 UTC (permalink / raw)
To: devicetree, dri-devel
Cc: neil.armstrong, quic_jesszhan, sam, airlied, daniel,
maarten.lankhorst, mripard, tzimmermann, robh+dt,
krzysztof.kozlowski+dt, conor+dt, wahrenst, dave.stevenson,
thierry.reding, changhuang.liang, keith.zhao, shengyang.chen,
jack.zhu, linux-kernel
The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
It also uses a Toshiba TC358762 DSI to DPI bridge chip but it needs different
timing from Raspberry Pi panel. Add new timing for it.
Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
---
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9367a4572dcf..e0896873ea33 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -4110,6 +4110,31 @@ static const struct panel_desc vl050_8048nt_c01 = {
.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
};
+static const struct drm_display_mode waveshare_7inch_mode = {
+ .clock = 29700000 / 1000,
+ .hdisplay = 800,
+ .hsync_start = 800 + 90,
+ .hsync_end = 800 + 90 + 5,
+ .htotal = 800 + 90 + 5 + 5,
+ .vdisplay = 480,
+ .vsync_start = 480 + 60,
+ .vsync_end = 480 + 60 + 5,
+ .vtotal = 480 + 60 + 5 + 5,
+ .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc waveshare_7inch = {
+ .modes = &waveshare_7inch_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .connector_type = DRM_MODE_CONNECTOR_DSI,
+};
+
static const struct drm_display_mode winstar_wf35ltiacd_mode = {
.clock = 6410,
.hdisplay = 320,
@@ -4592,6 +4617,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "vxt,vl050-8048nt-c01",
.data = &vl050_8048nt_c01,
+ }, {
+ .compatible = "waveshare,7inch-touchscreen",
+ .data = &waveshare_7inch,
}, {
.compatible = "winstar,wf35ltiacd",
.data = &winstar_wf35ltiacd,
--
2.17.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel
@ 2024-01-09 7:09 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-09 7:09 UTC (permalink / raw)
To: devicetree, dri-devel
Cc: neil.armstrong, conor+dt, keith.zhao, tzimmermann,
krzysztof.kozlowski+dt, dave.stevenson, sam, linux-kernel,
mripard, jack.zhu, robh+dt, thierry.reding, wahrenst,
shengyang.chen, quic_jesszhan, changhuang.liang
The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
It also uses a Toshiba TC358762 DSI to DPI bridge chip but it needs different
timing from Raspberry Pi panel. Add new timing for it.
Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
---
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9367a4572dcf..e0896873ea33 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -4110,6 +4110,31 @@ static const struct panel_desc vl050_8048nt_c01 = {
.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
};
+static const struct drm_display_mode waveshare_7inch_mode = {
+ .clock = 29700000 / 1000,
+ .hdisplay = 800,
+ .hsync_start = 800 + 90,
+ .hsync_end = 800 + 90 + 5,
+ .htotal = 800 + 90 + 5 + 5,
+ .vdisplay = 480,
+ .vsync_start = 480 + 60,
+ .vsync_end = 480 + 60 + 5,
+ .vtotal = 480 + 60 + 5 + 5,
+ .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc waveshare_7inch = {
+ .modes = &waveshare_7inch_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 154,
+ .height = 86,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .connector_type = DRM_MODE_CONNECTOR_DSI,
+};
+
static const struct drm_display_mode winstar_wf35ltiacd_mode = {
.clock = 6410,
.hdisplay = 320,
@@ -4592,6 +4617,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "vxt,vl050-8048nt-c01",
.data = &vl050_8048nt_c01,
+ }, {
+ .compatible = "waveshare,7inch-touchscreen",
+ .data = &waveshare_7inch,
}, {
.compatible = "winstar,wf35ltiacd",
.data = &winstar_wf35ltiacd,
--
2.17.1
^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-09 7:09 ` Shengyang Chen
@ 2024-01-09 11:19 ` neil.armstrong
-1 siblings, 0 replies; 36+ messages in thread
From: neil.armstrong @ 2024-01-09 11:19 UTC (permalink / raw)
To: Shengyang Chen, devicetree, dri-devel
Cc: conor+dt, keith.zhao, tzimmermann, krzysztof.kozlowski+dt,
dave.stevenson, sam, linux-kernel, mripard, jack.zhu, robh+dt,
thierry.reding, wahrenst, quic_jesszhan, changhuang.liang
Hi,
On 09/01/2024 08:09, Shengyang Chen wrote:
> This patchset adds waveshare 7inch touchscreen panel support
> for the StarFive JH7110 SoC.
Could you precise which SKU you're referring to ? is it 19885 => https://www.waveshare.com/7inch-dsi-lcd.htm ?
Are you sure it requires different timings from the RPi one ? In the Waveshare
wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it: https://www.waveshare.com/wiki/7inch_DSI_LCD
Neil
>
>
> changes since v1:
> - Rebased on tag v6.7.
>
> patch 1:
> - Gave up original changing.
> - Changed the commit message.
> - Add compatible in panel-simple.yaml
>
> patch 2:
> - Gave up original changing.
> - Changed the commit message.
> - Add new mode for the panel in panel-simple.c
>
> v1: https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
>
> Shengyang Chen (2):
> dt-bindings: display: panel: panel-simple: Add compatible property for
> waveshare 7inch touchscreen panel
> gpu: drm: panel: panel-simple: add new display mode for waveshare
> 7inch touchscreen panel
>
> .../bindings/display/panel/panel-simple.yaml | 2 ++
> drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-09 11:19 ` neil.armstrong
0 siblings, 0 replies; 36+ messages in thread
From: neil.armstrong @ 2024-01-09 11:19 UTC (permalink / raw)
To: Shengyang Chen, devicetree, dri-devel
Cc: quic_jesszhan, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, changhuang.liang, keith.zhao,
jack.zhu, linux-kernel
Hi,
On 09/01/2024 08:09, Shengyang Chen wrote:
> This patchset adds waveshare 7inch touchscreen panel support
> for the StarFive JH7110 SoC.
Could you precise which SKU you're referring to ? is it 19885 => https://www.waveshare.com/7inch-dsi-lcd.htm ?
Are you sure it requires different timings from the RPi one ? In the Waveshare
wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it: https://www.waveshare.com/wiki/7inch_DSI_LCD
Neil
>
>
> changes since v1:
> - Rebased on tag v6.7.
>
> patch 1:
> - Gave up original changing.
> - Changed the commit message.
> - Add compatible in panel-simple.yaml
>
> patch 2:
> - Gave up original changing.
> - Changed the commit message.
> - Add new mode for the panel in panel-simple.c
>
> v1: https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
>
> Shengyang Chen (2):
> dt-bindings: display: panel: panel-simple: Add compatible property for
> waveshare 7inch touchscreen panel
> gpu: drm: panel: panel-simple: add new display mode for waveshare
> 7inch touchscreen panel
>
> .../bindings/display/panel/panel-simple.yaml | 2 ++
> drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
2024-01-09 7:09 ` Shengyang Chen
@ 2024-01-09 16:32 ` Conor Dooley
-1 siblings, 0 replies; 36+ messages in thread
From: Conor Dooley @ 2024-01-09 16:32 UTC (permalink / raw)
To: Shengyang Chen
Cc: devicetree, dri-devel, neil.armstrong, quic_jesszhan, sam,
airlied, daniel, maarten.lankhorst, mripard, tzimmermann,
robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, changhuang.liang, keith.zhao,
jack.zhu, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
> It can be drived by Raspberry Pi panel's process but it needs different
> timing from Raspberry Pi panel. Add compatible property for it.
>
> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 11422af3477e..02f6b1b2ddc9 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -335,6 +335,8 @@ properties:
> - vivax,tpc9150-panel
> # VXT 800x480 color TFT LCD panel
> - vxt,vl050-8048nt-c01
> + # Waveshare 7" (800x480) touchscreen LCD panel
> + - waveshare,7inch-touchscreen
Is "7inch-touchscreen" really a specific enough identifier for this
device?
> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> - winstar,wf35ltiacd
> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
@ 2024-01-09 16:32 ` Conor Dooley
0 siblings, 0 replies; 36+ messages in thread
From: Conor Dooley @ 2024-01-09 16:32 UTC (permalink / raw)
To: Shengyang Chen
Cc: devicetree, conor+dt, keith.zhao, tzimmermann,
krzysztof.kozlowski+dt, neil.armstrong, sam, dave.stevenson,
linux-kernel, dri-devel, jack.zhu, robh+dt, thierry.reding,
mripard, quic_jesszhan, changhuang.liang, wahrenst
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
> It can be drived by Raspberry Pi panel's process but it needs different
> timing from Raspberry Pi panel. Add compatible property for it.
>
> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> ---
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 11422af3477e..02f6b1b2ddc9 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -335,6 +335,8 @@ properties:
> - vivax,tpc9150-panel
> # VXT 800x480 color TFT LCD panel
> - vxt,vl050-8048nt-c01
> + # Waveshare 7" (800x480) touchscreen LCD panel
> + - waveshare,7inch-touchscreen
Is "7inch-touchscreen" really a specific enough identifier for this
device?
> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> - winstar,wf35ltiacd
> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-09 11:19 ` neil.armstrong
@ 2024-01-09 17:21 ` Stefan Wahren
-1 siblings, 0 replies; 36+ messages in thread
From: Stefan Wahren @ 2024-01-09 17:21 UTC (permalink / raw)
To: neil.armstrong, Shengyang Chen, devicetree, dri-devel
Cc: quic_jesszhan, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt,
dave.stevenson, thierry.reding, changhuang.liang, keith.zhao,
jack.zhu, linux-kernel
Hi Neil,
Am 09.01.24 um 12:19 schrieb neil.armstrong@linaro.org:
> Hi,
>
> On 09/01/2024 08:09, Shengyang Chen wrote:
>> This patchset adds waveshare 7inch touchscreen panel support
>> for the StarFive JH7110 SoC.
>
> Could you precise which SKU you're referring to ? is it 19885 =>
> https://www.waveshare.com/7inch-dsi-lcd.htm ?
>
> Are you sure it requires different timings from the RPi one ? In the
> Waveshare
> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
> https://www.waveshare.com/wiki/7inch_DSI_LCD
i don't have an anser for your question, but the Raspberry Pi vendor
tree use different timings than the Mainline kernel:
https://github.com/raspberrypi/linux/commit/222b9baa97cc4c880d040a8c6a5da80d6a42c8e8
Additionally the
arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso suggests
that it uses the Raspberry Pi 7inch, but uses the timings of
powertip,ph800480t013-idf02 from panel-simple.
Maybe Shengyang could test these timings with the Waveshare touch. At
the end this rely on a proper implementation on the underlying drivers.
Sorry, for adding more confusion.
Regards
>
> Neil
>
>>
>>
>> changes since v1:
>> - Rebased on tag v6.7.
>>
>> patch 1:
>> - Gave up original changing.
>> - Changed the commit message.
>> - Add compatible in panel-simple.yaml
>>
>> patch 2:
>> - Gave up original changing.
>> - Changed the commit message.
>> - Add new mode for the panel in panel-simple.c
>>
>> v1:
>> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
>>
>> Shengyang Chen (2):
>> dt-bindings: display: panel: panel-simple: Add compatible property
>> for
>> waveshare 7inch touchscreen panel
>> gpu: drm: panel: panel-simple: add new display mode for waveshare
>> 7inch touchscreen panel
>>
>> .../bindings/display/panel/panel-simple.yaml | 2 ++
>> drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
>> 2 files changed, 30 insertions(+)
>>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-09 17:21 ` Stefan Wahren
0 siblings, 0 replies; 36+ messages in thread
From: Stefan Wahren @ 2024-01-09 17:21 UTC (permalink / raw)
To: neil.armstrong, Shengyang Chen, devicetree, dri-devel
Cc: conor+dt, keith.zhao, tzimmermann, krzysztof.kozlowski+dt,
dave.stevenson, sam, linux-kernel, mripard, jack.zhu, robh+dt,
thierry.reding, quic_jesszhan, changhuang.liang
Hi Neil,
Am 09.01.24 um 12:19 schrieb neil.armstrong@linaro.org:
> Hi,
>
> On 09/01/2024 08:09, Shengyang Chen wrote:
>> This patchset adds waveshare 7inch touchscreen panel support
>> for the StarFive JH7110 SoC.
>
> Could you precise which SKU you're referring to ? is it 19885 =>
> https://www.waveshare.com/7inch-dsi-lcd.htm ?
>
> Are you sure it requires different timings from the RPi one ? In the
> Waveshare
> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
> https://www.waveshare.com/wiki/7inch_DSI_LCD
i don't have an anser for your question, but the Raspberry Pi vendor
tree use different timings than the Mainline kernel:
https://github.com/raspberrypi/linux/commit/222b9baa97cc4c880d040a8c6a5da80d6a42c8e8
Additionally the
arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso suggests
that it uses the Raspberry Pi 7inch, but uses the timings of
powertip,ph800480t013-idf02 from panel-simple.
Maybe Shengyang could test these timings with the Waveshare touch. At
the end this rely on a proper implementation on the underlying drivers.
Sorry, for adding more confusion.
Regards
>
> Neil
>
>>
>>
>> changes since v1:
>> - Rebased on tag v6.7.
>>
>> patch 1:
>> - Gave up original changing.
>> - Changed the commit message.
>> - Add compatible in panel-simple.yaml
>>
>> patch 2:
>> - Gave up original changing.
>> - Changed the commit message.
>> - Add new mode for the panel in panel-simple.c
>>
>> v1:
>> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
>>
>> Shengyang Chen (2):
>> dt-bindings: display: panel: panel-simple: Add compatible property
>> for
>> waveshare 7inch touchscreen panel
>> gpu: drm: panel: panel-simple: add new display mode for waveshare
>> 7inch touchscreen panel
>>
>> .../bindings/display/panel/panel-simple.yaml | 2 ++
>> drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
>> 2 files changed, 30 insertions(+)
>>
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-09 11:19 ` neil.armstrong
@ 2024-01-09 17:28 ` Dave Stevenson
-1 siblings, 0 replies; 36+ messages in thread
From: Dave Stevenson @ 2024-01-09 17:28 UTC (permalink / raw)
To: neil.armstrong
Cc: devicetree, conor+dt, keith.zhao, tzimmermann,
krzysztof.kozlowski+dt, sam, linux-kernel, dri-devel, jack.zhu,
robh+dt, thierry.reding, mripard, Shengyang Chen, quic_jesszhan,
changhuang.liang, wahrenst
Hi
On Tue, 9 Jan 2024 at 11:19, <neil.armstrong@linaro.org> wrote:
>
> Hi,
>
> On 09/01/2024 08:09, Shengyang Chen wrote:
> > This patchset adds waveshare 7inch touchscreen panel support
> > for the StarFive JH7110 SoC.
>
> Could you precise which SKU you're referring to ? is it 19885 => https://www.waveshare.com/7inch-dsi-lcd.htm ?
>
> Are you sure it requires different timings from the RPi one ? In the Waveshare
> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it: https://www.waveshare.com/wiki/7inch_DSI_LCD
I raise the same question.
Keith Zhao earlier submitted effectively the same set of patches [1]
and the response for the updated timing was:
<quote>
My platform dphy tx hardware has certain limitations.
Only supports integer multiples of 10M bitrate:
such as 160M ,170M, 180M,190M,...1G(max)
as common dphy bitrate = pixclock*bpp/lanes.
This value cannot match successfully in most cases.
so in order to match bitrate , I choose a bitrate value around
pixclock*bpp/lanes,
Prevent overflow and underflow by fine-tuning the timing parameters:-(
that will make the new timming value.
</quote>
I then suggested mode_fixup should be used in the DSI host driver, and
Keith acknowledged that.
Is this new timing still because of the DSI host requirement?
Dave
[1] https://lists.freedesktop.org/archives/dri-devel/2023-December/434150.html
> Neil
>
> >
> >
> > changes since v1:
> > - Rebased on tag v6.7.
> >
> > patch 1:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add compatible in panel-simple.yaml
> >
> > patch 2:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add new mode for the panel in panel-simple.c
> >
> > v1: https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
> >
> > Shengyang Chen (2):
> > dt-bindings: display: panel: panel-simple: Add compatible property for
> > waveshare 7inch touchscreen panel
> > gpu: drm: panel: panel-simple: add new display mode for waveshare
> > 7inch touchscreen panel
> >
> > .../bindings/display/panel/panel-simple.yaml | 2 ++
> > drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-09 17:28 ` Dave Stevenson
0 siblings, 0 replies; 36+ messages in thread
From: Dave Stevenson @ 2024-01-09 17:28 UTC (permalink / raw)
To: neil.armstrong
Cc: Shengyang Chen, devicetree, dri-devel, quic_jesszhan, sam,
airlied, daniel, maarten.lankhorst, mripard, tzimmermann,
robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
thierry.reding, changhuang.liang, keith.zhao, jack.zhu,
linux-kernel
Hi
On Tue, 9 Jan 2024 at 11:19, <neil.armstrong@linaro.org> wrote:
>
> Hi,
>
> On 09/01/2024 08:09, Shengyang Chen wrote:
> > This patchset adds waveshare 7inch touchscreen panel support
> > for the StarFive JH7110 SoC.
>
> Could you precise which SKU you're referring to ? is it 19885 => https://www.waveshare.com/7inch-dsi-lcd.htm ?
>
> Are you sure it requires different timings from the RPi one ? In the Waveshare
> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it: https://www.waveshare.com/wiki/7inch_DSI_LCD
I raise the same question.
Keith Zhao earlier submitted effectively the same set of patches [1]
and the response for the updated timing was:
<quote>
My platform dphy tx hardware has certain limitations.
Only supports integer multiples of 10M bitrate:
such as 160M ,170M, 180M,190M,...1G(max)
as common dphy bitrate = pixclock*bpp/lanes.
This value cannot match successfully in most cases.
so in order to match bitrate , I choose a bitrate value around
pixclock*bpp/lanes,
Prevent overflow and underflow by fine-tuning the timing parameters:-(
that will make the new timming value.
</quote>
I then suggested mode_fixup should be used in the DSI host driver, and
Keith acknowledged that.
Is this new timing still because of the DSI host requirement?
Dave
[1] https://lists.freedesktop.org/archives/dri-devel/2023-December/434150.html
> Neil
>
> >
> >
> > changes since v1:
> > - Rebased on tag v6.7.
> >
> > patch 1:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add compatible in panel-simple.yaml
> >
> > patch 2:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add new mode for the panel in panel-simple.c
> >
> > v1: https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44271-1-shengyang.chen@starfivetech.com/
> >
> > Shengyang Chen (2):
> > dt-bindings: display: panel: panel-simple: Add compatible property for
> > waveshare 7inch touchscreen panel
> > gpu: drm: panel: panel-simple: add new display mode for waveshare
> > 7inch touchscreen panel
> >
> > .../bindings/display/panel/panel-simple.yaml | 2 ++
> > drivers/gpu/drm/panel/panel-simple.c | 28 +++++++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel
2024-01-09 7:09 ` Shengyang Chen
@ 2024-01-09 18:26 ` Jessica Zhang
-1 siblings, 0 replies; 36+ messages in thread
From: Jessica Zhang @ 2024-01-09 18:26 UTC (permalink / raw)
To: Shengyang Chen, devicetree, dri-devel
Cc: neil.armstrong, conor+dt, keith.zhao, tzimmermann,
krzysztof.kozlowski+dt, dave.stevenson, sam, linux-kernel,
mripard, jack.zhu, robh+dt, thierry.reding, wahrenst,
changhuang.liang
On 1/8/2024 11:09 PM, Shengyang Chen wrote:
> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
> It also uses a Toshiba TC358762 DSI to DPI bridge chip but it needs different
> timing from Raspberry Pi panel. Add new timing for it.
Hi Shengyang,
The patch itself LGTM, but in case you have to put out a new revision,
can you please use the "drm/panel: <driver name>:" prefix format that
other drm/panel commits use?
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
>
> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 9367a4572dcf..e0896873ea33 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -4110,6 +4110,31 @@ static const struct panel_desc vl050_8048nt_c01 = {
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> };
>
> +static const struct drm_display_mode waveshare_7inch_mode = {
> + .clock = 29700000 / 1000,
> + .hdisplay = 800,
> + .hsync_start = 800 + 90,
> + .hsync_end = 800 + 90 + 5,
> + .htotal = 800 + 90 + 5 + 5,
> + .vdisplay = 480,
> + .vsync_start = 480 + 60,
> + .vsync_end = 480 + 60 + 5,
> + .vtotal = 480 + 60 + 5 + 5,
> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> +};
> +
> +static const struct panel_desc waveshare_7inch = {
> + .modes = &waveshare_7inch_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 154,
> + .height = 86,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .connector_type = DRM_MODE_CONNECTOR_DSI,
> +};
> +
> static const struct drm_display_mode winstar_wf35ltiacd_mode = {
> .clock = 6410,
> .hdisplay = 320,
> @@ -4592,6 +4617,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "vxt,vl050-8048nt-c01",
> .data = &vl050_8048nt_c01,
> + }, {
> + .compatible = "waveshare,7inch-touchscreen",
> + .data = &waveshare_7inch,
> }, {
> .compatible = "winstar,wf35ltiacd",
> .data = &winstar_wf35ltiacd,
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel
@ 2024-01-09 18:26 ` Jessica Zhang
0 siblings, 0 replies; 36+ messages in thread
From: Jessica Zhang @ 2024-01-09 18:26 UTC (permalink / raw)
To: Shengyang Chen, devicetree, dri-devel
Cc: neil.armstrong, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, changhuang.liang, keith.zhao,
jack.zhu, linux-kernel
On 1/8/2024 11:09 PM, Shengyang Chen wrote:
> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
> It also uses a Toshiba TC358762 DSI to DPI bridge chip but it needs different
> timing from Raspberry Pi panel. Add new timing for it.
Hi Shengyang,
The patch itself LGTM, but in case you have to put out a new revision,
can you please use the "drm/panel: <driver name>:" prefix format that
other drm/panel commits use?
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
>
> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 9367a4572dcf..e0896873ea33 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -4110,6 +4110,31 @@ static const struct panel_desc vl050_8048nt_c01 = {
> .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> };
>
> +static const struct drm_display_mode waveshare_7inch_mode = {
> + .clock = 29700000 / 1000,
> + .hdisplay = 800,
> + .hsync_start = 800 + 90,
> + .hsync_end = 800 + 90 + 5,
> + .htotal = 800 + 90 + 5 + 5,
> + .vdisplay = 480,
> + .vsync_start = 480 + 60,
> + .vsync_end = 480 + 60 + 5,
> + .vtotal = 480 + 60 + 5 + 5,
> + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> +};
> +
> +static const struct panel_desc waveshare_7inch = {
> + .modes = &waveshare_7inch_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 154,
> + .height = 86,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .connector_type = DRM_MODE_CONNECTOR_DSI,
> +};
> +
> static const struct drm_display_mode winstar_wf35ltiacd_mode = {
> .clock = 6410,
> .hdisplay = 320,
> @@ -4592,6 +4617,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "vxt,vl050-8048nt-c01",
> .data = &vl050_8048nt_c01,
> + }, {
> + .compatible = "waveshare,7inch-touchscreen",
> + .data = &waveshare_7inch,
> }, {
> .compatible = "winstar,wf35ltiacd",
> .data = &winstar_wf35ltiacd,
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
2024-01-09 16:32 ` Conor Dooley
@ 2024-01-10 9:05 ` neil.armstrong
-1 siblings, 0 replies; 36+ messages in thread
From: neil.armstrong @ 2024-01-10 9:05 UTC (permalink / raw)
To: Conor Dooley, Shengyang Chen
Cc: devicetree, dri-devel, quic_jesszhan, sam, airlied, daniel,
maarten.lankhorst, mripard, tzimmermann, robh+dt,
krzysztof.kozlowski+dt, conor+dt, wahrenst, dave.stevenson,
thierry.reding, changhuang.liang, keith.zhao, jack.zhu,
linux-kernel
On 09/01/2024 17:32, Conor Dooley wrote:
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
>> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
>> It can be drived by Raspberry Pi panel's process but it needs different
>> timing from Raspberry Pi panel. Add compatible property for it.
>>
>> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
>> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
>> ---
>> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> index 11422af3477e..02f6b1b2ddc9 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -335,6 +335,8 @@ properties:
>> - vivax,tpc9150-panel
>> # VXT 800x480 color TFT LCD panel
>> - vxt,vl050-8048nt-c01
>> + # Waveshare 7" (800x480) touchscreen LCD panel
>> + - waveshare,7inch-touchscreen
>
> Is "7inch-touchscreen" really a specific enough identifier for this
> device?
Waveshare has very precise SKUs, this should be something like waveshare,7inch-dsi-sku19885 perhaps
Neil
>
>> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
>> - winstar,wf35ltiacd
>> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
@ 2024-01-10 9:05 ` neil.armstrong
0 siblings, 0 replies; 36+ messages in thread
From: neil.armstrong @ 2024-01-10 9:05 UTC (permalink / raw)
To: Conor Dooley, Shengyang Chen
Cc: devicetree, conor+dt, keith.zhao, tzimmermann,
krzysztof.kozlowski+dt, dave.stevenson, sam, linux-kernel,
dri-devel, jack.zhu, robh+dt, thierry.reding, mripard,
quic_jesszhan, changhuang.liang, wahrenst
On 09/01/2024 17:32, Conor Dooley wrote:
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
>> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
>> It can be drived by Raspberry Pi panel's process but it needs different
>> timing from Raspberry Pi panel. Add compatible property for it.
>>
>> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
>> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
>> ---
>> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> index 11422af3477e..02f6b1b2ddc9 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -335,6 +335,8 @@ properties:
>> - vivax,tpc9150-panel
>> # VXT 800x480 color TFT LCD panel
>> - vxt,vl050-8048nt-c01
>> + # Waveshare 7" (800x480) touchscreen LCD panel
>> + - waveshare,7inch-touchscreen
>
> Is "7inch-touchscreen" really a specific enough identifier for this
> device?
Waveshare has very precise SKUs, this should be something like waveshare,7inch-dsi-sku19885 perhaps
Neil
>
>> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
>> - winstar,wf35ltiacd
>> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-09 11:19 ` neil.armstrong
@ 2024-01-16 9:32 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:32 UTC (permalink / raw)
To: neil.armstrong, devicetree, dri-devel
Cc: conor+dt, Keith Zhao, tzimmermann, krzysztof.kozlowski+dt,
dave.stevenson, sam, linux-kernel, mripard, Jack Zhu, robh+dt,
thierry.reding, wahrenst, daniel, quic_jesszhan, airlied,
Changhuang Liang
Hi, Neil
Thanks for your comment.
> -----Original Message-----
> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> Sent: 2024年1月9日 19:19
> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> Hi,
>
> On 09/01/2024 08:09, Shengyang Chen wrote:
> > This patchset adds waveshare 7inch touchscreen panel support for the
> > StarFive JH7110 SoC.
>
> Could you precise which SKU you're referring to ? is it 19885 =>
> https://www.waveshare.com/7inch-dsi-lcd.htm ?
>
yes, it is
sorry for confusing you.
> Are you sure it requires different timings from the RPi one ? In the Waveshare
> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
> https://www.waveshare.com/wiki/7inch_DSI_LCD
>
Referring to Keith's answer
https://lists.freedesktop.org/archives/dri-devel/2023-December/434200.html
the panel timing value is generated to fit phy's bitrate and prevent overflow and underflow.
Referring to the suggestion, we may try other timing from panel-simple to drive the panel.
> Neil
>
> >
> >
> > changes since v1:
> > - Rebased on tag v6.7.
> >
> > patch 1:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add compatible in panel-simple.yaml
> >
> > patch 2:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add new mode for the panel in panel-simple.c
> >
> > v1:
> > https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44
> > 271-1-shengyang.chen@starfivetech.com/
> >
> > Shengyang Chen (2):
> > dt-bindings: display: panel: panel-simple: Add compatible property for
> > waveshare 7inch touchscreen panel
> > gpu: drm: panel: panel-simple: add new display mode for waveshare
> > 7inch touchscreen panel
> >
> > .../bindings/display/panel/panel-simple.yaml | 2 ++
> > drivers/gpu/drm/panel/panel-simple.c | 28
> +++++++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-16 9:32 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:32 UTC (permalink / raw)
To: neil.armstrong, devicetree, dri-devel
Cc: quic_jesszhan, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, Changhuang Liang, Keith Zhao,
Jack Zhu, linux-kernel
Hi, Neil
Thanks for your comment.
> -----Original Message-----
> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> Sent: 2024年1月9日 19:19
> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> Hi,
>
> On 09/01/2024 08:09, Shengyang Chen wrote:
> > This patchset adds waveshare 7inch touchscreen panel support for the
> > StarFive JH7110 SoC.
>
> Could you precise which SKU you're referring to ? is it 19885 =>
> https://www.waveshare.com/7inch-dsi-lcd.htm ?
>
yes, it is
sorry for confusing you.
> Are you sure it requires different timings from the RPi one ? In the Waveshare
> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
> https://www.waveshare.com/wiki/7inch_DSI_LCD
>
Referring to Keith's answer
https://lists.freedesktop.org/archives/dri-devel/2023-December/434200.html
the panel timing value is generated to fit phy's bitrate and prevent overflow and underflow.
Referring to the suggestion, we may try other timing from panel-simple to drive the panel.
> Neil
>
> >
> >
> > changes since v1:
> > - Rebased on tag v6.7.
> >
> > patch 1:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add compatible in panel-simple.yaml
> >
> > patch 2:
> > - Gave up original changing.
> > - Changed the commit message.
> > - Add new mode for the panel in panel-simple.c
> >
> > v1:
> > https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44
> > 271-1-shengyang.chen@starfivetech.com/
> >
> > Shengyang Chen (2):
> > dt-bindings: display: panel: panel-simple: Add compatible property for
> > waveshare 7inch touchscreen panel
> > gpu: drm: panel: panel-simple: add new display mode for waveshare
> > 7inch touchscreen panel
> >
> > .../bindings/display/panel/panel-simple.yaml | 2 ++
> > drivers/gpu/drm/panel/panel-simple.c | 28
> +++++++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-16 9:32 ` Shengyang Chen
@ 2024-01-16 9:34 ` neil.armstrong
-1 siblings, 0 replies; 36+ messages in thread
From: neil.armstrong @ 2024-01-16 9:34 UTC (permalink / raw)
To: Shengyang Chen, devicetree, dri-devel
Cc: quic_jesszhan, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, Changhuang Liang, Keith Zhao,
Jack Zhu, linux-kernel
On 16/01/2024 10:32, Shengyang Chen wrote:
> Hi, Neil
>
> Thanks for your comment.
>
>> -----Original Message-----
>> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
>> Sent: 2024年1月9日 19:19
>> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
>> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
>> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
>> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
>> tzimmermann@suse.de; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
>> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
>> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
>> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
>> linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>>
>> Hi,
>>
>> On 09/01/2024 08:09, Shengyang Chen wrote:
>>> This patchset adds waveshare 7inch touchscreen panel support for the
>>> StarFive JH7110 SoC.
>>
>> Could you precise which SKU you're referring to ? is it 19885 =>
>> https://www.waveshare.com/7inch-dsi-lcd.htm ?
>>
>
> yes, it is
> sorry for confusing you.
>
>> Are you sure it requires different timings from the RPi one ? In the Waveshare
>> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
>> https://www.waveshare.com/wiki/7inch_DSI_LCD
>>
>
> Referring to Keith's answer
> https://lists.freedesktop.org/archives/dri-devel/2023-December/434200.html
> the panel timing value is generated to fit phy's bitrate and prevent overflow and underflow.
>
> Referring to the suggestion, we may try other timing from panel-simple to drive the panel.
Please implement a mode_fixup in your DSI host driver instead.
Neil
>
>> Neil
>>
>>>
>>>
>>> changes since v1:
>>> - Rebased on tag v6.7.
>>>
>>> patch 1:
>>> - Gave up original changing.
>>> - Changed the commit message.
>>> - Add compatible in panel-simple.yaml
>>>
>>> patch 2:
>>> - Gave up original changing.
>>> - Changed the commit message.
>>> - Add new mode for the panel in panel-simple.c
>>>
>>> v1:
>>> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44
>>> 271-1-shengyang.chen@starfivetech.com/
>>>
>>> Shengyang Chen (2):
>>> dt-bindings: display: panel: panel-simple: Add compatible property for
>>> waveshare 7inch touchscreen panel
>>> gpu: drm: panel: panel-simple: add new display mode for waveshare
>>> 7inch touchscreen panel
>>>
>>> .../bindings/display/panel/panel-simple.yaml | 2 ++
>>> drivers/gpu/drm/panel/panel-simple.c | 28
>> +++++++++++++++++++
>>> 2 files changed, 30 insertions(+)
>>>
>
>
> Best Regards,
> Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-16 9:34 ` neil.armstrong
0 siblings, 0 replies; 36+ messages in thread
From: neil.armstrong @ 2024-01-16 9:34 UTC (permalink / raw)
To: Shengyang Chen, devicetree, dri-devel
Cc: conor+dt, Keith Zhao, tzimmermann, krzysztof.kozlowski+dt,
dave.stevenson, sam, linux-kernel, mripard, Jack Zhu, robh+dt,
thierry.reding, wahrenst, daniel, quic_jesszhan, airlied,
Changhuang Liang
On 16/01/2024 10:32, Shengyang Chen wrote:
> Hi, Neil
>
> Thanks for your comment.
>
>> -----Original Message-----
>> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
>> Sent: 2024年1月9日 19:19
>> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
>> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
>> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
>> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
>> tzimmermann@suse.de; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
>> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
>> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
>> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
>> linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>>
>> Hi,
>>
>> On 09/01/2024 08:09, Shengyang Chen wrote:
>>> This patchset adds waveshare 7inch touchscreen panel support for the
>>> StarFive JH7110 SoC.
>>
>> Could you precise which SKU you're referring to ? is it 19885 =>
>> https://www.waveshare.com/7inch-dsi-lcd.htm ?
>>
>
> yes, it is
> sorry for confusing you.
>
>> Are you sure it requires different timings from the RPi one ? In the Waveshare
>> wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
>> https://www.waveshare.com/wiki/7inch_DSI_LCD
>>
>
> Referring to Keith's answer
> https://lists.freedesktop.org/archives/dri-devel/2023-December/434200.html
> the panel timing value is generated to fit phy's bitrate and prevent overflow and underflow.
>
> Referring to the suggestion, we may try other timing from panel-simple to drive the panel.
Please implement a mode_fixup in your DSI host driver instead.
Neil
>
>> Neil
>>
>>>
>>>
>>> changes since v1:
>>> - Rebased on tag v6.7.
>>>
>>> patch 1:
>>> - Gave up original changing.
>>> - Changed the commit message.
>>> - Add compatible in panel-simple.yaml
>>>
>>> patch 2:
>>> - Gave up original changing.
>>> - Changed the commit message.
>>> - Add new mode for the panel in panel-simple.c
>>>
>>> v1:
>>> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.44
>>> 271-1-shengyang.chen@starfivetech.com/
>>>
>>> Shengyang Chen (2):
>>> dt-bindings: display: panel: panel-simple: Add compatible property for
>>> waveshare 7inch touchscreen panel
>>> gpu: drm: panel: panel-simple: add new display mode for waveshare
>>> 7inch touchscreen panel
>>>
>>> .../bindings/display/panel/panel-simple.yaml | 2 ++
>>> drivers/gpu/drm/panel/panel-simple.c | 28
>> +++++++++++++++++++
>>> 2 files changed, 30 insertions(+)
>>>
>
>
> Best Regards,
> Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
2024-01-09 16:32 ` Conor Dooley
@ 2024-01-16 9:40 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:40 UTC (permalink / raw)
To: Conor Dooley
Cc: devicetree, dri-devel, neil.armstrong, quic_jesszhan, sam,
airlied, daniel, maarten.lankhorst, mripard, tzimmermann,
robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, Changhuang Liang, Keith Zhao,
Jack Zhu, linux-kernel
Hi, Conor
Thanks for comment.
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: 2024年1月10日 0:32
> To: Shengyang Chen <shengyang.chen@starfivetech.com>
> Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> neil.armstrong@linaro.org; quic_jesszhan@quicinc.com; sam@ravnborg.org;
> airlied@gmail.com; daniel@ffwll.ch; maarten.lankhorst@linux.intel.com;
> mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> compatible property for waveshare 7inch touchscreen panel
>
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > panel It can be drived by Raspberry Pi panel's process but it needs
> > different timing from Raspberry Pi panel. Add compatible property for it.
> >
> > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> > ---
> > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index 11422af3477e..02f6b1b2ddc9 100644
> > ---
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam
> > +++ l
> > @@ -335,6 +335,8 @@ properties:
> > - vivax,tpc9150-panel
> > # VXT 800x480 color TFT LCD panel
> > - vxt,vl050-8048nt-c01
> > + # Waveshare 7" (800x480) touchscreen LCD panel
> > + - waveshare,7inch-touchscreen
>
> Is "7inch-touchscreen" really a specific enough identifier for this device?
>
Referring to official website[1] and Neil's suggestion, maybe I should change to
"7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed.
[1]: https://www.waveshare.com/7inch-dsi-lcd.htm
> > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> > - winstar,wf35ltiacd
> > # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> > --
> > 2.17.1
> >
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
@ 2024-01-16 9:40 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:40 UTC (permalink / raw)
To: Conor Dooley
Cc: devicetree, conor+dt, Keith Zhao, tzimmermann,
krzysztof.kozlowski+dt, neil.armstrong, sam, dave.stevenson,
linux-kernel, dri-devel, Jack Zhu, robh+dt, thierry.reding,
mripard, daniel, quic_jesszhan, airlied, Changhuang Liang,
wahrenst
Hi, Conor
Thanks for comment.
> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: 2024年1月10日 0:32
> To: Shengyang Chen <shengyang.chen@starfivetech.com>
> Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> neil.armstrong@linaro.org; quic_jesszhan@quicinc.com; sam@ravnborg.org;
> airlied@gmail.com; daniel@ffwll.ch; maarten.lankhorst@linux.intel.com;
> mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> compatible property for waveshare 7inch touchscreen panel
>
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > panel It can be drived by Raspberry Pi panel's process but it needs
> > different timing from Raspberry Pi panel. Add compatible property for it.
> >
> > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> > ---
> > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index 11422af3477e..02f6b1b2ddc9 100644
> > ---
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam
> > +++ l
> > @@ -335,6 +335,8 @@ properties:
> > - vivax,tpc9150-panel
> > # VXT 800x480 color TFT LCD panel
> > - vxt,vl050-8048nt-c01
> > + # Waveshare 7" (800x480) touchscreen LCD panel
> > + - waveshare,7inch-touchscreen
>
> Is "7inch-touchscreen" really a specific enough identifier for this device?
>
Referring to official website[1] and Neil's suggestion, maybe I should change to
"7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed.
[1]: https://www.waveshare.com/7inch-dsi-lcd.htm
> > # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> > - winstar,wf35ltiacd
> > # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> > --
> > 2.17.1
> >
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
2024-01-10 9:05 ` neil.armstrong
@ 2024-01-16 9:41 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:41 UTC (permalink / raw)
To: neil.armstrong, Conor Dooley
Cc: devicetree, conor+dt, Keith Zhao, tzimmermann,
krzysztof.kozlowski+dt, dave.stevenson, sam, linux-kernel,
dri-devel, Jack Zhu, robh+dt, thierry.reding, mripard, daniel,
quic_jesszhan, airlied, Changhuang Liang, wahrenst
> -----Original Message-----
> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> Sent: 2024年1月10日 17:06
> To: Conor Dooley <conor@kernel.org>; Shengyang Chen
> <shengyang.chen@starfivetech.com>
> Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> compatible property for waveshare 7inch touchscreen panel
>
> On 09/01/2024 17:32, Conor Dooley wrote:
> > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> >> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> >> panel It can be drived by Raspberry Pi panel's process but it needs
> >> different timing from Raspberry Pi panel. Add compatible property for it.
> >>
> >> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> >> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> >> ---
> >> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> index 11422af3477e..02f6b1b2ddc9 100644
> >> ---
> >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.ya
> >> +++ ml
> >> @@ -335,6 +335,8 @@ properties:
> >> - vivax,tpc9150-panel
> >> # VXT 800x480 color TFT LCD panel
> >> - vxt,vl050-8048nt-c01
> >> + # Waveshare 7" (800x480) touchscreen LCD panel
> >> + - waveshare,7inch-touchscreen
> >
> > Is "7inch-touchscreen" really a specific enough identifier for this
> > device?
>
> Waveshare has very precise SKUs, this should be something like
> waveshare,7inch-dsi-sku19885 perhaps
>
> Neil
thanks for mention, It will be checked if next version is needed.
>
> >
> >> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD
> panel
> >> - winstar,wf35ltiacd
> >> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> >> --
> >> 2.17.1
> >>
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
@ 2024-01-16 9:41 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:41 UTC (permalink / raw)
To: neil.armstrong, Conor Dooley
Cc: devicetree, dri-devel, quic_jesszhan, sam, airlied, daniel,
maarten.lankhorst, mripard, tzimmermann, robh+dt,
krzysztof.kozlowski+dt, conor+dt, wahrenst, dave.stevenson,
thierry.reding, Changhuang Liang, Keith Zhao, Jack Zhu,
linux-kernel
> -----Original Message-----
> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> Sent: 2024年1月10日 17:06
> To: Conor Dooley <conor@kernel.org>; Shengyang Chen
> <shengyang.chen@starfivetech.com>
> Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> compatible property for waveshare 7inch touchscreen panel
>
> On 09/01/2024 17:32, Conor Dooley wrote:
> > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> >> The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> >> panel It can be drived by Raspberry Pi panel's process but it needs
> >> different timing from Raspberry Pi panel. Add compatible property for it.
> >>
> >> Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> >> Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> >> ---
> >> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> index 11422af3477e..02f6b1b2ddc9 100644
> >> ---
> >> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.ya
> >> +++ ml
> >> @@ -335,6 +335,8 @@ properties:
> >> - vivax,tpc9150-panel
> >> # VXT 800x480 color TFT LCD panel
> >> - vxt,vl050-8048nt-c01
> >> + # Waveshare 7" (800x480) touchscreen LCD panel
> >> + - waveshare,7inch-touchscreen
> >
> > Is "7inch-touchscreen" really a specific enough identifier for this
> > device?
>
> Waveshare has very precise SKUs, this should be something like
> waveshare,7inch-dsi-sku19885 perhaps
>
> Neil
thanks for mention, It will be checked if next version is needed.
>
> >
> >> # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD
> panel
> >> - winstar,wf35ltiacd
> >> # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> >> --
> >> 2.17.1
> >>
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-09 17:21 ` Stefan Wahren
@ 2024-01-16 9:44 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:44 UTC (permalink / raw)
To: Stefan Wahren, neil.armstrong, devicetree, dri-devel
Cc: quic_jesszhan, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt,
dave.stevenson, thierry.reding, Changhuang Liang, Keith Zhao,
Jack Zhu, linux-kernel
Hi, Stefan
Thanks for your comment and suggestion.
> -----Original Message-----
> From: Stefan Wahren <wahrenst@gmx.net>
> Sent: 2024年1月10日 1:22
> To: neil.armstrong@linaro.org; Shengyang Chen
> <shengyang.chen@starfivetech.com>; devicetree@vger.kernel.org;
> dri-devel@lists.freedesktop.org
> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> Hi Neil,
>
> Am 09.01.24 um 12:19 schrieb neil.armstrong@linaro.org:
> > Hi,
> >
> > On 09/01/2024 08:09, Shengyang Chen wrote:
> >> This patchset adds waveshare 7inch touchscreen panel support for the
> >> StarFive JH7110 SoC.
> >
> > Could you precise which SKU you're referring to ? is it 19885 =>
> > https://www.waveshare.com/7inch-dsi-lcd.htm ?
> >
> > Are you sure it requires different timings from the RPi one ? In the
> > Waveshare wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to
> > drive it:
> > https://www.waveshare.com/wiki/7inch_DSI_LCD
> i don't have an anser for your question, but the Raspberry Pi vendor tree use
> different timings than the Mainline kernel:
>
> https://github.com/raspberrypi/linux/commit/222b9baa97cc4c880d040a8c6a5
> da80d6a42c8e8
>
> Additionally the
> arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso suggests that
> it uses the Raspberry Pi 7inch, but uses the timings of
> powertip,ph800480t013-idf02 from panel-simple.
>
> Maybe Shengyang could test these timings with the Waveshare touch. At the
> end this rely on a proper implementation on the underlying drivers.
>
> Sorry, for adding more confusion.
>
Thanks for suggestion.
We will try other timing from panel-simple.
Maybe we are not going to commit new panel timing patch
if we find useful timing from panel-simple to drive the panel.
> Regards
> >
> > Neil
> >
> >>
> >>
> >> changes since v1:
> >> - Rebased on tag v6.7.
> >>
> >> patch 1:
> >> - Gave up original changing.
> >> - Changed the commit message.
> >> - Add compatible in panel-simple.yaml
> >>
> >> patch 2:
> >> - Gave up original changing.
> >> - Changed the commit message.
> >> - Add new mode for the panel in panel-simple.c
> >>
> >> v1:
> >> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.4
> >> 4271-1-shengyang.chen@starfivetech.com/
> >>
> >> Shengyang Chen (2):
> >> dt-bindings: display: panel: panel-simple: Add compatible property
> >> for
> >> waveshare 7inch touchscreen panel
> >> gpu: drm: panel: panel-simple: add new display mode for waveshare
> >> 7inch touchscreen panel
> >>
> >> .../bindings/display/panel/panel-simple.yaml | 2 ++
> >> drivers/gpu/drm/panel/panel-simple.c | 28
> >> +++++++++++++++++++
> >> 2 files changed, 30 insertions(+)
> >>
> >
thanks
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-16 9:44 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:44 UTC (permalink / raw)
To: Stefan Wahren, neil.armstrong, devicetree, dri-devel
Cc: conor+dt, Keith Zhao, tzimmermann, krzysztof.kozlowski+dt,
dave.stevenson, sam, linux-kernel, mripard, Jack Zhu, robh+dt,
thierry.reding, daniel, quic_jesszhan, airlied, Changhuang Liang
Hi, Stefan
Thanks for your comment and suggestion.
> -----Original Message-----
> From: Stefan Wahren <wahrenst@gmx.net>
> Sent: 2024年1月10日 1:22
> To: neil.armstrong@linaro.org; Shengyang Chen
> <shengyang.chen@starfivetech.com>; devicetree@vger.kernel.org;
> dri-devel@lists.freedesktop.org
> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> Hi Neil,
>
> Am 09.01.24 um 12:19 schrieb neil.armstrong@linaro.org:
> > Hi,
> >
> > On 09/01/2024 08:09, Shengyang Chen wrote:
> >> This patchset adds waveshare 7inch touchscreen panel support for the
> >> StarFive JH7110 SoC.
> >
> > Could you precise which SKU you're referring to ? is it 19885 =>
> > https://www.waveshare.com/7inch-dsi-lcd.htm ?
> >
> > Are you sure it requires different timings from the RPi one ? In the
> > Waveshare wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to
> > drive it:
> > https://www.waveshare.com/wiki/7inch_DSI_LCD
> i don't have an anser for your question, but the Raspberry Pi vendor tree use
> different timings than the Mainline kernel:
>
> https://github.com/raspberrypi/linux/commit/222b9baa97cc4c880d040a8c6a5
> da80d6a42c8e8
>
> Additionally the
> arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso suggests that
> it uses the Raspberry Pi 7inch, but uses the timings of
> powertip,ph800480t013-idf02 from panel-simple.
>
> Maybe Shengyang could test these timings with the Waveshare touch. At the
> end this rely on a proper implementation on the underlying drivers.
>
> Sorry, for adding more confusion.
>
Thanks for suggestion.
We will try other timing from panel-simple.
Maybe we are not going to commit new panel timing patch
if we find useful timing from panel-simple to drive the panel.
> Regards
> >
> > Neil
> >
> >>
> >>
> >> changes since v1:
> >> - Rebased on tag v6.7.
> >>
> >> patch 1:
> >> - Gave up original changing.
> >> - Changed the commit message.
> >> - Add compatible in panel-simple.yaml
> >>
> >> patch 2:
> >> - Gave up original changing.
> >> - Changed the commit message.
> >> - Add new mode for the panel in panel-simple.c
> >>
> >> v1:
> >> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.4
> >> 4271-1-shengyang.chen@starfivetech.com/
> >>
> >> Shengyang Chen (2):
> >> dt-bindings: display: panel: panel-simple: Add compatible property
> >> for
> >> waveshare 7inch touchscreen panel
> >> gpu: drm: panel: panel-simple: add new display mode for waveshare
> >> 7inch touchscreen panel
> >>
> >> .../bindings/display/panel/panel-simple.yaml | 2 ++
> >> drivers/gpu/drm/panel/panel-simple.c | 28
> >> +++++++++++++++++++
> >> 2 files changed, 30 insertions(+)
> >>
> >
thanks
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-09 17:28 ` Dave Stevenson
@ 2024-01-16 9:54 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:54 UTC (permalink / raw)
To: Dave Stevenson, neil.armstrong
Cc: devicetree, conor+dt, Keith Zhao, tzimmermann,
krzysztof.kozlowski+dt, sam, linux-kernel, dri-devel, Jack Zhu,
robh+dt, thierry.reding, mripard, daniel, quic_jesszhan, airlied,
Changhuang Liang, wahrenst
Hi, Dave
Thanks for your comment
> -----Original Message-----
> From: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Sent: 2024年1月10日 1:29
> To: neil.armstrong@linaro.org
> Cc: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> thierry.reding@gmail.com; Changhuang Liang
> <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> Hi
>
> On Tue, 9 Jan 2024 at 11:19, <neil.armstrong@linaro.org> wrote:
> >
> > Hi,
> >
> > On 09/01/2024 08:09, Shengyang Chen wrote:
> > > This patchset adds waveshare 7inch touchscreen panel support for the
> > > StarFive JH7110 SoC.
> >
> > Could you precise which SKU you're referring to ? is it 19885 =>
> https://www.waveshare.com/7inch-dsi-lcd.htm ?
> >
> > Are you sure it requires different timings from the RPi one ? In the
> > Waveshare wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to
> > drive it: https://www.waveshare.com/wiki/7inch_DSI_LCD
>
> I raise the same question.
>
> Keith Zhao earlier submitted effectively the same set of patches [1] and the
> response for the updated timing was:
> <quote>
> My platform dphy tx hardware has certain limitations.
> Only supports integer multiples of 10M bitrate:
> such as 160M ,170M, 180M,190M,...1G(max)
>
> as common dphy bitrate = pixclock*bpp/lanes.
> This value cannot match successfully in most cases.
>
> so in order to match bitrate , I choose a bitrate value around pixclock*bpp/lanes,
> Prevent overflow and underflow by fine-tuning the timing parameters:-( that
> will make the new timming value.
> </quote>
>
> I then suggested mode_fixup should be used in the DSI host driver, and Keith
> acknowledged that.
>
> Is this new timing still because of the DSI host requirement?
>
Actually, the mode fixup method is referred and used in DSI's new patch
https://patchwork.kernel.org/project/dri-devel/patch/20240109072516.24328-3-shengyang.chen@starfivetech.com/
you can check it in cdns_dsi_jh7110_update()
This code is being reviewed and may need to be optimized later.
And the timing in this panel patch is tested and verified but we did not try other timing. Sorry about that.
As Stefan suggested, we should try other timing from panel-simple for example "powertip,ph800480t013-idf02".
If the other timing from panel-simple can be used, maybe it is not necessary for us to submit panel timing patch.
> Dave
>
> [1]
> https://lists.freedesktop.org/archives/dri-devel/2023-December/434150.html
>
> > Neil
> >
> > >
> > >
> > > changes since v1:
> > > - Rebased on tag v6.7.
> > >
> > > patch 1:
> > > - Gave up original changing.
> > > - Changed the commit message.
> > > - Add compatible in panel-simple.yaml
> > >
> > > patch 2:
> > > - Gave up original changing.
> > > - Changed the commit message.
> > > - Add new mode for the panel in panel-simple.c
> > >
> > > v1:
> > > https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.
> > > 44271-1-shengyang.chen@starfivetech.com/
> > >
> > > Shengyang Chen (2):
> > > dt-bindings: display: panel: panel-simple: Add compatible property for
> > > waveshare 7inch touchscreen panel
> > > gpu: drm: panel: panel-simple: add new display mode for waveshare
> > > 7inch touchscreen panel
> > >
> > > .../bindings/display/panel/panel-simple.yaml | 2 ++
> > > drivers/gpu/drm/panel/panel-simple.c | 28
> +++++++++++++++++++
> > > 2 files changed, 30 insertions(+)
> > >
> >
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-16 9:54 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:54 UTC (permalink / raw)
To: Dave Stevenson, neil.armstrong
Cc: devicetree, dri-devel, quic_jesszhan, sam, airlied, daniel,
maarten.lankhorst, mripard, tzimmermann, robh+dt,
krzysztof.kozlowski+dt, conor+dt, wahrenst, thierry.reding,
Changhuang Liang, Keith Zhao, Jack Zhu, linux-kernel
Hi, Dave
Thanks for your comment
> -----Original Message-----
> From: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Sent: 2024年1月10日 1:29
> To: neil.armstrong@linaro.org
> Cc: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> thierry.reding@gmail.com; Changhuang Liang
> <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> Hi
>
> On Tue, 9 Jan 2024 at 11:19, <neil.armstrong@linaro.org> wrote:
> >
> > Hi,
> >
> > On 09/01/2024 08:09, Shengyang Chen wrote:
> > > This patchset adds waveshare 7inch touchscreen panel support for the
> > > StarFive JH7110 SoC.
> >
> > Could you precise which SKU you're referring to ? is it 19885 =>
> https://www.waveshare.com/7inch-dsi-lcd.htm ?
> >
> > Are you sure it requires different timings from the RPi one ? In the
> > Waveshare wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to
> > drive it: https://www.waveshare.com/wiki/7inch_DSI_LCD
>
> I raise the same question.
>
> Keith Zhao earlier submitted effectively the same set of patches [1] and the
> response for the updated timing was:
> <quote>
> My platform dphy tx hardware has certain limitations.
> Only supports integer multiples of 10M bitrate:
> such as 160M ,170M, 180M,190M,...1G(max)
>
> as common dphy bitrate = pixclock*bpp/lanes.
> This value cannot match successfully in most cases.
>
> so in order to match bitrate , I choose a bitrate value around pixclock*bpp/lanes,
> Prevent overflow and underflow by fine-tuning the timing parameters:-( that
> will make the new timming value.
> </quote>
>
> I then suggested mode_fixup should be used in the DSI host driver, and Keith
> acknowledged that.
>
> Is this new timing still because of the DSI host requirement?
>
Actually, the mode fixup method is referred and used in DSI's new patch
https://patchwork.kernel.org/project/dri-devel/patch/20240109072516.24328-3-shengyang.chen@starfivetech.com/
you can check it in cdns_dsi_jh7110_update()
This code is being reviewed and may need to be optimized later.
And the timing in this panel patch is tested and verified but we did not try other timing. Sorry about that.
As Stefan suggested, we should try other timing from panel-simple for example "powertip,ph800480t013-idf02".
If the other timing from panel-simple can be used, maybe it is not necessary for us to submit panel timing patch.
> Dave
>
> [1]
> https://lists.freedesktop.org/archives/dri-devel/2023-December/434150.html
>
> > Neil
> >
> > >
> > >
> > > changes since v1:
> > > - Rebased on tag v6.7.
> > >
> > > patch 1:
> > > - Gave up original changing.
> > > - Changed the commit message.
> > > - Add compatible in panel-simple.yaml
> > >
> > > patch 2:
> > > - Gave up original changing.
> > > - Changed the commit message.
> > > - Add new mode for the panel in panel-simple.c
> > >
> > > v1:
> > > https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.
> > > 44271-1-shengyang.chen@starfivetech.com/
> > >
> > > Shengyang Chen (2):
> > > dt-bindings: display: panel: panel-simple: Add compatible property for
> > > waveshare 7inch touchscreen panel
> > > gpu: drm: panel: panel-simple: add new display mode for waveshare
> > > 7inch touchscreen panel
> > >
> > > .../bindings/display/panel/panel-simple.yaml | 2 ++
> > > drivers/gpu/drm/panel/panel-simple.c | 28
> +++++++++++++++++++
> > > 2 files changed, 30 insertions(+)
> > >
> >
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel
2024-01-09 18:26 ` Jessica Zhang
@ 2024-01-16 9:58 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:58 UTC (permalink / raw)
To: Jessica Zhang, devicetree, dri-devel
Cc: neil.armstrong, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, Changhuang Liang, Keith Zhao,
Jack Zhu, linux-kernel
Hi, Jessica
Thanks for your comment and review
> -----Original Message-----
> From: Jessica Zhang <quic_jesszhan@quicinc.com>
> Sent: 2024年1月10日 2:26
> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: neil.armstrong@linaro.org; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display
> mode for waveshare 7inch touchscreen panel
>
>
>
> On 1/8/2024 11:09 PM, Shengyang Chen wrote:
> > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > panel It also uses a Toshiba TC358762 DSI to DPI bridge chip but it
> > needs different timing from Raspberry Pi panel. Add new timing for it.
>
> Hi Shengyang,
>
> The patch itself LGTM, but in case you have to put out a new revision, can you
> please use the "drm/panel: <driver name>:" prefix format that other drm/panel
> commits use?
>
Thanks for your suggestion. The prefix format will be used if we have next version.
btw, referring to the suggestions, we are going to try other timing from panel-simple
in our platform. Maybe we are not necessary to submit new version.
Thanks a lot
> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>
> Thanks,
>
> Jessica Zhang
>
> >
> > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 28
> ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index 9367a4572dcf..e0896873ea33 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -4110,6 +4110,31 @@ static const struct panel_desc vl050_8048nt_c01
> = {
> > .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> > };
> >
> > +static const struct drm_display_mode waveshare_7inch_mode = {
> > + .clock = 29700000 / 1000,
> > + .hdisplay = 800,
> > + .hsync_start = 800 + 90,
> > + .hsync_end = 800 + 90 + 5,
> > + .htotal = 800 + 90 + 5 + 5,
> > + .vdisplay = 480,
> > + .vsync_start = 480 + 60,
> > + .vsync_end = 480 + 60 + 5,
> > + .vtotal = 480 + 60 + 5 + 5,
> > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, };
> > +
> > +static const struct panel_desc waveshare_7inch = {
> > + .modes = &waveshare_7inch_mode,
> > + .num_modes = 1,
> > + .bpc = 8,
> > + .size = {
> > + .width = 154,
> > + .height = 86,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > + .connector_type = DRM_MODE_CONNECTOR_DSI, };
> > +
> > static const struct drm_display_mode winstar_wf35ltiacd_mode = {
> > .clock = 6410,
> > .hdisplay = 320,
> > @@ -4592,6 +4617,9 @@ static const struct of_device_id
> platform_of_match[] = {
> > }, {
> > .compatible = "vxt,vl050-8048nt-c01",
> > .data = &vl050_8048nt_c01,
> > + }, {
> > + .compatible = "waveshare,7inch-touchscreen",
> > + .data = &waveshare_7inch,
> > }, {
> > .compatible = "winstar,wf35ltiacd",
> > .data = &winstar_wf35ltiacd,
> > --
> > 2.17.1
> >
thanks
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode for waveshare 7inch touchscreen panel
@ 2024-01-16 9:58 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 9:58 UTC (permalink / raw)
To: Jessica Zhang, devicetree, dri-devel
Cc: neil.armstrong, conor+dt, Keith Zhao, tzimmermann,
krzysztof.kozlowski+dt, dave.stevenson, sam, linux-kernel,
mripard, Jack Zhu, robh+dt, thierry.reding, wahrenst, daniel,
airlied, Changhuang Liang
Hi, Jessica
Thanks for your comment and review
> -----Original Message-----
> From: Jessica Zhang <quic_jesszhan@quicinc.com>
> Sent: 2024年1月10日 2:26
> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: neil.armstrong@linaro.org; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display
> mode for waveshare 7inch touchscreen panel
>
>
>
> On 1/8/2024 11:09 PM, Shengyang Chen wrote:
> > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > panel It also uses a Toshiba TC358762 DSI to DPI bridge chip but it
> > needs different timing from Raspberry Pi panel. Add new timing for it.
>
> Hi Shengyang,
>
> The patch itself LGTM, but in case you have to put out a new revision, can you
> please use the "drm/panel: <driver name>:" prefix format that other drm/panel
> commits use?
>
Thanks for your suggestion. The prefix format will be used if we have next version.
btw, referring to the suggestions, we are going to try other timing from panel-simple
in our platform. Maybe we are not necessary to submit new version.
Thanks a lot
> Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
>
> Thanks,
>
> Jessica Zhang
>
> >
> > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 28
> ++++++++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index 9367a4572dcf..e0896873ea33 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -4110,6 +4110,31 @@ static const struct panel_desc vl050_8048nt_c01
> = {
> > .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
> > };
> >
> > +static const struct drm_display_mode waveshare_7inch_mode = {
> > + .clock = 29700000 / 1000,
> > + .hdisplay = 800,
> > + .hsync_start = 800 + 90,
> > + .hsync_end = 800 + 90 + 5,
> > + .htotal = 800 + 90 + 5 + 5,
> > + .vdisplay = 480,
> > + .vsync_start = 480 + 60,
> > + .vsync_end = 480 + 60 + 5,
> > + .vtotal = 480 + 60 + 5 + 5,
> > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, };
> > +
> > +static const struct panel_desc waveshare_7inch = {
> > + .modes = &waveshare_7inch_mode,
> > + .num_modes = 1,
> > + .bpc = 8,
> > + .size = {
> > + .width = 154,
> > + .height = 86,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > + .connector_type = DRM_MODE_CONNECTOR_DSI, };
> > +
> > static const struct drm_display_mode winstar_wf35ltiacd_mode = {
> > .clock = 6410,
> > .hdisplay = 320,
> > @@ -4592,6 +4617,9 @@ static const struct of_device_id
> platform_of_match[] = {
> > }, {
> > .compatible = "vxt,vl050-8048nt-c01",
> > .data = &vl050_8048nt_c01,
> > + }, {
> > + .compatible = "waveshare,7inch-touchscreen",
> > + .data = &waveshare_7inch,
> > }, {
> > .compatible = "winstar,wf35ltiacd",
> > .data = &winstar_wf35ltiacd,
> > --
> > 2.17.1
> >
thanks
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
2024-01-16 9:34 ` neil.armstrong
@ 2024-01-16 10:02 ` Shengyang Chen
-1 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 10:02 UTC (permalink / raw)
To: neil.armstrong, devicetree, dri-devel
Cc: quic_jesszhan, sam, airlied, daniel, maarten.lankhorst, mripard,
tzimmermann, robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, Changhuang Liang, Keith Zhao,
Jack Zhu, linux-kernel
Hi, Neil
> -----Original Message-----
> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> Sent: 2024年1月16日 17:34
> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> On 16/01/2024 10:32, Shengyang Chen wrote:
> > Hi, Neil
> >
> > Thanks for your comment.
> >
> >> -----Original Message-----
> >> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> >> Sent: 2024年1月9日 19:19
> >> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> >> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> >> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> >> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com;
> >> mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> >> wahrenst@gmx.net; dave.stevenson@raspberrypi.com;
> >> thierry.reding@gmail.com; Changhuang Liang
> >> <changhuang.liang@starfivetech.com>; Keith Zhao
> >> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> >> linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel
> >> support
> >>
> >> Hi,
> >>
> >> On 09/01/2024 08:09, Shengyang Chen wrote:
> >>> This patchset adds waveshare 7inch touchscreen panel support for the
> >>> StarFive JH7110 SoC.
> >>
> >> Could you precise which SKU you're referring to ? is it 19885 =>
> >> https://www.waveshare.com/7inch-dsi-lcd.htm ?
> >>
> >
> > yes, it is
> > sorry for confusing you.
> >
> >> Are you sure it requires different timings from the RPi one ? In the
> >> Waveshare wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
> >> https://www.waveshare.com/wiki/7inch_DSI_LCD
> >>
> >
> > Referring to Keith's answer
> > https://lists.freedesktop.org/archives/dri-devel/2023-December/434200.
> > html the panel timing value is generated to fit phy's bitrate and
> > prevent overflow and underflow.
> >
> > Referring to the suggestion, we may try other timing from panel-simple to
> drive the panel.
>
> Please implement a mode_fixup in your DSI host driver instead.
>
The mode fixup method is already used. As reference:
https://patchwork.kernel.org/project/dri-devel/patch/20240109072516.24328-3-shengyang.chen@starfivetech.com/
you can check it in cdns_dsi_jh7110_update().
This code is being reviewed and may need to be optimized later.
> Neil
>
> >
> >> Neil
> >>
> >>>
> >>>
> >>> changes since v1:
> >>> - Rebased on tag v6.7.
> >>>
> >>> patch 1:
> >>> - Gave up original changing.
> >>> - Changed the commit message.
> >>> - Add compatible in panel-simple.yaml
> >>>
> >>> patch 2:
> >>> - Gave up original changing.
> >>> - Changed the commit message.
> >>> - Add new mode for the panel in panel-simple.c
> >>>
> >>> v1:
> >>> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.
> >>> 44 271-1-shengyang.chen@starfivetech.com/
> >>>
> >>> Shengyang Chen (2):
> >>> dt-bindings: display: panel: panel-simple: Add compatible property for
> >>> waveshare 7inch touchscreen panel
> >>> gpu: drm: panel: panel-simple: add new display mode for waveshare
> >>> 7inch touchscreen panel
> >>>
> >>> .../bindings/display/panel/panel-simple.yaml | 2 ++
> >>> drivers/gpu/drm/panel/panel-simple.c | 28
> >> +++++++++++++++++++
> >>> 2 files changed, 30 insertions(+)
> >>>
> >
> >
> > Best Regards,
> > Shengyang
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
@ 2024-01-16 10:02 ` Shengyang Chen
0 siblings, 0 replies; 36+ messages in thread
From: Shengyang Chen @ 2024-01-16 10:02 UTC (permalink / raw)
To: neil.armstrong, devicetree, dri-devel
Cc: conor+dt, Keith Zhao, tzimmermann, krzysztof.kozlowski+dt,
dave.stevenson, sam, linux-kernel, mripard, Jack Zhu, robh+dt,
thierry.reding, wahrenst, daniel, quic_jesszhan, airlied,
Changhuang Liang
Hi, Neil
> -----Original Message-----
> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> Sent: 2024年1月16日 17:34
> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com; mripard@kernel.org;
> tzimmermann@suse.de; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
>
> On 16/01/2024 10:32, Shengyang Chen wrote:
> > Hi, Neil
> >
> > Thanks for your comment.
> >
> >> -----Original Message-----
> >> From: neil.armstrong@linaro.org <neil.armstrong@linaro.org>
> >> Sent: 2024年1月9日 19:19
> >> To: Shengyang Chen <shengyang.chen@starfivetech.com>;
> >> devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org
> >> Cc: quic_jesszhan@quicinc.com; sam@ravnborg.org; airlied@gmail.com;
> >> daniel@ffwll.ch; maarten.lankhorst@linux.intel.com;
> >> mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> >> wahrenst@gmx.net; dave.stevenson@raspberrypi.com;
> >> thierry.reding@gmail.com; Changhuang Liang
> >> <changhuang.liang@starfivetech.com>; Keith Zhao
> >> <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> >> linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel
> >> support
> >>
> >> Hi,
> >>
> >> On 09/01/2024 08:09, Shengyang Chen wrote:
> >>> This patchset adds waveshare 7inch touchscreen panel support for the
> >>> StarFive JH7110 SoC.
> >>
> >> Could you precise which SKU you're referring to ? is it 19885 =>
> >> https://www.waveshare.com/7inch-dsi-lcd.htm ?
> >>
> >
> > yes, it is
> > sorry for confusing you.
> >
> >> Are you sure it requires different timings from the RPi one ? In the
> >> Waveshare wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to drive it:
> >> https://www.waveshare.com/wiki/7inch_DSI_LCD
> >>
> >
> > Referring to Keith's answer
> > https://lists.freedesktop.org/archives/dri-devel/2023-December/434200.
> > html the panel timing value is generated to fit phy's bitrate and
> > prevent overflow and underflow.
> >
> > Referring to the suggestion, we may try other timing from panel-simple to
> drive the panel.
>
> Please implement a mode_fixup in your DSI host driver instead.
>
The mode fixup method is already used. As reference:
https://patchwork.kernel.org/project/dri-devel/patch/20240109072516.24328-3-shengyang.chen@starfivetech.com/
you can check it in cdns_dsi_jh7110_update().
This code is being reviewed and may need to be optimized later.
> Neil
>
> >
> >> Neil
> >>
> >>>
> >>>
> >>> changes since v1:
> >>> - Rebased on tag v6.7.
> >>>
> >>> patch 1:
> >>> - Gave up original changing.
> >>> - Changed the commit message.
> >>> - Add compatible in panel-simple.yaml
> >>>
> >>> patch 2:
> >>> - Gave up original changing.
> >>> - Changed the commit message.
> >>> - Add new mode for the panel in panel-simple.c
> >>>
> >>> v1:
> >>> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.
> >>> 44 271-1-shengyang.chen@starfivetech.com/
> >>>
> >>> Shengyang Chen (2):
> >>> dt-bindings: display: panel: panel-simple: Add compatible property for
> >>> waveshare 7inch touchscreen panel
> >>> gpu: drm: panel: panel-simple: add new display mode for waveshare
> >>> 7inch touchscreen panel
> >>>
> >>> .../bindings/display/panel/panel-simple.yaml | 2 ++
> >>> drivers/gpu/drm/panel/panel-simple.c | 28
> >> +++++++++++++++++++
> >>> 2 files changed, 30 insertions(+)
> >>>
> >
> >
> > Best Regards,
> > Shengyang
Best Regards,
Shengyang
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
2024-01-16 9:40 ` Shengyang Chen
@ 2024-01-16 17:16 ` Conor Dooley
-1 siblings, 0 replies; 36+ messages in thread
From: Conor Dooley @ 2024-01-16 17:16 UTC (permalink / raw)
To: Shengyang Chen
Cc: devicetree, dri-devel, neil.armstrong, quic_jesszhan, sam,
airlied, daniel, maarten.lankhorst, mripard, tzimmermann,
robh+dt, krzysztof.kozlowski+dt, conor+dt, wahrenst,
dave.stevenson, thierry.reding, Changhuang Liang, Keith Zhao,
Jack Zhu, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2677 bytes --]
On Tue, Jan 16, 2024 at 09:40:21AM +0000, Shengyang Chen wrote:
> Hi, Conor
>
> Thanks for comment.
>
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>
> > Sent: 2024年1月10日 0:32
> > To: Shengyang Chen <shengyang.chen@starfivetech.com>
> > Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> > neil.armstrong@linaro.org; quic_jesszhan@quicinc.com; sam@ravnborg.org;
> > airlied@gmail.com; daniel@ffwll.ch; maarten.lankhorst@linux.intel.com;
> > mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org;
> > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> > dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> > Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> > <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> > compatible property for waveshare 7inch touchscreen panel
> >
> > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > > panel It can be drived by Raspberry Pi panel's process but it needs
> > > different timing from Raspberry Pi panel. Add compatible property for it.
> > >
> > > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> > > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> > > ---
> > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > index 11422af3477e..02f6b1b2ddc9 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam
> > > +++ l
> > > @@ -335,6 +335,8 @@ properties:
> > > - vivax,tpc9150-panel
> > > # VXT 800x480 color TFT LCD panel
> > > - vxt,vl050-8048nt-c01
> > > + # Waveshare 7" (800x480) touchscreen LCD panel
> > > + - waveshare,7inch-touchscreen
> >
> > Is "7inch-touchscreen" really a specific enough identifier for this device?
> >
>
> Referring to official website[1] and Neil's suggestion, maybe I should change to
> "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed.
The one with the sku certainly seems more specific, if a next version is
needed I would use that.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel
@ 2024-01-16 17:16 ` Conor Dooley
0 siblings, 0 replies; 36+ messages in thread
From: Conor Dooley @ 2024-01-16 17:16 UTC (permalink / raw)
To: Shengyang Chen
Cc: devicetree, conor+dt, Keith Zhao, tzimmermann,
krzysztof.kozlowski+dt, neil.armstrong, sam, dave.stevenson,
linux-kernel, dri-devel, Jack Zhu, robh+dt, thierry.reding,
mripard, daniel, quic_jesszhan, airlied, Changhuang Liang,
wahrenst
[-- Attachment #1: Type: text/plain, Size: 2677 bytes --]
On Tue, Jan 16, 2024 at 09:40:21AM +0000, Shengyang Chen wrote:
> Hi, Conor
>
> Thanks for comment.
>
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>
> > Sent: 2024年1月10日 0:32
> > To: Shengyang Chen <shengyang.chen@starfivetech.com>
> > Cc: devicetree@vger.kernel.org; dri-devel@lists.freedesktop.org;
> > neil.armstrong@linaro.org; quic_jesszhan@quicinc.com; sam@ravnborg.org;
> > airlied@gmail.com; daniel@ffwll.ch; maarten.lankhorst@linux.intel.com;
> > mripard@kernel.org; tzimmermann@suse.de; robh+dt@kernel.org;
> > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; wahrenst@gmx.net;
> > dave.stevenson@raspberrypi.com; thierry.reding@gmail.com; Changhuang
> > Liang <changhuang.liang@starfivetech.com>; Keith Zhao
> > <keith.zhao@starfivetech.com>; Jack Zhu <jack.zhu@starfivetech.com>;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> > compatible property for waveshare 7inch touchscreen panel
> >
> > On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > > panel It can be drived by Raspberry Pi panel's process but it needs
> > > different timing from Raspberry Pi panel. Add compatible property for it.
> > >
> > > Signed-off-by: Keith Zhao <keith.zhao@starfivetech.com>
> > > Signed-off-by: Shengyang Chen <shengyang.chen@starfivetech.com>
> > > ---
> > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > index 11422af3477e..02f6b1b2ddc9 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam
> > > +++ l
> > > @@ -335,6 +335,8 @@ properties:
> > > - vivax,tpc9150-panel
> > > # VXT 800x480 color TFT LCD panel
> > > - vxt,vl050-8048nt-c01
> > > + # Waveshare 7" (800x480) touchscreen LCD panel
> > > + - waveshare,7inch-touchscreen
> >
> > Is "7inch-touchscreen" really a specific enough identifier for this device?
> >
>
> Referring to official website[1] and Neil's suggestion, maybe I should change to
> "7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed.
The one with the sku certainly seems more specific, if a next version is
needed I would use that.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2024-01-16 17:16 UTC | newest]
Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-09 7:09 [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support Shengyang Chen
2024-01-09 7:09 ` Shengyang Chen
2024-01-09 7:09 ` [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel Shengyang Chen
2024-01-09 7:09 ` Shengyang Chen
2024-01-09 16:32 ` Conor Dooley
2024-01-09 16:32 ` Conor Dooley
2024-01-10 9:05 ` neil.armstrong
2024-01-10 9:05 ` neil.armstrong
2024-01-16 9:41 ` Shengyang Chen
2024-01-16 9:41 ` Shengyang Chen
2024-01-16 9:40 ` Shengyang Chen
2024-01-16 9:40 ` Shengyang Chen
2024-01-16 17:16 ` Conor Dooley
2024-01-16 17:16 ` Conor Dooley
2024-01-09 7:09 ` [PATCH v2 2/2] gpu: drm: panel: panel-simple: add new display mode " Shengyang Chen
2024-01-09 7:09 ` Shengyang Chen
2024-01-09 18:26 ` Jessica Zhang
2024-01-09 18:26 ` Jessica Zhang
2024-01-16 9:58 ` Shengyang Chen
2024-01-16 9:58 ` Shengyang Chen
2024-01-09 11:19 ` [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support neil.armstrong
2024-01-09 11:19 ` neil.armstrong
2024-01-09 17:21 ` Stefan Wahren
2024-01-09 17:21 ` Stefan Wahren
2024-01-16 9:44 ` Shengyang Chen
2024-01-16 9:44 ` Shengyang Chen
2024-01-09 17:28 ` Dave Stevenson
2024-01-09 17:28 ` Dave Stevenson
2024-01-16 9:54 ` Shengyang Chen
2024-01-16 9:54 ` Shengyang Chen
2024-01-16 9:32 ` Shengyang Chen
2024-01-16 9:32 ` Shengyang Chen
2024-01-16 9:34 ` neil.armstrong
2024-01-16 9:34 ` neil.armstrong
2024-01-16 10:02 ` Shengyang Chen
2024-01-16 10:02 ` Shengyang Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.