* [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory
@ 2024-01-16 6:27 André Draszik
2024-01-16 7:41 ` Michal Simek
2024-01-16 19:30 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: André Draszik @ 2024-01-16 6:27 UTC (permalink / raw)
To: linux-kernel, robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree
Cc: Michal Simek, Masahiro Yamada, André Draszik
From: André Draszik <andre.draszik@linaro.org>
Commit 5e3ef4546819 ("dt-bindings: ignore paths outside kernel for
DT_SCHEMA_FILES") anchored all searches to the bindings directory
(since bindings only exist below that), but it turns out this is not
always desired.
Just anchor to the base kernel source directory and while at it, break
the overly long line for legibility.
Reported-by: Michal Simek <michal.simek@amd.com>
Closes: https://lore.kernel.org/all/827695c3-bb33-4a86-8586-2c7323530398@amd.com/
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
Documentation/devicetree/bindings/Makefile | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index 2323fd5b7cda..129cf698fa8a 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -28,7 +28,10 @@ $(obj)/%.example.dts: $(src)/%.yaml check_dtschema_version FORCE
find_all_cmd = find $(srctree)/$(src) \( -name '*.yaml' ! \
-name 'processed-schema*' \)
-find_cmd = $(find_all_cmd) | sed 's|^$(srctree)/$(src)/||' | grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | sed 's|^|$(srctree)/$(src)/|'
+find_cmd = $(find_all_cmd) | \
+ sed 's|^$(srctree)/||' | \
+ grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | \
+ sed 's|^|$(srctree)/|'
CHK_DT_DOCS := $(shell $(find_cmd))
quiet_cmd_yamllint = LINT $(src)
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory
2024-01-16 6:27 [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory André Draszik
@ 2024-01-16 7:41 ` Michal Simek
2024-01-16 19:30 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Michal Simek @ 2024-01-16 7:41 UTC (permalink / raw)
To: André Draszik, linux-kernel, robh+dt,
krzysztof.kozlowski+dt, conor+dt, devicetree
Cc: Masahiro Yamada, André Draszik
On 1/16/24 07:27, André Draszik wrote:
> From: André Draszik <andre.draszik@linaro.org>
>
> Commit 5e3ef4546819 ("dt-bindings: ignore paths outside kernel for
> DT_SCHEMA_FILES") anchored all searches to the bindings directory
> (since bindings only exist below that), but it turns out this is not
> always desired.
>
> Just anchor to the base kernel source directory and while at it, break
> the overly long line for legibility.
>
> Reported-by: Michal Simek <michal.simek@amd.com>
> Closes: https://lore.kernel.org/all/827695c3-bb33-4a86-8586-2c7323530398@amd.com/
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> Documentation/devicetree/bindings/Makefile | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
> index 2323fd5b7cda..129cf698fa8a 100644
> --- a/Documentation/devicetree/bindings/Makefile
> +++ b/Documentation/devicetree/bindings/Makefile
> @@ -28,7 +28,10 @@ $(obj)/%.example.dts: $(src)/%.yaml check_dtschema_version FORCE
> find_all_cmd = find $(srctree)/$(src) \( -name '*.yaml' ! \
> -name 'processed-schema*' \)
>
> -find_cmd = $(find_all_cmd) | sed 's|^$(srctree)/$(src)/||' | grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | sed 's|^|$(srctree)/$(src)/|'
> +find_cmd = $(find_all_cmd) | \
> + sed 's|^$(srctree)/||' | \
> + grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | \
> + sed 's|^|$(srctree)/|'
> CHK_DT_DOCS := $(shell $(find_cmd))
>
> quiet_cmd_yamllint = LINT $(src)
Tested-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory
2024-01-16 6:27 [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory André Draszik
2024-01-16 7:41 ` Michal Simek
@ 2024-01-16 19:30 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-01-16 19:30 UTC (permalink / raw)
To: André Draszik
Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, André Draszik,
Michal Simek, Masahiro Yamada, conor+dt, linux-kernel
On Tue, 16 Jan 2024 06:27:31 +0000, André Draszik wrote:
> From: André Draszik <andre.draszik@linaro.org>
>
> Commit 5e3ef4546819 ("dt-bindings: ignore paths outside kernel for
> DT_SCHEMA_FILES") anchored all searches to the bindings directory
> (since bindings only exist below that), but it turns out this is not
> always desired.
>
> Just anchor to the base kernel source directory and while at it, break
> the overly long line for legibility.
>
> Reported-by: Michal Simek <michal.simek@amd.com>
> Closes: https://lore.kernel.org/all/827695c3-bb33-4a86-8586-2c7323530398@amd.com/
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> Documentation/devicetree/bindings/Makefile | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Added a 'Fixes' tag and applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-16 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-16 6:27 [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory André Draszik
2024-01-16 7:41 ` Michal Simek
2024-01-16 19:30 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.