* [PATCH v1 0/2] Add camera subsystem for StarFive
@ 2024-01-19 10:06 ` Changhuang Liang
0 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 10:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou
Cc: Jack Zhu, Changhuang Liang, linux-media, linux-kernel,
linux-riscv, devicetree
This series add camera subsystem node for StarFive JH7110 SoC. It based
on top of the master branch of media_stage repository.
Changhuang Liang (2):
dt-bindings: media: starfive: Match driver and yaml property names
riscv: dts: starfive: jh7110: Add camera subsystem nodes
.../bindings/media/starfive,jh7110-camss.yaml | 31 ++----
.../jh7110-starfive-visionfive-2.dtsi | 103 ++++++++++++++++++
arch/riscv/boot/dts/starfive/jh7110.dtsi | 60 ++++++++++
3 files changed, 171 insertions(+), 23 deletions(-)
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v1 0/2] Add camera subsystem for StarFive
@ 2024-01-19 10:06 ` Changhuang Liang
0 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 10:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou
Cc: Jack Zhu, Changhuang Liang, linux-media, linux-kernel,
linux-riscv, devicetree
This series add camera subsystem node for StarFive JH7110 SoC. It based
on top of the master branch of media_stage repository.
Changhuang Liang (2):
dt-bindings: media: starfive: Match driver and yaml property names
riscv: dts: starfive: jh7110: Add camera subsystem nodes
.../bindings/media/starfive,jh7110-camss.yaml | 31 ++----
.../jh7110-starfive-visionfive-2.dtsi | 103 ++++++++++++++++++
arch/riscv/boot/dts/starfive/jh7110.dtsi | 60 ++++++++++
3 files changed, 171 insertions(+), 23 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-01-19 10:06 ` Changhuang Liang
@ 2024-01-19 10:06 ` Changhuang Liang
-1 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 10:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou
Cc: Jack Zhu, Changhuang Liang, linux-media, linux-kernel,
linux-riscv, devicetree
Drop some unused properties for clocks, resets and interrupts for
StarFive JH7110 camera subsystem.
Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
Reviewed-by: Jack Zhu <jack.zhu@starfivetech.com>
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
.../bindings/media/starfive,jh7110-camss.yaml | 31 +++++--------------
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
index c66586d90fa2..2504381058b3 100644
--- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
+++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
@@ -4,14 +4,14 @@
$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Starfive SoC CAMSS ISP
+title: StarFive SoC CAMSS ISP
maintainers:
- Jack Zhu <jack.zhu@starfivetech.com>
- Changhuang Liang <changhuang.liang@starfivetech.com>
description:
- The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It
+ The StarFive CAMSS ISP is a Camera interface for StarFive JH7110 SoC. It
consists of a VIN controller (Video In Controller, a top-level control unit)
and an ISP.
@@ -28,26 +28,21 @@ properties:
- const: isp
clocks:
- maxItems: 7
+ maxItems: 3
clock-names:
items:
- - const: apb_func
- const: wrapper_clk_c
- - const: dvp_inv
- - const: axiwr
- - const: mipi_rx0_pxl
- const: ispcore_2x
- const: isp_axi
resets:
- maxItems: 6
+ maxItems: 5
reset-names:
items:
- const: wrapper_p
- const: wrapper_c
- - const: axird
- const: axiwr
- const: isp_top_n
- const: isp_top_axi
@@ -57,7 +52,7 @@ properties:
- description: JH7110 ISP Power Domain Switch Controller.
interrupts:
- maxItems: 4
+ maxItems: 3
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -125,34 +120,24 @@ examples:
reg = <0x19840000 0x10000>,
<0x19870000 0x30000>;
reg-names = "syscon", "isp";
- clocks = <&ispcrg 0>,
- <&ispcrg 13>,
- <&ispcrg 2>,
- <&ispcrg 12>,
- <&ispcrg 1>,
+ clocks = <&ispcrg 13>,
<&syscrg 51>,
<&syscrg 52>;
- clock-names = "apb_func",
- "wrapper_clk_c",
- "dvp_inv",
- "axiwr",
- "mipi_rx0_pxl",
+ clock-names = "wrapper_clk_c",
"ispcore_2x",
"isp_axi";
resets = <&ispcrg 0>,
<&ispcrg 1>,
- <&ispcrg 10>,
<&ispcrg 11>,
<&syscrg 41>,
<&syscrg 42>;
reset-names = "wrapper_p",
"wrapper_c",
- "axird",
"axiwr",
"isp_top_n",
"isp_top_axi";
power-domains = <&pwrc 5>;
- interrupts = <92>, <87>, <88>, <90>;
+ interrupts = <92>, <87>, <90>;
ports {
#address-cells = <1>;
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-01-19 10:06 ` Changhuang Liang
0 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 10:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou
Cc: Jack Zhu, Changhuang Liang, linux-media, linux-kernel,
linux-riscv, devicetree
Drop some unused properties for clocks, resets and interrupts for
StarFive JH7110 camera subsystem.
Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
Reviewed-by: Jack Zhu <jack.zhu@starfivetech.com>
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
.../bindings/media/starfive,jh7110-camss.yaml | 31 +++++--------------
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
index c66586d90fa2..2504381058b3 100644
--- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
+++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
@@ -4,14 +4,14 @@
$id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: Starfive SoC CAMSS ISP
+title: StarFive SoC CAMSS ISP
maintainers:
- Jack Zhu <jack.zhu@starfivetech.com>
- Changhuang Liang <changhuang.liang@starfivetech.com>
description:
- The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It
+ The StarFive CAMSS ISP is a Camera interface for StarFive JH7110 SoC. It
consists of a VIN controller (Video In Controller, a top-level control unit)
and an ISP.
@@ -28,26 +28,21 @@ properties:
- const: isp
clocks:
- maxItems: 7
+ maxItems: 3
clock-names:
items:
- - const: apb_func
- const: wrapper_clk_c
- - const: dvp_inv
- - const: axiwr
- - const: mipi_rx0_pxl
- const: ispcore_2x
- const: isp_axi
resets:
- maxItems: 6
+ maxItems: 5
reset-names:
items:
- const: wrapper_p
- const: wrapper_c
- - const: axird
- const: axiwr
- const: isp_top_n
- const: isp_top_axi
@@ -57,7 +52,7 @@ properties:
- description: JH7110 ISP Power Domain Switch Controller.
interrupts:
- maxItems: 4
+ maxItems: 3
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -125,34 +120,24 @@ examples:
reg = <0x19840000 0x10000>,
<0x19870000 0x30000>;
reg-names = "syscon", "isp";
- clocks = <&ispcrg 0>,
- <&ispcrg 13>,
- <&ispcrg 2>,
- <&ispcrg 12>,
- <&ispcrg 1>,
+ clocks = <&ispcrg 13>,
<&syscrg 51>,
<&syscrg 52>;
- clock-names = "apb_func",
- "wrapper_clk_c",
- "dvp_inv",
- "axiwr",
- "mipi_rx0_pxl",
+ clock-names = "wrapper_clk_c",
"ispcore_2x",
"isp_axi";
resets = <&ispcrg 0>,
<&ispcrg 1>,
- <&ispcrg 10>,
<&ispcrg 11>,
<&syscrg 41>,
<&syscrg 42>;
reset-names = "wrapper_p",
"wrapper_c",
- "axird",
"axiwr",
"isp_top_n",
"isp_top_axi";
power-domains = <&pwrc 5>;
- interrupts = <92>, <87>, <88>, <90>;
+ interrupts = <92>, <87>, <90>;
ports {
#address-cells = <1>;
--
2.25.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v1 2/2] riscv: dts: starfive: jh7110: Add camera subsystem nodes
2024-01-19 10:06 ` Changhuang Liang
@ 2024-01-19 10:06 ` Changhuang Liang
-1 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 10:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou
Cc: Jack Zhu, Changhuang Liang, linux-media, linux-kernel,
linux-riscv, devicetree
Add camera subsystem nodes for the StarFive JH7110 SoC. They contain the
imx219, dphy-rx, csi2rx, camss node.
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
.../jh7110-starfive-visionfive-2.dtsi | 103 ++++++++++++++++++
arch/riscv/boot/dts/starfive/jh7110.dtsi | 60 ++++++++++
2 files changed, 163 insertions(+)
diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
index b89e9791efa7..e0027bb379ef 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
@@ -30,6 +30,37 @@ cpus {
timebase-frequency = <4000000>;
};
+ imx219_clk: imx219-clock {
+ compatible = "fixed-clock";
+ clock-output-names = "imx219_clk";
+ clock-frequency = <24000000>;
+ #clock-cells = <0>;
+ };
+
+ imx219_vana_2v8: 2p8v {
+ compatible = "regulator-fixed";
+ regulator-name = "camera_vana";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-always-on;
+ };
+
+ imx219_vdig_1v8: 1p8v {
+ compatible = "regulator-fixed";
+ regulator-name = "camera_vdig";
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ };
+
+ imx219_vddl_1v2: 1p2v {
+ compatible = "regulator-fixed";
+ regulator-name = "camera_vddl";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0x0 0x40000000 0x1 0x0>;
@@ -125,6 +156,59 @@ &tdm_ext {
clock-frequency = <49152000>;
};
+&camss {
+ assigned-clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
+ <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>;
+ assigned-clock-rates = <49500000>, <198000000>;
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ };
+
+ port@1 {
+ reg = <1>;
+
+ camss_from_csi2rx: endpoint {
+ remote-endpoint = <&csi2rx_to_camss>;
+ };
+ };
+ };
+};
+
+&csi2rx {
+ assigned-clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>;
+ assigned-clock-rates = <297000000>;
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ csi2rx_from_imx219: endpoint {
+ remote-endpoint = <&imx219_to_csi2rx>;
+ clock-lanes = <0>;
+ data-lanes = <1 2>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ csi2rx_to_camss: endpoint {
+ remote-endpoint = <&camss_from_csi2rx>;
+ };
+ };
+ };
+};
+
&gmac0 {
phy-handle = <&phy0>;
phy-mode = "rgmii-id";
@@ -228,6 +312,25 @@ &i2c6 {
pinctrl-names = "default";
pinctrl-0 = <&i2c6_pins>;
status = "okay";
+
+ imx219: sensor@10 {
+ compatible = "sony,imx219";
+ reg = <0x10>;
+ clocks = <&imx219_clk>;
+ reset-gpios = <&sysgpio 18 GPIO_ACTIVE_HIGH>;
+ VANA-supply = <&imx219_vana_2v8>;
+ VDIG-supply = <&imx219_vdig_1v8>;
+ VDDL-supply = <&imx219_vddl_1v2>;
+
+ port {
+ imx219_to_csi2rx: endpoint {
+ remote-endpoint = <&csi2rx_from_imx219>;
+ data-lanes = <1 2>;
+ clock-noncontinuous;
+ link-frequencies = /bits/ 64 <456000000>;
+ };
+ };
+ };
};
&i2srx {
diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
index 45213cdf50dc..b4d1564c123c 100644
--- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
@@ -1104,6 +1104,32 @@ pwrc: power-controller@17030000 {
#power-domain-cells = <1>;
};
+ csi2rx: csi@19800000 {
+ compatible = "starfive,jh7110-csi2rx", "cdns,csi2rx";
+ reg = <0x0 0x19800000 0x0 0x10000>;
+ clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>,
+ <&ispcrg JH7110_ISPCLK_VIN_APB>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF0>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF1>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF2>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF3>;
+ clock-names = "sys_clk", "p_clk",
+ "pixel_if0_clk", "pixel_if1_clk",
+ "pixel_if2_clk", "pixel_if3_clk";
+ resets = <&ispcrg JH7110_ISPRST_VIN_SYS>,
+ <&ispcrg JH7110_ISPRST_VIN_APB>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF0>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF1>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF2>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF3>;
+ reset-names = "sys", "reg_bank",
+ "pixel_if0", "pixel_if1",
+ "pixel_if2", "pixel_if3";
+ phys = <&csi_phy>;
+ phy-names = "dphy";
+ status = "disabled";
+ };
+
ispcrg: clock-controller@19810000 {
compatible = "starfive,jh7110-ispcrg";
reg = <0x0 0x19810000 0x0 0x10000>;
@@ -1121,6 +1147,40 @@ ispcrg: clock-controller@19810000 {
power-domains = <&pwrc JH7110_PD_ISP>;
};
+ csi_phy: phy@19820000 {
+ compatible = "starfive,jh7110-dphy-rx";
+ reg = <0x0 0x19820000 0x0 0x10000>;
+ clocks = <&ispcrg JH7110_ISPCLK_M31DPHY_CFG_IN>,
+ <&ispcrg JH7110_ISPCLK_M31DPHY_REF_IN>,
+ <&ispcrg JH7110_ISPCLK_M31DPHY_TX_ESC_LAN0>;
+ clock-names = "cfg", "ref", "tx";
+ resets = <&ispcrg JH7110_ISPRST_M31DPHY_HW>,
+ <&ispcrg JH7110_ISPRST_M31DPHY_B09_AON>;
+ power-domains = <&aon_syscon JH7110_AON_PD_DPHY_RX>;
+ #phy-cells = <0>;
+ };
+
+ camss: isp@19840000 {
+ compatible = "starfive,jh7110-camss";
+ reg = <0x0 0x19840000 0x0 0x10000>,
+ <0x0 0x19870000 0x0 0x30000>;
+ reg-names = "syscon", "isp";
+ clocks = <&ispcrg JH7110_ISPCLK_ISPV2_TOP_WRAPPER_C>,
+ <&syscrg JH7110_SYSCLK_ISP_TOP_CORE>,
+ <&syscrg JH7110_SYSCLK_ISP_TOP_AXI>;
+ clock-names = "wrapper_clk_c", "ispcore_2x", "isp_axi";
+ resets = <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_P>,
+ <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_C>,
+ <&ispcrg JH7110_ISPRST_VIN_P_AXI_WR>,
+ <&syscrg JH7110_SYSRST_ISP_TOP>,
+ <&syscrg JH7110_SYSRST_ISP_TOP_AXI>;
+ reset-names = "wrapper_p", "wrapper_c", "axiwr",
+ "isp_top_n", "isp_top_axi";
+ power-domains = <&pwrc JH7110_PD_ISP>;
+ interrupts = <92>, <87>, <90>;
+ status = "disabled";
+ };
+
voutcrg: clock-controller@295c0000 {
compatible = "starfive,jh7110-voutcrg";
reg = <0x0 0x295c0000 0x0 0x10000>;
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v1 2/2] riscv: dts: starfive: jh7110: Add camera subsystem nodes
@ 2024-01-19 10:06 ` Changhuang Liang
0 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 10:06 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou
Cc: Jack Zhu, Changhuang Liang, linux-media, linux-kernel,
linux-riscv, devicetree
Add camera subsystem nodes for the StarFive JH7110 SoC. They contain the
imx219, dphy-rx, csi2rx, camss node.
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
.../jh7110-starfive-visionfive-2.dtsi | 103 ++++++++++++++++++
arch/riscv/boot/dts/starfive/jh7110.dtsi | 60 ++++++++++
2 files changed, 163 insertions(+)
diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
index b89e9791efa7..e0027bb379ef 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
@@ -30,6 +30,37 @@ cpus {
timebase-frequency = <4000000>;
};
+ imx219_clk: imx219-clock {
+ compatible = "fixed-clock";
+ clock-output-names = "imx219_clk";
+ clock-frequency = <24000000>;
+ #clock-cells = <0>;
+ };
+
+ imx219_vana_2v8: 2p8v {
+ compatible = "regulator-fixed";
+ regulator-name = "camera_vana";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-always-on;
+ };
+
+ imx219_vdig_1v8: 1p8v {
+ compatible = "regulator-fixed";
+ regulator-name = "camera_vdig";
+ regulator-min-microvolt = <1500000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ };
+
+ imx219_vddl_1v2: 1p2v {
+ compatible = "regulator-fixed";
+ regulator-name = "camera_vddl";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0x0 0x40000000 0x1 0x0>;
@@ -125,6 +156,59 @@ &tdm_ext {
clock-frequency = <49152000>;
};
+&camss {
+ assigned-clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
+ <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>;
+ assigned-clock-rates = <49500000>, <198000000>;
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ };
+
+ port@1 {
+ reg = <1>;
+
+ camss_from_csi2rx: endpoint {
+ remote-endpoint = <&csi2rx_to_camss>;
+ };
+ };
+ };
+};
+
+&csi2rx {
+ assigned-clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>;
+ assigned-clock-rates = <297000000>;
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ csi2rx_from_imx219: endpoint {
+ remote-endpoint = <&imx219_to_csi2rx>;
+ clock-lanes = <0>;
+ data-lanes = <1 2>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ csi2rx_to_camss: endpoint {
+ remote-endpoint = <&camss_from_csi2rx>;
+ };
+ };
+ };
+};
+
&gmac0 {
phy-handle = <&phy0>;
phy-mode = "rgmii-id";
@@ -228,6 +312,25 @@ &i2c6 {
pinctrl-names = "default";
pinctrl-0 = <&i2c6_pins>;
status = "okay";
+
+ imx219: sensor@10 {
+ compatible = "sony,imx219";
+ reg = <0x10>;
+ clocks = <&imx219_clk>;
+ reset-gpios = <&sysgpio 18 GPIO_ACTIVE_HIGH>;
+ VANA-supply = <&imx219_vana_2v8>;
+ VDIG-supply = <&imx219_vdig_1v8>;
+ VDDL-supply = <&imx219_vddl_1v2>;
+
+ port {
+ imx219_to_csi2rx: endpoint {
+ remote-endpoint = <&csi2rx_from_imx219>;
+ data-lanes = <1 2>;
+ clock-noncontinuous;
+ link-frequencies = /bits/ 64 <456000000>;
+ };
+ };
+ };
};
&i2srx {
diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
index 45213cdf50dc..b4d1564c123c 100644
--- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
@@ -1104,6 +1104,32 @@ pwrc: power-controller@17030000 {
#power-domain-cells = <1>;
};
+ csi2rx: csi@19800000 {
+ compatible = "starfive,jh7110-csi2rx", "cdns,csi2rx";
+ reg = <0x0 0x19800000 0x0 0x10000>;
+ clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>,
+ <&ispcrg JH7110_ISPCLK_VIN_APB>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF0>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF1>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF2>,
+ <&ispcrg JH7110_ISPCLK_VIN_PIXEL_IF3>;
+ clock-names = "sys_clk", "p_clk",
+ "pixel_if0_clk", "pixel_if1_clk",
+ "pixel_if2_clk", "pixel_if3_clk";
+ resets = <&ispcrg JH7110_ISPRST_VIN_SYS>,
+ <&ispcrg JH7110_ISPRST_VIN_APB>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF0>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF1>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF2>,
+ <&ispcrg JH7110_ISPRST_VIN_PIXEL_IF3>;
+ reset-names = "sys", "reg_bank",
+ "pixel_if0", "pixel_if1",
+ "pixel_if2", "pixel_if3";
+ phys = <&csi_phy>;
+ phy-names = "dphy";
+ status = "disabled";
+ };
+
ispcrg: clock-controller@19810000 {
compatible = "starfive,jh7110-ispcrg";
reg = <0x0 0x19810000 0x0 0x10000>;
@@ -1121,6 +1147,40 @@ ispcrg: clock-controller@19810000 {
power-domains = <&pwrc JH7110_PD_ISP>;
};
+ csi_phy: phy@19820000 {
+ compatible = "starfive,jh7110-dphy-rx";
+ reg = <0x0 0x19820000 0x0 0x10000>;
+ clocks = <&ispcrg JH7110_ISPCLK_M31DPHY_CFG_IN>,
+ <&ispcrg JH7110_ISPCLK_M31DPHY_REF_IN>,
+ <&ispcrg JH7110_ISPCLK_M31DPHY_TX_ESC_LAN0>;
+ clock-names = "cfg", "ref", "tx";
+ resets = <&ispcrg JH7110_ISPRST_M31DPHY_HW>,
+ <&ispcrg JH7110_ISPRST_M31DPHY_B09_AON>;
+ power-domains = <&aon_syscon JH7110_AON_PD_DPHY_RX>;
+ #phy-cells = <0>;
+ };
+
+ camss: isp@19840000 {
+ compatible = "starfive,jh7110-camss";
+ reg = <0x0 0x19840000 0x0 0x10000>,
+ <0x0 0x19870000 0x0 0x30000>;
+ reg-names = "syscon", "isp";
+ clocks = <&ispcrg JH7110_ISPCLK_ISPV2_TOP_WRAPPER_C>,
+ <&syscrg JH7110_SYSCLK_ISP_TOP_CORE>,
+ <&syscrg JH7110_SYSCLK_ISP_TOP_AXI>;
+ clock-names = "wrapper_clk_c", "ispcore_2x", "isp_axi";
+ resets = <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_P>,
+ <&ispcrg JH7110_ISPRST_ISPV2_TOP_WRAPPER_C>,
+ <&ispcrg JH7110_ISPRST_VIN_P_AXI_WR>,
+ <&syscrg JH7110_SYSRST_ISP_TOP>,
+ <&syscrg JH7110_SYSRST_ISP_TOP_AXI>;
+ reset-names = "wrapper_p", "wrapper_c", "axiwr",
+ "isp_top_n", "isp_top_axi";
+ power-domains = <&pwrc JH7110_PD_ISP>;
+ interrupts = <92>, <87>, <90>;
+ status = "disabled";
+ };
+
voutcrg: clock-controller@295c0000 {
compatible = "starfive,jh7110-voutcrg";
reg = <0x0 0x295c0000 0x0 0x10000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-01-19 10:06 ` Changhuang Liang
@ 2024-01-19 10:16 ` Conor Dooley
-1 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-01-19 10:16 UTC (permalink / raw)
To: Changhuang Liang
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
[-- Attachment #1.1: Type: text/plain, Size: 4089 bytes --]
On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> Drop some unused properties for clocks, resets and interrupts for
> StarFive JH7110 camera subsystem.
What do you mean "unused"?
Do these clocks etc exist but are not used by the driver?
Or do they not exist at all?
The two are very different!
Thanks,
Conor.
>
> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
> Reviewed-by: Jack Zhu <jack.zhu@starfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> .../bindings/media/starfive,jh7110-camss.yaml | 31 +++++--------------
> 1 file changed, 8 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> index c66586d90fa2..2504381058b3 100644
> --- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> @@ -4,14 +4,14 @@
> $id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Starfive SoC CAMSS ISP
> +title: StarFive SoC CAMSS ISP
>
> maintainers:
> - Jack Zhu <jack.zhu@starfivetech.com>
> - Changhuang Liang <changhuang.liang@starfivetech.com>
>
> description:
> - The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It
> + The StarFive CAMSS ISP is a Camera interface for StarFive JH7110 SoC. It
> consists of a VIN controller (Video In Controller, a top-level control unit)
> and an ISP.
>
> @@ -28,26 +28,21 @@ properties:
> - const: isp
>
> clocks:
> - maxItems: 7
> + maxItems: 3
>
> clock-names:
> items:
> - - const: apb_func
> - const: wrapper_clk_c
> - - const: dvp_inv
> - - const: axiwr
> - - const: mipi_rx0_pxl
> - const: ispcore_2x
> - const: isp_axi
>
> resets:
> - maxItems: 6
> + maxItems: 5
>
> reset-names:
> items:
> - const: wrapper_p
> - const: wrapper_c
> - - const: axird
> - const: axiwr
> - const: isp_top_n
> - const: isp_top_axi
> @@ -57,7 +52,7 @@ properties:
> - description: JH7110 ISP Power Domain Switch Controller.
>
> interrupts:
> - maxItems: 4
> + maxItems: 3
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> @@ -125,34 +120,24 @@ examples:
> reg = <0x19840000 0x10000>,
> <0x19870000 0x30000>;
> reg-names = "syscon", "isp";
> - clocks = <&ispcrg 0>,
> - <&ispcrg 13>,
> - <&ispcrg 2>,
> - <&ispcrg 12>,
> - <&ispcrg 1>,
> + clocks = <&ispcrg 13>,
> <&syscrg 51>,
> <&syscrg 52>;
> - clock-names = "apb_func",
> - "wrapper_clk_c",
> - "dvp_inv",
> - "axiwr",
> - "mipi_rx0_pxl",
> + clock-names = "wrapper_clk_c",
> "ispcore_2x",
> "isp_axi";
> resets = <&ispcrg 0>,
> <&ispcrg 1>,
> - <&ispcrg 10>,
> <&ispcrg 11>,
> <&syscrg 41>,
> <&syscrg 42>;
> reset-names = "wrapper_p",
> "wrapper_c",
> - "axird",
> "axiwr",
> "isp_top_n",
> "isp_top_axi";
> power-domains = <&pwrc 5>;
> - interrupts = <92>, <87>, <88>, <90>;
> + interrupts = <92>, <87>, <90>;
>
> ports {
> #address-cells = <1>;
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-01-19 10:16 ` Conor Dooley
0 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-01-19 10:16 UTC (permalink / raw)
To: Changhuang Liang
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
[-- Attachment #1: Type: text/plain, Size: 4089 bytes --]
On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> Drop some unused properties for clocks, resets and interrupts for
> StarFive JH7110 camera subsystem.
What do you mean "unused"?
Do these clocks etc exist but are not used by the driver?
Or do they not exist at all?
The two are very different!
Thanks,
Conor.
>
> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
> Reviewed-by: Jack Zhu <jack.zhu@starfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> .../bindings/media/starfive,jh7110-camss.yaml | 31 +++++--------------
> 1 file changed, 8 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> index c66586d90fa2..2504381058b3 100644
> --- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> @@ -4,14 +4,14 @@
> $id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Starfive SoC CAMSS ISP
> +title: StarFive SoC CAMSS ISP
>
> maintainers:
> - Jack Zhu <jack.zhu@starfivetech.com>
> - Changhuang Liang <changhuang.liang@starfivetech.com>
>
> description:
> - The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It
> + The StarFive CAMSS ISP is a Camera interface for StarFive JH7110 SoC. It
> consists of a VIN controller (Video In Controller, a top-level control unit)
> and an ISP.
>
> @@ -28,26 +28,21 @@ properties:
> - const: isp
>
> clocks:
> - maxItems: 7
> + maxItems: 3
>
> clock-names:
> items:
> - - const: apb_func
> - const: wrapper_clk_c
> - - const: dvp_inv
> - - const: axiwr
> - - const: mipi_rx0_pxl
> - const: ispcore_2x
> - const: isp_axi
>
> resets:
> - maxItems: 6
> + maxItems: 5
>
> reset-names:
> items:
> - const: wrapper_p
> - const: wrapper_c
> - - const: axird
> - const: axiwr
> - const: isp_top_n
> - const: isp_top_axi
> @@ -57,7 +52,7 @@ properties:
> - description: JH7110 ISP Power Domain Switch Controller.
>
> interrupts:
> - maxItems: 4
> + maxItems: 3
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> @@ -125,34 +120,24 @@ examples:
> reg = <0x19840000 0x10000>,
> <0x19870000 0x30000>;
> reg-names = "syscon", "isp";
> - clocks = <&ispcrg 0>,
> - <&ispcrg 13>,
> - <&ispcrg 2>,
> - <&ispcrg 12>,
> - <&ispcrg 1>,
> + clocks = <&ispcrg 13>,
> <&syscrg 51>,
> <&syscrg 52>;
> - clock-names = "apb_func",
> - "wrapper_clk_c",
> - "dvp_inv",
> - "axiwr",
> - "mipi_rx0_pxl",
> + clock-names = "wrapper_clk_c",
> "ispcore_2x",
> "isp_axi";
> resets = <&ispcrg 0>,
> <&ispcrg 1>,
> - <&ispcrg 10>,
> <&ispcrg 11>,
> <&syscrg 41>,
> <&syscrg 42>;
> reset-names = "wrapper_p",
> "wrapper_c",
> - "axird",
> "axiwr",
> "isp_top_n",
> "isp_top_axi";
> power-domains = <&pwrc 5>;
> - interrupts = <92>, <87>, <88>, <90>;
> + interrupts = <92>, <87>, <90>;
>
> ports {
> #address-cells = <1>;
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-01-19 10:16 ` Conor Dooley
@ 2024-01-19 12:57 ` Changhuang Liang
-1 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 12:57 UTC (permalink / raw)
To: Conor Dooley
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
Hi , Conor
> 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml
> property names
>
> On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > Drop some unused properties for clocks, resets and interrupts for
> > StarFive JH7110 camera subsystem.
>
> What do you mean "unused"?
>
> Do these clocks etc exist but are not used by the driver?
>
> Or do they not exist at all?
>
> The two are very different!
>
> Thanks,
> Conor.
>
These clocks etc exist but are not used by the driver.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-01-19 12:57 ` Changhuang Liang
0 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-19 12:57 UTC (permalink / raw)
To: Conor Dooley
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
Hi , Conor
> 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml
> property names
>
> On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > Drop some unused properties for clocks, resets and interrupts for
> > StarFive JH7110 camera subsystem.
>
> What do you mean "unused"?
>
> Do these clocks etc exist but are not used by the driver?
>
> Or do they not exist at all?
>
> The two are very different!
>
> Thanks,
> Conor.
>
These clocks etc exist but are not used by the driver.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-01-19 12:57 ` Changhuang Liang
@ 2024-01-19 13:58 ` Conor Dooley
-1 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-01-19 13:58 UTC (permalink / raw)
To: Changhuang Liang
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi , Conor
>
> > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml
> > property names
> >
> > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > Drop some unused properties for clocks, resets and interrupts for
> > > StarFive JH7110 camera subsystem.
> >
> > What do you mean "unused"?
> >
> > Do these clocks etc exist but are not used by the driver?
> >
> > Or do they not exist at all?
> >
> > The two are very different!
> These clocks etc exist but are not used by the driver.
That's not an acceptable reason for removing them from the binding. If
they exist, they should be documented, regardless of whether the driver
makes use of them. NAK.
Also, your mail didn't end up on LKML, so there's something wrong with
your setup.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-01-19 13:58 ` Conor Dooley
0 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-01-19 13:58 UTC (permalink / raw)
To: Changhuang Liang
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
[-- Attachment #1.1: Type: text/plain, Size: 997 bytes --]
On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi , Conor
>
> > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml
> > property names
> >
> > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > Drop some unused properties for clocks, resets and interrupts for
> > > StarFive JH7110 camera subsystem.
> >
> > What do you mean "unused"?
> >
> > Do these clocks etc exist but are not used by the driver?
> >
> > Or do they not exist at all?
> >
> > The two are very different!
> These clocks etc exist but are not used by the driver.
That's not an acceptable reason for removing them from the binding. If
they exist, they should be documented, regardless of whether the driver
makes use of them. NAK.
Also, your mail didn't end up on LKML, so there's something wrong with
your setup.
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-01-19 13:58 ` Conor Dooley
@ 2024-01-22 1:33 ` Changhuang Liang
-1 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-22 1:33 UTC (permalink / raw)
To: Conor Dooley
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
> On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > the content is safe
> >
> > Hi , Conor
> >
> > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver
> > > and yaml property names
> > >
> > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > > Drop some unused properties for clocks, resets and interrupts for
> > > > StarFive JH7110 camera subsystem.
> > >
> > > What do you mean "unused"?
> > >
> > > Do these clocks etc exist but are not used by the driver?
> > >
> > > Or do they not exist at all?
> > >
> > > The two are very different!
>
> > These clocks etc exist but are not used by the driver.
>
> That's not an acceptable reason for removing them from the binding. If they
> exist, they should be documented, regardless of whether the driver makes use
> of them. NAK.
If so, how to avoid the warning of dtbs_check.
Thanks,
Changhuang
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-01-22 1:33 ` Changhuang Liang
0 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-01-22 1:33 UTC (permalink / raw)
To: Conor Dooley
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Emil Renner Berthing, Paul Walmsley,
Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media, linux-kernel,
linux-riscv, devicetree
> On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > the content is safe
> >
> > Hi , Conor
> >
> > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver
> > > and yaml property names
> > >
> > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > > Drop some unused properties for clocks, resets and interrupts for
> > > > StarFive JH7110 camera subsystem.
> > >
> > > What do you mean "unused"?
> > >
> > > Do these clocks etc exist but are not used by the driver?
> > >
> > > Or do they not exist at all?
> > >
> > > The two are very different!
>
> > These clocks etc exist but are not used by the driver.
>
> That's not an acceptable reason for removing them from the binding. If they
> exist, they should be documented, regardless of whether the driver makes use
> of them. NAK.
If so, how to avoid the warning of dtbs_check.
Thanks,
Changhuang
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-01-22 1:33 ` Changhuang Liang
@ 2024-01-22 8:24 ` Conor Dooley
-1 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-01-22 8:24 UTC (permalink / raw)
To: Changhuang Liang
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
On Mon, Jan 22, 2024 at 01:33:56AM +0000, Changhuang Liang wrote:
>
> > On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > the content is safe
> > >
> > > Hi , Conor
> > >
> > > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver
> > > > and yaml property names
> > > >
> > > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > > > Drop some unused properties for clocks, resets and interrupts for
> > > > > StarFive JH7110 camera subsystem.
> > > >
> > > > What do you mean "unused"?
> > > >
> > > > Do these clocks etc exist but are not used by the driver?
> > > >
> > > > Or do they not exist at all?
> > > >
> > > > The two are very different!
> >
> > > These clocks etc exist but are not used by the driver.
> >
> > That's not an acceptable reason for removing them from the binding. If they
> > exist, they should be documented, regardless of whether the driver makes use
> > of them. NAK.
>
> If so, how to avoid the warning of dtbs_check.
By also adding the clocks, resets and interrupts to the dts.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-01-22 8:24 ` Conor Dooley
0 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-01-22 8:24 UTC (permalink / raw)
To: Changhuang Liang
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
[-- Attachment #1.1: Type: text/plain, Size: 1185 bytes --]
On Mon, Jan 22, 2024 at 01:33:56AM +0000, Changhuang Liang wrote:
>
> > On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > the content is safe
> > >
> > > Hi , Conor
> > >
> > > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver
> > > > and yaml property names
> > > >
> > > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > > > Drop some unused properties for clocks, resets and interrupts for
> > > > > StarFive JH7110 camera subsystem.
> > > >
> > > > What do you mean "unused"?
> > > >
> > > > Do these clocks etc exist but are not used by the driver?
> > > >
> > > > Or do they not exist at all?
> > > >
> > > > The two are very different!
> >
> > > These clocks etc exist but are not used by the driver.
> >
> > That's not an acceptable reason for removing them from the binding. If they
> > exist, they should be documented, regardless of whether the driver makes use
> > of them. NAK.
>
> If so, how to avoid the warning of dtbs_check.
By also adding the clocks, resets and interrupts to the dts.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-01-22 8:24 ` Conor Dooley
@ 2024-03-27 18:03 ` Conor Dooley
-1 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-03-27 18:03 UTC (permalink / raw)
To: Changhuang Liang
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
[-- Attachment #1.1: Type: text/plain, Size: 1691 bytes --]
On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
> On Mon, Jan 22, 2024 at 01:33:56AM +0000, Changhuang Liang wrote:
> >
> > > On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > > the content is safe
> > > >
> > > > Hi , Conor
> > > >
> > > > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver
> > > > > and yaml property names
> > > > >
> > > > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > > > > Drop some unused properties for clocks, resets and interrupts for
> > > > > > StarFive JH7110 camera subsystem.
> > > > >
> > > > > What do you mean "unused"?
> > > > >
> > > > > Do these clocks etc exist but are not used by the driver?
> > > > >
> > > > > Or do they not exist at all?
> > > > >
> > > > > The two are very different!
> > >
> > > > These clocks etc exist but are not used by the driver.
> > >
> > > That's not an acceptable reason for removing them from the binding. If they
> > > exist, they should be documented, regardless of whether the driver makes use
> > > of them. NAK.
> >
> > If so, how to avoid the warning of dtbs_check.
>
> By also adding the clocks, resets and interrupts to the dts.
Going through patchwork stuff now that the merge window is done. I'm
gonna mark the dts patch as changes requeted. The binding (and dts)
should describe all of the clocks the hardware has, whether or not you
choose to use them all in software does not matter. Can you please
resend the dts patch, with all of the clocks, resets and interrupts
present?
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-03-27 18:03 ` Conor Dooley
0 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-03-27 18:03 UTC (permalink / raw)
To: Changhuang Liang
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]
On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
> On Mon, Jan 22, 2024 at 01:33:56AM +0000, Changhuang Liang wrote:
> >
> > > On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote:
> > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > > the content is safe
> > > >
> > > > Hi , Conor
> > > >
> > > > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver
> > > > > and yaml property names
> > > > >
> > > > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> > > > > > Drop some unused properties for clocks, resets and interrupts for
> > > > > > StarFive JH7110 camera subsystem.
> > > > >
> > > > > What do you mean "unused"?
> > > > >
> > > > > Do these clocks etc exist but are not used by the driver?
> > > > >
> > > > > Or do they not exist at all?
> > > > >
> > > > > The two are very different!
> > >
> > > > These clocks etc exist but are not used by the driver.
> > >
> > > That's not an acceptable reason for removing them from the binding. If they
> > > exist, they should be documented, regardless of whether the driver makes use
> > > of them. NAK.
> >
> > If so, how to avoid the warning of dtbs_check.
>
> By also adding the clocks, resets and interrupts to the dts.
Going through patchwork stuff now that the merge window is done. I'm
gonna mark the dts patch as changes requeted. The binding (and dts)
should describe all of the clocks the hardware has, whether or not you
choose to use them all in software does not matter. Can you please
resend the dts patch, with all of the clocks, resets and interrupts
present?
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* 回复: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-03-27 18:03 ` Conor Dooley
@ 2024-03-28 1:06 ` Changhuang Liang
-1 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-03-28 1:06 UTC (permalink / raw)
To: Conor Dooley
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
Hi, Conor,
> On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
[...]
> > > > > > Do these clocks etc exist but are not used by the driver?
> > > > > >
> > > > > > Or do they not exist at all?
> > > > > >
> > > > > > The two are very different!
> > > >
> > > > > These clocks etc exist but are not used by the driver.
> > > >
> > > > That's not an acceptable reason for removing them from the
> > > > binding. If they exist, they should be documented, regardless of
> > > > whether the driver makes use of them. NAK.
> > >
> > > If so, how to avoid the warning of dtbs_check.
> >
> > By also adding the clocks, resets and interrupts to the dts.
>
> Going through patchwork stuff now that the merge window is done. I'm gonna
> mark the dts patch as changes requeted. The binding (and dts) should
> describe all of the clocks the hardware has, whether or not you choose to use
> them all in software does not matter. Can you please resend the dts patch,
> with all of the clocks, resets and interrupts present?
>
You have applied the dts patch.
https://lore.kernel.org/all/20240219032741.18387-1-changhuang.liang@starfivetech.com/
Regards,
Changhuang
^ permalink raw reply [flat|nested] 22+ messages in thread
* 回复: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-03-28 1:06 ` Changhuang Liang
0 siblings, 0 replies; 22+ messages in thread
From: Changhuang Liang @ 2024-03-28 1:06 UTC (permalink / raw)
To: Conor Dooley
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
Hi, Conor,
> On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
[...]
> > > > > > Do these clocks etc exist but are not used by the driver?
> > > > > >
> > > > > > Or do they not exist at all?
> > > > > >
> > > > > > The two are very different!
> > > >
> > > > > These clocks etc exist but are not used by the driver.
> > > >
> > > > That's not an acceptable reason for removing them from the
> > > > binding. If they exist, they should be documented, regardless of
> > > > whether the driver makes use of them. NAK.
> > >
> > > If so, how to avoid the warning of dtbs_check.
> >
> > By also adding the clocks, resets and interrupts to the dts.
>
> Going through patchwork stuff now that the merge window is done. I'm gonna
> mark the dts patch as changes requeted. The binding (and dts) should
> describe all of the clocks the hardware has, whether or not you choose to use
> them all in software does not matter. Can you please resend the dts patch,
> with all of the clocks, resets and interrupts present?
>
You have applied the dts patch.
https://lore.kernel.org/all/20240219032741.18387-1-changhuang.liang@starfivetech.com/
Regards,
Changhuang
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
2024-03-28 1:06 ` Changhuang Liang
@ 2024-03-28 6:28 ` Conor Dooley
-1 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-03-28 6:28 UTC (permalink / raw)
To: Changhuang Liang
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
On 28 March 2024 01:06:42 GMT, Changhuang Liang <changhuang.liang@starfivetech.com> wrote:
>Hi, Conor,
>
>> On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
>[...]
>> > > > > > Do these clocks etc exist but are not used by the driver?
>> > > > > >
>> > > > > > Or do they not exist at all?
>> > > > > >
>> > > > > > The two are very different!
>> > > >
>> > > > > These clocks etc exist but are not used by the driver.
>> > > >
>> > > > That's not an acceptable reason for removing them from the
>> > > > binding. If they exist, they should be documented, regardless of
>> > > > whether the driver makes use of them. NAK.
>> > >
>> > > If so, how to avoid the warning of dtbs_check.
>> >
>> > By also adding the clocks, resets and interrupts to the dts.
>>
>> Going through patchwork stuff now that the merge window is done. I'm gonna
>> mark the dts patch as changes requeted. The binding (and dts) should
>> describe all of the clocks the hardware has, whether or not you choose to use
>> them all in software does not matter. Can you please resend the dts patch,
>> with all of the clocks, resets and interrupts present?
>>
>
>You have applied the dts patch.
>https://lore.kernel.org/all/20240219032741.18387-1-changhuang.liang@starfivetech.com/
Oh, sorry for the noise then. I guess I was
mislead by patchwork marking this as new :)
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: 回复: 回复: 回复: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names
@ 2024-03-28 6:28 ` Conor Dooley
0 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-03-28 6:28 UTC (permalink / raw)
To: Changhuang Liang
Cc: Conor Dooley, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Emil Renner Berthing,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Jack Zhu, linux-media,
linux-kernel, linux-riscv, devicetree
On 28 March 2024 01:06:42 GMT, Changhuang Liang <changhuang.liang@starfivetech.com> wrote:
>Hi, Conor,
>
>> On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote:
>[...]
>> > > > > > Do these clocks etc exist but are not used by the driver?
>> > > > > >
>> > > > > > Or do they not exist at all?
>> > > > > >
>> > > > > > The two are very different!
>> > > >
>> > > > > These clocks etc exist but are not used by the driver.
>> > > >
>> > > > That's not an acceptable reason for removing them from the
>> > > > binding. If they exist, they should be documented, regardless of
>> > > > whether the driver makes use of them. NAK.
>> > >
>> > > If so, how to avoid the warning of dtbs_check.
>> >
>> > By also adding the clocks, resets and interrupts to the dts.
>>
>> Going through patchwork stuff now that the merge window is done. I'm gonna
>> mark the dts patch as changes requeted. The binding (and dts) should
>> describe all of the clocks the hardware has, whether or not you choose to use
>> them all in software does not matter. Can you please resend the dts patch,
>> with all of the clocks, resets and interrupts present?
>>
>
>You have applied the dts patch.
>https://lore.kernel.org/all/20240219032741.18387-1-changhuang.liang@starfivetech.com/
Oh, sorry for the noise then. I guess I was
mislead by patchwork marking this as new :)
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2024-03-28 6:28 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-19 10:06 [PATCH v1 0/2] Add camera subsystem for StarFive Changhuang Liang
2024-01-19 10:06 ` Changhuang Liang
2024-01-19 10:06 ` [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names Changhuang Liang
2024-01-19 10:06 ` Changhuang Liang
2024-01-19 10:16 ` Conor Dooley
2024-01-19 10:16 ` Conor Dooley
2024-01-19 12:57 ` 回复: " Changhuang Liang
2024-01-19 12:57 ` Changhuang Liang
2024-01-19 13:58 ` Conor Dooley
2024-01-19 13:58 ` Conor Dooley
2024-01-22 1:33 ` 回复: " Changhuang Liang
2024-01-22 1:33 ` Changhuang Liang
2024-01-22 8:24 ` Conor Dooley
2024-01-22 8:24 ` Conor Dooley
2024-03-27 18:03 ` Conor Dooley
2024-03-27 18:03 ` Conor Dooley
2024-03-28 1:06 ` 回复: " Changhuang Liang
2024-03-28 1:06 ` Changhuang Liang
2024-03-28 6:28 ` Conor Dooley
2024-03-28 6:28 ` Conor Dooley
2024-01-19 10:06 ` [PATCH v1 2/2] riscv: dts: starfive: jh7110: Add camera subsystem nodes Changhuang Liang
2024-01-19 10:06 ` Changhuang Liang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.