From: Tom Rini <trini@konsulko.com>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 01/20] Convert CONFIG_SPL_STACK to Kconfig
Date: Tue, 23 Jan 2024 20:34:02 -0500 [thread overview]
Message-ID: <20240124013402.GZ3652023@bill-the-cat> (raw)
In-Reply-To: <028260b9-255d-4630-b793-1f065ffb1e7f@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 2036 bytes --]
On Wed, Jan 24, 2024 at 09:15:07AM +0800, Kever Yang wrote:
> Hi Tom,
>
> On 2024/1/24 01:58, Tom Rini wrote:
> > On Tue, Jan 23, 2024 at 11:53:18AM +0800, Kever Yang wrote:
> >
> > > Hi Tom,
> > >
> > > rk3036 only has small size internal sram, so it can only use very
> > > simple SPL which only including dram init, and no SPL_FRAMEWORK
> > > support.
> > > In this convert, the CONFIG_SPL_STACK is lost for this SoC, any
> > > suggestions on this kind of issue?
> > Does this work?
> >
> > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > index e7b84fc1fa68..9deee0fdbea8 100644
> > --- a/common/spl/Kconfig
> > +++ b/common/spl/Kconfig
> > @@ -372,7 +372,8 @@ config SPL_SHARES_INIT_SP_ADDR
> > config SPL_STACK
> > hex "Initial stack pointer location"
> > - depends on (ARM || ARCH_JZ47XX || MICROBLAZE || RISCV) && SPL_FRAMEWORK
> > + depends on (ARM || ARCH_JZ47XX || MICROBLAZE || RISCV) && \
> > + SPL_FRAMEWORK || ROCKCHIP_RK3036
> This works with adding CONFIG_SPL_STACK in rk3036 board defconfig.
> > depends on !SPL_SHARES_INIT_SP_ADDR
> > default 0x946bb8 if ARCH_MX7
> > default 0x93ffb8 if ARCH_MX6 && MX6_OCRAM_256KB
> >
> > You will have to update the ROCKCHIP_RK3036 platforms otherwise the
> > build will hang now.
>
> What do you mean to update the platform?
>
> The rk3036 case should be one of the available option for those "small"/low
> end SoCs has very limit
>
> size of internal dram, only need minimal SPL+ U-Boot, and no requirement
> for ATF/OPTEEwhich will have to use TPL+SPL+U-Boot.
>
>
> The CONFIG_SPL_STACK is used in assemble init code, it doesn't need to
> depends on SPL_FRAMEWORK, isn't it?
I just mean that with the above Kconfig change, all RK3036 platforms
must set a value for CONFIG_SPL_STACK at the same time, or they will
fail to build (and CI will get hung). It sounds like all RK3036
platforms need to set the value in order to work, so this isn't a bug,
just a feature. Is that clearer?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-01-24 1:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 16:55 [PATCH 01/20] Convert CONFIG_SPL_STACK to Kconfig Tom Rini
2022-05-29 16:55 ` [PATCH 02/20] imx6: Update CONFIG_SPL_STACK defaults in Kconfig Tom Rini
2022-05-29 16:55 ` [PATCH 03/20] imx7: " Tom Rini
2022-05-29 16:55 ` [PATCH 04/20] Convert CONFIG_TPL_NAND_INIT to Kconfig Tom Rini
2022-05-29 16:55 ` [PATCH 05/20] Convert CONFIG_SPL_RELOC_TEXT_BASE et al " Tom Rini
2022-05-29 16:55 ` [PATCH 06/20] Convert CONFIG_SPL_BSS_START_ADDR " Tom Rini
2022-05-29 16:55 ` [PATCH 07/20] Convert CONFIG_SYS_SPL_MALLOC_SIZE et al " Tom Rini
2022-05-29 16:55 ` [PATCH 08/20] Remove CONFIG_SYS_SPL_LEN largely Tom Rini
2022-05-29 16:55 ` [PATCH 09/20] etamin: Remove CONFIG_SPL_CMT defines Tom Rini
2022-05-29 16:55 ` [PATCH 10/20] Convert CONFIG_SPL_GD_ADDR to Kconfig Tom Rini
2022-05-29 16:55 ` [PATCH 11/20] Drop CONFIG_SPL_SPI_FLASH_MINIMAL Tom Rini
2022-05-29 16:55 ` [PATCH 12/20] Remove CONFIG_SPL_STACK_SIZE Tom Rini
2022-05-29 16:55 ` [PATCH 13/20] Convert CONFIG_SPL_TARGET to Kconfig Tom Rini
2022-05-29 16:55 ` [PATCH 14/20] Convert CONFIG_SYS_SPL_ARGS_ADDR " Tom Rini
2022-05-29 16:55 ` [PATCH 15/20] ax25-ae350: Move CONFIG_SYS_FDT_BASE " Tom Rini
[not found] ` <HK0PR03MB29945ABCCE6928CEB0BA22A5C1DD9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2022-06-02 1:14 ` Rick Chen
2022-05-29 16:55 ` [PATCH 16/20] Drop CONFIG_SPL_SIZE Tom Rini
2022-05-29 16:55 ` [PATCH 17/20] spl: Remove CONFIG_SPL_START_S_PATH and rework the logic behind it Tom Rini
2022-05-29 16:55 ` [PATCH 18/20] Convert CONFIG_SYS_NAND_SPL_KERNEL_OFFS to Kconfig Tom Rini
2022-05-29 16:55 ` [PATCH 19/20] Convert CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR et al " Tom Rini
2022-05-29 16:55 ` [PATCH 20/20] riotboard, syzygy_hub: Disable SPL_FALCON_BOOT_MMCSD Tom Rini
2022-06-06 21:36 ` [PATCH 01/20] Convert CONFIG_SPL_STACK to Kconfig Tom Rini
2024-01-23 3:53 ` Kever Yang
2024-01-23 17:58 ` Tom Rini
2024-01-24 1:15 ` Kever Yang
2024-01-24 1:34 ` Tom Rini [this message]
2024-01-24 7:50 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124013402.GZ3652023@bill-the-cat \
--to=trini@konsulko.com \
--cc=kever.yang@rock-chips.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.