drivers/hwmon/nzxt-smart2.c:461:12-13: WARNING opportunity for min()

drivers/hwmon/nzxt-smart2.c:461:12-13: WARNING opportunity for min()

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Aleksandr Mezin <mezin.alexander@gmail.com>
CC: Guenter Roeck <linux@roeck-us.net>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   ecb1b8288dc7ccbdcb3b9df005fa1c0e0c0388a7
commit: 53e68c20aeb1e23419bed811aa3a309ceda200f9 hwmon: add driver for NZXT RGB&Fan Controller/Smart Device v2.
date:   2 years, 1 month ago
:::::: branch date: 15 hours ago
:::::: commit date: 2 years, 1 month ago
config: arm-randconfig-r062-20240117 (https://download.01.org/0day-ci/archive/20240126/202401261737.6yWl89yE-lkp@intel.com/config)
compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project 9bde5becb44ea071f5e1fa1f5d4071dc8788b18c)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202401261737.6yWl89yE-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/hwmon/nzxt-smart2.c:461:12-13: WARNING opportunity for min()

vim +461 drivers/hwmon/nzxt-smart2.c

53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  444  
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  445  static int send_output_report(struct drvdata *drvdata, const void *data,
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  446  			      size_t data_size)
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  447  {
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  448  	int ret;
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  449  
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  450  	if (data_size > sizeof(drvdata->output_buffer))
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  451  		return -EINVAL;
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  452  
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  453  	memcpy(drvdata->output_buffer, data, data_size);
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  454  
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  455  	if (data_size < sizeof(drvdata->output_buffer))
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  456  		memset(drvdata->output_buffer + data_size, 0,
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  457  		       sizeof(drvdata->output_buffer) - data_size);
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  458  
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  459  	ret = hid_hw_output_report(drvdata->hid, drvdata->output_buffer,
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  460  				   sizeof(drvdata->output_buffer));
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31 @461  	return ret < 0 ? ret : 0;
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  462  }
53e68c20aeb1e2 Aleksandr Mezin 2021-10-31  463  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki