* [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
@ 2024-01-31 5:01 kernel test robot
2024-01-31 12:35 ` Kalle Valo
2024-02-02 2:45 ` Baochen Qiang
0 siblings, 2 replies; 6+ messages in thread
From: kernel test robot @ 2024-01-31 5:01 UTC (permalink / raw)
To: Wen Gong; +Cc: oe-kbuild-all, Kalle Valo, ath10k, Kalle Valo, Baochen Qiang
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
head: 2c471f31297856be56f60ef29f2565dea1470800
commit: 92425f788feede9bf152ecf3fb7a264942ee7719 [47/100] wifi: ath11k: fill parameters for vdev set tpc power WMI command
config: i386-randconfig-141-20240129 (https://download.01.org/0day-ci/archive/20240131/202401311243.NyXwWZxP-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401311243.NyXwWZxP-lkp@intel.com/
New smatch warnings:
drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
Old smatch warnings:
drivers/net/wireless/ath/ath11k/mac.c:2321 ath11k_peer_assoc_h_he() error: uninitialized symbol 'rx_mcs_80'.
drivers/net/wireless/ath/ath11k/mac.c:2321 ath11k_peer_assoc_h_he() error: uninitialized symbol 'rx_mcs_160'.
drivers/net/wireless/ath/ath11k/mac.c:2323 ath11k_peer_assoc_h_he() error: uninitialized symbol 'rx_mcs_80'.
vim +/eirp_power +7949 drivers/net/wireless/ath/ath11k/mac.c
7780
7781 void ath11k_mac_fill_reg_tpc_info(struct ath11k *ar,
7782 struct ieee80211_vif *vif,
7783 struct ieee80211_chanctx_conf *ctx)
7784 {
7785 struct ath11k_base *ab = ar->ab;
7786 struct ath11k_vif *arvif = (void *)vif->drv_priv;
7787 struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
7788 struct ath11k_reg_tpc_power_info *reg_tpc_info = &arvif->reg_tpc_info;
7789 struct ieee80211_channel *chan, *temp_chan;
7790 u8 pwr_lvl_idx, num_pwr_levels, pwr_reduction;
7791 bool is_psd_power = false, is_tpe_present = false;
7792 s8 max_tx_power[IEEE80211_MAX_NUM_PWR_LEVEL],
7793 psd_power, tx_power, eirp_power;
7794 u16 start_freq, center_freq;
7795
7796 chan = ctx->def.chan;
7797 start_freq = ath11k_mac_get_6ghz_start_frequency(&ctx->def);
7798 pwr_reduction = bss_conf->pwr_reduction;
7799
7800 if (arvif->reg_tpc_info.num_pwr_levels) {
7801 is_tpe_present = true;
7802 num_pwr_levels = arvif->reg_tpc_info.num_pwr_levels;
7803 } else {
7804 num_pwr_levels = ath11k_mac_get_num_pwr_levels(&ctx->def);
7805 }
7806
7807 for (pwr_lvl_idx = 0; pwr_lvl_idx < num_pwr_levels; pwr_lvl_idx++) {
7808 /* STA received TPE IE*/
7809 if (is_tpe_present) {
7810 /* local power is PSD power*/
7811 if (chan->flags & IEEE80211_CHAN_PSD) {
7812 /* Connecting AP is psd power */
7813 if (reg_tpc_info->is_psd_power) {
7814 is_psd_power = true;
7815 ath11k_mac_get_psd_channel(ar, 20,
7816 &start_freq,
7817 ¢er_freq,
7818 pwr_lvl_idx,
7819 &temp_chan,
7820 &tx_power);
7821 psd_power = temp_chan->psd;
7822 eirp_power = tx_power;
7823 max_tx_power[pwr_lvl_idx] =
7824 min_t(s8,
7825 psd_power,
7826 reg_tpc_info->tpe[pwr_lvl_idx]);
7827 /* Connecting AP is not psd power */
7828 } else {
7829 ath11k_mac_get_eirp_power(ar,
7830 &start_freq,
7831 ¢er_freq,
7832 pwr_lvl_idx,
7833 &temp_chan,
7834 &ctx->def,
7835 &tx_power);
7836 psd_power = temp_chan->psd;
7837 /* convert psd power to EIRP power based
7838 * on channel width
7839 */
7840 tx_power =
7841 min_t(s8, tx_power,
7842 psd_power + 13 + pwr_lvl_idx * 3);
7843 max_tx_power[pwr_lvl_idx] =
7844 min_t(s8,
7845 tx_power,
7846 reg_tpc_info->tpe[pwr_lvl_idx]);
7847 }
7848 /* local power is not PSD power */
7849 } else {
7850 /* Connecting AP is psd power */
7851 if (reg_tpc_info->is_psd_power) {
7852 is_psd_power = true;
7853 ath11k_mac_get_psd_channel(ar, 20,
7854 &start_freq,
7855 ¢er_freq,
7856 pwr_lvl_idx,
7857 &temp_chan,
7858 &tx_power);
7859 eirp_power = tx_power;
7860 max_tx_power[pwr_lvl_idx] =
7861 reg_tpc_info->tpe[pwr_lvl_idx];
7862 /* Connecting AP is not psd power */
7863 } else {
7864 ath11k_mac_get_eirp_power(ar,
7865 &start_freq,
7866 ¢er_freq,
7867 pwr_lvl_idx,
7868 &temp_chan,
7869 &ctx->def,
7870 &tx_power);
7871 max_tx_power[pwr_lvl_idx] =
7872 min_t(s8,
7873 tx_power,
7874 reg_tpc_info->tpe[pwr_lvl_idx]);
7875 }
7876 }
7877 /* STA not received TPE IE */
7878 } else {
7879 /* local power is PSD power*/
7880 if (chan->flags & IEEE80211_CHAN_PSD) {
7881 is_psd_power = true;
7882 ath11k_mac_get_psd_channel(ar, 20,
7883 &start_freq,
7884 ¢er_freq,
7885 pwr_lvl_idx,
7886 &temp_chan,
7887 &tx_power);
7888 psd_power = temp_chan->psd;
7889 eirp_power = tx_power;
7890 max_tx_power[pwr_lvl_idx] = psd_power;
7891 } else {
7892 ath11k_mac_get_eirp_power(ar,
7893 &start_freq,
7894 ¢er_freq,
7895 pwr_lvl_idx,
7896 &temp_chan,
7897 &ctx->def,
7898 &tx_power);
7899 max_tx_power[pwr_lvl_idx] = tx_power;
7900 }
7901 }
7902
7903 if (is_psd_power) {
7904 /* If AP local power constraint is present */
7905 if (pwr_reduction)
7906 eirp_power = eirp_power - pwr_reduction;
7907
7908 /* If firmware updated max tx power is non zero, then take
7909 * the min of firmware updated ap tx power
7910 * and max power derived from above mentioned parameters.
7911 */
7912 ath11k_dbg(ab, ATH11K_DBG_MAC,
7913 "eirp power : %d firmware report power : %d\n",
7914 eirp_power, ar->max_allowed_tx_power);
7915 /* Firmware reports lower max_allowed_tx_power during vdev
7916 * start response. In case of 6 GHz, firmware is not aware
7917 * of EIRP power unless driver sets EIRP power through WMI
7918 * TPC command. So radio which does not support idle power
7919 * save can set maximum calculated EIRP power directly to
7920 * firmware through TPC command without min comparison with
7921 * vdev start response's max_allowed_tx_power.
7922 */
7923 if (ar->max_allowed_tx_power && ab->hw_params.idle_ps)
7924 eirp_power = min_t(s8,
7925 eirp_power,
7926 ar->max_allowed_tx_power);
7927 } else {
7928 /* If AP local power constraint is present */
7929 if (pwr_reduction)
7930 max_tx_power[pwr_lvl_idx] =
7931 max_tx_power[pwr_lvl_idx] - pwr_reduction;
7932 /* If firmware updated max tx power is non zero, then take
7933 * the min of firmware updated ap tx power
7934 * and max power derived from above mentioned parameters.
7935 */
7936 if (ar->max_allowed_tx_power && ab->hw_params.idle_ps)
7937 max_tx_power[pwr_lvl_idx] =
7938 min_t(s8,
7939 max_tx_power[pwr_lvl_idx],
7940 ar->max_allowed_tx_power);
7941 }
7942 reg_tpc_info->chan_power_info[pwr_lvl_idx].chan_cfreq = center_freq;
7943 reg_tpc_info->chan_power_info[pwr_lvl_idx].tx_power =
7944 max_tx_power[pwr_lvl_idx];
7945 }
7946
7947 reg_tpc_info->num_pwr_levels = num_pwr_levels;
7948 reg_tpc_info->is_psd_power = is_psd_power;
> 7949 reg_tpc_info->eirp_power = eirp_power;
7950 reg_tpc_info->ap_power_type =
7951 ath11k_reg_ap_pwr_convert(vif->bss_conf.power_type);
7952 }
7953
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
2024-01-31 5:01 [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power' kernel test robot
@ 2024-01-31 12:35 ` Kalle Valo
2024-02-01 4:31 ` Baochen Qiang
2024-02-02 2:45 ` Baochen Qiang
1 sibling, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2024-01-31 12:35 UTC (permalink / raw)
To: Baochen Qiang; +Cc: Wen Gong, oe-kbuild-all, ath10k, kernel test robot, ath11k
+ ath11k list
kernel test robot <lkp@intel.com> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
> head: 2c471f31297856be56f60ef29f2565dea1470800
> commit: 92425f788feede9bf152ecf3fb7a264942ee7719 [47/100] wifi:
> ath11k: fill parameters for vdev set tpc power WMI command
> config: i386-randconfig-141-20240129
> (https://download.01.org/0day-ci/archive/20240131/202401311243.NyXwWZxP-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401311243.NyXwWZxP-lkp@intel.com/
>
> New smatch warnings:
> drivers/net/wireless/ath/ath11k/mac.c:7949
> ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol
> 'eirp_power'.
Baochen, could you take a look at this new warning and if it's valid
send a fix for it, please?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
2024-01-31 12:35 ` Kalle Valo
@ 2024-02-01 4:31 ` Baochen Qiang
2024-02-01 16:19 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Baochen Qiang @ 2024-02-01 4:31 UTC (permalink / raw)
To: Kalle Valo; +Cc: Wen Gong, oe-kbuild-all, ath10k, kernel test robot, ath11k
On 1/31/2024 8:35 PM, Kalle Valo wrote:
> + ath11k list
>
> kernel test robot <lkp@intel.com> writes:
>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
>> head: 2c471f31297856be56f60ef29f2565dea1470800
>> commit: 92425f788feede9bf152ecf3fb7a264942ee7719 [47/100] wifi:
>> ath11k: fill parameters for vdev set tpc power WMI command
>> config: i386-randconfig-141-20240129
>> (https://download.01.org/0day-ci/archive/20240131/202401311243.NyXwWZxP-lkp@intel.com/config)
>> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202401311243.NyXwWZxP-lkp@intel.com/
>>
>> New smatch warnings:
>> drivers/net/wireless/ath/ath11k/mac.c:7949
>> ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol
>> 'eirp_power'.
>
> Baochen, could you take a look at this new warning and if it's valid
> send a fix for it, please?
I sent the patch yesterday. search
"wifi: ath11k: initialize eirp_power before use"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
2024-02-01 4:31 ` Baochen Qiang
@ 2024-02-01 16:19 ` Kalle Valo
2024-02-02 2:45 ` Baochen Qiang
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2024-02-01 16:19 UTC (permalink / raw)
To: Baochen Qiang; +Cc: oe-kbuild-all, ath10k, kernel test robot, ath11k
Baochen Qiang <quic_bqiang@quicinc.com> writes:
> On 1/31/2024 8:35 PM, Kalle Valo wrote:
>> + ath11k list
>> kernel test robot <lkp@intel.com> writes:
>>
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
>>> head: 2c471f31297856be56f60ef29f2565dea1470800
>>> commit: 92425f788feede9bf152ecf3fb7a264942ee7719 [47/100] wifi:
>>> ath11k: fill parameters for vdev set tpc power WMI command
>>> config: i386-randconfig-141-20240129
>>> (https://download.01.org/0day-ci/archive/20240131/202401311243.NyXwWZxP-lkp@intel.com/config)
>>> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
>>>
>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>> the same patch/commit), kindly add following tags
>>> | Reported-by: kernel test robot <lkp@intel.com>
>>> | Closes:
>>> | https://lore.kernel.org/oe-kbuild-all/202401311243.NyXwWZxP-lkp@intel.com/
>>>
>>> New smatch warnings:
>>> drivers/net/wireless/ath/ath11k/mac.c:7949
>>> ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol
>>> 'eirp_power'.
>> Baochen, could you take a look at this new warning and if it's valid
>> send a fix for it, please?
>
> I sent the patch yesterday. search
> "wifi: ath11k: initialize eirp_power before use"
Great, thanks again Baochen. It's always a good practice to reply to
build bot mails, something like "This is a valid warning, I'll fix it"
is usually enough.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
2024-01-31 5:01 [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power' kernel test robot
2024-01-31 12:35 ` Kalle Valo
@ 2024-02-02 2:45 ` Baochen Qiang
1 sibling, 0 replies; 6+ messages in thread
From: Baochen Qiang @ 2024-02-02 2:45 UTC (permalink / raw)
To: kernel test robot, Wen Gong; +Cc: oe-kbuild-all, Kalle Valo, ath10k, Kalle Valo
On 1/31/2024 1:01 PM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
> head: 2c471f31297856be56f60ef29f2565dea1470800
> commit: 92425f788feede9bf152ecf3fb7a264942ee7719 [47/100] wifi: ath11k: fill parameters for vdev set tpc power WMI command
> config: i386-randconfig-141-20240129 (https://download.01.org/0day-ci/archive/20240131/202401311243.NyXwWZxP-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401311243.NyXwWZxP-lkp@intel.com/
>
> New smatch warnings:
> drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
>
> Old smatch warnings:
> drivers/net/wireless/ath/ath11k/mac.c:2321 ath11k_peer_assoc_h_he() error: uninitialized symbol 'rx_mcs_80'.
> drivers/net/wireless/ath/ath11k/mac.c:2321 ath11k_peer_assoc_h_he() error: uninitialized symbol 'rx_mcs_160'.
> drivers/net/wireless/ath/ath11k/mac.c:2323 ath11k_peer_assoc_h_he() error: uninitialized symbol 'rx_mcs_80'.
>
> vim +/eirp_power +7949 drivers/net/wireless/ath/ath11k/mac.c
>
> 7780
> 7781 void ath11k_mac_fill_reg_tpc_info(struct ath11k *ar,
> 7782 struct ieee80211_vif *vif,
> 7783 struct ieee80211_chanctx_conf *ctx)
> 7784 {
> 7785 struct ath11k_base *ab = ar->ab;
> 7786 struct ath11k_vif *arvif = (void *)vif->drv_priv;
> 7787 struct ieee80211_bss_conf *bss_conf = &vif->bss_conf;
> 7788 struct ath11k_reg_tpc_power_info *reg_tpc_info = &arvif->reg_tpc_info;
> 7789 struct ieee80211_channel *chan, *temp_chan;
> 7790 u8 pwr_lvl_idx, num_pwr_levels, pwr_reduction;
> 7791 bool is_psd_power = false, is_tpe_present = false;
> 7792 s8 max_tx_power[IEEE80211_MAX_NUM_PWR_LEVEL],
> 7793 psd_power, tx_power, eirp_power;
> 7794 u16 start_freq, center_freq;
> 7795
> 7796 chan = ctx->def.chan;
> 7797 start_freq = ath11k_mac_get_6ghz_start_frequency(&ctx->def);
> 7798 pwr_reduction = bss_conf->pwr_reduction;
> 7799
> 7800 if (arvif->reg_tpc_info.num_pwr_levels) {
> 7801 is_tpe_present = true;
> 7802 num_pwr_levels = arvif->reg_tpc_info.num_pwr_levels;
> 7803 } else {
> 7804 num_pwr_levels = ath11k_mac_get_num_pwr_levels(&ctx->def);
> 7805 }
> 7806
> 7807 for (pwr_lvl_idx = 0; pwr_lvl_idx < num_pwr_levels; pwr_lvl_idx++) {
> 7808 /* STA received TPE IE*/
> 7809 if (is_tpe_present) {
> 7810 /* local power is PSD power*/
> 7811 if (chan->flags & IEEE80211_CHAN_PSD) {
> 7812 /* Connecting AP is psd power */
> 7813 if (reg_tpc_info->is_psd_power) {
> 7814 is_psd_power = true;
> 7815 ath11k_mac_get_psd_channel(ar, 20,
> 7816 &start_freq,
> 7817 ¢er_freq,
> 7818 pwr_lvl_idx,
> 7819 &temp_chan,
> 7820 &tx_power);
> 7821 psd_power = temp_chan->psd;
> 7822 eirp_power = tx_power;
> 7823 max_tx_power[pwr_lvl_idx] =
> 7824 min_t(s8,
> 7825 psd_power,
> 7826 reg_tpc_info->tpe[pwr_lvl_idx]);
> 7827 /* Connecting AP is not psd power */
> 7828 } else {
> 7829 ath11k_mac_get_eirp_power(ar,
> 7830 &start_freq,
> 7831 ¢er_freq,
> 7832 pwr_lvl_idx,
> 7833 &temp_chan,
> 7834 &ctx->def,
> 7835 &tx_power);
> 7836 psd_power = temp_chan->psd;
> 7837 /* convert psd power to EIRP power based
> 7838 * on channel width
> 7839 */
> 7840 tx_power =
> 7841 min_t(s8, tx_power,
> 7842 psd_power + 13 + pwr_lvl_idx * 3);
> 7843 max_tx_power[pwr_lvl_idx] =
> 7844 min_t(s8,
> 7845 tx_power,
> 7846 reg_tpc_info->tpe[pwr_lvl_idx]);
> 7847 }
> 7848 /* local power is not PSD power */
> 7849 } else {
> 7850 /* Connecting AP is psd power */
> 7851 if (reg_tpc_info->is_psd_power) {
> 7852 is_psd_power = true;
> 7853 ath11k_mac_get_psd_channel(ar, 20,
> 7854 &start_freq,
> 7855 ¢er_freq,
> 7856 pwr_lvl_idx,
> 7857 &temp_chan,
> 7858 &tx_power);
> 7859 eirp_power = tx_power;
> 7860 max_tx_power[pwr_lvl_idx] =
> 7861 reg_tpc_info->tpe[pwr_lvl_idx];
> 7862 /* Connecting AP is not psd power */
> 7863 } else {
> 7864 ath11k_mac_get_eirp_power(ar,
> 7865 &start_freq,
> 7866 ¢er_freq,
> 7867 pwr_lvl_idx,
> 7868 &temp_chan,
> 7869 &ctx->def,
> 7870 &tx_power);
> 7871 max_tx_power[pwr_lvl_idx] =
> 7872 min_t(s8,
> 7873 tx_power,
> 7874 reg_tpc_info->tpe[pwr_lvl_idx]);
> 7875 }
> 7876 }
> 7877 /* STA not received TPE IE */
> 7878 } else {
> 7879 /* local power is PSD power*/
> 7880 if (chan->flags & IEEE80211_CHAN_PSD) {
> 7881 is_psd_power = true;
> 7882 ath11k_mac_get_psd_channel(ar, 20,
> 7883 &start_freq,
> 7884 ¢er_freq,
> 7885 pwr_lvl_idx,
> 7886 &temp_chan,
> 7887 &tx_power);
> 7888 psd_power = temp_chan->psd;
> 7889 eirp_power = tx_power;
> 7890 max_tx_power[pwr_lvl_idx] = psd_power;
> 7891 } else {
> 7892 ath11k_mac_get_eirp_power(ar,
> 7893 &start_freq,
> 7894 ¢er_freq,
> 7895 pwr_lvl_idx,
> 7896 &temp_chan,
> 7897 &ctx->def,
> 7898 &tx_power);
> 7899 max_tx_power[pwr_lvl_idx] = tx_power;
> 7900 }
> 7901 }
> 7902
> 7903 if (is_psd_power) {
> 7904 /* If AP local power constraint is present */
> 7905 if (pwr_reduction)
> 7906 eirp_power = eirp_power - pwr_reduction;
> 7907
> 7908 /* If firmware updated max tx power is non zero, then take
> 7909 * the min of firmware updated ap tx power
> 7910 * and max power derived from above mentioned parameters.
> 7911 */
> 7912 ath11k_dbg(ab, ATH11K_DBG_MAC,
> 7913 "eirp power : %d firmware report power : %d\n",
> 7914 eirp_power, ar->max_allowed_tx_power);
> 7915 /* Firmware reports lower max_allowed_tx_power during vdev
> 7916 * start response. In case of 6 GHz, firmware is not aware
> 7917 * of EIRP power unless driver sets EIRP power through WMI
> 7918 * TPC command. So radio which does not support idle power
> 7919 * save can set maximum calculated EIRP power directly to
> 7920 * firmware through TPC command without min comparison with
> 7921 * vdev start response's max_allowed_tx_power.
> 7922 */
> 7923 if (ar->max_allowed_tx_power && ab->hw_params.idle_ps)
> 7924 eirp_power = min_t(s8,
> 7925 eirp_power,
> 7926 ar->max_allowed_tx_power);
> 7927 } else {
> 7928 /* If AP local power constraint is present */
> 7929 if (pwr_reduction)
> 7930 max_tx_power[pwr_lvl_idx] =
> 7931 max_tx_power[pwr_lvl_idx] - pwr_reduction;
> 7932 /* If firmware updated max tx power is non zero, then take
> 7933 * the min of firmware updated ap tx power
> 7934 * and max power derived from above mentioned parameters.
> 7935 */
> 7936 if (ar->max_allowed_tx_power && ab->hw_params.idle_ps)
> 7937 max_tx_power[pwr_lvl_idx] =
> 7938 min_t(s8,
> 7939 max_tx_power[pwr_lvl_idx],
> 7940 ar->max_allowed_tx_power);
> 7941 }
> 7942 reg_tpc_info->chan_power_info[pwr_lvl_idx].chan_cfreq = center_freq;
> 7943 reg_tpc_info->chan_power_info[pwr_lvl_idx].tx_power =
> 7944 max_tx_power[pwr_lvl_idx];
> 7945 }
> 7946
> 7947 reg_tpc_info->num_pwr_levels = num_pwr_levels;
> 7948 reg_tpc_info->is_psd_power = is_psd_power;
>> 7949 reg_tpc_info->eirp_power = eirp_power;
> 7950 reg_tpc_info->ap_power_type =
> 7951 ath11k_reg_ap_pwr_convert(vif->bss_conf.power_type);
> 7952 }
> 7953
This is a valid waring, I will fix it.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.
2024-02-01 16:19 ` Kalle Valo
@ 2024-02-02 2:45 ` Baochen Qiang
0 siblings, 0 replies; 6+ messages in thread
From: Baochen Qiang @ 2024-02-02 2:45 UTC (permalink / raw)
To: Kalle Valo; +Cc: oe-kbuild-all, ath10k, kernel test robot, ath11k
On 2/2/2024 12:19 AM, Kalle Valo wrote:
> Baochen Qiang <quic_bqiang@quicinc.com> writes:
>
>> On 1/31/2024 8:35 PM, Kalle Valo wrote:
>>> + ath11k list
>>> kernel test robot <lkp@intel.com> writes:
>>>
>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
>>>> head: 2c471f31297856be56f60ef29f2565dea1470800
>>>> commit: 92425f788feede9bf152ecf3fb7a264942ee7719 [47/100] wifi:
>>>> ath11k: fill parameters for vdev set tpc power WMI command
>>>> config: i386-randconfig-141-20240129
>>>> (https://download.01.org/0day-ci/archive/20240131/202401311243.NyXwWZxP-lkp@intel.com/config)
>>>> compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
>>>>
>>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>>>> the same patch/commit), kindly add following tags
>>>> | Reported-by: kernel test robot <lkp@intel.com>
>>>> | Closes:
>>>> | https://lore.kernel.org/oe-kbuild-all/202401311243.NyXwWZxP-lkp@intel.com/
>>>>
>>>> New smatch warnings:
>>>> drivers/net/wireless/ath/ath11k/mac.c:7949
>>>> ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol
>>>> 'eirp_power'.
>>> Baochen, could you take a look at this new warning and if it's valid
>>> send a fix for it, please?
>>
>> I sent the patch yesterday. search
>> "wifi: ath11k: initialize eirp_power before use"
>
> Great, thanks again Baochen. It's always a good practice to reply to
> build bot mails, something like "This is a valid warning, I'll fix it"
> is usually enough.
Got it Kalle, will do.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-02 2:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-31 5:01 [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power' kernel test robot
2024-01-31 12:35 ` Kalle Valo
2024-02-01 4:31 ` Baochen Qiang
2024-02-01 16:19 ` Kalle Valo
2024-02-02 2:45 ` Baochen Qiang
2024-02-02 2:45 ` Baochen Qiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.