From: Ian Rogers <irogers@google.com> To: "Peter Zijlstra" <peterz@infradead.org>, "Ingo Molnar" <mingo@redhat.com>, "Arnaldo Carvalho de Melo" <acme@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Alexander Shishkin" <alexander.shishkin@linux.intel.com>, "Jiri Olsa" <jolsa@kernel.org>, "Namhyung Kim" <namhyung@kernel.org>, "Ian Rogers" <irogers@google.com>, "Adrian Hunter" <adrian.hunter@intel.com>, "Suzuki K Poulose" <suzuki.poulose@arm.com>, "Mike Leach" <mike.leach@linaro.org>, "James Clark" <james.clark@arm.com>, "Leo Yan" <leo.yan@linaro.org>, "John Garry" <john.g.garry@oracle.com>, "Will Deacon" <will@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Darren Hart" <dvhart@infradead.org>, "Davidlohr Bueso" <dave@stgolabs.net>, "André Almeida" <andrealmeid@igalia.com>, "Kan Liang" <kan.liang@linux.intel.com>, "K Prateek Nayak" <kprateek.nayak@amd.com>, "Sean Christopherson" <seanjc@google.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Kajol Jain" <kjain@linux.ibm.com>, "Athira Rajeev" <atrajeev@linux.vnet.ibm.com>, "Andrew Jones" <ajones@ventanamicro.com>, "Alexandre Ghiti" <alexghiti@rivosinc.com>, "Atish Patra" <atishp@rivosinc.com>, "Steinar H. Gunderson" <sesse@google.com>, "Yang Jihong" <yangjihong1@huawei.com>, "Yang Li" <yang.lee@linux.alibaba.com>, "Changbin Du" <changbin.du@huawei.com>, "Sandipan Das" <sandipan.das@amd.com>, "Ravi Bangoria" <ravi.bangoria@amd.com>, "Paran Lee" <p4ranlee@gmail.com>, "Nick Desaulniers" <ndesaulniers@google.com>, "Huacai Chen" <chenhuacai@kernel.org>, "Yanteng Si" <siyanteng@loongson.cn>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: [PATCH v3 7/8] perf stat: Remove duplicate cpus_map_matched function Date: Fri, 2 Feb 2024 15:40:56 -0800 [thread overview] Message-ID: <20240202234057.2085863-8-irogers@google.com> (raw) In-Reply-To: <20240202234057.2085863-1-irogers@google.com> Use libperf's perf_cpu_map__equal that performs the same function. Signed-off-by: Ian Rogers <irogers@google.com> Reviewed-by: James Clark <james.clark@arm.com> --- tools/perf/builtin-stat.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 280eb0c99d2b..d80bad7c73e4 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -164,26 +164,6 @@ static struct perf_stat_config stat_config = { .iostat_run = false, }; -static bool cpus_map_matched(struct evsel *a, struct evsel *b) -{ - if (!a->core.cpus && !b->core.cpus) - return true; - - if (!a->core.cpus || !b->core.cpus) - return false; - - if (perf_cpu_map__nr(a->core.cpus) != perf_cpu_map__nr(b->core.cpus)) - return false; - - for (int i = 0; i < perf_cpu_map__nr(a->core.cpus); i++) { - if (perf_cpu_map__cpu(a->core.cpus, i).cpu != - perf_cpu_map__cpu(b->core.cpus, i).cpu) - return false; - } - - return true; -} - static void evlist__check_cpu_maps(struct evlist *evlist) { struct evsel *evsel, *warned_leader = NULL; @@ -194,7 +174,7 @@ static void evlist__check_cpu_maps(struct evlist *evlist) /* Check that leader matches cpus with each member. */ if (leader == evsel) continue; - if (cpus_map_matched(leader, evsel)) + if (perf_cpu_map__equal(leader->core.cpus, evsel->core.cpus)) continue; /* If there's mismatch disable the group and warn user. */ -- 2.43.0.594.gd9cf4e227d-goog
WARNING: multiple messages have this Message-ID (diff)
From: Ian Rogers <irogers@google.com> To: "Peter Zijlstra" <peterz@infradead.org>, "Ingo Molnar" <mingo@redhat.com>, "Arnaldo Carvalho de Melo" <acme@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Alexander Shishkin" <alexander.shishkin@linux.intel.com>, "Jiri Olsa" <jolsa@kernel.org>, "Namhyung Kim" <namhyung@kernel.org>, "Ian Rogers" <irogers@google.com>, "Adrian Hunter" <adrian.hunter@intel.com>, "Suzuki K Poulose" <suzuki.poulose@arm.com>, "Mike Leach" <mike.leach@linaro.org>, "James Clark" <james.clark@arm.com>, "Leo Yan" <leo.yan@linaro.org>, "John Garry" <john.g.garry@oracle.com>, "Will Deacon" <will@kernel.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Darren Hart" <dvhart@infradead.org>, "Davidlohr Bueso" <dave@stgolabs.net>, "André Almeida" <andrealmeid@igalia.com>, "Kan Liang" <kan.liang@linux.intel.com>, "K Prateek Nayak" <kprateek.nayak@amd.com>, "Sean Christopherson" <seanjc@google.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Kajol Jain" <kjain@linux.ibm.com>, "Athira Rajeev" <atrajeev@linux.vnet.ibm.com>, "Andrew Jones" <ajones@ventanamicro.com>, "Alexandre Ghiti" <alexghiti@rivosinc.com>, "Atish Patra" <atishp@rivosinc.com>, "Steinar H. Gunderson" <sesse@google.com>, "Yang Jihong" <yangjihong1@huawei.com>, "Yang Li" <yang.lee@linux.alibaba.com>, "Changbin Du" <changbin.du@huawei.com>, "Sandipan Das" <sandipan.das@amd.com>, "Ravi Bangoria" <ravi.bangoria@amd.com>, "Paran Lee" <p4ranlee@gmail.com>, "Nick Desaulniers" <ndesaulniers@google.com>, "Huacai Chen" <chenhuacai@kernel.org>, "Yanteng Si" <siyanteng@loongson.cn>, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: [PATCH v3 7/8] perf stat: Remove duplicate cpus_map_matched function Date: Fri, 2 Feb 2024 15:40:56 -0800 [thread overview] Message-ID: <20240202234057.2085863-8-irogers@google.com> (raw) In-Reply-To: <20240202234057.2085863-1-irogers@google.com> Use libperf's perf_cpu_map__equal that performs the same function. Signed-off-by: Ian Rogers <irogers@google.com> Reviewed-by: James Clark <james.clark@arm.com> --- tools/perf/builtin-stat.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 280eb0c99d2b..d80bad7c73e4 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -164,26 +164,6 @@ static struct perf_stat_config stat_config = { .iostat_run = false, }; -static bool cpus_map_matched(struct evsel *a, struct evsel *b) -{ - if (!a->core.cpus && !b->core.cpus) - return true; - - if (!a->core.cpus || !b->core.cpus) - return false; - - if (perf_cpu_map__nr(a->core.cpus) != perf_cpu_map__nr(b->core.cpus)) - return false; - - for (int i = 0; i < perf_cpu_map__nr(a->core.cpus); i++) { - if (perf_cpu_map__cpu(a->core.cpus, i).cpu != - perf_cpu_map__cpu(b->core.cpus, i).cpu) - return false; - } - - return true; -} - static void evlist__check_cpu_maps(struct evlist *evlist) { struct evsel *evsel, *warned_leader = NULL; @@ -194,7 +174,7 @@ static void evlist__check_cpu_maps(struct evlist *evlist) /* Check that leader matches cpus with each member. */ if (leader == evsel) continue; - if (cpus_map_matched(leader, evsel)) + if (perf_cpu_map__equal(leader->core.cpus, evsel->core.cpus)) continue; /* If there's mismatch disable the group and warn user. */ -- 2.43.0.594.gd9cf4e227d-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-02 23:41 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-02 23:40 [PATCH v3 0/8] Clean up libperf cpumap's empty function Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-02 23:40 ` [PATCH v3 1/8] libperf cpumap: Add any, empty and min helpers Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-02 23:40 ` [PATCH v3 2/8] libperf cpumap: Ensure empty cpumap is NULL from alloc Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-17 0:25 ` Namhyung Kim 2024-02-17 0:25 ` Namhyung Kim 2024-02-17 0:52 ` Ian Rogers 2024-02-17 0:52 ` Ian Rogers 2024-02-19 10:38 ` James Clark 2024-02-19 10:38 ` James Clark 2024-02-02 23:40 ` [PATCH v3 3/8] perf arm-spe/cs-etm: Directly iterate CPU maps Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-17 1:01 ` Namhyung Kim 2024-02-17 1:01 ` Namhyung Kim 2024-02-17 1:33 ` Ian Rogers 2024-02-17 1:33 ` Ian Rogers 2024-02-19 10:16 ` James Clark 2024-02-19 10:16 ` James Clark 2024-02-02 23:40 ` [PATCH v3 4/8] perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty use Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-02 23:40 ` [PATCH v3 5/8] perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-02 23:40 ` [PATCH v3 6/8] perf arm64 header: Remove unnecessary CPU map get and put Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-02 23:40 ` Ian Rogers [this message] 2024-02-02 23:40 ` [PATCH v3 7/8] perf stat: Remove duplicate cpus_map_matched function Ian Rogers 2024-02-02 23:40 ` [PATCH v3 8/8] perf cpumap: Use perf_cpu_map__for_each_cpu when possible Ian Rogers 2024-02-02 23:40 ` Ian Rogers 2024-02-14 22:02 ` [PATCH v3 0/8] Clean up libperf cpumap's empty function Ian Rogers 2024-02-14 22:02 ` Ian Rogers 2024-02-17 1:04 ` Namhyung Kim 2024-02-17 1:04 ` Namhyung Kim 2024-03-07 23:47 ` Namhyung Kim 2024-03-07 23:47 ` Namhyung Kim 2024-03-18 21:37 ` Arnaldo Carvalho de Melo 2024-03-18 21:37 ` Arnaldo Carvalho de Melo 2024-03-19 4:18 ` Namhyung Kim 2024-03-19 4:18 ` Namhyung Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240202234057.2085863-8-irogers@google.com \ --to=irogers@google.com \ --cc=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=ajones@ventanamicro.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=alexghiti@rivosinc.com \ --cc=andrealmeid@igalia.com \ --cc=atishp@rivosinc.com \ --cc=atrajeev@linux.vnet.ibm.com \ --cc=bpf@vger.kernel.org \ --cc=changbin.du@huawei.com \ --cc=chenhuacai@kernel.org \ --cc=coresight@lists.linaro.org \ --cc=dave@stgolabs.net \ --cc=dvhart@infradead.org \ --cc=james.clark@arm.com \ --cc=john.g.garry@oracle.com \ --cc=jolsa@kernel.org \ --cc=kan.liang@linux.intel.com \ --cc=kjain@linux.ibm.com \ --cc=kprateek.nayak@amd.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mike.leach@linaro.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=ndesaulniers@google.com \ --cc=p4ranlee@gmail.com \ --cc=pbonzini@redhat.com \ --cc=peterz@infradead.org \ --cc=ravi.bangoria@amd.com \ --cc=sandipan.das@amd.com \ --cc=seanjc@google.com \ --cc=sesse@google.com \ --cc=siyanteng@loongson.cn \ --cc=suzuki.poulose@arm.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ --cc=yang.lee@linux.alibaba.com \ --cc=yangjihong1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.