All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] arm: sunxi: Reduce inrush current on Olimex A20-OLinuXino_MICRO configs
@ 2024-02-11 20:52 Philippe Coval
  2024-02-11 23:43 ` Andre Przywara
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Coval @ 2024-02-11 20:52 UTC (permalink / raw)
  To: u-boot
  Cc: Philippe Coval, Olliver Schinagl, Priit Laes, Maxime Ripard,
	Andre Przywara, Hans de Goede, Jagan Teki, Sam Edwards,
	Samuel Holland, Tom Rini

This change fix reboot, both configurations
were tested on my Olimex A20 Micro Rev E with debian-12.

This issue was also present and fixed on A20 Lime2 (in 8311e84b18),
quoting Olliver Schinagl:

    The lime2 features a too large capacitor on the LDO3 output, which
    causes the PMIC to shutdown when enabling power. To be able to still
    boot up however, we must gradually enable power on LDO3 for this board.
    We do this by enabling both the inrush quirk and the maximum slope the
    AXP209 supports.

Link: https://bugs.debian.org/1060752
Cc: Olliver Schinagl <oliver@schinagl.nl>
Cc: Priit Laes <plaes@plaes.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Philippe Coval <rzr@users.sf.net>
---

Changes in v2:
- Add qirk to eMMC configuration of same machine

 configs/A20-OLinuXino_MICRO-eMMC_defconfig | 1 +
 configs/A20-OLinuXino_MICRO_defconfig      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/A20-OLinuXino_MICRO-eMMC_defconfig b/configs/A20-OLinuXino_MICRO-eMMC_defconfig
index ca5869f43d..2f26b0ca01 100644
--- a/configs/A20-OLinuXino_MICRO-eMMC_defconfig
+++ b/configs/A20-OLinuXino_MICRO-eMMC_defconfig
@@ -20,6 +20,7 @@ CONFIG_ETH_DESIGNWARE=y
 CONFIG_MII=y
 CONFIG_SUN7I_GMAC=y
 CONFIG_SUN7I_GMAC_FORCE_TXERR=y
+CONFIG_AXP_ALDO3_INRUSH_QUIRK=y
 CONFIG_AXP_ALDO3_VOLT=2800
 CONFIG_AXP_ALDO4_VOLT=2800
 CONFIG_SCSI=y
diff --git a/configs/A20-OLinuXino_MICRO_defconfig b/configs/A20-OLinuXino_MICRO_defconfig
index db4270f9b2..673ab85c8a 100644
--- a/configs/A20-OLinuXino_MICRO_defconfig
+++ b/configs/A20-OLinuXino_MICRO_defconfig
@@ -20,6 +20,7 @@ CONFIG_ETH_DESIGNWARE=y
 CONFIG_MII=y
 CONFIG_SUN7I_GMAC=y
 CONFIG_SUN7I_GMAC_FORCE_TXERR=y
+CONFIG_AXP_ALDO3_INRUSH_QUIRK=y
 CONFIG_AXP_ALDO3_VOLT=2800
 CONFIG_AXP_ALDO4_VOLT=2800
 CONFIG_SCSI=y
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm: sunxi: Reduce inrush current on Olimex A20-OLinuXino_MICRO configs
  2024-02-11 20:52 [PATCH v2] arm: sunxi: Reduce inrush current on Olimex A20-OLinuXino_MICRO configs Philippe Coval
@ 2024-02-11 23:43 ` Andre Przywara
  0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2024-02-11 23:43 UTC (permalink / raw)
  To: Philippe Coval
  Cc: u-boot, Olliver Schinagl, Priit Laes, Maxime Ripard,
	Hans de Goede, Jagan Teki, Sam Edwards, Samuel Holland, Tom Rini

On Sun, 11 Feb 2024 21:52:13 +0100
Philippe Coval <rzr@users.sf.net> wrote:

Hi Philippe,

> This change fix reboot, both configurations
> were tested on my Olimex A20 Micro Rev E with debian-12.
> 
> This issue was also present and fixed on A20 Lime2 (in 8311e84b18),
> quoting Olliver Schinagl:
> 
>     The lime2 features a too large capacitor on the LDO3 output, which
>     causes the PMIC to shutdown when enabling power. To be able to still
>     boot up however, we must gradually enable power on LDO3 for this board.
>     We do this by enabling both the inrush quirk and the maximum slope the
>     AXP209 supports.
> 
> Link: https://bugs.debian.org/1060752
> Cc: Olliver Schinagl <oliver@schinagl.nl>
> Cc: Priit Laes <plaes@plaes.org>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Signed-off-by: Philippe Coval <rzr@users.sf.net>

Thanks for the changes, this looks good to me now.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

I will queue this for the sunxi/master.

Cheers,
Andre

> ---
> 
> Changes in v2:
> - Add qirk to eMMC configuration of same machine
> 
>  configs/A20-OLinuXino_MICRO-eMMC_defconfig | 1 +
>  configs/A20-OLinuXino_MICRO_defconfig      | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/configs/A20-OLinuXino_MICRO-eMMC_defconfig b/configs/A20-OLinuXino_MICRO-eMMC_defconfig
> index ca5869f43d..2f26b0ca01 100644
> --- a/configs/A20-OLinuXino_MICRO-eMMC_defconfig
> +++ b/configs/A20-OLinuXino_MICRO-eMMC_defconfig
> @@ -20,6 +20,7 @@ CONFIG_ETH_DESIGNWARE=y
>  CONFIG_MII=y
>  CONFIG_SUN7I_GMAC=y
>  CONFIG_SUN7I_GMAC_FORCE_TXERR=y
> +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y
>  CONFIG_AXP_ALDO3_VOLT=2800
>  CONFIG_AXP_ALDO4_VOLT=2800
>  CONFIG_SCSI=y
> diff --git a/configs/A20-OLinuXino_MICRO_defconfig b/configs/A20-OLinuXino_MICRO_defconfig
> index db4270f9b2..673ab85c8a 100644
> --- a/configs/A20-OLinuXino_MICRO_defconfig
> +++ b/configs/A20-OLinuXino_MICRO_defconfig
> @@ -20,6 +20,7 @@ CONFIG_ETH_DESIGNWARE=y
>  CONFIG_MII=y
>  CONFIG_SUN7I_GMAC=y
>  CONFIG_SUN7I_GMAC_FORCE_TXERR=y
> +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y
>  CONFIG_AXP_ALDO3_VOLT=2800
>  CONFIG_AXP_ALDO4_VOLT=2800
>  CONFIG_SCSI=y


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-11 23:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-11 20:52 [PATCH v2] arm: sunxi: Reduce inrush current on Olimex A20-OLinuXino_MICRO configs Philippe Coval
2024-02-11 23:43 ` Andre Przywara

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.