From: Francesco Dolcini <francesco@dolcini.it>
To: Roger Quadros <rogerq@kernel.org>
Cc: Andrejs Cainikovs <andrejs.cainikovs@gmail.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
Sjoerd Simons <sjoerd@collabora.com>,
Andrejs Cainikovs <andrejs.cainikovs@toradex.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Bin Liu [EP]" <b-liu@ti.com>,
"Gunasekaran, Ravi" <r-gunasekaran@ti.com>
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62-main: disable usb lpm
Date: Mon, 12 Feb 2024 13:54:02 +0100 [thread overview]
Message-ID: <20240212125402.GA5043@francesco-nb> (raw)
In-Reply-To: <2629cd30-23aa-4f03-8452-ae13297fd6b6@kernel.org>
Hello Roger,
On Mon, Feb 12, 2024 at 02:13:56PM +0200, Roger Quadros wrote:
> On 09/02/2024 15:02, Andrejs Cainikovs wrote:
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index 464b7565d085..c49fbce5cb70 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -663,6 +665,8 @@ usb1: usb@31100000 {
> > interrupt-names = "host", "peripheral";
> > maximum-speed = "high-speed";
> > dr_mode = "otg";
> > + snps,usb2-gadget-lpm-disable;
> > + snps,usb2-lpm-disable;
>
> Instead of this could you please check if this series fixes the issue for you?
> https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/
Isn't this change correct despite whatever the test results on that
change are going to be? The manual is pretty adamant on LPM not being
supported by the AM62 SoC.
Francesco
WARNING: multiple messages have this Message-ID (diff)
From: Francesco Dolcini <francesco@dolcini.it>
To: Roger Quadros <rogerq@kernel.org>
Cc: Andrejs Cainikovs <andrejs.cainikovs@gmail.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
Sjoerd Simons <sjoerd@collabora.com>,
Andrejs Cainikovs <andrejs.cainikovs@toradex.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Bin Liu [EP]" <b-liu@ti.com>,
"Gunasekaran, Ravi" <r-gunasekaran@ti.com>
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62-main: disable usb lpm
Date: Mon, 12 Feb 2024 13:54:02 +0100 [thread overview]
Message-ID: <20240212125402.GA5043@francesco-nb> (raw)
In-Reply-To: <2629cd30-23aa-4f03-8452-ae13297fd6b6@kernel.org>
Hello Roger,
On Mon, Feb 12, 2024 at 02:13:56PM +0200, Roger Quadros wrote:
> On 09/02/2024 15:02, Andrejs Cainikovs wrote:
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index 464b7565d085..c49fbce5cb70 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -663,6 +665,8 @@ usb1: usb@31100000 {
> > interrupt-names = "host", "peripheral";
> > maximum-speed = "high-speed";
> > dr_mode = "otg";
> > + snps,usb2-gadget-lpm-disable;
> > + snps,usb2-lpm-disable;
>
> Instead of this could you please check if this series fixes the issue for you?
> https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/
Isn't this change correct despite whatever the test results on that
change are going to be? The manual is pretty adamant on LPM not being
supported by the AM62 SoC.
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-12 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 13:02 [PATCH v1] arm64: dts: ti: k3-am62-main: disable usb lpm Andrejs Cainikovs
2024-02-09 13:02 ` Andrejs Cainikovs
2024-02-12 12:13 ` Roger Quadros
2024-02-12 12:13 ` Roger Quadros
2024-02-12 12:54 ` Francesco Dolcini [this message]
2024-02-12 12:54 ` Francesco Dolcini
2024-02-13 11:34 ` Roger Quadros
2024-02-13 11:34 ` Roger Quadros
2024-02-14 9:46 ` Andrejs Cainikovs
2024-02-14 9:46 ` Andrejs Cainikovs
2024-02-13 11:43 ` Francesco Dolcini
2024-02-13 11:43 ` Francesco Dolcini
2024-02-14 9:25 ` Roger Quadros
2024-02-14 9:25 ` Roger Quadros
2024-02-15 9:45 ` Vignesh Raghavendra
2024-02-15 9:45 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212125402.GA5043@francesco-nb \
--to=francesco@dolcini.it \
--cc=a-govindraju@ti.com \
--cc=andrejs.cainikovs@gmail.com \
--cc=andrejs.cainikovs@toradex.com \
--cc=b-liu@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=r-gunasekaran@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=sjoerd@collabora.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.