All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Mihai Sain <mihai.sain@microchip.com>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
	linux-kernel@vger.kernel.org, andre.przywara@arm.com,
	conor+dt@kernel.org, claudiu.beznea@tuxon.dev,
	robh+dt@kernel.org, cristian.birsan@microchip.com,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node
Date: Wed, 14 Feb 2024 17:54:26 +0000	[thread overview]
Message-ID: <20240214-robe-pregnancy-a1b056c9fe14@spud> (raw)
In-Reply-To: <20240214080348.7540-3-mihai.sain@microchip.com>


[-- Attachment #1.1: Type: text/plain, Size: 1672 bytes --]

On Wed, Feb 14, 2024 at 10:03:47AM +0200, Mihai Sain wrote:
> Add flexcom 10 node for usage on the SAMA7G54 Curiosity board.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>  arch/arm/boot/dts/microchip/sama7g5.dtsi | 26 ++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> index 269e0a3ca269..c90e404e8ed9 100644
> --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> @@ -958,6 +958,32 @@ i2c9: i2c@600 {
>  			};
>  		};
>  
> +		flx10: flexcom@e2820000 {
> +			compatible = "atmel,sama5d2-flexcom";
> +			reg = <0xe2820000 0x200>;

This is a sama7g5, how come this flexcom is using a sama5d2 compatible?

Cheers,
Conor.

> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 48>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0x0 0xe2820000 0x800>;
> +			status = "disabled";
> +
> +			i2c10: i2c@600 {
> +				compatible = "microchip,sama7g5-i2c", "microchip,sam9x60-i2c";
> +				reg = <0x600 0x200>;
> +				interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				clocks = <&pmc PMC_TYPE_PERIPHERAL 48>;
> +				atmel,fifo-size = <32>;
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(25)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(26)>;
> +				dma-names = "rx", "tx";
> +				atmel,use-dma-rx;
> +				atmel,use-dma-tx;
> +				status = "disabled";
> +			};
> +		};
> +
>  		flx11: flexcom@e2824000 {
>  			compatible = "atmel,sama5d2-flexcom";
>  			reg = <0xe2824000 0x200>;
> -- 
> 2.43.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Mihai Sain <mihai.sain@microchip.com>
Cc: claudiu.beznea@tuxon.dev, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
	andre.przywara@arm.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, cristian.birsan@microchip.com
Subject: Re: [PATCH v2 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node
Date: Wed, 14 Feb 2024 17:54:26 +0000	[thread overview]
Message-ID: <20240214-robe-pregnancy-a1b056c9fe14@spud> (raw)
In-Reply-To: <20240214080348.7540-3-mihai.sain@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

On Wed, Feb 14, 2024 at 10:03:47AM +0200, Mihai Sain wrote:
> Add flexcom 10 node for usage on the SAMA7G54 Curiosity board.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>  arch/arm/boot/dts/microchip/sama7g5.dtsi | 26 ++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> index 269e0a3ca269..c90e404e8ed9 100644
> --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> @@ -958,6 +958,32 @@ i2c9: i2c@600 {
>  			};
>  		};
>  
> +		flx10: flexcom@e2820000 {
> +			compatible = "atmel,sama5d2-flexcom";
> +			reg = <0xe2820000 0x200>;

This is a sama7g5, how come this flexcom is using a sama5d2 compatible?

Cheers,
Conor.

> +			clocks = <&pmc PMC_TYPE_PERIPHERAL 48>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0x0 0xe2820000 0x800>;
> +			status = "disabled";
> +
> +			i2c10: i2c@600 {
> +				compatible = "microchip,sama7g5-i2c", "microchip,sam9x60-i2c";
> +				reg = <0x600 0x200>;
> +				interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				clocks = <&pmc PMC_TYPE_PERIPHERAL 48>;
> +				atmel,fifo-size = <32>;
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(25)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(26)>;
> +				dma-names = "rx", "tx";
> +				atmel,use-dma-rx;
> +				atmel,use-dma-tx;
> +				status = "disabled";
> +			};
> +		};
> +
>  		flx11: flexcom@e2824000 {
>  			compatible = "atmel,sama5d2-flexcom";
>  			reg = <0xe2824000 0x200>;
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-02-14 17:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14  8:03 [PATCH v2 0/3] Add initial support for Microchip SAMA7G54 Curiosity board Mihai Sain
2024-02-14  8:03 ` Mihai Sain
2024-02-14  8:03 ` [PATCH v2 1/3] dt-bindings: ARM: at91: Document Microchip SAMA7G54 Curiosity Mihai Sain
2024-02-14  8:03   ` Mihai Sain
2024-02-14  8:03 ` [PATCH v2 2/3] ARM: dts: microchip: sama7g5: Add flexcom 10 node Mihai Sain
2024-02-14  8:03   ` Mihai Sain
2024-02-14 17:54   ` Conor Dooley [this message]
2024-02-14 17:54     ` Conor Dooley
2024-02-15  7:19   ` claudiu beznea
2024-02-15  7:19     ` claudiu beznea
2024-02-14  8:03 ` [PATCH v2 3/3] ARM: dts: microchip: sama7g54_curiosity: Add initial device tree of the board Mihai Sain
2024-02-14  8:03   ` Mihai Sain
2024-02-15  7:23   ` claudiu beznea
2024-02-15  7:23     ` claudiu beznea
2024-02-15  7:25   ` claudiu beznea
2024-02-15  7:25     ` claudiu beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240214-robe-pregnancy-a1b056c9fe14@spud \
    --to=conor@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andre.przywara@arm.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=cristian.birsan@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.sain@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.