All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS
@ 2024-02-14 22:45 Mark O'Donovan
  2024-02-19  7:21 ` Chris Clayton
  0 siblings, 1 reply; 4+ messages in thread
From: Mark O'Donovan @ 2024-02-14 22:45 UTC (permalink / raw)
  To: linux-kernel; +Cc: ntfs3, almaz.alexandrovich, Mark O'Donovan

When CONFIG_NTFS3_LZX_XPRESS is not set then we get the following:
fs/ntfs3/frecord.c:2460:16: error: unused variable ‘i_size’

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
---
 fs/ntfs3/frecord.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index 3b42938a9d3b..7f27382e0ce2 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -2457,7 +2457,6 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
 	struct ATTR_LIST_ENTRY *le = NULL;
 	struct runs_tree *run = &ni->file.run;
 	u64 valid_size = ni->i_valid;
-	loff_t i_size = i_size_read(&ni->vfs_inode);
 	u64 vbo_disk;
 	size_t unc_size;
 	u32 frame_size, i, npages_disk, ondisk_size;
@@ -2509,6 +2508,7 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
 		err = -EOPNOTSUPP;
 		goto out1;
 #else
+		loff_t i_size = i_size_read(&ni->vfs_inode);
 		u32 frame_bits = ni_ext_compress_bits(ni);
 		u64 frame64 = frame_vbo >> frame_bits;
 		u64 frames, vbo_data;

base-commit: 7e90b5c295ec1e47c8ad865429f046970c549a66
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS
  2024-02-14 22:45 [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS Mark O'Donovan
@ 2024-02-19  7:21 ` Chris Clayton
  2024-02-21  8:27   ` Chris Clayton
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Clayton @ 2024-02-19  7:21 UTC (permalink / raw)
  To: Mark O'Donovan, linux-kernel; +Cc: ntfs3, almaz.alexandrovich

Hi.

On 14/02/2024 22:45, Mark O'Donovan wrote:
> When CONFIG_NTFS3_LZX_XPRESS is not set then we get the following:
> fs/ntfs3/frecord.c:2460:16: error: unused variable ‘i_size’
> 
> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
> ---
>  fs/ntfs3/frecord.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
> index 3b42938a9d3b..7f27382e0ce2 100644
> --- a/fs/ntfs3/frecord.c
> +++ b/fs/ntfs3/frecord.c
> @@ -2457,7 +2457,6 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>  	struct ATTR_LIST_ENTRY *le = NULL;
>  	struct runs_tree *run = &ni->file.run;
>  	u64 valid_size = ni->i_valid;
> -	loff_t i_size = i_size_read(&ni->vfs_inode);
>  	u64 vbo_disk;
>  	size_t unc_size;
>  	u32 frame_size, i, npages_disk, ondisk_size;
> @@ -2509,6 +2508,7 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>  		err = -EOPNOTSUPP;
>  		goto out1;
>  #else
> +		loff_t i_size = i_size_read(&ni->vfs_inode);
>  		u32 frame_bits = ni_ext_compress_bits(ni);
>  		u64 frame64 = frame_vbo >> frame_bits;
>  		u64 frames, vbo_data;
> 
> base-commit: 7e90b5c295ec1e47c8ad865429f046970c549a66

Mark - Thanks for the patch.
Alex - Fixes a build bug introduced by 4fd6c08a16d7f1ba10212c9ef7bc73218144b463.

Tested-by: Chris Clayton <chris2553@googlemail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS
  2024-02-19  7:21 ` Chris Clayton
@ 2024-02-21  8:27   ` Chris Clayton
  2024-02-21  9:23     ` Thorsten Leemhuis
  0 siblings, 1 reply; 4+ messages in thread
From: Chris Clayton @ 2024-02-21  8:27 UTC (permalink / raw)
  To: Mark O'Donovan, linux-kernel; +Cc: ntfs3, almaz.alexandrovich, regressions

Hi

This build regression also shows up, along with other problems, in a report to the ntfs3 list by the kernel test robot.[1]

Also, as this patch seems not to have been picked up by the NTFS3 maintainer I've added Thorsten Leemhuis so he can
consider adding this egression to the tracker.

[1] https://lore.kernel.org/ntfs3/202402211322.4GbTCzp8-lkp@intel.com/T/#u

Chris



On 19/02/2024 07:21, Chris Clayton wrote:
> Hi.
> 
> On 14/02/2024 22:45, Mark O'Donovan wrote:
>> When CONFIG_NTFS3_LZX_XPRESS is not set then we get the following:
>> fs/ntfs3/frecord.c:2460:16: error: unused variable ‘i_size’
>>
>> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
>> ---
>>  fs/ntfs3/frecord.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
>> index 3b42938a9d3b..7f27382e0ce2 100644
>> --- a/fs/ntfs3/frecord.c
>> +++ b/fs/ntfs3/frecord.c
>> @@ -2457,7 +2457,6 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>>  	struct ATTR_LIST_ENTRY *le = NULL;
>>  	struct runs_tree *run = &ni->file.run;
>>  	u64 valid_size = ni->i_valid;
>> -	loff_t i_size = i_size_read(&ni->vfs_inode);
>>  	u64 vbo_disk;
>>  	size_t unc_size;
>>  	u32 frame_size, i, npages_disk, ondisk_size;
>> @@ -2509,6 +2508,7 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>>  		err = -EOPNOTSUPP;
>>  		goto out1;
>>  #else
>> +		loff_t i_size = i_size_read(&ni->vfs_inode);
>>  		u32 frame_bits = ni_ext_compress_bits(ni);
>>  		u64 frame64 = frame_vbo >> frame_bits;
>>  		u64 frames, vbo_data;
>>
>> base-commit: 7e90b5c295ec1e47c8ad865429f046970c549a66
> 
> Mark - Thanks for the patch.
> Alex - Fixes a build bug introduced by 4fd6c08a16d7f1ba10212c9ef7bc73218144b463.
> 
> Tested-by: Chris Clayton <chris2553@googlemail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS
  2024-02-21  8:27   ` Chris Clayton
@ 2024-02-21  9:23     ` Thorsten Leemhuis
  0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Leemhuis @ 2024-02-21  9:23 UTC (permalink / raw)
  To: Chris Clayton, Mark O'Donovan, linux-kernel
  Cc: ntfs3, almaz.alexandrovich

On 21.02.24 09:27, Chris Clayton wrote:
> 
> This build regression also shows up, along with other problems, in a
> report to the ntfs3 list by the kernel test robot.[1]
> 
> Also, as this patch seems not to have been picked up by the NTFS3
> maintainer I've added Thorsten Leemhuis so he can consider adding
> this egression to the tracker.

You mistyped my email address, but I noticed this by chance. :-D

Mark, could you do me a favor and send a v2 that picked up the Tested-by
and includes a Fixes: tag for the commit causing it? Then in case
Konstantin doesn't pick this up any time soon I'll ask Linus to pick
this up straight from the list.

Ciao, Thorsten

> [1]
> https://lore.kernel.org/ntfs3/202402211322.4GbTCzp8-lkp@intel.com/T/#u>
> Chris>
> On 19/02/2024 07:21, Chris Clayton wrote:
>> Hi.
>>
>> On 14/02/2024 22:45, Mark O'Donovan wrote:
>>> When CONFIG_NTFS3_LZX_XPRESS is not set then we get the following:
>>> fs/ntfs3/frecord.c:2460:16: error: unused variable ‘i_size’
>>>
>>> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
>>> ---
>>>  fs/ntfs3/frecord.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
>>> index 3b42938a9d3b..7f27382e0ce2 100644
>>> --- a/fs/ntfs3/frecord.c
>>> +++ b/fs/ntfs3/frecord.c
>>> @@ -2457,7 +2457,6 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>>>  	struct ATTR_LIST_ENTRY *le = NULL;
>>>  	struct runs_tree *run = &ni->file.run;
>>>  	u64 valid_size = ni->i_valid;
>>> -	loff_t i_size = i_size_read(&ni->vfs_inode);
>>>  	u64 vbo_disk;
>>>  	size_t unc_size;
>>>  	u32 frame_size, i, npages_disk, ondisk_size;
>>> @@ -2509,6 +2508,7 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>>>  		err = -EOPNOTSUPP;
>>>  		goto out1;
>>>  #else
>>> +		loff_t i_size = i_size_read(&ni->vfs_inode);
>>>  		u32 frame_bits = ni_ext_compress_bits(ni);
>>>  		u64 frame64 = frame_vbo >> frame_bits;
>>>  		u64 frames, vbo_data;
>>>
>>> base-commit: 7e90b5c295ec1e47c8ad865429f046970c549a66
>>
>> Mark - Thanks for the patch.
>> Alex - Fixes a build bug introduced by 4fd6c08a16d7f1ba10212c9ef7bc73218144b463.
>>
>> Tested-by: Chris Clayton <chris2553@googlemail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-21  9:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-14 22:45 [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS Mark O'Donovan
2024-02-19  7:21 ` Chris Clayton
2024-02-21  8:27   ` Chris Clayton
2024-02-21  9:23     ` Thorsten Leemhuis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.