* [failures] mm-hugetlb-ensure-adequate-cma-areas-available-for-hugetlb_cma.patch removed from -mm tree
@ 2024-02-16 1:31 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2024-02-16 1:31 UTC (permalink / raw)
To: mm-commits, muchun.song, anshuman.khandual, akpm
The quilt patch titled
Subject: mm/hugetlb: ensure adequate CMA areas available for hugetlb_cma[]
has been removed from the -mm tree. Its filename was
mm-hugetlb-ensure-adequate-cma-areas-available-for-hugetlb_cma.patch
This patch was dropped because it had testing failures
------------------------------------------------------
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: mm/hugetlb: ensure adequate CMA areas available for hugetlb_cma[]
Date: Thu, 15 Feb 2024 10:04:05 +0530
HugeTLB CMA area array is being created for possible MAX_NUMNODES without
ensuring corresponding MAX_CMA_AREAS support in CMA. This fails the build
for such scenarios indicating need for CONFIG_CMA_AREAS adjustment.
Link: https://lkml.kernel.org/r/20240215043405.2379295-1-anshuman.khandual@arm.com
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Muchun Song <muchun.song@linux.dev>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/hugetlb.c | 7 +++++++
1 file changed, 7 insertions(+)
--- a/mm/hugetlb.c~mm-hugetlb-ensure-adequate-cma-areas-available-for-hugetlb_cma
+++ a/mm/hugetlb.c
@@ -7855,6 +7855,13 @@ void __init hugetlb_cma_reserve(int orde
}
reserved = 0;
+
+ /*
+ * There needs to be enough MAX_CMA_AREAS to accommodate
+ * MAX_NUMNODES heap areas being created here. Otherwise
+ * adjust CONFIG_CMA_AREAS as required.
+ */
+ BUILD_BUG_ON(MAX_CMA_AREAS < MAX_NUMNODES);
for_each_online_node(nid) {
int res;
char name[CMA_MAX_NAME];
_
Patches currently in -mm which might be from anshuman.khandual@arm.com are
mm-memblock-add-memblock_rsrv_noinit-into-flagname-array.patch
mm-cma-dont-treat-bad-input-arguments-for-cma_alloc-as-its-failure.patch
mm-cma-drop-config_cma_debug.patch
mm-cma-make-max_cma_areas-=-config_cma_areas.patch
mm-cma-add-sysfs-file-release_pages_success.patch
mm-hugetlb-move-page-order-check-inside-hugetlb_cma_reserve.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-16 1:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-16 1:31 [failures] mm-hugetlb-ensure-adequate-cma-areas-available-for-hugetlb_cma.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.