* [PATCH i-g-t] tests/kms_atomic: fix musl compilation
@ 2024-03-04 16:43 Kamil Konieczny
2024-03-04 21:33 ` ✓ CI.xeBAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kamil Konieczny @ 2024-03-04 16:43 UTC (permalink / raw)
To: igt-dev; +Cc: Kamil Konieczny
On musl there is already defined PAGE_SIZE and it is casing
compilation error:
../tests/kms_atomic.c: In function 'crtc_invalid_params_fence'
../tests/kms_atomic.c:893:25: error: expected identifier or '(' before numeric constant
893 | const ptrdiff_t PAGE_SIZE = sysconf(_SC_PAGE_SIZE);
Change this variable name in order to fix it.
Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/138
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
tests/kms_atomic.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 96cd58571..489b0d709 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -890,7 +890,7 @@ static void crtc_invalid_params_fence(data_t *data, igt_output_t *output)
{
int timeline, fence_fd;
void *map;
- const ptrdiff_t PAGE_SIZE = sysconf(_SC_PAGE_SIZE);
+ const ptrdiff_t page_size = sysconf(_SC_PAGE_SIZE);
uint64_t old_mode_id = data->pipe->values[IGT_CRTC_MODE_ID];
igt_require_sw_sync();
@@ -898,28 +898,28 @@ static void crtc_invalid_params_fence(data_t *data, igt_output_t *output)
timeline = sw_sync_timeline_create();
/* invalid out_fence_ptr */
- map = mmap(NULL, PAGE_SIZE, PROT_READ, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
+ map = mmap(NULL, page_size, PROT_READ, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
igt_assert(map != MAP_FAILED);
igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
- munmap(map, PAGE_SIZE);
+ munmap(map, page_size);
/* invalid out_fence_ptr */
- map = mmap(NULL, PAGE_SIZE, PROT_EXEC, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
+ map = mmap(NULL, page_size, PROT_EXEC, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
igt_assert(map != MAP_FAILED);
igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
- munmap(map, PAGE_SIZE);
+ munmap(map, page_size);
/* invalid out_fence_ptr */
- map = mmap(NULL, PAGE_SIZE, PROT_NONE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
+ map = mmap(NULL, page_size, PROT_NONE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
igt_assert(map != MAP_FAILED);
igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
- munmap(map, PAGE_SIZE);
+ munmap(map, page_size);
/* valid in fence but not allowed prop on crtc */
fence_fd = sw_sync_timeline_create_fence(timeline, 1);
--
2.42.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ CI.xeBAT: success for tests/kms_atomic: fix musl compilation
2024-03-04 16:43 [PATCH i-g-t] tests/kms_atomic: fix musl compilation Kamil Konieczny
@ 2024-03-04 21:33 ` Patchwork
2024-03-04 22:01 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-05 12:44 ` [PATCH i-g-t] " Juha-Pekka Heikkila
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2024-03-04 21:33 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
== Series Details ==
Series: tests/kms_atomic: fix musl compilation
URL : https://patchwork.freedesktop.org/series/130682/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7745_BAT -> XEIGTPW_10772_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Changes
-------
No changes found
Build changes
-------------
* IGT: IGT_7745 -> IGTPW_10772
* Linux: xe-890-1636103d7fa7ca9dedb181d611cd214af79b04d1 -> xe-892-e8bc216572501440efb20e112bb5aa60599f1863
IGTPW_10772: 10772
IGT_7745: 838ad56bf511c1caf56851c661fb5828c0440e3b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-890-1636103d7fa7ca9dedb181d611cd214af79b04d1: 1636103d7fa7ca9dedb181d611cd214af79b04d1
xe-892-e8bc216572501440efb20e112bb5aa60599f1863: e8bc216572501440efb20e112bb5aa60599f1863
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10772/index.html
[-- Attachment #2: Type: text/html, Size: 1617 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for tests/kms_atomic: fix musl compilation
2024-03-04 16:43 [PATCH i-g-t] tests/kms_atomic: fix musl compilation Kamil Konieczny
2024-03-04 21:33 ` ✓ CI.xeBAT: success for " Patchwork
@ 2024-03-04 22:01 ` Patchwork
2024-03-05 13:59 ` Kamil Konieczny
2024-03-05 12:44 ` [PATCH i-g-t] " Juha-Pekka Heikkila
2 siblings, 1 reply; 5+ messages in thread
From: Patchwork @ 2024-03-04 22:01 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5520 bytes --]
== Series Details ==
Series: tests/kms_atomic: fix musl compilation
URL : https://patchwork.freedesktop.org/series/130682/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14382 -> IGTPW_10772
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_10772 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10772, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/index.html
Participating hosts (41 -> 37)
------------------------------
Missing (4): fi-cfl-8109u bat-jsl-1 fi-snb-2520m bat-arls-3
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_10772:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@client:
- bat-dg2-8: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14382/bat-dg2-8/igt@i915_selftest@live@client.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/bat-dg2-8/igt@i915_selftest@live@client.html
* igt@kms_pm_rpm@basic-pci-d3-state:
- bat-dg2-11: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14382/bat-dg2-11/igt@kms_pm_rpm@basic-pci-d3-state.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/bat-dg2-11/igt@kms_pm_rpm@basic-pci-d3-state.html
Known issues
------------
Here are the changes found in IGTPW_10772 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- fi-tgl-1115g4: NOTRUN -> [SKIP][5] ([i915#9318])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html
* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][6] ([i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([i915#4613]) +3 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][8] ([i915#4103]) +1 other test skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_dsc@dsc-basic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][9] ([i915#3555] / [i915#3840])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@kms_dsc@dsc-basic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([fdo#109285])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#9812])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr@psr-sprite-plane-onoff:
- fi-tgl-1115g4: NOTRUN -> [SKIP][12] ([i915#9732]) +3 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@kms_psr@psr-sprite-plane-onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([i915#3555])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {bat-rpls-3}: [DMESG-WARN][14] ([i915#5591]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14382/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
[i915#9812]: https://gitlab.freedesktop.org/drm/intel/issues/9812
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7745 -> IGTPW_10772
CI-20190529: 20190529
CI_DRM_14382: e8bc216572501440efb20e112bb5aa60599f1863 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10772: 10772
IGT_7745: 838ad56bf511c1caf56851c661fb5828c0440e3b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/index.html
[-- Attachment #2: Type: text/html, Size: 6509 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH i-g-t] tests/kms_atomic: fix musl compilation
2024-03-04 16:43 [PATCH i-g-t] tests/kms_atomic: fix musl compilation Kamil Konieczny
2024-03-04 21:33 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-04 22:01 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2024-03-05 12:44 ` Juha-Pekka Heikkila
2 siblings, 0 replies; 5+ messages in thread
From: Juha-Pekka Heikkila @ 2024-03-05 12:44 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 4.3.2024 18.43, Kamil Konieczny wrote:
> On musl there is already defined PAGE_SIZE and it is casing
> compilation error:
>
> ../tests/kms_atomic.c: In function 'crtc_invalid_params_fence'
> ../tests/kms_atomic.c:893:25: error: expected identifier or '(' before numeric constant
> 893 | const ptrdiff_t PAGE_SIZE = sysconf(_SC_PAGE_SIZE);
>
> Change this variable name in order to fix it.
>
> Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/138
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/kms_atomic.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index 96cd58571..489b0d709 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -890,7 +890,7 @@ static void crtc_invalid_params_fence(data_t *data, igt_output_t *output)
> {
> int timeline, fence_fd;
> void *map;
> - const ptrdiff_t PAGE_SIZE = sysconf(_SC_PAGE_SIZE);
> + const ptrdiff_t page_size = sysconf(_SC_PAGE_SIZE);
> uint64_t old_mode_id = data->pipe->values[IGT_CRTC_MODE_ID];
>
> igt_require_sw_sync();
> @@ -898,28 +898,28 @@ static void crtc_invalid_params_fence(data_t *data, igt_output_t *output)
> timeline = sw_sync_timeline_create();
>
> /* invalid out_fence_ptr */
> - map = mmap(NULL, PAGE_SIZE, PROT_READ, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> + map = mmap(NULL, page_size, PROT_READ, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> igt_assert(map != MAP_FAILED);
>
> igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
> crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
> - munmap(map, PAGE_SIZE);
> + munmap(map, page_size);
>
> /* invalid out_fence_ptr */
> - map = mmap(NULL, PAGE_SIZE, PROT_EXEC, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> + map = mmap(NULL, page_size, PROT_EXEC, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> igt_assert(map != MAP_FAILED);
>
> igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
> crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
> - munmap(map, PAGE_SIZE);
> + munmap(map, page_size);
>
> /* invalid out_fence_ptr */
> - map = mmap(NULL, PAGE_SIZE, PROT_NONE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> + map = mmap(NULL, page_size, PROT_NONE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> igt_assert(map != MAP_FAILED);
>
> igt_pipe_obj_set_prop_value(data->pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)map);
> crtc_commit_atomic_err(data->pipe, data->primary, ATOMIC_RELAX_NONE, EFAULT);
> - munmap(map, PAGE_SIZE);
> + munmap(map, page_size);
>
> /* valid in fence but not allowed prop on crtc */
> fence_fd = sw_sync_timeline_create_fence(timeline, 1);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for tests/kms_atomic: fix musl compilation
2024-03-04 22:01 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2024-03-05 13:59 ` Kamil Konieczny
0 siblings, 0 replies; 5+ messages in thread
From: Kamil Konieczny @ 2024-03-05 13:59 UTC (permalink / raw)
To: igt-dev
Hi igt-dev,
On 2024-03-04 at 22:01:55 -0000, Patchwork wrote:
> == Series Details ==
>
> Series: tests/kms_atomic: fix musl compilation
> URL : https://patchwork.freedesktop.org/series/130682/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_14382 -> IGTPW_10772
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with IGTPW_10772 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in IGTPW_10772, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/index.html
>
> Participating hosts (41 -> 37)
> ------------------------------
>
> Missing (4): fi-cfl-8109u bat-jsl-1 fi-snb-2520m bat-arls-3
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in IGTPW_10772:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live@client:
> - bat-dg2-8: [PASS][1] -> [ABORT][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14382/bat-dg2-8/igt@i915_selftest@live@client.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/bat-dg2-8/igt@i915_selftest@live@client.html
>
> * igt@kms_pm_rpm@basic-pci-d3-state:
> - bat-dg2-11: [PASS][3] -> [ABORT][4]
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14382/bat-dg2-11/igt@kms_pm_rpm@basic-pci-d3-state.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/bat-dg2-11/igt@kms_pm_rpm@basic-pci-d3-state.html
>
This is unrelated to change in kms_atomic,
Regards,
Kamil
>
> Known issues
> ------------
>
> Here are the changes found in IGTPW_10772 that come from known issues:
>
> ### IGT changes ###
>
...cut...
>
>
> #### Possible fixes ####
>
> * igt@i915_selftest@live@hangcheck:
> - {bat-rpls-3}: [DMESG-WARN][14] ([i915#5591]) -> [PASS][15]
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14382/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/bat-rpls-3/igt@i915_selftest@live@hangcheck.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
> [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
> [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
> [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
> [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
> [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
> [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
> [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
> [i915#9732]: https://gitlab.freedesktop.org/drm/intel/issues/9732
> [i915#9812]: https://gitlab.freedesktop.org/drm/intel/issues/9812
>
>
> Build changes
> -------------
>
> * CI: CI-20190529 -> None
> * IGT: IGT_7745 -> IGTPW_10772
>
> CI-20190529: 20190529
> CI_DRM_14382: e8bc216572501440efb20e112bb5aa60599f1863 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGTPW_10772: 10772
> IGT_7745: 838ad56bf511c1caf56851c661fb5828c0440e3b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10772/index.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-05 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-04 16:43 [PATCH i-g-t] tests/kms_atomic: fix musl compilation Kamil Konieczny
2024-03-04 21:33 ` ✓ CI.xeBAT: success for " Patchwork
2024-03-04 22:01 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-05 13:59 ` Kamil Konieczny
2024-03-05 12:44 ` [PATCH i-g-t] " Juha-Pekka Heikkila
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.