[Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

[Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

[Jeremy J. Peper]

bump to latest version because previous version did not work with python 3.11
corrected version mismatch with my first submission

Signed-off-by: Jeremy J. Peper <jeremy@jeremypeper.com>
---
 package/targetcli-fb/targetcli-fb.hash | 2 +-
 package/targetcli-fb/targetcli-fb.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/targetcli-fb/targetcli-fb.hash b/package/targetcli-fb/targetcli-fb.hash
index 64f68a66..1732fa99 100644
--- a/package/targetcli-fb/targetcli-fb.hash
+++ b/package/targetcli-fb/targetcli-fb.hash
@@ -1,3 +1,3 @@
 # locally computed
-sha256  7ae4120a54f24b13263b4b85c43952a03546f8b9fc9bd15fe87678f68245a33f  targetcli-fb-2.1.54.tar.gz
+sha256  605f4e4e4e7189d6a03f11a4f55e7ddb4671002d542c2f684f87dd68391dcdc2  targetcli-fb-2.1.58.tar.gz
 sha256  5df2a0d87d6c562f0ea11c688ac52532aa28d744cabc7994ff0537f64b3b3320  COPYING
diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
index 2d375417..8cdcc6f6 100644
--- a/package/targetcli-fb/targetcli-fb.mk
+++ b/package/targetcli-fb/targetcli-fb.mk
@@ -6,7 +6,7 @@
 
 # When upgrading the version, be sure to also upgrade python-rtslib-fb
 # and python-configshell-fb at the same time.
-TARGETCLI_FB_VERSION = 2.1.54
+TARGETCLI_FB_VERSION = 2.1.58
 TARGETCLI_FB_SITE = $(call github,open-iscsi,targetcli-fb,v$(TARGETCLI_FB_VERSION))
 TARGETCLI_FB_LICENSE = Apache-2.0
 TARGETCLI_FB_LICENSE_FILES = COPYING
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/3] package/python-configshell-fb: bump version to 1.1.30

[Jeremy J. Peper]

bump to latest version because previous version did not work with python 3.11

Signed-off-by: Jeremy J. Peper <jeremy@jeremypeper.com>
---
 package/python-configshell-fb/python-configshell-fb.hash | 2 +-
 package/python-configshell-fb/python-configshell-fb.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/python-configshell-fb/python-configshell-fb.hash b/package/python-configshell-fb/python-configshell-fb.hash
index 8fc38f61..e0905010 100644
--- a/package/python-configshell-fb/python-configshell-fb.hash
+++ b/package/python-configshell-fb/python-configshell-fb.hash
@@ -1,3 +1,3 @@
 # locally computed
-sha256  24b47284b463dcfb9ee0c1558827e13442127e62fa279b6e0253f136cf49058c  python-configshell-fb-1.1.29.tar.gz
+sha256  44696b92bea2b44c1d0bf2828477dddeb3b4dfb312ad82ce06d7b704c0985e27  python-configshell-fb-1.1.30.tar.gz
 sha256  5df2a0d87d6c562f0ea11c688ac52532aa28d744cabc7994ff0537f64b3b3320  COPYING
diff --git a/package/python-configshell-fb/python-configshell-fb.mk b/package/python-configshell-fb/python-configshell-fb.mk
index d0dd421e..3446a86e 100644
--- a/package/python-configshell-fb/python-configshell-fb.mk
+++ b/package/python-configshell-fb/python-configshell-fb.mk
@@ -6,7 +6,7 @@
 
 # When upgrading the version, be sure to also upgrade python-rtslib-fb
 # and targetcli-fb at the same time.
-PYTHON_CONFIGSHELL_FB_VERSION = 1.1.29
+PYTHON_CONFIGSHELL_FB_VERSION = 1.1.30
 PYTHON_CONFIGSHELL_FB_SITE = $(call github,open-iscsi,configshell-fb,v$(PYTHON_CONFIGSHELL_FB_VERSION))
 PYTHON_CONFIGSHELL_FB_LICENSE = Apache-2.0
 PYTHON_CONFIGSHELL_FB_LICENSE_FILES = COPYING
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/3] package/python-configshell-fb: bump version to 1.1.30

[Peter Korsgaard]

>>>>> "Jeremy" == Jeremy J Peper <jeremy@jeremypeper.com> writes:

 > bump to latest version because previous version did not work with python 3.11
 > Signed-off-by: Jeremy J. Peper <jeremy@jeremypeper.com>

Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 3/3] package/python-rtslib-fb: 2.1.76

[Jeremy J. Peper]

bump to latest version because previous version did not work with python 3.11

Signed-off-by: Jeremy J. Peper <jeremy@jeremypeper.com>
---
 package/python-rtslib-fb/python-rtslib-fb.hash | 2 +-
 package/python-rtslib-fb/python-rtslib-fb.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/python-rtslib-fb/python-rtslib-fb.hash b/package/python-rtslib-fb/python-rtslib-fb.hash
index 3c2e39ff..39c390ed 100644
--- a/package/python-rtslib-fb/python-rtslib-fb.hash
+++ b/package/python-rtslib-fb/python-rtslib-fb.hash
@@ -1,3 +1,3 @@
 # locally computed
-sha256  9f581c4bcffebc60be236af8a6ebdeccdb66d0435eeb04ab1b743c170b95d046  python-rtslib-fb-2.1.74.tar.gz
+sha256  ac15c113d09209c7b0d14d94a12ed88205a7c2feadd1096f573049fd737f7e74  python-rtslib-fb-2.1.76.tar.gz
 sha256  5df2a0d87d6c562f0ea11c688ac52532aa28d744cabc7994ff0537f64b3b3320  COPYING
diff --git a/package/python-rtslib-fb/python-rtslib-fb.mk b/package/python-rtslib-fb/python-rtslib-fb.mk
index 09bde874..6396d26a 100644
--- a/package/python-rtslib-fb/python-rtslib-fb.mk
+++ b/package/python-rtslib-fb/python-rtslib-fb.mk
@@ -6,7 +6,7 @@
 
 # When upgrading the version, be sure to also upgrade
 # python-configshell-fb and targetcli-fb at the same time.
-PYTHON_RTSLIB_FB_VERSION = 2.1.74
+PYTHON_RTSLIB_FB_VERSION = 2.1.76
 # Do not switch site to PyPI: it does not contain the latest version.
 PYTHON_RTSLIB_FB_SITE = $(call github,open-iscsi,rtslib-fb,v$(PYTHON_RTSLIB_FB_VERSION))
 PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 3/3] package/python-rtslib-fb: 2.1.76

[Peter Korsgaard]

>>>>> "Jeremy" == Jeremy J Peper <jeremy@jeremypeper.com> writes:

 > bump to latest version because previous version did not work with python 3.11
 > Signed-off-by: Jeremy J. Peper <jeremy@jeremypeper.com>

Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

[Arnout Vandecappelle via buildroot]

  Hi Jeremy,

On 12/03/2024 20:35, Jeremy J. Peper wrote:
> bump to latest version because previous version did not work with python 3.11
> corrected version mismatch with my first submission

  I unfortunately already pushed before I noticed: you shouldn't include 
"personal comments" or references to the patch history in the commit message 
itself - that belongs under the --- line. So it should have been:

package/targetcli-fb: bump version to 2.1.58

Bump to latest version because previous version did not work with python 3.11

Signed-off-by: ...
---
v2: correct version mismatch




  And another thing: we've had Python 3.11 for more than a year, so this has 
been broken for quite some time. To make sure we notice in the future, it would 
be good to have a runtime test that detects the situation.

  Regards,
  Arnout

> 
> Signed-off-by: Jeremy J. Peper <jeremy@jeremypeper.com>
> ---
>   package/targetcli-fb/targetcli-fb.hash | 2 +-
>   package/targetcli-fb/targetcli-fb.mk   | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/targetcli-fb/targetcli-fb.hash b/package/targetcli-fb/targetcli-fb.hash
> index 64f68a66..1732fa99 100644
> --- a/package/targetcli-fb/targetcli-fb.hash
> +++ b/package/targetcli-fb/targetcli-fb.hash
> @@ -1,3 +1,3 @@
>   # locally computed
> -sha256  7ae4120a54f24b13263b4b85c43952a03546f8b9fc9bd15fe87678f68245a33f  targetcli-fb-2.1.54.tar.gz
> +sha256  605f4e4e4e7189d6a03f11a4f55e7ddb4671002d542c2f684f87dd68391dcdc2  targetcli-fb-2.1.58.tar.gz
>   sha256  5df2a0d87d6c562f0ea11c688ac52532aa28d744cabc7994ff0537f64b3b3320  COPYING
> diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
> index 2d375417..8cdcc6f6 100644
> --- a/package/targetcli-fb/targetcli-fb.mk
> +++ b/package/targetcli-fb/targetcli-fb.mk
> @@ -6,7 +6,7 @@
>   
>   # When upgrading the version, be sure to also upgrade python-rtslib-fb
>   # and python-configshell-fb at the same time.
> -TARGETCLI_FB_VERSION = 2.1.54
> +TARGETCLI_FB_VERSION = 2.1.58
>   TARGETCLI_FB_SITE = $(call github,open-iscsi,targetcli-fb,v$(TARGETCLI_FB_VERSION))
>   TARGETCLI_FB_LICENSE = Apache-2.0
>   TARGETCLI_FB_LICENSE_FILES = COPYING
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

[Jeremy J. Peper]

On Friday, March 15, 2024 3:31:09 PM CDT Arnout Vandecappelle wrote:
>   Hi Jeremy,
> 
> On 12/03/2024 20:35, Jeremy J. Peper wrote:
> > bump to latest version because previous version did not work with python
> > 3.11 corrected version mismatch with my first submission
> 
>   I unfortunately already pushed before I noticed: you shouldn't include
> "personal comments" or references to the patch history in the commit message
> itself - that belongs under the --- line. So it should have been:
> 
> package/targetcli-fb: bump version to 2.1.58
> 
> Bump to latest version because previous version did not work with python
> 3.11
> 
> Signed-off-by: ...
> ---
> v2: correct version mismatch

Sorry about that, I will endeavour to do that properly in the future. 

> 
>   And another thing: we've had Python 3.11 for more than a year, so this has
> been broken for quite some time. To make sure we notice in the future, it
> would be good to have a runtime test that detects the situation.
> 
>   Regards,
>   Arnout

I believe you are correct, it appears to have been broken for at least the 
past few stable releases. 

Adding the test sounds like a good idea and I'd be interested in setting that 
up at some point but I'm not sure when I'll get a chance to work through that 
learning curve. 

> > Signed-off-by: Jeremy J. Peper <jeremy@jeremypeper.com>
> > ---
> > 
> >   package/targetcli-fb/targetcli-fb.hash | 2 +-
> >   package/targetcli-fb/targetcli-fb.mk   | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/targetcli-fb/targetcli-fb.hash
> > b/package/targetcli-fb/targetcli-fb.hash index 64f68a66..1732fa99 100644
> > --- a/package/targetcli-fb/targetcli-fb.hash
> > +++ b/package/targetcli-fb/targetcli-fb.hash
> > @@ -1,3 +1,3 @@
> > 
> >   # locally computed
> > 
> > -sha256  7ae4120a54f24b13263b4b85c43952a03546f8b9fc9bd15fe87678f68245a33f 
> > targetcli-fb-2.1.54.tar.gz +sha256 
> > 605f4e4e4e7189d6a03f11a4f55e7ddb4671002d542c2f684f87dd68391dcdc2 
> > targetcli-fb-2.1.58.tar.gz> 
> >   sha256  5df2a0d87d6c562f0ea11c688ac52532aa28d744cabc7994ff0537f64b3b3320
> >    COPYING> 
> > diff --git a/package/targetcli-fb/targetcli-fb.mk
> > b/package/targetcli-fb/targetcli-fb.mk index 2d375417..8cdcc6f6 100644
> > --- a/package/targetcli-fb/targetcli-fb.mk
> > +++ b/package/targetcli-fb/targetcli-fb.mk
> > @@ -6,7 +6,7 @@
> > 
> >   # When upgrading the version, be sure to also upgrade python-rtslib-fb
> >   # and python-configshell-fb at the same time.
> > 
> > -TARGETCLI_FB_VERSION = 2.1.54
> > +TARGETCLI_FB_VERSION = 2.1.58
> > 
> >   TARGETCLI_FB_SITE = $(call
> >   github,open-iscsi,targetcli-fb,v$(TARGETCLI_FB_VERSION))
> >   TARGETCLI_FB_LICENSE = Apache-2.0
> >   TARGETCLI_FB_LICENSE_FILES = COPYING

Are there any other changes that I need to make before this is suitable to be 
committed? 

Thanks again for all your feedback and guidance.
-Jeremy




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

[Arnout Vandecappelle via buildroot]

On 15/03/2024 23:21, Jeremy J. Peper wrote:
> On Friday, March 15, 2024 3:31:09 PM CDT Arnout Vandecappelle wrote:
>>    Hi Jeremy,
>>
>> On 12/03/2024 20:35, Jeremy J. Peper wrote:
>>> bump to latest version because previous version did not work with python
>>> 3.11 corrected version mismatch with my first submission
>>
>>    I unfortunately already pushed before I noticed: you shouldn't include
>> "personal comments" or references to the patch history in the commit message
>> itself - that belongs under the --- line. So it should have been:
>>
>> package/targetcli-fb: bump version to 2.1.58
>>
>> Bump to latest version because previous version did not work with python
>> 3.11
>>
>> Signed-off-by: ...
>> ---
>> v2: correct version mismatch
> 
> Sorry about that, I will endeavour to do that properly in the future.

  No worries. I made this comment so you could learn.


>>    And another thing: we've had Python 3.11 for more than a year, so this has
>> been broken for quite some time. To make sure we notice in the future, it
>> would be good to have a runtime test that detects the situation.
>>
>>    Regards,
>>    Arnout
> 
> I believe you are correct, it appears to have been broken for at least the
> past few stable releases.
> 
> Adding the test sounds like a good idea and I'd be interested in setting that
> up at some point but I'm not sure when I'll get a chance to work through that
> learning curve.

  For a Python package, the test is usually quite simple: just import it, and if 
there's a C library linked with it, make sure you make a call into the C 
library. See e.g. support/testing/tests/package/test_python_click.py

  A slightly more complicated test can import a Python script to do the actual 
test. See e.g. support/testing/tests/package/test_python_gnupg.py which runs 
support/testing/tests/package/sample_python_gnupg.py

[snip]
> Are there any other changes that I need to make before this is suitable to be
> committed?

  I apparently didn't make my self clear enough: it is already committed (that's 
why I said "I already pushed"). In fact, the entire series is committed.


  Regards,
  Arnout

> 
> Thanks again for all your feedback and guidance.
> -Jeremy
> 
> 
> 
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

[Jeremy J. Peper]

On Saturday, March 16, 2024 2:21:35 PM CDT Arnout Vandecappelle wrote:
> On 15/03/2024 23:21, Jeremy J. Peper wrote:
> > On Friday, March 15, 2024 3:31:09 PM CDT Arnout Vandecappelle wrote:
> >>    Hi Jeremy,
> >> 
> >> On 12/03/2024 20:35, Jeremy J. Peper wrote:
> >>> bump to latest version because previous version did not work with python
> >>> 3.11 corrected version mismatch with my first submission
> >>> 
> >>    I unfortunately already pushed before I noticed: you shouldn't include
> >> 
> >> "personal comments" or references to the patch history in the commit
> >> message itself - that belongs under the --- line. So it should have
> >> been:
> >> 
> >> package/targetcli-fb: bump version to 2.1.58
> >> 
> >> Bump to latest version because previous version did not work with python
> >> 3.11
> >> 
> >> Signed-off-by: ...
> >> ---
> >> v2: correct version mismatch
> > 
> > Sorry about that, I will endeavour to do that properly in the future.
> 
>   No worries. I made this comment so you could learn.
> 
> >>    And another thing: we've had Python 3.11 for more than a year, so this
> >>    has
> >> 
> >> been broken for quite some time. To make sure we notice in the future, it
> >> would be good to have a runtime test that detects the situation.
> >> 
> >>    Regards,
> >>    Arnout
> > 
> > I believe you are correct, it appears to have been broken for at least the
> > past few stable releases.
> > 
> > Adding the test sounds like a good idea and I'd be interested in setting
> > that up at some point but I'm not sure when I'll get a chance to work
> > through that learning curve.
> 
>   For a Python package, the test is usually quite simple: just import it,
> and if there's a C library linked with it, make sure you make a call into
> the C library. See e.g. support/testing/tests/package/test_python_click.py
> 
>   A slightly more complicated test can import a Python script to do the
> actual test. See e.g. support/testing/tests/package/test_python_gnupg.py
> which runs support/testing/tests/package/sample_python_gnupg.py
> 
> [snip]
> 
> > Are there any other changes that I need to make before this is suitable to
> > be committed?
> 
>   I apparently didn't make my self clear enough: it is already committed
> (that's why I said "I already pushed"). In fact, the entire series is
> committed.
> 
> 
>   Regards,
>   Arnout
> 
> > Thanks again for all your feedback and guidance.
> > -Jeremy

Excellent, is it possible to get this fix added to the next release of 
2024.02.x ?



_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] package/targetcli-fb: bump version to 2.1.58

[Peter Korsgaard]

>>>>> "Jeremy" == Jeremy J Peper <jeremy@jeremypeper.com> writes:

 >> > Thanks again for all your feedback and guidance.
 >> > -Jeremy

 > Excellent, is it possible to get this fix added to the next release of 
 > 2024.02.x ?

Yes, committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks - It will
be part of the upcoming 2024.02.1 release.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot