* [merged mm-nonmm-stable] assoc_array-fix-the-return-value-in-assoc_array_insert_mid_shortcut.patch removed from -mm tree
@ 2024-03-12 20:09 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2024-03-12 20:09 UTC (permalink / raw)
To: mm-commits, s.shtylyov, r.smirnov, akpm
The quilt patch titled
Subject: assoc_array: fix the return value in assoc_array_insert_mid_shortcut()
has been removed from the -mm tree. Its filename was
assoc_array-fix-the-return-value-in-assoc_array_insert_mid_shortcut.patch
This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Roman Smirnov <r.smirnov@omp.ru>
Subject: assoc_array: fix the return value in assoc_array_insert_mid_shortcut()
Date: Thu, 7 Mar 2024 10:17:17 +0300
Returning the edit variable is redundant because it is dereferenced right
before it is returned. It would be better to return true.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Link: https://lkml.kernel.org/r/20240307071717.5318-1-r.smirnov@omp.ru
Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/assoc_array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/assoc_array.c~assoc_array-fix-the-return-value-in-assoc_array_insert_mid_shortcut
+++ a/lib/assoc_array.c
@@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_short
edit->leaf_p = &new_n0->slots[0];
pr_devel("<--%s() = ok [split shortcut]\n", __func__);
- return edit;
+ return true;
}
/**
_
Patches currently in -mm which might be from r.smirnov@omp.ru are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-12 20:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-12 20:09 [merged mm-nonmm-stable] assoc_array-fix-the-return-value-in-assoc_array_insert_mid_shortcut.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.