* [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside.
@ 2024-03-18 6:04 Yufeng Wang
2024-03-18 8:26 ` Denis Efremov
0 siblings, 1 reply; 4+ messages in thread
From: Yufeng Wang @ 2024-03-18 6:04 UTC (permalink / raw)
To: Denis Efremov, Jens Axboe, linux-block, linux-kernel
Cc: inux-kernel, Yufeng Wang, stable
Cc: stable@vger.kernel.org
Signed-off-by: Yufeng Wang <wangyufeng@kylinos.cn>
---
drivers/block/floppy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 1b399ec8c07d..25c9d85667f1 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
pending = set_next_request();
spin_unlock_irq(&floppy_lock);
if (!pending) {
- do_floppy = NULL;
unlock_fdc();
return;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside.
2024-03-18 6:04 [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside Yufeng Wang
@ 2024-03-18 8:26 ` Denis Efremov
0 siblings, 0 replies; 4+ messages in thread
From: Denis Efremov @ 2024-03-18 8:26 UTC (permalink / raw)
To: Yufeng Wang, Jens Axboe, linux-block, linux-kernel; +Cc: inux-kernel, stable
Hello,
On 3/18/24 10:04, Yufeng Wang wrote:
> Cc: stable@vger.kernel.org
> Signed-off-by: Yufeng Wang <wangyufeng@kylinos.cn>
> ---
> drivers/block/floppy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 1b399ec8c07d..25c9d85667f1 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
> pending = set_next_request();
> spin_unlock_irq(&floppy_lock);
> if (!pending) {
> - do_floppy = NULL;
> unlock_fdc();
> return;
> }
I'll answer to the 2nd email.
Thanks,
Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside.
2024-03-18 6:07 Yufeng Wang
@ 2024-03-18 8:34 ` Denis Efremov
0 siblings, 0 replies; 4+ messages in thread
From: Denis Efremov @ 2024-03-18 8:34 UTC (permalink / raw)
To: Yufeng Wang, Jens Axboe, linux-block, linux-kernel; +Cc: stable
Hello,
Please, add a small commit message to the patch. The commit title
is too long and can be reduced to something like "floppy: remove duplicated
code in redo_fd_request()". Rest can be added to the commit message.
On 3/18/24 10:07, Yufeng Wang wrote:
> Cc: stable@vger.kernel.org
We don't need to send this patch to stable. It's not a bugfix.
Please, send v2 with commit message and new title.
The change looks good to me.
> Signed-off-by: Yufeng Wang <wangyufeng@kylinos.cn>
> ---
> drivers/block/floppy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 1b399ec8c07d..25c9d85667f1 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
> pending = set_next_request();
> spin_unlock_irq(&floppy_lock);
> if (!pending) {
> - do_floppy = NULL;
> unlock_fdc();
> return;
> }
Thanks,
Denis
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside.
@ 2024-03-18 6:07 Yufeng Wang
2024-03-18 8:34 ` Denis Efremov
0 siblings, 1 reply; 4+ messages in thread
From: Yufeng Wang @ 2024-03-18 6:07 UTC (permalink / raw)
To: Denis Efremov, Jens Axboe, linux-block, linux-kernel; +Cc: Yufeng Wang, stable
Cc: stable@vger.kernel.org
Signed-off-by: Yufeng Wang <wangyufeng@kylinos.cn>
---
drivers/block/floppy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 1b399ec8c07d..25c9d85667f1 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -2787,7 +2787,6 @@ static void redo_fd_request(void)
pending = set_next_request();
spin_unlock_irq(&floppy_lock);
if (!pending) {
- do_floppy = NULL;
unlock_fdc();
return;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-18 8:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-18 6:04 [PATCH] floppy: remove duplicated code, unlock_fdc() function has the same code "do_floppy = NULL" inside Yufeng Wang
2024-03-18 8:26 ` Denis Efremov
2024-03-18 6:07 Yufeng Wang
2024-03-18 8:34 ` Denis Efremov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.