All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] tty: serial: sc16is7xx: convert to use maple tree register cache
@ 2024-03-18  6:42 wangkaiyuan
  2024-03-18 10:28 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: wangkaiyuan @ 2024-03-18  6:42 UTC (permalink / raw)
  To: gregkh, jirislaby, hvilleneuve, andriy.shevchenko
  Cc: linux-kernel, linux-serial, wangkaiyuan

The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.

Signed-off-by: wangkaiyuan <wangkaiyuan@inspur.com>
---
 drivers/tty/serial/sc16is7xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 929206a9a6e1..410b772cdbb3 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1696,7 +1696,7 @@ static struct regmap_config regcfg = {
 	.reg_bits = 5,
 	.pad_bits = 3,
 	.val_bits = 8,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_MAPLE,
 	.volatile_reg = sc16is7xx_regmap_volatile,
 	.precious_reg = sc16is7xx_regmap_precious,
 	.writeable_noinc_reg = sc16is7xx_regmap_noinc,
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] tty: serial: sc16is7xx: convert to use maple tree register cache
  2024-03-18  6:42 [PATCH 2/2] tty: serial: sc16is7xx: convert to use maple tree register cache wangkaiyuan
@ 2024-03-18 10:28 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2024-03-18 10:28 UTC (permalink / raw)
  To: wangkaiyuan; +Cc: gregkh, jirislaby, hvilleneuve, linux-kernel, linux-serial

On Mon, Mar 18, 2024 at 02:42:16PM +0800, wangkaiyuan wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.

Okay,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-18 10:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-18  6:42 [PATCH 2/2] tty: serial: sc16is7xx: convert to use maple tree register cache wangkaiyuan
2024-03-18 10:28 ` Andy Shevchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.