* [PATCH] ocfs2: update inode ctime in ocfs2_fileattr_set
@ 2024-03-18 11:56 Su Yue
2024-03-19 1:43 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: Su Yue @ 2024-03-18 11:56 UTC (permalink / raw)
To: ocfs2-devel; +Cc: joseph.qi, Su Yue
From: Su Yue <glass.su@suse.com>
inode ctime should be updated if ocfs2_fileattr_set is called.
Signed-off-by: Su Yue <glass.su@suse.com>
---
fs/ocfs2/ioctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index b1550ba73f96..71beef7f8a60 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -125,6 +125,7 @@ int ocfs2_fileattr_set(struct mnt_idmap *idmap,
ocfs2_inode->ip_attr = flags;
ocfs2_set_inode_flags(inode);
+ inode_set_ctime_current(inode);
status = ocfs2_mark_inode_dirty(handle, inode, bh);
if (status < 0)
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ocfs2: update inode ctime in ocfs2_fileattr_set
2024-03-18 11:56 [PATCH] ocfs2: update inode ctime in ocfs2_fileattr_set Su Yue
@ 2024-03-19 1:43 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2024-03-19 1:43 UTC (permalink / raw)
To: Su Yue, akpm; +Cc: ocfs2-devel
On 3/18/24 7:56 PM, Su Yue wrote:
> From: Su Yue <glass.su@suse.com>
>
> inode ctime should be updated if ocfs2_fileattr_set is called.
>
> Signed-off-by: Su Yue <glass.su@suse.com>
Looks fine.
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/ioctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
> index b1550ba73f96..71beef7f8a60 100644
> --- a/fs/ocfs2/ioctl.c
> +++ b/fs/ocfs2/ioctl.c
> @@ -125,6 +125,7 @@ int ocfs2_fileattr_set(struct mnt_idmap *idmap,
>
> ocfs2_inode->ip_attr = flags;
> ocfs2_set_inode_flags(inode);
> + inode_set_ctime_current(inode);
>
> status = ocfs2_mark_inode_dirty(handle, inode, bh);
> if (status < 0)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-19 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-18 11:56 [PATCH] ocfs2: update inode ctime in ocfs2_fileattr_set Su Yue
2024-03-19 1:43 ` Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.