[PATCH] spi: lm70llp: fix links in doc

[PATCH] spi: lm70llp: fix links in doc

[Kousik Sanagavarapu]

Update links in the documentation which point to the datasheet and
schematic.

The current links don't work because National Semiconductor (which is
the manufacturer of this board and lm70) has been a part of Texas
Instruments since 2011 and hence http://www.national.com/ doesn't work
anymore.

Fixes: 78961a574037 ("spi_lm70llp parport adapter driver")
Fixes: 2b7300513b98 ("hwmon: (lm70) Code streamlining and cleanup")
Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
I didn't find the schematic link's TI website equivalent anywhere.  The
board (not lm70) also doesn't seem to be manufactured anymore.  So just
in case someone is still using it...

 Documentation/spi/spi-lm70llp.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/spi/spi-lm70llp.rst b/Documentation/spi/spi-lm70llp.rst
index 2f20e5b405e6..ff98ddc76a74 100644
--- a/Documentation/spi/spi-lm70llp.rst
+++ b/Documentation/spi/spi-lm70llp.rst
@@ -6,7 +6,7 @@ Supported board/chip:
 
   * National Semiconductor LM70 LLP evaluation board
 
-    Datasheet: http://www.national.com/pf/LM/LM70.html
+    Datasheet: https://www.ti.com/lit/gpn/lm70
 
 Author:
         Kaiwan N Billimoria <kaiwan@designergraphix.com>
@@ -28,7 +28,7 @@ Hardware Interfacing
 The schematic for this particular board (the LM70EVAL-LLP) is
 available (on page 4) here:
 
-  http://www.national.com/appinfo/tempsensors/files/LM70LLPEVALmanual.pdf
+  https://download.datasheets.com/pdfs/documentation/nat/kit&board/lm70llpevalmanual.pdf
 
 The hardware interfacing on the LM70 LLP eval board is as follows:
 
-- 
2.44.0.273.g4bc5b65358.dirty

[PATCH v2 0/2] lm70 and lm70llp doc link fixes

[Kousik Sanagavarapu]

Fix links from the documentation and in-code comments pointing to
datasheets.

Changes since v1:
- I forgot to fix the links in in-code comments in spi, so do that.
- New commit to address the same issues in hwmon/lm70 since the spi eval board
  is based on that.

Sorry for the noise from v1.

Kousik Sanagavarapu (2):
  spi: lm70llp: fix links in doc and comments
  hwmon: lm70: fix links in doc and comments

 Documentation/hwmon/lm70.rst      | 2 +-
 Documentation/spi/spi-lm70llp.rst | 4 ++--
 drivers/hwmon/lm70.c              | 4 ++--
 drivers/spi/spi-lm70llp.c         | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.44.0.273.g4bc5b65358.dirty

[PATCH v2 1/2] spi: lm70llp: fix links in doc and comments

[Kousik Sanagavarapu]

Update links in the documentation and in-code comments which point to
the datasheet and schematic.

The current links don't work because National Semiconductor (which is
the manufacturer of this board and lm70) has been a part of Texas
Instruments since 2011 and hence http://www.national.com/ doesn't work
anymore.

Fixes: 78961a574037 ("spi_lm70llp parport adapter driver")
Fixes: 2b7300513b98 ("hwmon: (lm70) Code streamlining and cleanup")
Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
 Documentation/spi/spi-lm70llp.rst | 4 ++--
 drivers/spi/spi-lm70llp.c         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/spi/spi-lm70llp.rst b/Documentation/spi/spi-lm70llp.rst
index 2f20e5b405e6..ff98ddc76a74 100644
--- a/Documentation/spi/spi-lm70llp.rst
+++ b/Documentation/spi/spi-lm70llp.rst
@@ -6,7 +6,7 @@ Supported board/chip:
 
   * National Semiconductor LM70 LLP evaluation board
 
-    Datasheet: http://www.national.com/pf/LM/LM70.html
+    Datasheet: https://www.ti.com/lit/gpn/lm70
 
 Author:
         Kaiwan N Billimoria <kaiwan@designergraphix.com>
@@ -28,7 +28,7 @@ Hardware Interfacing
 The schematic for this particular board (the LM70EVAL-LLP) is
 available (on page 4) here:
 
-  http://www.national.com/appinfo/tempsensors/files/LM70LLPEVALmanual.pdf
+  https://download.datasheets.com/pdfs/documentation/nat/kit&board/lm70llpevalmanual.pdf
 
 The hardware interfacing on the LM70 LLP eval board is as follows:
 
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index f982bdebd028..3c0c24ed1f3d 100644
--- a/drivers/spi/spi-lm70llp.c
+++ b/drivers/spi/spi-lm70llp.c
@@ -29,10 +29,10 @@
  *
  * Datasheet and Schematic:
  * The LM70 is a temperature sensor chip from National Semiconductor; its
- * datasheet is available at http://www.national.com/pf/LM/LM70.html
+ * datasheet is available at https://www.ti.com/lit/gpn/lm70
  * The schematic for this particular board (the LM70EVAL-LLP) is
  * available (on page 4) here:
- *  http://www.national.com/appinfo/tempsensors/files/LM70LLPEVALmanual.pdf
+ *  https://download.datasheets.com/pdfs/documentation/nat/kit&board/lm70llpevalmanual.pdf
  *
  * Also see Documentation/spi/spi-lm70llp.rst.  The SPI<->parport code here is
  * (heavily) based on spi-butterfly by David Brownell.
-- 
2.44.0.273.g4bc5b65358.dirty

[PATCH v2 2/2] hwmon: lm70: fix links in doc and comments

[Kousik Sanagavarapu]

Update links in the documentation and in-code comments which point to
the datasheet.

The current links don't work because National Semiconductor (which is
the manufacturer of this board and lm70) has been a part of Texas
Instruments since 2011 and hence http://www.national.com/ doesn't work
anymore.

Fixes: e1a8e913f97e ("[PATCH] lm70: New hardware monitoring driver")
Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
 Documentation/hwmon/lm70.rst | 2 +-
 drivers/hwmon/lm70.c         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/hwmon/lm70.rst b/Documentation/hwmon/lm70.rst
index 11303a7e16a8..02ed60dddffb 100644
--- a/Documentation/hwmon/lm70.rst
+++ b/Documentation/hwmon/lm70.rst
@@ -5,7 +5,7 @@ Supported chips:
 
   * National Semiconductor LM70
 
-    Datasheet: http://www.national.com/pf/LM/LM70.html
+    Datasheet: https://www.ti.com/product/LM70
 
   * Texas Instruments TMP121/TMP123
 
diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
index c20a749fc7f2..481e4e1f8f4f 100644
--- a/drivers/hwmon/lm70.c
+++ b/drivers/hwmon/lm70.c
@@ -6,9 +6,9 @@
  * Copyright (C) 2006 Kaiwan N Billimoria <kaiwan@designergraphix.com>
  *
  * The LM70 communicates with a host processor via an SPI/Microwire Bus
- * interface. The complete datasheet is available at National's website
+ * interface. The complete datasheet is available at TI's website
  * here:
- * http://www.national.com/pf/LM/LM70.html
+ * https://www.ti.com/product/LM70
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-- 
2.44.0.273.g4bc5b65358.dirty

Re: (subset) [PATCH v2 0/2] lm70 and lm70llp doc link fixes

[Mark Brown]

On Mon, 18 Mar 2024 21:08:33 +0530, Kousik Sanagavarapu wrote:
> Fix links from the documentation and in-code comments pointing to
> datasheets.
> 
> Changes since v1:
> - I forgot to fix the links in in-code comments in spi, so do that.
> - New commit to address the same issues in hwmon/lm70 since the spi eval board
>   is based on that.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/2] spi: lm70llp: fix links in doc and comments
      commit: 7397175cb7b48f7a3fc699083aa46f1234904c7e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH v2 2/2] hwmon: lm70: fix links in doc and comments

[Guenter Roeck]

On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
> Update links in the documentation and in-code comments which point to
> the datasheet.
> 
> The current links don't work because National Semiconductor (which is
> the manufacturer of this board and lm70) has been a part of Texas
                      ^^^^^^^^^^

Is this a leftover from the other patch ? The lm70 driver supports
the LM70 chip, not a specific board.

Guenter

Re: [PATCH v2 2/2] hwmon: lm70: fix links in doc and comments

[Kousik Sanagavarapu]

On Mon, Mar 18, 2024 at 11:11:29AM -0700, Guenter Roeck wrote:
> On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
> > Update links in the documentation and in-code comments which point to
> > the datasheet.
> > 
> > The current links don't work because National Semiconductor (which is
> > the manufacturer of this board and lm70) has been a part of Texas
>                       ^^^^^^^^^^
> 
> Is this a leftover from the other patch ? The lm70 driver supports
> the LM70 chip, not a specific board.

Yeah, it should be "the manufacturer of lm70".  Thanks for spotting.

Should I fix and resend this specific patch as v3 or would you edit it
while pulling?

Re: [PATCH v2 2/2] hwmon: lm70: fix links in doc and comments

[Guenter Roeck]

On 3/18/24 11:29, Kousik Sanagavarapu wrote:
> On Mon, Mar 18, 2024 at 11:11:29AM -0700, Guenter Roeck wrote:
>> On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
>>> Update links in the documentation and in-code comments which point to
>>> the datasheet.
>>>
>>> The current links don't work because National Semiconductor (which is
>>> the manufacturer of this board and lm70) has been a part of Texas
>>                        ^^^^^^^^^^
>>
>> Is this a leftover from the other patch ? The lm70 driver supports
>> the LM70 chip, not a specific board.
> 
> Yeah, it should be "the manufacturer of lm70".  Thanks for spotting.
> 
> Should I fix and resend this specific patch as v3 or would you edit it
> while pulling?
> 

I'll edit it.

Thanks,
Guenter

Re: [PATCH v2 2/2] hwmon: lm70: fix links in doc and comments

[Guenter Roeck]

On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
> Update links in the documentation and in-code comments which point to
> the datasheet.
> 
> The current links don't work because National Semiconductor (which is
> the manufacturer of this board and lm70) has been a part of Texas
> Instruments since 2011 and hence http://www.national.com/ doesn't work
> anymore.
> 
> Fixes: e1a8e913f97e ("[PATCH] lm70: New hardware monitoring driver")
> Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>

Applied to hwmon-next.

Please note that I'll push the branch after the commit window closed.

Thanks,
Guenter