From: Elad Nachman <enachman@marvell.com>
To: <taras.chornyi@plvision.eu>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<andrew@lunn.ch>, <kory.maincent@bootlin.com>,
<thomas.petazzoni@bootlin.com>, <miquel.raynal@bootlin.com>,
<przemyslaw.kitszel@intel.com>, <dkirjanov@suse.de>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <enachman@marvell.com>
Subject: [PATCH v2 0/5] Fix prestera driver fail to probe twice
Date: Wed, 20 Mar 2024 19:20:03 +0200 [thread overview]
Message-ID: <20240320172008.2989693-1-enachman@marvell.com> (raw)
From: Elad Nachman <enachman@marvell.com>
Fix issues resulting from insmod, rmmod and insmod of the
prestera driver:
1. Call of firmware switch HW reset was missing, and is required
in order to make the firmware loader shift to the correct state
needed for loading the next firmware.
2. Time-out for waiting for firmware loader to be ready was too small.
3. memory referencing after freeing
4. MAC addresses wrapping
5. Missing SFP unbind (phylink release) of a port during the port release.
v2:
1) Split first patch to firmware call for switch HW reset and to
increasing of firmware loader wait to be ready timeout
2) Explain why is switch HW reset call to the firmware required
before shutdown in commit message, and fix wording
3) Use a simpler bitwise-and on the last byte of the base MAC address
instead of randomizing again the entire MAC address.
reflect that change in the commit message, and explain why it is
needed (switch HW implementation requirement).
4) Add Fixes Tags to all commits.
5) For timeout enlargement commit, fix wording in comment and move
timeout units to milliseconds.
6) Add Tested-By tags.
7) Add patch to call prestera_port_sfp_unbind() from
prestera_destroy_ports() in order to release phylink.
Elad Nachman (5):
net: marvell: prestera: fix driver reload
net: marvell: prestera: enlarge fw restart time
net: marvell: prestera: fix memory use after free
net: marvell: prestera: force good base mac
net: marvell: prestera: unbind sfp port on exit
drivers/net/ethernet/marvell/prestera/prestera_hw.c | 8 ++++++++
drivers/net/ethernet/marvell/prestera/prestera_hw.h | 1 +
drivers/net/ethernet/marvell/prestera/prestera_main.c | 5 ++++-
drivers/net/ethernet/marvell/prestera/prestera_pci.c | 7 ++++++-
drivers/net/ethernet/marvell/prestera/prestera_router.c | 1 -
.../net/ethernet/marvell/prestera/prestera_router_hw.c | 1 -
6 files changed, 19 insertions(+), 4 deletions(-)
--
2.25.1
next reply other threads:[~2024-03-20 17:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 17:20 Elad Nachman [this message]
2024-03-20 17:20 ` [PATCH v2 1/5] net: marvell: prestera: fix driver reload Elad Nachman
2024-03-20 22:58 ` Andrew Lunn
2024-03-21 17:22 ` [EXTERNAL] " Elad Nachman
2024-03-20 17:20 ` [PATCH v2 2/5] net: marvell: prestera: enlarge fw restart time Elad Nachman
2024-03-21 0:10 ` Andrew Lunn
2024-03-21 17:24 ` [EXTERNAL] " Elad Nachman
2024-03-20 17:20 ` [PATCH v2 3/5] net: marvell: prestera: fix memory use after free Elad Nachman
2024-03-21 0:14 ` Andrew Lunn
2024-03-20 17:20 ` [PATCH v2 4/5] net: marvell: prestera: force good base mac Elad Nachman
2024-03-21 0:13 ` Andrew Lunn
2024-03-20 17:20 ` [PATCH v2 5/5] net: marvell: prestera: unbind sfp port on exit Elad Nachman
2024-03-21 0:13 ` Andrew Lunn
2024-03-21 0:18 ` [PATCH v2 0/5] Fix prestera driver fail to probe twice Andrew Lunn
2024-03-21 17:33 ` [EXTERNAL] " Elad Nachman
2024-03-21 19:22 ` Andrew Lunn
2024-03-24 7:53 ` Elad Nachman
2024-03-24 15:25 ` Andrew Lunn
2024-03-25 12:45 ` Kory Maincent
2024-03-25 13:04 ` Andrew Lunn
2024-03-27 17:27 ` Elad Nachman
2024-03-21 9:06 ` Kory Maincent
2024-03-21 15:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320172008.2989693-1-enachman@marvell.com \
--to=enachman@marvell.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=edumazet@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=taras.chornyi@plvision.eu \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.