Re: [PATCH v2 0/5] Fix prestera driver fail to probe twice

From: Andrew Lunn <andrew@lunn.ch>
To: Elad Nachman <enachman@marvell.com>
Cc: taras.chornyi@plvision.eu, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	kory.maincent@bootlin.com, thomas.petazzoni@bootlin.com,
	miquel.raynal@bootlin.com, przemyslaw.kitszel@intel.com,
	dkirjanov@suse.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Fix prestera driver fail to probe twice
Date: Thu, 21 Mar 2024 01:18:16 +0100	[thread overview]
Message-ID: <4104387a-d7b5-4029-b822-060ef478c6e3@lunn.ch> (raw)
In-Reply-To: <20240320172008.2989693-1-enachman@marvell.com>

On Wed, Mar 20, 2024 at 07:20:03PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
> 
> Fix issues resulting from insmod, rmmod and insmod of the
> prestera driver:
> 
> 1. Call of firmware switch HW reset was missing, and is required
>    in order to make the firmware loader shift to the correct state
>    needed for loading the next firmware.
> 2. Time-out for waiting for firmware loader to be ready was too small.
> 3. memory referencing after freeing
> 4. MAC addresses wrapping
> 5. Missing SFP unbind (phylink release) of a port during the port release.

I don't see any problems with 3-5. Maybe post them independent of the
first 2 and they can be merged.

Are you really saying it is impossible to determine if the hardware is
in the boot loader waiting for firmware, or is running the firmware?

   Andrew