Re: [PATCH v4 10/11] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO

From: Bhargav Raviprakash <bhargav.r@ltts.com>
To: jpanis@baylibre.com
Cc: arnd@arndb.de, bhargav.r@ltts.com, broonie@kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	eblanc@baylibre.com, gregkh@linuxfoundation.org,
	kristo@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	lee@kernel.org, lgirdwood@gmail.com, linus.walleij@linaro.org,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, nm@ti.com,
	robh+dt@kernel.org, vigneshr@ti.com
Subject: Re: [PATCH v4 10/11] pinctrl: pinctrl-tps6594: Add TPS65224 PMIC pinctrl and GPIO
Date: Fri, 22 Mar 2024 19:40:43 +0530	[thread overview]
Message-ID: <20240322141043.498005-1-bhargav.r@ltts.com> (raw)
In-Reply-To: <b473d940-0301-472d-90f0-297da6815377@baylibre.com>

On Fri, 22 Mar 2024 09:06:13 +0100, Julien Panis wrote:
> On 3/21/24 12:10, Julien Panis wrote:
> > On 3/20/24 11:25, Bhargav Raviprakash wrote:
> >> From: Nirmala Devi Mal Nadar <m.nirmaladevi@ltts.com>
> >>
> >> Add support for TPS65224 pinctrl and GPIOs to TPS6594 driver as they have
> >> significant functional overlap.
> >> TPS65224 PMIC has 6 GPIOS which can be configured as GPIO or other
> >> dedicated device functions.
> >>
> >> Signed-off-by: Nirmala Devi Mal Nadar <m.nirmaladevi@ltts.com>
> >> Signed-off-by: Bhargav Raviprakash <bhargav.r@ltts.com>
> >> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > With this patch, an issue is observed on am62a:
> >
> > root@am62axx-evm:~# dmesg | grep tps
> > ...
> > [   12.122631] tps6594-pinctrl tps6594-pinctrl.2.auto: error -EINVAL: Couldn't register 
> > gpio_regmap driver
> > [   12.133216] tps6594-pinctrl: probe of tps6594-pinctrl.2.auto failed with error -22
> >
> > Without this patch, the issue disappears. Do you observe
> > the same result with your am62p ?
> >
> > Julien Panis
> >
> 
> Hi Barghav.
> 
> I found the issue in your patch.
> 
> In probe function you handle TPS652254 and TPS6594 'switch' cases,
> but you do not handle TPS6593 and LP8764 cases.
> Since AM62A uses a TPS6593, it currently falls in the default case,
> and as a result probe fails.
> 
> Please fix it for v5.
> 
> Julien Panis

Hi Julien,

Thanks for pointing it out.
We added support for TPS6594 alone as mentioned in header description "Pinmux and GPIO driver for tps6594 PMIC". 
TPS6594 and TPS6593 has similar gpio map, however gpio map for LP8764 is different from TPS6594 / TPS6593.

Regards,
Bhargav