Re: [PATCH 1/2] ntfs3: serve as alias for the legacy ntfs driver

From: Christian Brauner <brauner@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	 Anton Altaparmakov <anton@tuxera.com>,
	Namjae Jeon <linkinjeon@kernel.org>,
	ntfs3@lists.linux.dev,  linux-fsdevel@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	 regressions@lists.linux.dev
Subject: Re: [PATCH 1/2] ntfs3: serve as alias for the legacy ntfs driver
Date: Mon, 25 Mar 2024 13:01:51 +0100	[thread overview]
Message-ID: <20240325-waldhaus-fegten-59746baa161d@brauner> (raw)
In-Reply-To: <ZgFNWPCYQC6xYOBX@hovoldconsulting.com>

On Mon, Mar 25, 2024 at 11:09:28AM +0100, Johan Hovold wrote:
> On Mon, Mar 25, 2024 at 09:34:36AM +0100, Christian Brauner wrote:
> > Johan Hovold reported that removing the legacy ntfs driver broke boot
> > for him since his fstab uses the legacy ntfs driver to access firmware
> > from the original Windows partition.
> > 
> > Use ntfs3 as an alias for legacy ntfs if CONFIG_NTFS_FS is selected.
> > This is similar to how ext3 is treated.
> > 
> > Fixes: 7ffa8f3d3023 ("fs: Remove NTFS classic")
> > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> > Cc: Johan Hovold <johan@kernel.org>
> > Link: https://lore.kernel.org/r/Zf2zPf5TO5oYt3I3@hovoldconsulting.com
> > Signed-off-by: Christian Brauner <brauner@kernel.org>
> > ---
> > Hey,
> > 
> > This is so far compile tested. It would be great if someone could test
> > this. @Johan?
> 
> This seems to do the trick. Thanks for the quick fix.
> 
> Tested-by: Johan Hovold <johan+linaro@kernel.org>
> 
> Do we want to do something about the fact that ntfs mounts may now
> become writable as well?

We can enforce that mounting as ntfs means that it's read-only unless rw
support is compiled in most likely. @Anton or other maintainers?