Re: [PATCH 2/2] ntfs3: remove warning

From: Johan Hovold <johan@kernel.org>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: Christian Brauner <brauner@kernel.org>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Anton Altaparmakov <anton@tuxera.com>,
	Namjae Jeon <linkinjeon@kernel.org>,
	ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	linux-ntfs-dev@lists.sourceforge.net,
	regressions@lists.linux.dev
Subject: Re: [PATCH 2/2] ntfs3: remove warning
Date: Thu, 18 Apr 2024 08:36:21 +0200	[thread overview]
Message-ID: <ZiC_ZQcIjM3xv3zT@hovoldconsulting.com> (raw)
In-Reply-To: <015aa42b-abac-4810-8743-43913ab8e2d9@paragon-software.com>

On Wed, Apr 17, 2024 at 07:07:06PM +0300, Konstantin Komarov wrote:
> On 25.03.2024 11:34, Christian Brauner wrote:
> > This causes visible changes for users that rely on ntfs3 to serve as an
> > alternative for the legacy ntfs driver. Print statements such as this
> > should probably be made conditional on a debug config option or similar.

> The initial and true reason for multiple warnings is the disregard of 
> short (DOS) names when counting hard links.
> 
> This patch should fixes this bug:
> https://lore.kernel.org/ntfs3/0cb0b314-e4f6-40a2-9628-0fe7d905a676@paragon-software.com/T/#u

As I just replied in that thread, I'm also seeing link counts being
reduced from 3 to 1, that is, to not just be decremented by one due to
the DOS name bug.

Are you sure there are no further issues here and that the patch is
indeed correct?

I did not test the patch, which is white-space damaged, but if it
addresses also the remaining warnings then the commit message would need
to be updated as well.

Johan