* [PATCH v5 0/1] Add StarFive JH8100 dwmac support
@ 2024-03-27 1:57 ` Tan Chun Hau
0 siblings, 0 replies; 15+ messages in thread
From: Tan Chun Hau @ 2024-03-27 1:57 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Emil Renner Berthing, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Simon Horman, Bartosz Golaszewski,
Andrew Halaney, Jisheng Zhang, Uwe Kleine-König,
Russell King
Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel,
linux-stm32, linux-arm-kernel, linux-riscv
Add StarFive JH8100 dwmac support.
The JH8100 dwmac shares the same driver code as the JH7110 dwmac
and has only one reset signal.
Please refer to below:
JH8100: reset-names = "stmmaceth";
JH7110: reset-names = "stmmaceth", "ahb";
JH7100: reset-names = "ahb";
Example usage of JH8100 in the device tree:
gmac0: ethernet@16030000 {
compatible = "starfive,jh8100-dwmac",
"starfive,jh7110-dwmac",
"snps,dwmac-5.20";
...
};
Changes in v5:
- Addressed duplicated interrupts and interrupt-names.
Tan Chun Hau (1):
dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support
.../devicetree/bindings/net/snps,dwmac.yaml | 1 +
.../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++----
2 files changed, 25 insertions(+), 5 deletions(-)
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH v5 0/1] Add StarFive JH8100 dwmac support @ 2024-03-27 1:57 ` Tan Chun Hau 0 siblings, 0 replies; 15+ messages in thread From: Tan Chun Hau @ 2024-03-27 1:57 UTC (permalink / raw) To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv Add StarFive JH8100 dwmac support. The JH8100 dwmac shares the same driver code as the JH7110 dwmac and has only one reset signal. Please refer to below: JH8100: reset-names = "stmmaceth"; JH7110: reset-names = "stmmaceth", "ahb"; JH7100: reset-names = "ahb"; Example usage of JH8100 in the device tree: gmac0: ethernet@16030000 { compatible = "starfive,jh8100-dwmac", "starfive,jh7110-dwmac", "snps,dwmac-5.20"; ... }; Changes in v5: - Addressed duplicated interrupts and interrupt-names. Tan Chun Hau (1): dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support .../devicetree/bindings/net/snps,dwmac.yaml | 1 + .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- 2 files changed, 25 insertions(+), 5 deletions(-) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v5 0/1] Add StarFive JH8100 dwmac support @ 2024-03-27 1:57 ` Tan Chun Hau 0 siblings, 0 replies; 15+ messages in thread From: Tan Chun Hau @ 2024-03-27 1:57 UTC (permalink / raw) To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv Add StarFive JH8100 dwmac support. The JH8100 dwmac shares the same driver code as the JH7110 dwmac and has only one reset signal. Please refer to below: JH8100: reset-names = "stmmaceth"; JH7110: reset-names = "stmmaceth", "ahb"; JH7100: reset-names = "ahb"; Example usage of JH8100 in the device tree: gmac0: ethernet@16030000 { compatible = "starfive,jh8100-dwmac", "starfive,jh7110-dwmac", "snps,dwmac-5.20"; ... }; Changes in v5: - Addressed duplicated interrupts and interrupt-names. Tan Chun Hau (1): dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support .../devicetree/bindings/net/snps,dwmac.yaml | 1 + .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- 2 files changed, 25 insertions(+), 5 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support 2024-03-27 1:57 ` Tan Chun Hau (?) @ 2024-03-27 1:57 ` Tan Chun Hau -1 siblings, 0 replies; 15+ messages in thread From: Tan Chun Hau @ 2024-03-27 1:57 UTC (permalink / raw) To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv Add StarFive JH8100 dwmac support. The JH8100 dwmac shares the same driver code as the JH7110 dwmac and has only one reset signal. Please refer to below: JH8100: reset-names = "stmmaceth"; JH7110: reset-names = "stmmaceth", "ahb"; JH7100: reset-names = "ahb"; Example usage of JH8100 in the device tree: gmac0: ethernet@16030000 { compatible = "starfive,jh8100-dwmac", "starfive,jh7110-dwmac", "snps,dwmac-5.20"; ... }; Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> --- .../devicetree/bindings/net/snps,dwmac.yaml | 1 + .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 6b0341a8e0ea..a6d596b7dcf4 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -97,6 +97,7 @@ properties: - snps,dwxgmac-2.10 - starfive,jh7100-dwmac - starfive,jh7110-dwmac + - starfive,jh8100-dwmac reg: minItems: 1 diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml index 0d1962980f57..5805a58c55d1 100644 --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml @@ -18,6 +18,7 @@ select: enum: - starfive,jh7100-dwmac - starfive,jh7110-dwmac + - starfive,jh8100-dwmac required: - compatible @@ -30,6 +31,10 @@ properties: - items: - const: starfive,jh7110-dwmac - const: snps,dwmac-5.20 + - items: + - const: starfive,jh8100-dwmac + - const: starfive,jh7110-dwmac + - const: snps,dwmac-5.20 reg: maxItems: 1 @@ -116,11 +121,25 @@ allOf: minItems: 3 maxItems: 3 - resets: - minItems: 2 - - reset-names: - minItems: 2 + if: + properties: + compatible: + contains: + const: starfive,jh8100-dwmac + then: + properties: + resets: + maxItems: 1 + + reset-names: + const: stmmaceth + else: + properties: + resets: + minItems: 2 + + reset-names: + minItems: 2 unevaluatedProperties: false -- 2.25.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-03-27 1:57 ` Tan Chun Hau 0 siblings, 0 replies; 15+ messages in thread From: Tan Chun Hau @ 2024-03-27 1:57 UTC (permalink / raw) To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv Add StarFive JH8100 dwmac support. The JH8100 dwmac shares the same driver code as the JH7110 dwmac and has only one reset signal. Please refer to below: JH8100: reset-names = "stmmaceth"; JH7110: reset-names = "stmmaceth", "ahb"; JH7100: reset-names = "ahb"; Example usage of JH8100 in the device tree: gmac0: ethernet@16030000 { compatible = "starfive,jh8100-dwmac", "starfive,jh7110-dwmac", "snps,dwmac-5.20"; ... }; Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> --- .../devicetree/bindings/net/snps,dwmac.yaml | 1 + .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 6b0341a8e0ea..a6d596b7dcf4 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -97,6 +97,7 @@ properties: - snps,dwxgmac-2.10 - starfive,jh7100-dwmac - starfive,jh7110-dwmac + - starfive,jh8100-dwmac reg: minItems: 1 diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml index 0d1962980f57..5805a58c55d1 100644 --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml @@ -18,6 +18,7 @@ select: enum: - starfive,jh7100-dwmac - starfive,jh7110-dwmac + - starfive,jh8100-dwmac required: - compatible @@ -30,6 +31,10 @@ properties: - items: - const: starfive,jh7110-dwmac - const: snps,dwmac-5.20 + - items: + - const: starfive,jh8100-dwmac + - const: starfive,jh7110-dwmac + - const: snps,dwmac-5.20 reg: maxItems: 1 @@ -116,11 +121,25 @@ allOf: minItems: 3 maxItems: 3 - resets: - minItems: 2 - - reset-names: - minItems: 2 + if: + properties: + compatible: + contains: + const: starfive,jh8100-dwmac + then: + properties: + resets: + maxItems: 1 + + reset-names: + const: stmmaceth + else: + properties: + resets: + minItems: 2 + + reset-names: + minItems: 2 unevaluatedProperties: false -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-03-27 1:57 ` Tan Chun Hau 0 siblings, 0 replies; 15+ messages in thread From: Tan Chun Hau @ 2024-03-27 1:57 UTC (permalink / raw) To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv Add StarFive JH8100 dwmac support. The JH8100 dwmac shares the same driver code as the JH7110 dwmac and has only one reset signal. Please refer to below: JH8100: reset-names = "stmmaceth"; JH7110: reset-names = "stmmaceth", "ahb"; JH7100: reset-names = "ahb"; Example usage of JH8100 in the device tree: gmac0: ethernet@16030000 { compatible = "starfive,jh8100-dwmac", "starfive,jh7110-dwmac", "snps,dwmac-5.20"; ... }; Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> --- .../devicetree/bindings/net/snps,dwmac.yaml | 1 + .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 6b0341a8e0ea..a6d596b7dcf4 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -97,6 +97,7 @@ properties: - snps,dwxgmac-2.10 - starfive,jh7100-dwmac - starfive,jh7110-dwmac + - starfive,jh8100-dwmac reg: minItems: 1 diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml index 0d1962980f57..5805a58c55d1 100644 --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml @@ -18,6 +18,7 @@ select: enum: - starfive,jh7100-dwmac - starfive,jh7110-dwmac + - starfive,jh8100-dwmac required: - compatible @@ -30,6 +31,10 @@ properties: - items: - const: starfive,jh7110-dwmac - const: snps,dwmac-5.20 + - items: + - const: starfive,jh8100-dwmac + - const: starfive,jh7110-dwmac + - const: snps,dwmac-5.20 reg: maxItems: 1 @@ -116,11 +121,25 @@ allOf: minItems: 3 maxItems: 3 - resets: - minItems: 2 - - reset-names: - minItems: 2 + if: + properties: + compatible: + contains: + const: starfive,jh8100-dwmac + then: + properties: + resets: + maxItems: 1 + + reset-names: + const: stmmaceth + else: + properties: + resets: + minItems: 2 + + reset-names: + minItems: 2 unevaluatedProperties: false -- 2.25.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support 2024-03-27 1:57 ` Tan Chun Hau (?) @ 2024-03-27 7:54 ` Krzysztof Kozlowski -1 siblings, 0 replies; 15+ messages in thread From: Krzysztof Kozlowski @ 2024-03-27 7:54 UTC (permalink / raw) To: Tan Chun Hau, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv On 27/03/2024 02:57, Tan Chun Hau wrote: > Add StarFive JH8100 dwmac support. > The JH8100 dwmac shares the same driver code as the JH7110 dwmac > and has only one reset signal. > > Please refer to below: > > JH8100: reset-names = "stmmaceth"; > JH7110: reset-names = "stmmaceth", "ahb"; > JH7100: reset-names = "ahb"; > > Example usage of JH8100 in the device tree: > > gmac0: ethernet@16030000 { > compatible = "starfive,jh8100-dwmac", > "starfive,jh7110-dwmac", > "snps,dwmac-5.20"; > ... > }; > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > 2 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 6b0341a8e0ea..a6d596b7dcf4 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -97,6 +97,7 @@ properties: > - snps,dwxgmac-2.10 > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jh8100-dwmac I think that's not needed. You have there already your fallback. > > reg: > minItems: 1 > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > index 0d1962980f57..5805a58c55d1 100644 > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > @@ -18,6 +18,7 @@ select: > enum: > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jh8100-dwmac Same here, even more obvious. > required: > - compatible > > @@ -30,6 +31,10 @@ properties: > - items: > - const: starfive,jh7110-dwmac > - const: snps,dwmac-5.20 > + - items: > + - const: starfive,jh8100-dwmac > + - const: starfive,jh7110-dwmac > + - const: snps,dwmac-5.20 > > reg: > maxItems: 1 > @@ -116,11 +121,25 @@ allOf: > minItems: 3 > maxItems: 3 > > - resets: > - minItems: 2 > - > - reset-names: > - minItems: 2 > + if: I would personally avoid nesting if within if. It gets unreadable. Although Rob did not comment on this one, so I guess it is fine. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-03-27 7:54 ` Krzysztof Kozlowski 0 siblings, 0 replies; 15+ messages in thread From: Krzysztof Kozlowski @ 2024-03-27 7:54 UTC (permalink / raw) To: Tan Chun Hau, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv On 27/03/2024 02:57, Tan Chun Hau wrote: > Add StarFive JH8100 dwmac support. > The JH8100 dwmac shares the same driver code as the JH7110 dwmac > and has only one reset signal. > > Please refer to below: > > JH8100: reset-names = "stmmaceth"; > JH7110: reset-names = "stmmaceth", "ahb"; > JH7100: reset-names = "ahb"; > > Example usage of JH8100 in the device tree: > > gmac0: ethernet@16030000 { > compatible = "starfive,jh8100-dwmac", > "starfive,jh7110-dwmac", > "snps,dwmac-5.20"; > ... > }; > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > 2 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 6b0341a8e0ea..a6d596b7dcf4 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -97,6 +97,7 @@ properties: > - snps,dwxgmac-2.10 > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jh8100-dwmac I think that's not needed. You have there already your fallback. > > reg: > minItems: 1 > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > index 0d1962980f57..5805a58c55d1 100644 > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > @@ -18,6 +18,7 @@ select: > enum: > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jh8100-dwmac Same here, even more obvious. > required: > - compatible > > @@ -30,6 +31,10 @@ properties: > - items: > - const: starfive,jh7110-dwmac > - const: snps,dwmac-5.20 > + - items: > + - const: starfive,jh8100-dwmac > + - const: starfive,jh7110-dwmac > + - const: snps,dwmac-5.20 > > reg: > maxItems: 1 > @@ -116,11 +121,25 @@ allOf: > minItems: 3 > maxItems: 3 > > - resets: > - minItems: 2 > - > - reset-names: > - minItems: 2 > + if: I would personally avoid nesting if within if. It gets unreadable. Although Rob did not comment on this one, so I guess it is fine. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-03-27 7:54 ` Krzysztof Kozlowski 0 siblings, 0 replies; 15+ messages in thread From: Krzysztof Kozlowski @ 2024-03-27 7:54 UTC (permalink / raw) To: Tan Chun Hau, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring, Emil Renner Berthing, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King Cc: Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv On 27/03/2024 02:57, Tan Chun Hau wrote: > Add StarFive JH8100 dwmac support. > The JH8100 dwmac shares the same driver code as the JH7110 dwmac > and has only one reset signal. > > Please refer to below: > > JH8100: reset-names = "stmmaceth"; > JH7110: reset-names = "stmmaceth", "ahb"; > JH7100: reset-names = "ahb"; > > Example usage of JH8100 in the device tree: > > gmac0: ethernet@16030000 { > compatible = "starfive,jh8100-dwmac", > "starfive,jh7110-dwmac", > "snps,dwmac-5.20"; > ... > }; > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > 2 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 6b0341a8e0ea..a6d596b7dcf4 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -97,6 +97,7 @@ properties: > - snps,dwxgmac-2.10 > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jh8100-dwmac I think that's not needed. You have there already your fallback. > > reg: > minItems: 1 > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > index 0d1962980f57..5805a58c55d1 100644 > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > @@ -18,6 +18,7 @@ select: > enum: > - starfive,jh7100-dwmac > - starfive,jh7110-dwmac > + - starfive,jh8100-dwmac Same here, even more obvious. > required: > - compatible > > @@ -30,6 +31,10 @@ properties: > - items: > - const: starfive,jh7110-dwmac > - const: snps,dwmac-5.20 > + - items: > + - const: starfive,jh8100-dwmac > + - const: starfive,jh7110-dwmac > + - const: snps,dwmac-5.20 > > reg: > maxItems: 1 > @@ -116,11 +121,25 @@ allOf: > minItems: 3 > maxItems: 3 > > - resets: > - minItems: 2 > - > - reset-names: > - minItems: 2 > + if: I would personally avoid nesting if within if. It gets unreadable. Although Rob did not comment on this one, so I guess it is fine. Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support 2024-03-27 7:54 ` Krzysztof Kozlowski (?) @ 2024-03-28 20:42 ` Rob Herring -1 siblings, 0 replies; 15+ messages in thread From: Rob Herring @ 2024-03-28 20:42 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Tan Chun Hau, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Emil Renner Berthing, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King, Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv On Wed, Mar 27, 2024 at 08:54:30AM +0100, Krzysztof Kozlowski wrote: > On 27/03/2024 02:57, Tan Chun Hau wrote: > > Add StarFive JH8100 dwmac support. > > The JH8100 dwmac shares the same driver code as the JH7110 dwmac > > and has only one reset signal. > > > > Please refer to below: > > > > JH8100: reset-names = "stmmaceth"; > > JH7110: reset-names = "stmmaceth", "ahb"; > > JH7100: reset-names = "ahb"; > > > > Example usage of JH8100 in the device tree: > > > > gmac0: ethernet@16030000 { > > compatible = "starfive,jh8100-dwmac", > > "starfive,jh7110-dwmac", > > "snps,dwmac-5.20"; > > ... > > }; > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > > 2 files changed, 25 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index 6b0341a8e0ea..a6d596b7dcf4 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -97,6 +97,7 @@ properties: > > - snps,dwxgmac-2.10 > > - starfive,jh7100-dwmac > > - starfive,jh7110-dwmac > > + - starfive,jh8100-dwmac > > I think that's not needed. You have there already your fallback. > > > > > reg: > > minItems: 1 > > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > index 0d1962980f57..5805a58c55d1 100644 > > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > @@ -18,6 +18,7 @@ select: > > enum: > > - starfive,jh7100-dwmac > > - starfive,jh7110-dwmac > > + - starfive,jh8100-dwmac > > Same here, even more obvious. Agreed. > > > required: > > - compatible > > > > @@ -30,6 +31,10 @@ properties: > > - items: > > - const: starfive,jh7110-dwmac > > - const: snps,dwmac-5.20 > > + - items: > > + - const: starfive,jh8100-dwmac > > + - const: starfive,jh7110-dwmac > > + - const: snps,dwmac-5.20 > > > > reg: > > maxItems: 1 > > @@ -116,11 +121,25 @@ allOf: > > minItems: 3 > > maxItems: 3 > > > > - resets: > > - minItems: 2 > > - > > - reset-names: > > - minItems: 2 > > + if: > > I would personally avoid nesting if within if. It gets unreadable. > Although Rob did not comment on this one, so I guess it is fine. I normally agree, but here I suggested it as it looked to be the simplest option. With the 2 other comments addressed, Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-03-28 20:42 ` Rob Herring 0 siblings, 0 replies; 15+ messages in thread From: Rob Herring @ 2024-03-28 20:42 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Tan Chun Hau, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Emil Renner Berthing, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King, Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv On Wed, Mar 27, 2024 at 08:54:30AM +0100, Krzysztof Kozlowski wrote: > On 27/03/2024 02:57, Tan Chun Hau wrote: > > Add StarFive JH8100 dwmac support. > > The JH8100 dwmac shares the same driver code as the JH7110 dwmac > > and has only one reset signal. > > > > Please refer to below: > > > > JH8100: reset-names = "stmmaceth"; > > JH7110: reset-names = "stmmaceth", "ahb"; > > JH7100: reset-names = "ahb"; > > > > Example usage of JH8100 in the device tree: > > > > gmac0: ethernet@16030000 { > > compatible = "starfive,jh8100-dwmac", > > "starfive,jh7110-dwmac", > > "snps,dwmac-5.20"; > > ... > > }; > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > > 2 files changed, 25 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index 6b0341a8e0ea..a6d596b7dcf4 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -97,6 +97,7 @@ properties: > > - snps,dwxgmac-2.10 > > - starfive,jh7100-dwmac > > - starfive,jh7110-dwmac > > + - starfive,jh8100-dwmac > > I think that's not needed. You have there already your fallback. > > > > > reg: > > minItems: 1 > > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > index 0d1962980f57..5805a58c55d1 100644 > > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > @@ -18,6 +18,7 @@ select: > > enum: > > - starfive,jh7100-dwmac > > - starfive,jh7110-dwmac > > + - starfive,jh8100-dwmac > > Same here, even more obvious. Agreed. > > > required: > > - compatible > > > > @@ -30,6 +31,10 @@ properties: > > - items: > > - const: starfive,jh7110-dwmac > > - const: snps,dwmac-5.20 > > + - items: > > + - const: starfive,jh8100-dwmac > > + - const: starfive,jh7110-dwmac > > + - const: snps,dwmac-5.20 > > > > reg: > > maxItems: 1 > > @@ -116,11 +121,25 @@ allOf: > > minItems: 3 > > maxItems: 3 > > > > - resets: > > - minItems: 2 > > - > > - reset-names: > > - minItems: 2 > > + if: > > I would personally avoid nesting if within if. It gets unreadable. > Although Rob did not comment on this one, so I guess it is fine. I normally agree, but here I suggested it as it looked to be the simplest option. With the 2 other comments addressed, Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-03-28 20:42 ` Rob Herring 0 siblings, 0 replies; 15+ messages in thread From: Rob Herring @ 2024-03-28 20:42 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Tan Chun Hau, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Emil Renner Berthing, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King, Ley Foon Tan, Jee Heng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv On Wed, Mar 27, 2024 at 08:54:30AM +0100, Krzysztof Kozlowski wrote: > On 27/03/2024 02:57, Tan Chun Hau wrote: > > Add StarFive JH8100 dwmac support. > > The JH8100 dwmac shares the same driver code as the JH7110 dwmac > > and has only one reset signal. > > > > Please refer to below: > > > > JH8100: reset-names = "stmmaceth"; > > JH7110: reset-names = "stmmaceth", "ahb"; > > JH7100: reset-names = "ahb"; > > > > Example usage of JH8100 in the device tree: > > > > gmac0: ethernet@16030000 { > > compatible = "starfive,jh8100-dwmac", > > "starfive,jh7110-dwmac", > > "snps,dwmac-5.20"; > > ... > > }; > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > --- > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > > 2 files changed, 25 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index 6b0341a8e0ea..a6d596b7dcf4 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -97,6 +97,7 @@ properties: > > - snps,dwxgmac-2.10 > > - starfive,jh7100-dwmac > > - starfive,jh7110-dwmac > > + - starfive,jh8100-dwmac > > I think that's not needed. You have there already your fallback. > > > > > reg: > > minItems: 1 > > diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > index 0d1962980f57..5805a58c55d1 100644 > > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > @@ -18,6 +18,7 @@ select: > > enum: > > - starfive,jh7100-dwmac > > - starfive,jh7110-dwmac > > + - starfive,jh8100-dwmac > > Same here, even more obvious. Agreed. > > > required: > > - compatible > > > > @@ -30,6 +31,10 @@ properties: > > - items: > > - const: starfive,jh7110-dwmac > > - const: snps,dwmac-5.20 > > + - items: > > + - const: starfive,jh8100-dwmac > > + - const: starfive,jh7110-dwmac > > + - const: snps,dwmac-5.20 > > > > reg: > > maxItems: 1 > > @@ -116,11 +121,25 @@ allOf: > > minItems: 3 > > maxItems: 3 > > > > - resets: > > - minItems: 2 > > - > > - reset-names: > > - minItems: 2 > > + if: > > I would personally avoid nesting if within if. It gets unreadable. > Although Rob did not comment on this one, so I guess it is fine. I normally agree, but here I suggested it as it looked to be the simplest option. With the 2 other comments addressed, Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support 2024-03-28 20:42 ` Rob Herring (?) @ 2024-04-03 9:56 ` ChunHau Tan -1 siblings, 0 replies; 15+ messages in thread From: ChunHau Tan @ 2024-04-03 9:56 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Emil Renner Berthing, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King, Leyfoon Tan, JeeHeng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Friday, 29 March, 2024 4:42 AM > To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Emil Renner > Berthing <kernel@esmil.dk>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>; > Maxime Coquelin <mcoquelin.stm32@gmail.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>; Bartosz > Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney > <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe > Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King > <rmk+kernel@armlinux.org.uk>; Leyfoon Tan <leyfoon.tan@starfivetech.com>; > JeeHeng Sia <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-stm32@st-md-mailman.stormreply.com; > linux-arm-kernel@lists.infradead.org; linux-riscv@lists.infradead.org > Subject: Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add > StarFive JH8100 support > > On Wed, Mar 27, 2024 at 08:54:30AM +0100, Krzysztof Kozlowski wrote: > > On 27/03/2024 02:57, Tan Chun Hau wrote: > > > Add StarFive JH8100 dwmac support. > > > The JH8100 dwmac shares the same driver code as the JH7110 dwmac and > > > has only one reset signal. > > > > > > Please refer to below: > > > > > > JH8100: reset-names = "stmmaceth"; > > > JH7110: reset-names = "stmmaceth", "ahb"; > > > JH7100: reset-names = "ahb"; > > > > > > Example usage of JH8100 in the device tree: > > > > > > gmac0: ethernet@16030000 { > > > compatible = "starfive,jh8100-dwmac", > > > "starfive,jh7110-dwmac", > > > "snps,dwmac-5.20"; > > > ... > > > }; > > > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > > --- > > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > > > 2 files changed, 25 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index 6b0341a8e0ea..a6d596b7dcf4 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -97,6 +97,7 @@ properties: > > > - snps,dwxgmac-2.10 > > > - starfive,jh7100-dwmac > > > - starfive,jh7110-dwmac > > > + - starfive,jh8100-dwmac > > > > I think that's not needed. You have there already your fallback. Okay, I will remove it. > > > > > > > > reg: > > > minItems: 1 > > > diff --git > > > a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > index 0d1962980f57..5805a58c55d1 100644 > > > --- > > > a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.ya > > > +++ ml > > > @@ -18,6 +18,7 @@ select: > > > enum: > > > - starfive,jh7100-dwmac > > > - starfive,jh7110-dwmac > > > + - starfive,jh8100-dwmac > > > > Same here, even more obvious. > > Agreed. Okay, I will remove it. > > > > > > required: > > > - compatible > > > > > > @@ -30,6 +31,10 @@ properties: > > > - items: > > > - const: starfive,jh7110-dwmac > > > - const: snps,dwmac-5.20 > > > + - items: > > > + - const: starfive,jh8100-dwmac > > > + - const: starfive,jh7110-dwmac > > > + - const: snps,dwmac-5.20 > > > > > > reg: > > > maxItems: 1 > > > @@ -116,11 +121,25 @@ allOf: > > > minItems: 3 > > > maxItems: 3 > > > > > > - resets: > > > - minItems: 2 > > > - > > > - reset-names: > > > - minItems: 2 > > > + if: > > > > I would personally avoid nesting if within if. It gets unreadable. > > Although Rob did not comment on this one, so I guess it is fine. > > I normally agree, but here I suggested it as it looked to be the simplest option. > > With the 2 other comments addressed, > > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-04-03 9:56 ` ChunHau Tan 0 siblings, 0 replies; 15+ messages in thread From: ChunHau Tan @ 2024-04-03 9:56 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Emil Renner Berthing, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King, Leyfoon Tan, JeeHeng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Friday, 29 March, 2024 4:42 AM > To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Emil Renner > Berthing <kernel@esmil.dk>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>; > Maxime Coquelin <mcoquelin.stm32@gmail.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>; Bartosz > Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney > <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe > Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King > <rmk+kernel@armlinux.org.uk>; Leyfoon Tan <leyfoon.tan@starfivetech.com>; > JeeHeng Sia <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-stm32@st-md-mailman.stormreply.com; > linux-arm-kernel@lists.infradead.org; linux-riscv@lists.infradead.org > Subject: Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add > StarFive JH8100 support > > On Wed, Mar 27, 2024 at 08:54:30AM +0100, Krzysztof Kozlowski wrote: > > On 27/03/2024 02:57, Tan Chun Hau wrote: > > > Add StarFive JH8100 dwmac support. > > > The JH8100 dwmac shares the same driver code as the JH7110 dwmac and > > > has only one reset signal. > > > > > > Please refer to below: > > > > > > JH8100: reset-names = "stmmaceth"; > > > JH7110: reset-names = "stmmaceth", "ahb"; > > > JH7100: reset-names = "ahb"; > > > > > > Example usage of JH8100 in the device tree: > > > > > > gmac0: ethernet@16030000 { > > > compatible = "starfive,jh8100-dwmac", > > > "starfive,jh7110-dwmac", > > > "snps,dwmac-5.20"; > > > ... > > > }; > > > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > > --- > > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > > > 2 files changed, 25 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index 6b0341a8e0ea..a6d596b7dcf4 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -97,6 +97,7 @@ properties: > > > - snps,dwxgmac-2.10 > > > - starfive,jh7100-dwmac > > > - starfive,jh7110-dwmac > > > + - starfive,jh8100-dwmac > > > > I think that's not needed. You have there already your fallback. Okay, I will remove it. > > > > > > > > reg: > > > minItems: 1 > > > diff --git > > > a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > index 0d1962980f57..5805a58c55d1 100644 > > > --- > > > a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.ya > > > +++ ml > > > @@ -18,6 +18,7 @@ select: > > > enum: > > > - starfive,jh7100-dwmac > > > - starfive,jh7110-dwmac > > > + - starfive,jh8100-dwmac > > > > Same here, even more obvious. > > Agreed. Okay, I will remove it. > > > > > > required: > > > - compatible > > > > > > @@ -30,6 +31,10 @@ properties: > > > - items: > > > - const: starfive,jh7110-dwmac > > > - const: snps,dwmac-5.20 > > > + - items: > > > + - const: starfive,jh8100-dwmac > > > + - const: starfive,jh7110-dwmac > > > + - const: snps,dwmac-5.20 > > > > > > reg: > > > maxItems: 1 > > > @@ -116,11 +121,25 @@ allOf: > > > minItems: 3 > > > maxItems: 3 > > > > > > - resets: > > > - minItems: 2 > > > - > > > - reset-names: > > > - minItems: 2 > > > + if: > > > > I would personally avoid nesting if within if. It gets unreadable. > > Although Rob did not comment on this one, so I guess it is fine. > > I normally agree, but here I suggested it as it looked to be the simplest option. > > With the 2 other comments addressed, > > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support @ 2024-04-03 9:56 ` ChunHau Tan 0 siblings, 0 replies; 15+ messages in thread From: ChunHau Tan @ 2024-04-03 9:56 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Emil Renner Berthing, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin, Alexandre Torgue, Simon Horman, Bartosz Golaszewski, Andrew Halaney, Jisheng Zhang, Uwe Kleine-König, Russell King, Leyfoon Tan, JeeHeng Sia, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-riscv > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Friday, 29 March, 2024 4:42 AM > To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller > <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Emil Renner > Berthing <kernel@esmil.dk>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>; > Maxime Coquelin <mcoquelin.stm32@gmail.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>; Bartosz > Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney > <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe > Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King > <rmk+kernel@armlinux.org.uk>; Leyfoon Tan <leyfoon.tan@starfivetech.com>; > JeeHeng Sia <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-stm32@st-md-mailman.stormreply.com; > linux-arm-kernel@lists.infradead.org; linux-riscv@lists.infradead.org > Subject: Re: [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add > StarFive JH8100 support > > On Wed, Mar 27, 2024 at 08:54:30AM +0100, Krzysztof Kozlowski wrote: > > On 27/03/2024 02:57, Tan Chun Hau wrote: > > > Add StarFive JH8100 dwmac support. > > > The JH8100 dwmac shares the same driver code as the JH7110 dwmac and > > > has only one reset signal. > > > > > > Please refer to below: > > > > > > JH8100: reset-names = "stmmaceth"; > > > JH7110: reset-names = "stmmaceth", "ahb"; > > > JH7100: reset-names = "ahb"; > > > > > > Example usage of JH8100 in the device tree: > > > > > > gmac0: ethernet@16030000 { > > > compatible = "starfive,jh8100-dwmac", > > > "starfive,jh7110-dwmac", > > > "snps,dwmac-5.20"; > > > ... > > > }; > > > > > > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com> > > > --- > > > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > > > .../bindings/net/starfive,jh7110-dwmac.yaml | 29 +++++++++++++++---- > > > 2 files changed, 25 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index 6b0341a8e0ea..a6d596b7dcf4 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -97,6 +97,7 @@ properties: > > > - snps,dwxgmac-2.10 > > > - starfive,jh7100-dwmac > > > - starfive,jh7110-dwmac > > > + - starfive,jh8100-dwmac > > > > I think that's not needed. You have there already your fallback. Okay, I will remove it. > > > > > > > > reg: > > > minItems: 1 > > > diff --git > > > a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > index 0d1962980f57..5805a58c55d1 100644 > > > --- > > > a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.ya > > > +++ ml > > > @@ -18,6 +18,7 @@ select: > > > enum: > > > - starfive,jh7100-dwmac > > > - starfive,jh7110-dwmac > > > + - starfive,jh8100-dwmac > > > > Same here, even more obvious. > > Agreed. Okay, I will remove it. > > > > > > required: > > > - compatible > > > > > > @@ -30,6 +31,10 @@ properties: > > > - items: > > > - const: starfive,jh7110-dwmac > > > - const: snps,dwmac-5.20 > > > + - items: > > > + - const: starfive,jh8100-dwmac > > > + - const: starfive,jh7110-dwmac > > > + - const: snps,dwmac-5.20 > > > > > > reg: > > > maxItems: 1 > > > @@ -116,11 +121,25 @@ allOf: > > > minItems: 3 > > > maxItems: 3 > > > > > > - resets: > > > - minItems: 2 > > > - > > > - reset-names: > > > - minItems: 2 > > > + if: > > > > I would personally avoid nesting if within if. It gets unreadable. > > Although Rob did not comment on this one, so I guess it is fine. > > I normally agree, but here I suggested it as it looked to be the simplest option. > > With the 2 other comments addressed, > > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2024-04-03 10:31 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-03-27 1:57 [PATCH v5 0/1] Add StarFive JH8100 dwmac support Tan Chun Hau 2024-03-27 1:57 ` Tan Chun Hau 2024-03-27 1:57 ` Tan Chun Hau 2024-03-27 1:57 ` [PATCH v5 1/1] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support Tan Chun Hau 2024-03-27 1:57 ` Tan Chun Hau 2024-03-27 1:57 ` Tan Chun Hau 2024-03-27 7:54 ` Krzysztof Kozlowski 2024-03-27 7:54 ` Krzysztof Kozlowski 2024-03-27 7:54 ` Krzysztof Kozlowski 2024-03-28 20:42 ` Rob Herring 2024-03-28 20:42 ` Rob Herring 2024-03-28 20:42 ` Rob Herring 2024-04-03 9:56 ` ChunHau Tan 2024-04-03 9:56 ` ChunHau Tan 2024-04-03 9:56 ` ChunHau Tan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.