All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] perf test record.sh: Raise limit of open file descriptors
@ 2024-03-11  8:11 vmolnaro
  2024-03-20 12:14 ` Michael Petlan
  0 siblings, 1 reply; 10+ messages in thread
From: vmolnaro @ 2024-03-11  8:11 UTC (permalink / raw)
  To: linux-perf-users, acme, acme; +Cc: mpetlan

From: Veronika Molnarova <vmolnaro@redhat.com>

Subtest for system-wide record with '--threads=cpu' option fails due
to a limit of open file descriptors on systems with 128 or more CPUs
as the default limit is set to 1024.

The number of open file descriptors should be slightly above
nmb_events*nmb_cpus + nmb_cpus(for perf.data.n) + 4*nmb_cpus(for pipes),
which equals 8*nmb_cpus. Therefore, temporarily raise the limit to
16*nmb_cpus for the test.

Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
---
 tools/perf/tests/shell/record.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 4fbc74805d52..8acd55d09a1c 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -11,6 +11,14 @@ err=0
 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
 testprog="perf test -w thloop"
 testsym="test_loop"
+default_fd_limit=$(ulimit -n)
+# With option --threads=cpu the number of open file descriptors should be
+# equal to sum of:    nmb_cpus * nmb_events (2+dummy),
+#                     nmb_threads for perf.data.n (equal to nmb_cpus) and
+#                     2*nmb_cpus of pipes = 4*nmb_cpus (each pipe has 2 ends)
+# All together it needs 8*nmb_cpus file descriptors plus some are also used 
+# outside of testing, thus raising the limit to 16*nmb_cpus
+min_fd_limit=$(($(getconf _NPROCESSORS_ONLN) * 16))
 
 cleanup() {
   rm -rf "${perfdata}"
@@ -154,10 +162,18 @@ test_workload() {
   echo "Basic target workload test [Success]"
 }
 
+# raise the limit of file descriptors to minimum
+if [[ $default_fd_limit -lt $min_fd_limit ]]; then
+	ulimit -n $min_fd_limit
+fi
+
 test_per_thread
 test_register_capture
 test_system_wide
 test_workload
 
+# restore the default value
+ulimit -n $default_fd_limit
+
 cleanup
 exit $err
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] perf test record.sh: Raise limit of open file descriptors
@ 2023-11-15 14:05 vmolnaro
  2023-11-21 12:32 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 10+ messages in thread
From: vmolnaro @ 2023-11-15 14:05 UTC (permalink / raw)
  To: linux-perf-users, acme, acme; +Cc: mpetlan

From: Veronika Molnarova <vmolnaro@redhat.com>

Subtest for system-wide record with '--threads' option fails due to a
limit of open file descriptors(usually set to 1024) on systems with
128 and more CPUs.

If the default limit is set lower than 2048 file descriptors,
temporarily raise it to this value for the test.

Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>
---
 tools/perf/tests/shell/record.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 4fbc74805d52..c6c43263809a 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -11,6 +11,8 @@ err=0
 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
 testprog="perf test -w thloop"
 testsym="test_loop"
+min_fd_limit=2048
+default_fd_limit=$(ulimit -n)
 
 cleanup() {
   rm -rf "${perfdata}"
@@ -154,10 +156,16 @@ test_workload() {
   echo "Basic target workload test [Success]"
 }
 
+if [[ $default_fd_limit -lt $min_fd_limit ]]; then
+	ulimit -n $min_fd_limit
+fi
+
 test_per_thread
 test_register_capture
 test_system_wide
 test_workload
 
+ulimit -n $default_fd_limit
+
 cleanup
 exit $err
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-05-21  9:28 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-11  8:11 [PATCH v2] perf test record.sh: Raise limit of open file descriptors vmolnaro
2024-03-20 12:14 ` Michael Petlan
2024-03-20 14:19   ` Arnaldo Carvalho de Melo
2024-03-28 15:46     ` [PATCH] " vmolnaro
2024-04-25 19:00     ` [PATCH v2] " Arnaldo Carvalho de Melo
2024-04-29  8:53       ` vmolnaro
2024-05-21  9:27         ` Michael Petlan
  -- strict thread matches above, loose matches on Subject: below --
2023-11-15 14:05 [PATCH] " vmolnaro
2023-11-21 12:32 ` Arnaldo Carvalho de Melo
2023-11-30 21:29   ` vmolnaro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.