[PATCH 0/2] Move liberror-perl to meta-perl

[PATCH 0/2] Move liberror-perl to meta-perl

[Tim Orling]

This perl package has not seen any updates since 2020.

The upstream author of Error has deprecated it for quite some time.

https://metacpan.org/pod/Error#WARNING

    'Using the "Error" module is no longer recommended due to the
     black-magical nature of its syntactic sugar, which often tends
     to break. Its maintainers have stopped actively writing code
     that uses it, and discourage people from doing so.'

The only recipe in oe-core which had any depdency on it was coreutils-ptest,
and that has now been removed. All ptests passed for core-image-ptest-coreutils
on qemux86-64.

It is not clear when the dependency in coreutils was present, but it is
definitely not needed in the current v9.4 release.

Tim Orling (2):
  coreutils: drop obsolete liberror-perl RDEPENDS
  liberror-perl: move to meta-perl

 meta/conf/distro/include/maintainers.inc      |  1 -
 .../distro/include/ptest-packagelists.inc     |  1 -
 meta/recipes-core/coreutils/coreutils_9.4.bb  |  4 +-
 .../perl/liberror-perl_0.17029.bb             | 48 -------------------
 4 files changed, 2 insertions(+), 52 deletions(-)
 delete mode 100644 meta/recipes-devtools/perl/liberror-perl_0.17029.bb

-- 
2.34.1

[PATCH 1/2] coreutils: drop obsolete liberror-perl RDEPENDS

[Tim Orling]

The upstream maintainer for Error has deprecated it for quite some time [1].
There is no dependency in current coreutils tests for it.

[YOCTO #15461]

[1] https://metacpan.org/pod/Error#WARNING

    Using the "Error" module is no longer recommended due to the black-magical
    nature of its syntactic sugar, which often tends to break. Its maintainers
    have stopped actively writing code that uses it, and discourage people from
    doing so.

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 meta/recipes-core/coreutils/coreutils_9.4.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/coreutils/coreutils_9.4.bb b/meta/recipes-core/coreutils/coreutils_9.4.bb
index fc51adcd5b1..62ecdea6ec1 100644
--- a/meta/recipes-core/coreutils/coreutils_9.4.bb
+++ b/meta/recipes-core/coreutils/coreutils_9.4.bb
@@ -23,7 +23,7 @@ SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
 SRC_URI[sha256sum] = "ea613a4cf44612326e917201bbbcdfbd301de21ffc3b59b6e5c07e040b275e52"
 
 # http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=v8.27-101-gf5d7c0842
-# 
+#
 CVE_STATUS[CVE-2016-2781] = "disputed: runcon is not really a sandbox command, use `runcon ... setsid ...` to avoid this particular issue."
 
 EXTRA_OECONF:class-target = "--enable-install-program=arch,hostname --libexecdir=${libdir}"
@@ -169,7 +169,7 @@ BBCLASSEXTEND = "native nativesdk"
 
 inherit ptest
 
-RDEPENDS:${PN}-ptest += "bash findutils gawk liberror-perl make perl perl-modules python3-core sed shadow"
+RDEPENDS:${PN}-ptest += "bash findutils gawk make perl perl-modules python3-core sed shadow"
 
 # -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
 # may need tweaking if DEPENDS changes
-- 
2.34.1

[PATCH 2/2] liberror-perl: move to meta-perl

[Tim Orling]

The upstream maintainer for Error has deprecated it for quite some time [1].
The only dependency in oe-core was coreutils-ptest.

[YOCTO #15461]

[1] https://metacpan.org/pod/Error#WARNING

    Using the "Error" module is no longer recommended due to the black-magical
    nature of its syntactic sugar, which often tends to break. Its maintainers
    have stopped actively writing code that uses it, and discourage people from
    doing so. See the "SEE ALSO" section below for better recommendations [2].

[2] https://metacpan.org/pod/Error#SEE-ALSO

    SEE ALSO
    --------

    See Exception::Class for a different module providing Object-Oriented
    exception handling, along with a convenient syntax for declaring hierarchies
    for them. It doesn't provide Error's syntactic sugar of try { ... },
    catch { ... }, etc. which may be a good thing or a bad thing based on what
    you want. (Because Error's syntactic sugar tends to break.)

    Error::Exception aims to combine Error and Exception::Class "with correct
    stringification".

    TryCatch and Try::Tiny are similar in concept to Error.pm only providing a
    syntax that hopefully breaks less.

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
---
 meta/conf/distro/include/maintainers.inc      |  1 -
 .../distro/include/ptest-packagelists.inc     |  1 -
 .../perl/liberror-perl_0.17029.bb             | 48 -------------------
 3 files changed, 50 deletions(-)
 delete mode 100644 meta/recipes-devtools/perl/liberror-perl_0.17029.bb

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index 4ca5430a941..2d1f9fdec55 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -328,7 +328,6 @@ RECIPE_MAINTAINER:pn-libdrm = "Otavio Salvador <otavio.salvador@ossystems.com.br
 RECIPE_MAINTAINER:pn-libedit = "Khem Raj <raj.khem@gmail.com>"
 RECIPE_MAINTAINER:pn-libepoxy = "Anuj Mittal <anuj.mittal@intel.com>"
 RECIPE_MAINTAINER:pn-liberation-fonts = "Alexander Kanavin <alex.kanavin@gmail.com>"
-RECIPE_MAINTAINER:pn-liberror-perl = "Tim Orling <tim.orling@konsulko.com>"
 RECIPE_MAINTAINER:pn-libevdev = "Anuj Mittal <anuj.mittal@intel.com>"
 RECIPE_MAINTAINER:pn-libevent = "Anuj Mittal <anuj.mittal@intel.com>"
 RECIPE_MAINTAINER:pn-libexif = "Alexander Kanavin <alex.kanavin@gmail.com>"
diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index 0192146dbd0..84f67644437 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -28,7 +28,6 @@ PTESTS_FAST = "\
     json-c \
     json-glib \
     libconvert-asn1-perl \
-    liberror-perl \
     libgpg-error\
     libnl \
     libpcre \
diff --git a/meta/recipes-devtools/perl/liberror-perl_0.17029.bb b/meta/recipes-devtools/perl/liberror-perl_0.17029.bb
deleted file mode 100644
index e54bb11ccd3..00000000000
--- a/meta/recipes-devtools/perl/liberror-perl_0.17029.bb
+++ /dev/null
@@ -1,48 +0,0 @@
-SUMMARY = "Error - Error/exception handling in an OO-ish way"
-DESCRIPTION = "The Error package provides two interfaces. Firstly \
-Error provides a procedural interface to exception handling. \
-Secondly Error is a base class for errors/exceptions that can \
-either be thrown, for subsequent catch, or can simply be recorded."
-HOMEPAGE = "https://github.com/shlomif/perl-error.pm"
-SECTION = "libs"
-LICENSE = "Artistic-1.0 | GPL-1.0-or-later"
-
-LIC_FILES_CHKSUM = "file://LICENSE;md5=8f3499d09ee74a050c0319391ff9d100"
-
-
-DEPENDS += "perl"
-
-RDEPENDS:${PN} += " \
-    perl-module-carp \
-    perl-module-exporter \
-    perl-module-scalar-util \
-    perl-module-overload \
-    perl-module-strict \
-    perl-module-vars \
-    perl-module-warnings \
-"
-
-RDEPENDS:${PN}-ptest += " \
-    perl-module-base \
-    perl-module-file-spec \
-    perl-module-io-handle \
-    perl-module-ipc-open3 \
-    perl-module-lib \
-    perl-module-test-more \
-"
-
-SRC_URI = "http://cpan.metacpan.org/authors/id/S/SH/SHLOMIF/Error-${PV}.tar.gz"
-
-SRC_URI[md5sum] = "6732b1c6207e4a9a3e2987c88368039a"
-SRC_URI[sha256sum] = "1a23f7913032aed6d4b68321373a3899ca66590f4727391a091ec19c95bf7adc"
-
-S = "${WORKDIR}/Error-${PV}"
-
-inherit cpan ptest-perl
-
-do_install:prepend() {
-	# test requires "-T" (taint) command line option
-	rm -rf ${B}/t/pod-coverage.t
-}
-
-BBCLASSEXTEND = "native"
-- 
2.34.1