All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] system: expose BR2_ROOTFS_POST_SCRIPT_ARGS for PRE_BUILD scripts
@ 2024-03-28 20:35 Yann E. MORIN
  2024-04-28 12:10 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2024-03-28 20:35 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=96b3295ca1fc00973fa2754dafb80fe6db23f48f
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Currently, we pass BR2_ROOTFS_POST_SCRIPT_ARGS to each of the scripts in
BR2_ROOTFS_PRE_BUILD_SCRIPT, but the option is not exposed in menuconfig
when only pre-build scripts are used.

Add the pre-build scripts to the condition exposing the extra args
option.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
 system/Config.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/system/Config.in b/system/Config.in
index 33ca69b933..e590a8a3ff 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -695,12 +695,13 @@ config BR2_ROOTFS_POST_IMAGE_SCRIPT
 
 config BR2_ROOTFS_POST_SCRIPT_ARGS
 	string "Extra arguments passed to custom scripts"
-	depends on BR2_ROOTFS_POST_BUILD_SCRIPT != "" \
+	depends on BR2_ROOTFS_PRE_BUILD_SCRIPT != "" \
+	        || BR2_ROOTFS_POST_BUILD_SCRIPT != "" \
 		|| BR2_ROOTFS_POST_FAKEROOT_SCRIPT != "" \
 		|| BR2_ROOTFS_POST_IMAGE_SCRIPT != ""
 	help
-	  Pass these additional arguments to each post-build or
-	  post-image scripts.
+	  Pass these additional arguments to each pre-build, post-build,
+	  post-fakeroot and post-image scripts.
 
 	  Note that all the post-build and post-image scripts will be
 	  passed the same set of arguments, you can not pass different
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [git commit] system: expose BR2_ROOTFS_POST_SCRIPT_ARGS for PRE_BUILD scripts
  2024-03-28 20:35 [Buildroot] [git commit] system: expose BR2_ROOTFS_POST_SCRIPT_ARGS for PRE_BUILD scripts Yann E. MORIN
@ 2024-04-28 12:10 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2024-04-28 12:10 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=96b3295ca1fc00973fa2754dafb80fe6db23f48f
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > Currently, we pass BR2_ROOTFS_POST_SCRIPT_ARGS to each of the scripts in
 > BR2_ROOTFS_PRE_BUILD_SCRIPT, but the option is not exposed in menuconfig
 > when only pre-build scripts are used.

 > Add the pre-build scripts to the condition exposing the extra args
 > option.

 > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-28 12:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 20:35 [Buildroot] [git commit] system: expose BR2_ROOTFS_POST_SCRIPT_ARGS for PRE_BUILD scripts Yann E. MORIN
2024-04-28 12:10 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.