* [PATCH 0/2] crash: clean up outdated codes and doc related to CRASH_CORE
@ 2024-03-29 13:28 Baoquan He
2024-03-29 13:28 ` Baoquan He
2024-03-29 13:28 ` [PATCH 2/2] Documentation: kdump: clean up the outdated description Baoquan He
0 siblings, 2 replies; 12+ messages in thread
From: Baoquan He @ 2024-03-29 13:28 UTC (permalink / raw)
To: kexec; +Cc: akpm, geert, chenhuacai, Baoquan He
As Geert pointed out that there are still left codes and doc related to
CRASH_CORE in arch/loongarch and Documentation. So make these two
patches to clean them up. Thanks to Geert.
Baoquan He (2):
arch/loongarch: clean up the left code and Kconfig item related to
CRASH_CORE
Documentation: kdump: clean up the outdated description
Documentation/admin-guide/kdump/kdump.rst | 8 ++++----
arch/loongarch/Kconfig | 2 +-
.../include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
--
2.41.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
2024-03-29 13:28 [PATCH 0/2] crash: clean up outdated codes and doc related to CRASH_CORE Baoquan He
@ 2024-03-29 13:28 ` Baoquan He
2024-03-29 13:28 ` [PATCH 2/2] Documentation: kdump: clean up the outdated description Baoquan He
1 sibling, 0 replies; 12+ messages in thread
From: Baoquan He @ 2024-03-29 13:28 UTC (permalink / raw)
To: kexec; +Cc: akpm, geert, chenhuacai, Baoquan He, WANG Xuerui, loongarch
In commit 85fcde402db1 ("kexec: split crashkernel reservation code
out from crash_core.c"), crashkernel reservation code is split out from
crash_core.c, and add CRASH_RESERVE to control it. And also rename each
ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
But the relevant part in loongarch is missed. Do it now.
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: WANG Xuerui <kernel@xen0n.name>
Cc: loongarch@lists.linux.dev
---
arch/loongarch/Kconfig | 2 +-
arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index a5f300ec6f28..54ad04dacdee 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
select RELOCATABLE
config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
- def_bool CRASH_CORE
+ def_bool CRASH_RESERVE
config RELOCATABLE
bool "Relocatable kernel"
diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
similarity index 75%
rename from arch/loongarch/include/asm/crash_core.h
rename to arch/loongarch/include/asm/crash_reserve.h
index 218bdbfa527b..a1d9b84b1c7d 100644
--- a/arch/loongarch/include/asm/crash_core.h
+++ b/arch/loongarch/include/asm/crash_reserve.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef _LOONGARCH_CRASH_CORE_H
-#define _LOONGARCH_CRASH_CORE_H
+#ifndef _LOONGARCH_CRASH_RESERVE_H
+#define _LOONGARCH_CRASH_RESERVE_H
#define CRASH_ALIGN SZ_2M
--
2.41.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
@ 2024-03-29 13:28 ` Baoquan He
0 siblings, 0 replies; 12+ messages in thread
From: Baoquan He @ 2024-03-29 13:28 UTC (permalink / raw)
To: kexec; +Cc: akpm, geert, chenhuacai, Baoquan He, WANG Xuerui, loongarch
In commit 85fcde402db1 ("kexec: split crashkernel reservation code
out from crash_core.c"), crashkernel reservation code is split out from
crash_core.c, and add CRASH_RESERVE to control it. And also rename each
ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
But the relevant part in loongarch is missed. Do it now.
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: WANG Xuerui <kernel@xen0n.name>
Cc: loongarch@lists.linux.dev
---
arch/loongarch/Kconfig | 2 +-
arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
index a5f300ec6f28..54ad04dacdee 100644
--- a/arch/loongarch/Kconfig
+++ b/arch/loongarch/Kconfig
@@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
select RELOCATABLE
config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
- def_bool CRASH_CORE
+ def_bool CRASH_RESERVE
config RELOCATABLE
bool "Relocatable kernel"
diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
similarity index 75%
rename from arch/loongarch/include/asm/crash_core.h
rename to arch/loongarch/include/asm/crash_reserve.h
index 218bdbfa527b..a1d9b84b1c7d 100644
--- a/arch/loongarch/include/asm/crash_core.h
+++ b/arch/loongarch/include/asm/crash_reserve.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef _LOONGARCH_CRASH_CORE_H
-#define _LOONGARCH_CRASH_CORE_H
+#ifndef _LOONGARCH_CRASH_RESERVE_H
+#define _LOONGARCH_CRASH_RESERVE_H
#define CRASH_ALIGN SZ_2M
--
2.41.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] Documentation: kdump: clean up the outdated description
2024-03-29 13:28 [PATCH 0/2] crash: clean up outdated codes and doc related to CRASH_CORE Baoquan He
2024-03-29 13:28 ` Baoquan He
@ 2024-03-29 13:28 ` Baoquan He
1 sibling, 0 replies; 12+ messages in thread
From: Baoquan He @ 2024-03-29 13:28 UTC (permalink / raw)
To: kexec; +Cc: akpm, geert, chenhuacai, Baoquan He, corbet
After commit 443cbaf9e2fd ("crash: split vmcoreinfo exporting code out
from crash_core.c"), Kconfig item CRASH_CORE has gone away in kernel.
Items VMCORE_INFO and CRASH_RESERVE are used instead.
So clean up the outdated description about CRASH_CORE and update it
accordingly.
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: corbet@lwn.net
---
Documentation/admin-guide/kdump/kdump.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/admin-guide/kdump/kdump.rst b/Documentation/admin-guide/kdump/kdump.rst
index 0302a93b1d40..5376890adbeb 100644
--- a/Documentation/admin-guide/kdump/kdump.rst
+++ b/Documentation/admin-guide/kdump/kdump.rst
@@ -136,10 +136,6 @@ System kernel config options
CONFIG_KEXEC_CORE=y
- Subsequently, CRASH_CORE is selected by KEXEC_CORE::
-
- CONFIG_CRASH_CORE=y
-
2) Enable "sysfs file system support" in "Filesystem" -> "Pseudo
filesystems." This is usually enabled by default::
@@ -168,6 +164,10 @@ Dump-capture kernel config options (Arch Independent)
CONFIG_CRASH_DUMP=y
+ And this will select VMCORE_INFO and CRASH_RESERVE::
+ CONFIG_VMCORE_INFO=y
+ CONFIG_CRASH_RESERVE=y
+
2) Enable "/proc/vmcore support" under "Filesystems" -> "Pseudo filesystems"::
CONFIG_PROC_VMCORE=y
--
2.41.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
2024-03-29 13:28 ` Baoquan He
@ 2024-03-30 13:59 ` Huacai Chen
-1 siblings, 0 replies; 12+ messages in thread
From: Huacai Chen @ 2024-03-30 13:59 UTC (permalink / raw)
To: Baoquan He; +Cc: kexec, akpm, geert, WANG Xuerui, loongarch
Queued, thanks.
Huacai
On Fri, Mar 29, 2024 at 9:28 PM Baoquan He <bhe@redhat.com> wrote:
>
> In commit 85fcde402db1 ("kexec: split crashkernel reservation code
> out from crash_core.c"), crashkernel reservation code is split out from
> crash_core.c, and add CRASH_RESERVE to control it. And also rename each
> ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
>
> But the relevant part in loongarch is missed. Do it now.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: WANG Xuerui <kernel@xen0n.name>
> Cc: loongarch@lists.linux.dev
> ---
> arch/loongarch/Kconfig | 2 +-
> arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index a5f300ec6f28..54ad04dacdee 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
> select RELOCATABLE
>
> config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> - def_bool CRASH_CORE
> + def_bool CRASH_RESERVE
>
> config RELOCATABLE
> bool "Relocatable kernel"
> diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
> similarity index 75%
> rename from arch/loongarch/include/asm/crash_core.h
> rename to arch/loongarch/include/asm/crash_reserve.h
> index 218bdbfa527b..a1d9b84b1c7d 100644
> --- a/arch/loongarch/include/asm/crash_core.h
> +++ b/arch/loongarch/include/asm/crash_reserve.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> -#ifndef _LOONGARCH_CRASH_CORE_H
> -#define _LOONGARCH_CRASH_CORE_H
> +#ifndef _LOONGARCH_CRASH_RESERVE_H
> +#define _LOONGARCH_CRASH_RESERVE_H
>
> #define CRASH_ALIGN SZ_2M
>
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
@ 2024-03-30 13:59 ` Huacai Chen
0 siblings, 0 replies; 12+ messages in thread
From: Huacai Chen @ 2024-03-30 13:59 UTC (permalink / raw)
To: Baoquan He; +Cc: kexec, akpm, geert, WANG Xuerui, loongarch
Queued, thanks.
Huacai
On Fri, Mar 29, 2024 at 9:28 PM Baoquan He <bhe@redhat.com> wrote:
>
> In commit 85fcde402db1 ("kexec: split crashkernel reservation code
> out from crash_core.c"), crashkernel reservation code is split out from
> crash_core.c, and add CRASH_RESERVE to control it. And also rename each
> ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
>
> But the relevant part in loongarch is missed. Do it now.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: WANG Xuerui <kernel@xen0n.name>
> Cc: loongarch@lists.linux.dev
> ---
> arch/loongarch/Kconfig | 2 +-
> arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
>
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index a5f300ec6f28..54ad04dacdee 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
> select RELOCATABLE
>
> config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> - def_bool CRASH_CORE
> + def_bool CRASH_RESERVE
>
> config RELOCATABLE
> bool "Relocatable kernel"
> diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
> similarity index 75%
> rename from arch/loongarch/include/asm/crash_core.h
> rename to arch/loongarch/include/asm/crash_reserve.h
> index 218bdbfa527b..a1d9b84b1c7d 100644
> --- a/arch/loongarch/include/asm/crash_core.h
> +++ b/arch/loongarch/include/asm/crash_reserve.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> -#ifndef _LOONGARCH_CRASH_CORE_H
> -#define _LOONGARCH_CRASH_CORE_H
> +#ifndef _LOONGARCH_CRASH_RESERVE_H
> +#define _LOONGARCH_CRASH_RESERVE_H
>
> #define CRASH_ALIGN SZ_2M
>
> --
> 2.41.0
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
2024-03-30 13:59 ` Huacai Chen
@ 2024-03-30 14:23 ` Baoquan He
-1 siblings, 0 replies; 12+ messages in thread
From: Baoquan He @ 2024-03-30 14:23 UTC (permalink / raw)
To: Huacai Chen; +Cc: kexec, akpm, geert, WANG Xuerui, loongarch
On 03/30/24 at 09:59pm, Huacai Chen wrote:
> Queued, thanks.
Thanks, Huacai. While I noticed Andrew has queued this patchset in his
mm-unstable branch.
>
> Huacai
>
> On Fri, Mar 29, 2024 at 9:28 PM Baoquan He <bhe@redhat.com> wrote:
> >
> > In commit 85fcde402db1 ("kexec: split crashkernel reservation code
> > out from crash_core.c"), crashkernel reservation code is split out from
> > crash_core.c, and add CRASH_RESERVE to control it. And also rename each
> > ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
> >
> > But the relevant part in loongarch is missed. Do it now.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: Huacai Chen <chenhuacai@kernel.org>
> > Cc: WANG Xuerui <kernel@xen0n.name>
> > Cc: loongarch@lists.linux.dev
> > ---
> > arch/loongarch/Kconfig | 2 +-
> > arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> > rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
> >
> > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > index a5f300ec6f28..54ad04dacdee 100644
> > --- a/arch/loongarch/Kconfig
> > +++ b/arch/loongarch/Kconfig
> > @@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
> > select RELOCATABLE
> >
> > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> > - def_bool CRASH_CORE
> > + def_bool CRASH_RESERVE
> >
> > config RELOCATABLE
> > bool "Relocatable kernel"
> > diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
> > similarity index 75%
> > rename from arch/loongarch/include/asm/crash_core.h
> > rename to arch/loongarch/include/asm/crash_reserve.h
> > index 218bdbfa527b..a1d9b84b1c7d 100644
> > --- a/arch/loongarch/include/asm/crash_core.h
> > +++ b/arch/loongarch/include/asm/crash_reserve.h
> > @@ -1,6 +1,6 @@
> > /* SPDX-License-Identifier: GPL-2.0-only */
> > -#ifndef _LOONGARCH_CRASH_CORE_H
> > -#define _LOONGARCH_CRASH_CORE_H
> > +#ifndef _LOONGARCH_CRASH_RESERVE_H
> > +#define _LOONGARCH_CRASH_RESERVE_H
> >
> > #define CRASH_ALIGN SZ_2M
> >
> > --
> > 2.41.0
> >
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
@ 2024-03-30 14:23 ` Baoquan He
0 siblings, 0 replies; 12+ messages in thread
From: Baoquan He @ 2024-03-30 14:23 UTC (permalink / raw)
To: Huacai Chen; +Cc: kexec, akpm, geert, WANG Xuerui, loongarch
On 03/30/24 at 09:59pm, Huacai Chen wrote:
> Queued, thanks.
Thanks, Huacai. While I noticed Andrew has queued this patchset in his
mm-unstable branch.
>
> Huacai
>
> On Fri, Mar 29, 2024 at 9:28 PM Baoquan He <bhe@redhat.com> wrote:
> >
> > In commit 85fcde402db1 ("kexec: split crashkernel reservation code
> > out from crash_core.c"), crashkernel reservation code is split out from
> > crash_core.c, and add CRASH_RESERVE to control it. And also rename each
> > ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
> >
> > But the relevant part in loongarch is missed. Do it now.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: Huacai Chen <chenhuacai@kernel.org>
> > Cc: WANG Xuerui <kernel@xen0n.name>
> > Cc: loongarch@lists.linux.dev
> > ---
> > arch/loongarch/Kconfig | 2 +-
> > arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> > rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
> >
> > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > index a5f300ec6f28..54ad04dacdee 100644
> > --- a/arch/loongarch/Kconfig
> > +++ b/arch/loongarch/Kconfig
> > @@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
> > select RELOCATABLE
> >
> > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> > - def_bool CRASH_CORE
> > + def_bool CRASH_RESERVE
> >
> > config RELOCATABLE
> > bool "Relocatable kernel"
> > diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
> > similarity index 75%
> > rename from arch/loongarch/include/asm/crash_core.h
> > rename to arch/loongarch/include/asm/crash_reserve.h
> > index 218bdbfa527b..a1d9b84b1c7d 100644
> > --- a/arch/loongarch/include/asm/crash_core.h
> > +++ b/arch/loongarch/include/asm/crash_reserve.h
> > @@ -1,6 +1,6 @@
> > /* SPDX-License-Identifier: GPL-2.0-only */
> > -#ifndef _LOONGARCH_CRASH_CORE_H
> > -#define _LOONGARCH_CRASH_CORE_H
> > +#ifndef _LOONGARCH_CRASH_RESERVE_H
> > +#define _LOONGARCH_CRASH_RESERVE_H
> >
> > #define CRASH_ALIGN SZ_2M
> >
> > --
> > 2.41.0
> >
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
2024-03-30 14:23 ` Baoquan He
@ 2024-04-17 3:14 ` Huacai Chen
-1 siblings, 0 replies; 12+ messages in thread
From: Huacai Chen @ 2024-04-17 3:14 UTC (permalink / raw)
To: Baoquan He; +Cc: kexec, akpm, geert, WANG Xuerui, loongarch
Hi, Andrew,
On Sat, Mar 30, 2024 at 10:24 PM Baoquan He <bhe@redhat.com> wrote:
>
> On 03/30/24 at 09:59pm, Huacai Chen wrote:
> > Queued, thanks.
>
> Thanks, Huacai. While I noticed Andrew has queued this patchset in his
> mm-unstable branch.
If I'm not mistaken, mm-unstable is target for the next 6.10, not for
the current 6.9. But I think this patch should be a fix for 6.9, so I
think it is more suitable in the loongarch-fixes branch. What's your
opinion?
The same question for this patch which fix a build warning:
https://lore.kernel.org/loongarch/CANiq72kACt+FfeYXJxfQpmGH=uPqkDA0oprfnebw52VSKyn7kQ@mail.gmail.com/T/#t
Huacai
>
> >
> > Huacai
> >
> > On Fri, Mar 29, 2024 at 9:28 PM Baoquan He <bhe@redhat.com> wrote:
> > >
> > > In commit 85fcde402db1 ("kexec: split crashkernel reservation code
> > > out from crash_core.c"), crashkernel reservation code is split out from
> > > crash_core.c, and add CRASH_RESERVE to control it. And also rename each
> > > ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
> > >
> > > But the relevant part in loongarch is missed. Do it now.
> > >
> > > Signed-off-by: Baoquan He <bhe@redhat.com>
> > > Cc: Huacai Chen <chenhuacai@kernel.org>
> > > Cc: WANG Xuerui <kernel@xen0n.name>
> > > Cc: loongarch@lists.linux.dev
> > > ---
> > > arch/loongarch/Kconfig | 2 +-
> > > arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
> > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
> > >
> > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > > index a5f300ec6f28..54ad04dacdee 100644
> > > --- a/arch/loongarch/Kconfig
> > > +++ b/arch/loongarch/Kconfig
> > > @@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
> > > select RELOCATABLE
> > >
> > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> > > - def_bool CRASH_CORE
> > > + def_bool CRASH_RESERVE
> > >
> > > config RELOCATABLE
> > > bool "Relocatable kernel"
> > > diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
> > > similarity index 75%
> > > rename from arch/loongarch/include/asm/crash_core.h
> > > rename to arch/loongarch/include/asm/crash_reserve.h
> > > index 218bdbfa527b..a1d9b84b1c7d 100644
> > > --- a/arch/loongarch/include/asm/crash_core.h
> > > +++ b/arch/loongarch/include/asm/crash_reserve.h
> > > @@ -1,6 +1,6 @@
> > > /* SPDX-License-Identifier: GPL-2.0-only */
> > > -#ifndef _LOONGARCH_CRASH_CORE_H
> > > -#define _LOONGARCH_CRASH_CORE_H
> > > +#ifndef _LOONGARCH_CRASH_RESERVE_H
> > > +#define _LOONGARCH_CRASH_RESERVE_H
> > >
> > > #define CRASH_ALIGN SZ_2M
> > >
> > > --
> > > 2.41.0
> > >
> >
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
@ 2024-04-17 3:14 ` Huacai Chen
0 siblings, 0 replies; 12+ messages in thread
From: Huacai Chen @ 2024-04-17 3:14 UTC (permalink / raw)
To: Baoquan He; +Cc: kexec, akpm, geert, WANG Xuerui, loongarch
Hi, Andrew,
On Sat, Mar 30, 2024 at 10:24 PM Baoquan He <bhe@redhat.com> wrote:
>
> On 03/30/24 at 09:59pm, Huacai Chen wrote:
> > Queued, thanks.
>
> Thanks, Huacai. While I noticed Andrew has queued this patchset in his
> mm-unstable branch.
If I'm not mistaken, mm-unstable is target for the next 6.10, not for
the current 6.9. But I think this patch should be a fix for 6.9, so I
think it is more suitable in the loongarch-fixes branch. What's your
opinion?
The same question for this patch which fix a build warning:
https://lore.kernel.org/loongarch/CANiq72kACt+FfeYXJxfQpmGH=uPqkDA0oprfnebw52VSKyn7kQ@mail.gmail.com/T/#t
Huacai
>
> >
> > Huacai
> >
> > On Fri, Mar 29, 2024 at 9:28 PM Baoquan He <bhe@redhat.com> wrote:
> > >
> > > In commit 85fcde402db1 ("kexec: split crashkernel reservation code
> > > out from crash_core.c"), crashkernel reservation code is split out from
> > > crash_core.c, and add CRASH_RESERVE to control it. And also rename each
> > > ARCH's <asm/crash_core.h> to <asm/crash_reserve.h> accordingly.
> > >
> > > But the relevant part in loongarch is missed. Do it now.
> > >
> > > Signed-off-by: Baoquan He <bhe@redhat.com>
> > > Cc: Huacai Chen <chenhuacai@kernel.org>
> > > Cc: WANG Xuerui <kernel@xen0n.name>
> > > Cc: loongarch@lists.linux.dev
> > > ---
> > > arch/loongarch/Kconfig | 2 +-
> > > arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} | 4 ++--
> > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > rename arch/loongarch/include/asm/{crash_core.h => crash_reserve.h} (75%)
> > >
> > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> > > index a5f300ec6f28..54ad04dacdee 100644
> > > --- a/arch/loongarch/Kconfig
> > > +++ b/arch/loongarch/Kconfig
> > > @@ -595,7 +595,7 @@ config ARCH_SELECTS_CRASH_DUMP
> > > select RELOCATABLE
> > >
> > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> > > - def_bool CRASH_CORE
> > > + def_bool CRASH_RESERVE
> > >
> > > config RELOCATABLE
> > > bool "Relocatable kernel"
> > > diff --git a/arch/loongarch/include/asm/crash_core.h b/arch/loongarch/include/asm/crash_reserve.h
> > > similarity index 75%
> > > rename from arch/loongarch/include/asm/crash_core.h
> > > rename to arch/loongarch/include/asm/crash_reserve.h
> > > index 218bdbfa527b..a1d9b84b1c7d 100644
> > > --- a/arch/loongarch/include/asm/crash_core.h
> > > +++ b/arch/loongarch/include/asm/crash_reserve.h
> > > @@ -1,6 +1,6 @@
> > > /* SPDX-License-Identifier: GPL-2.0-only */
> > > -#ifndef _LOONGARCH_CRASH_CORE_H
> > > -#define _LOONGARCH_CRASH_CORE_H
> > > +#ifndef _LOONGARCH_CRASH_RESERVE_H
> > > +#define _LOONGARCH_CRASH_RESERVE_H
> > >
> > > #define CRASH_ALIGN SZ_2M
> > >
> > > --
> > > 2.41.0
> > >
> >
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
2024-04-17 3:14 ` Huacai Chen
@ 2024-04-17 7:32 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2024-04-17 7:32 UTC (permalink / raw)
To: Huacai Chen; +Cc: Baoquan He, kexec, akpm, WANG Xuerui, loongarch
On Wed, Apr 17, 2024 at 5:15 AM Huacai Chen <chenhuacai@kernel.org> wrote:
> On Sat, Mar 30, 2024 at 10:24 PM Baoquan He <bhe@redhat.com> wrote:
> >
> > On 03/30/24 at 09:59pm, Huacai Chen wrote:
> > > Queued, thanks.
> >
> > Thanks, Huacai. While I noticed Andrew has queued this patchset in his
> > mm-unstable branch.
> If I'm not mistaken, mm-unstable is target for the next 6.10, not for
> the current 6.9. But I think this patch should be a fix for 6.9, so I
> think it is more suitable in the loongarch-fixes branch. What's your
> opinion?
This would have been slightly more obvious with
Fixes: 85fcde402db191b5 ("kexec: split crashkernel reservation code
out from crash_core.c")
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item related to CRASH_CORE
@ 2024-04-17 7:32 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2024-04-17 7:32 UTC (permalink / raw)
To: Huacai Chen; +Cc: Baoquan He, kexec, akpm, WANG Xuerui, loongarch
On Wed, Apr 17, 2024 at 5:15 AM Huacai Chen <chenhuacai@kernel.org> wrote:
> On Sat, Mar 30, 2024 at 10:24 PM Baoquan He <bhe@redhat.com> wrote:
> >
> > On 03/30/24 at 09:59pm, Huacai Chen wrote:
> > > Queued, thanks.
> >
> > Thanks, Huacai. While I noticed Andrew has queued this patchset in his
> > mm-unstable branch.
> If I'm not mistaken, mm-unstable is target for the next 6.10, not for
> the current 6.9. But I think this patch should be a fix for 6.9, so I
> think it is more suitable in the loongarch-fixes branch. What's your
> opinion?
This would have been slightly more obvious with
Fixes: 85fcde402db191b5 ("kexec: split crashkernel reservation code
out from crash_core.c")
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-04-17 7:33 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-29 13:28 [PATCH 0/2] crash: clean up outdated codes and doc related to CRASH_CORE Baoquan He
2024-03-29 13:28 ` [PATCH 1/2] arch/loongarch: clean up the left code and Kconfig item " Baoquan He
2024-03-29 13:28 ` Baoquan He
2024-03-30 13:59 ` Huacai Chen
2024-03-30 13:59 ` Huacai Chen
2024-03-30 14:23 ` Baoquan He
2024-03-30 14:23 ` Baoquan He
2024-04-17 3:14 ` Huacai Chen
2024-04-17 3:14 ` Huacai Chen
2024-04-17 7:32 ` Geert Uytterhoeven
2024-04-17 7:32 ` Geert Uytterhoeven
2024-03-29 13:28 ` [PATCH 2/2] Documentation: kdump: clean up the outdated description Baoquan He
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.