* [PATCH] lib: fix newline in debug message
@ 2024-03-29 14:22 Maxim Moskalets
2024-03-30 1:57 ` Heinrich Schuchardt
0 siblings, 1 reply; 2+ messages in thread
From: Maxim Moskalets @ 2024-03-29 14:22 UTC (permalink / raw)
To: u-boot, trini, sjg; +Cc: Maxim Moskalets, Maxim Moskalets
Signed-off-by: Maxim Moskalets <maximmosk4@gmail.com>
---
lib/rsa/rsa-verify.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
index 1007b6979a..e1093ce1a4 100644
--- a/lib/rsa/rsa-verify.c
+++ b/lib/rsa/rsa-verify.c
@@ -342,7 +342,7 @@ static int rsa_verify_key(struct image_sign_info *info,
return -EINVAL;
}
- debug("Checksum algorithm: %s", checksum->name);
+ debug("Checksum algorithm: %s\n", checksum->name);
/* Sanity check for stack size */
if (sig_len > RSA_MAX_SIG_BITS / 8) {
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lib: fix newline in debug message
2024-03-29 14:22 [PATCH] lib: fix newline in debug message Maxim Moskalets
@ 2024-03-30 1:57 ` Heinrich Schuchardt
0 siblings, 0 replies; 2+ messages in thread
From: Heinrich Schuchardt @ 2024-03-30 1:57 UTC (permalink / raw)
To: Maxim Moskalets; +Cc: Maxim Moskalets, u-boot, trini, sjg
Thank you for catching this.
%s/fix/add missing/ would make the subject clearer.
We prefer to have a commit message in all patches, e.g.
Add missing line break to improve readability.
On 3/29/24 15:22, Maxim Moskalets wrote:
> Signed-off-by: Maxim Moskalets <maximmosk4@gmail.com>
> ---
> lib/rsa/rsa-verify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c
> index 1007b6979a..e1093ce1a4 100644
> --- a/lib/rsa/rsa-verify.c
> +++ b/lib/rsa/rsa-verify.c
> @@ -342,7 +342,7 @@ static int rsa_verify_key(struct image_sign_info *info,
> return -EINVAL;
> }
>
> - debug("Checksum algorithm: %s", checksum->name);
> + debug("Checksum algorithm: %s\n", checksum->name);
>
> /* Sanity check for stack size */
> if (sig_len > RSA_MAX_SIG_BITS / 8) {
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-30 1:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-29 14:22 [PATCH] lib: fix newline in debug message Maxim Moskalets
2024-03-30 1:57 ` Heinrich Schuchardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.